[GitHub] [activemq-artemis] michaelandrepearce opened a new pull request #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
michaelandrepearce opened a new pull request #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856 This is needed to aid some lift and shift migration from activemq5 where non-java clients have support for older openwire

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #38: AMQNET-616: Add TCP Keep-Alive support

2019-10-01 Thread GitBox
michaelandrepearce merged pull request #38: AMQNET-616: Add TCP Keep-Alive support URL: https://github.com/apache/activemq-nms-amqp/pull/38 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #35: NO-JIRA: Pingpong benchmark

2019-10-01 Thread GitBox
michaelandrepearce merged pull request #35: NO-JIRA: Pingpong benchmark URL: https://github.com/apache/activemq-nms-amqp/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #39: AMQNET-617: Support Message Selectors

2019-10-01 Thread GitBox
michaelandrepearce commented on a change in pull request #39: AMQNET-617: Support Message Selectors URL: https://github.com/apache/activemq-nms-amqp/pull/39#discussion_r330014347 ## File path: README.md ## @@ -62,7 +62,7 @@ So in general most of the top level classes that

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #39: AMQNET-617: Support Message Selectors

2019-10-01 Thread GitBox
michaelandrepearce commented on a change in pull request #39: AMQNET-617: Support Message Selectors URL: https://github.com/apache/activemq-nms-amqp/pull/39#discussion_r330014347 ## File path: README.md ## @@ -62,7 +62,7 @@ So in general most of the top level classes that

[GitHub] [activemq-nms-amqp] michaelpearce-gain commented on a change in pull request #39: AMQNET-617: Support Message Selectors

2019-10-01 Thread GitBox
michaelpearce-gain commented on a change in pull request #39: AMQNET-617: Support Message Selectors URL: https://github.com/apache/activemq-nms-amqp/pull/39#discussion_r330029245 ## File path: README.md ## @@ -62,7 +62,7 @@ So in general most of the top level classes that

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #39: AMQNET-617: Support Message Selectors

2019-10-01 Thread GitBox
michaelandrepearce merged pull request #39: AMQNET-617: Support Message Selectors URL: https://github.com/apache/activemq-nms-amqp/pull/39 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #39: AMQNET-617: Support Message Selectors

2019-10-01 Thread GitBox
michaelandrepearce commented on a change in pull request #39: AMQNET-617: Support Message Selectors URL: https://github.com/apache/activemq-nms-amqp/pull/39#discussion_r330014347 ## File path: README.md ## @@ -62,7 +62,7 @@ So in general most of the top level classes that

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
clebertsuconic commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537036309 This is just adding a jar on the /lib, how that helps? wouldn't that be simply a client library? just

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
michaelandrepearce commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537091589 Hi Clebert basically openwire tries to load dynamically the marshallers. Just by adding the legacy jar (as

[GitHub] [activemq-artemis] tabish121 commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
tabish121 commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537095260 Openwire legacy contains codecs for v2-v8 so clients that connect with those versions would down negotiate to v1 and

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
clebertsuconic commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537093003 OIC.. thanks! This is an automated message

[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2854: the 2.10.0 clustered-grouping demo have BUG

2019-10-01 Thread GitBox
clebertsuconic edited a comment on issue #2854: the 2.10.0 clustered-grouping demo have BUG URL: https://github.com/apache/activemq-artemis/pull/2854#issuecomment-537094327 You made a git-mess on this PR. You should do the following: ```sh git remote add upstream

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2854: the 2.10.0 clustered-grouping demo have BUG

2019-10-01 Thread GitBox
clebertsuconic commented on issue #2854: the 2.10.0 clustered-grouping demo have BUG URL: https://github.com/apache/activemq-artemis/pull/2854#issuecomment-537094327 YOu made a mess on this PR. You should do the following: ```sh git remote add upstream

[GitHub] [activemq-artemis] asfgit merged pull request #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
asfgit merged pull request #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] asfgit merged pull request #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
asfgit merged pull request #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] clebertsuconic closed pull request #2854: the 2.10.0 clustered-grouping demo have BUG

2019-10-01 Thread GitBox
clebertsuconic closed pull request #2854: the 2.10.0 clustered-grouping demo have BUG URL: https://github.com/apache/activemq-artemis/pull/2854 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2854: the 2.10.0 clustered-grouping demo have BUG

2019-10-01 Thread GitBox
clebertsuconic commented on issue #2854: the 2.10.0 clustered-grouping demo have BUG URL: https://github.com/apache/activemq-artemis/pull/2854#issuecomment-537095619 Actually.. I don't see any changes in this commit at all. Isn't this just a question? Where is your change?

[GitHub] [activemq-artemis] gemmellr commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
gemmellr commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537107622 Too late now its merged, but its not clear why the commit message has a cherry pick -x reference when it is the

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
michaelandrepearce commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537109477 @gemmellr thats because to make PR it was cherry picked out onto the branch for pr from another internal

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
clebertsuconic commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537113076 it's not possible to push -f on master.. it's pointless to revert it / and send it again. I didn't

[GitHub] [activemq-artemis] gemmellr commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
gemmellr commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537113405 Gah, ninja'd by seconds :) This is an automated

[GitHub] [activemq-artemis] gemmellr commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire

2019-10-01 Thread GitBox
gemmellr commented on issue #2856: ARTEMIS-2509 Add some basic support for legacy openwire URL: https://github.com/apache/activemq-artemis/pull/2856#issuecomment-537113261 No need to mess other folks up editing master, just pointing out it. Clebert suggested in a mail thread recently that

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #41: AMQNET-605: Pre-buffered messages shouldn't be released when consumer closes down

2019-10-01 Thread GitBox
michaelandrepearce merged pull request #41: AMQNET-605: Pre-buffered messages shouldn't be released when consumer closes down URL: https://github.com/apache/activemq-nms-amqp/pull/41 This is an automated message from the

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #40: AMQNET-618: Support noLocal filter

2019-10-01 Thread GitBox
michaelandrepearce merged pull request #40: AMQNET-618: Support noLocal filter URL: https://github.com/apache/activemq-nms-amqp/pull/40 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-nms-amqp] Havret opened a new pull request #41: AMQNET-605: Pre-buffered messages shouldn't be released when consumer closes down

2019-10-01 Thread GitBox
Havret opened a new pull request #41: AMQNET-605: Pre-buffered messages shouldn't be released when consumer closes down URL: https://github.com/apache/activemq-nms-amqp/pull/41 This PR removes failing unit test, as we shouldn't support this scenario, hence this behavior is specific for

[GitHub] [activemq-nms-amqp] Havret opened a new pull request #40: AMQNET-618: Support noLocal filter

2019-10-01 Thread GitBox
Havret opened a new pull request #40: AMQNET-618: Support noLocal filter URL: https://github.com/apache/activemq-nms-amqp/pull/40 This PR adds support for noLocal message filter. This is an automated message from the Apache