[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-532892930 @cjwmorgan-sol @michaelandrepearce Where are we with this one? Are we coming to any conclusions? I don't know if I am to make any adjustments or what

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #33: [WIP] Update docs

michaelandrepearce commented on a change in pull request #33: [WIP] Update docs URL: https://github.com/apache/activemq-nms-amqp/pull/33#discussion_r325963096 ## File path: docs/configuration.md ## @@ -0,0 +1,21 @@ +# Client configuration +This file details various configur

[GitHub] [activemq-artemis] asfgit closed pull request #2834: ARTEMIS-2488: Handle the case where source address is null

asfgit closed pull request #2834: ARTEMIS-2488: Handle the case where source address is null URL: https://github.com/apache/activemq-artemis/pull/2834 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [activemq-artemis] asfgit closed pull request #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

asfgit closed pull request #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] asfgit merged pull request #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

asfgit merged pull request #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-nms-amqp] Havret commented on issue #28: NO-JIRA: Extend logging

Havret commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-532892930 @cjwmorgan-sol @michaelandrepearce Where are we with this one? Are we coming to any conclusions? I don't know I am to make any adjustments or what. --

[GitHub] [activemq-nms-amqp] Havret opened a new pull request #33: [WIP] Update docs

Havret opened a new pull request #33: [WIP] Update docs URL: https://github.com/apache/activemq-nms-amqp/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [activemq-artemis] lulf commented on a change in pull request #2834: ARTEMIS-2488: Handle the case where source address is null

lulf commented on a change in pull request #2834: ARTEMIS-2488: Handle the case where source address is null URL: https://github.com/apache/activemq-artemis/pull/2834#discussion_r325826961 ## File path: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artem

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

clebertsuconic commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843#issuecomment-532782837 @michaelandrepearce xnio has a wrapper using Netty libraries... it's not using any of our APIs.

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

michaelandrepearce commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843#issuecomment-532763801 What im saying is because it was working before was by luck that we had made a copy. The issu

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

michaelandrepearce edited a comment on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843#issuecomment-532762474 Looking at the xnio the issue is before we worked on a copy, thus if xnio mutated the

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

michaelandrepearce commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843#issuecomment-532762474 Looking at the xnio the issue is before we worked on a copy, thus if xnio mutated the buffer

[GitHub] [activemq-artemis] franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532760149 @michaelandrepearce I've sent a messag to @wy96f on the PR related to https://issues.apache.org/jira/br

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

michaelandrepearce commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532759528 Good to see we are reaching out to @wy96f, It be great if we have a test to reproduce obviousl

[GitHub] [activemq-artemis] franz1981 commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

franz1981 commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843#issuecomment-532758809 @wy96f We are actually receiving (and sending) several 0s on the wire (via xnio on wildfly, that will

[GitHub] [activemq-artemis] franz1981 removed a comment on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

franz1981 removed a comment on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532756890 @wy96f We are actually receiving (and sending) several 0s on the wire (via xnio on wildfly, tha

[GitHub] [activemq-artemis] franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532756890 @wy96f We are actually receiving (and sending) several 0s on the wire (via xnio on wildfly, that will w

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message

clebertsuconic commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message URL: https://github.com/apache/activemq-artemis/pull/2839#discussion_r325761313 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i…

clebertsuconic opened a new pull request #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843 …nto some integration usage Revert "ARTEMIS-2336 Use zero copy to replicate journal/page/large message fil

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

clebertsuconic commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532749156 @michaelandrepearce me and Franz are dealing with the following issue: https://issues.apache.org/j

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

michaelandrepearce commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532746924 @franz1981 i know you closed it, but a test case to reproduce and confirm any fix would be nee

[GitHub] [activemq-artemis] franz1981 closed pull request #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

franz1981 closed pull request #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842 This is an automated message from the Apache Git Service. T

[GitHub] [activemq-artemis] franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532741437 Probably the issue is more complex then this, I'm going to close this -

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2834: ARTEMIS-2488: Handle the case where source address is null

clebertsuconic commented on a change in pull request #2834: ARTEMIS-2488: Handle the case where source address is null URL: https://github.com/apache/activemq-artemis/pull/2834#discussion_r325705859 ## File path: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/acti

[GitHub] [activemq-artemis] franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

franz1981 commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532666729 Don't merge it yet, still testing it :) ---

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

franz1981 opened a new pull request #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded URL: https://github.com/apache/activemq-artemis/pull/2842 This is an automated message from the Apache Git Serv

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r325575480 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/i

[GitHub] [activemq-artemis] ecki commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message

ecki commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message URL: https://github.com/apache/activemq-artemis/pull/2839#discussion_r325603833 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistenc

[GitHub] [activemq-artemis] MrEasy commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message

MrEasy commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message URL: https://github.com/apache/activemq-artemis/pull/2839#discussion_r325603848 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persiste

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message

wy96f commented on a change in pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message URL: https://github.com/apache/activemq-artemis/pull/2839#discussion_r325585266 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persisten

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r325575480 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/i

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r325571766 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/