[GitHub] [activemq-artemis] tabish121 commented on issue #3082: ARTEMIS-2706 Discounting Transfer payload size

tabish121 commented on issue #3082: ARTEMIS-2706 Discounting Transfer payload size URL: https://github.com/apache/activemq-artemis/pull/3082#issuecomment-613701819 Tested here and frames are now written in a reasonable size distribution

[GitHub] [activemq-artemis] asfgit merged pull request #3082: ARTEMIS-2706 Discounting Transfer payload size

asfgit merged pull request #3082: ARTEMIS-2706 Discounting Transfer payload size URL: https://github.com/apache/activemq-artemis/pull/3082 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] asfgit merged pull request #3082: ARTEMIS-2706 Discounting Transfer payload size

asfgit merged pull request #3082: ARTEMIS-2706 Discounting Transfer payload size URL: https://github.com/apache/activemq-artemis/pull/3082 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3082: ARTEMIS-2706 Discounting Transfer payload size

clebertsuconic opened a new pull request #3082: ARTEMIS-2706 Discounting Transfer payload size URL: https://github.com/apache/activemq-artemis/pull/3082 This is an automated message from the Apache Git Service. To respond

[GitHub] [activemq-artemis] clebertsuconic commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

clebertsuconic commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613676799 ok, I will do what Robbie suggested me.. 50 + tag.length

[GitHub] [activemq-artemis] tabish121 commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

tabish121 commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613676103 I think worst case on Transfer without accounting for delivery tag and delivery state is something like 31

[GitHub] [activemq-artemis] gemmellr commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

gemmellr commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613671058 23 isnt going to be enough, its fitting here as its the very start of the delivery activity, but the

[GitHub] [activemq-artemis] gemmellr commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

gemmellr commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613669789 There isnt a constant, as the encoded size of the transfer performative varies depending on what fields are

[GitHub] [activemq-artemis] clebertsuconic commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

clebertsuconic commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613669693 I can discount 23 (or make 25) from the body size I'm writing... it should be fine as long as I'm

[GitHub] [activemq-artemis] clebertsuconic commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

clebertsuconic commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613662778 @tabish121 so, what should I do, create the buffer size - than the payload? is there a constant

[GitHub] [activemq-artemis] jbertram commented on issue #3047: ARTEMIS-2680 use q name for addr if none specified via config

jbertram commented on issue #3047: ARTEMIS-2680 use q name for addr if none specified via config URL: https://github.com/apache/activemq-artemis/pull/3047#issuecomment-613657590 @michaelandrepearce, for what it's worth as I was going through the tests to update them to use the new

[GitHub] [activemq-artemis] tabish121 commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

tabish121 commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613656867 The change doesn't account for the Transfer performative encoded in front of the payload as was mentioned

[GitHub] [activemq-artemis] jbertram opened a new pull request #3047: ARTEMIS-2680 use q name for addr if none specified via config

jbertram opened a new pull request #3047: ARTEMIS-2680 use q name for addr if none specified via config URL: https://github.com/apache/activemq-artemis/pull/3047 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] jbertram commented on issue #3047: ARTEMIS-2680 use q name for addr if none specified via config

jbertram commented on issue #3047: ARTEMIS-2680 use q name for addr if none specified via config URL: https://github.com/apache/activemq-artemis/pull/3047#issuecomment-613652196 This is moot now that the `QueueConfiguration` work has been merged.

[GitHub] [activemq-artemis] clebertsuconic commented on issue #3047: ARTEMIS-2680 use q name for addr if none specified via config

clebertsuconic commented on issue #3047: ARTEMIS-2680 use q name for addr if none specified via config URL: https://github.com/apache/activemq-artemis/pull/3047#issuecomment-613647549 this needs to be rebased. This is an

[GitHub] [activemq-artemis] jbertram commented on issue #3081: ARTEMIS-2711 use peer host:port for acceptor SSL engine

jbertram commented on issue #3081: ARTEMIS-2711 use peer host:port for acceptor SSL engine URL: https://github.com/apache/activemq-artemis/pull/3081#issuecomment-613637036 Yes, it can wait until after the release. This is an

[GitHub] [activemq-artemis] clebertsuconic commented on issue #3081: ARTEMIS-2711 use peer host:port for acceptor SSL engine

clebertsuconic commented on issue #3081: ARTEMIS-2711 use peer host:port for acceptor SSL engine URL: https://github.com/apache/activemq-artemis/pull/3081#issuecomment-613635449 Can we wait the release before we merge this?

[GitHub] [activemq-artemis] asfgit merged pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

asfgit merged pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] jbertram opened a new pull request #3081: ARTEMIS-2711 use peer host:port for acceptor SSL engine

jbertram opened a new pull request #3081: ARTEMIS-2711 use peer host:port for acceptor SSL engine URL: https://github.com/apache/activemq-artemis/pull/3081 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] asfgit merged pull request #3080: ARTEMIS-2685 Fixing Examples

asfgit merged pull request #3080: ARTEMIS-2685 Fixing Examples URL: https://github.com/apache/activemq-artemis/pull/3080 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [activemq-artemis] asfgit merged pull request #3080: ARTEMIS-2685 Fixing Examples

asfgit merged pull request #3080: ARTEMIS-2685 Fixing Examples URL: https://github.com/apache/activemq-artemis/pull/3080 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

gemmellr commented on a change in pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#discussion_r408038172 ## File path:

[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

gemmellr commented on a change in pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#discussion_r408038172 ## File path:

[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

gemmellr commented on a change in pull request #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#discussion_r408038172 ## File path:

[GitHub] [activemq-artemis] fvaleri commented on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring

fvaleri commented on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-613270226 OK, changed Bin to Binary and rebased. This is an

[GitHub] [activemq-artemis] fvaleri commented on a change in pull request #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring

fvaleri commented on a change in pull request #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring URL: https://github.com/apache/activemq-artemis/pull/3043#discussion_r407913973 ## File path: