Re: [PR] HIVE-12371: Use DriverManager.getLoginTimeout() as fallback [hive]

jneira-stratio commented on PR #4964: URL: https://github.com/apache/hive/pull/4964#issuecomment-1970553683 > there are some 180+ test failures & all looks related They surely might be. However i cant see how the change _standalone_ could cause them as it is restoring a previous

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

sonarcloud[bot] commented on PR #4959: URL: https://github.com/apache/hive/pull/4959#issuecomment-1970288996 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1506862344 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1424,30 +1422,36 @@ public void visit(LeafNode

Re: [PR] HIVE-12371: Use DriverManager.getLoginTimeout() as fallback [hive]

github-actions[bot] commented on PR #4964: URL: https://github.com/apache/hive/pull/4964#issuecomment-1970152782 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] Update Hive version in Docker README [hive]

sonarcloud[bot] commented on PR #5105: URL: https://github.com/apache/hive/pull/5105#issuecomment-1969803673 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Update Hive version in Docker README [hive]

mertyyanik opened a new pull request, #5105: URL: https://github.com/apache/hive/pull/5105 ### What changes were proposed in this pull request? While the quickstart page for Docker was up to date, the readme was not. I added the updates on the page to the readme. Quicstart

Re: [PR] HIVE-28093: Re-execute DAG in case of NoCurrentDAGException [hive]

sonarcloud[bot] commented on PR #5103: URL: https://github.com/apache/hive/pull/5103#issuecomment-1969626662 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1506164080 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1505,14 +1507,9 @@ public void visit(LeafNode

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1506152341 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1424,30 +1422,36 @@ public void visit(LeafNode

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1506152341 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1424,30 +1422,36 @@ public void visit(LeafNode

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1506152341 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1424,30 +1422,36 @@ public void visit(LeafNode

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-1969109963 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28093: Re-execute DAG in case of NoCurrentDAGException [hive]

abstractdog commented on PR #5103: URL: https://github.com/apache/hive/pull/5103#issuecomment-1968997117 > Minor Stuff, else looks good thanks a lot, addressed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HIVE-25972: HIVE_VECTORIZATION_USE_ROW_DESERIALIZE in hiveconf.java imply default value is false，in fact the default value is 'true' [hive]

SourabhBadhya merged PR #3824: URL: https://github.com/apache/hive/pull/3824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28093: Re-execute DAG in case of NoCurrentDAGException [hive]

abstractdog commented on code in PR #5103: URL: https://github.com/apache/hive/pull/5103#discussion_r1505911098 ## ql/src/test/org/apache/hadoop/hive/ql/reexec/TestReExecuteLostAMQueryPlugin.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HIVE-28093: Re-execute DAG in case of NoCurrentDAGException [hive]

abstractdog commented on code in PR #5103: URL: https://github.com/apache/hive/pull/5103#discussion_r1505909179 ## ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecuteLostAMQueryPlugin.java: ## @@ -44,15 +50,28 @@ public void run(HookContext hookContext) throws Exception {

Re: [PR] HIVE-28093: Re-execute DAG in case of NoCurrentDAGException [hive]

abstractdog commented on code in PR #5103: URL: https://github.com/apache/hive/pull/5103#discussion_r1505907827 ## ql/src/test/org/apache/hadoop/hive/ql/reexec/TestReExecuteLostAMQueryPlugin.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HIVE-28093: Re-execute DAG in case of NoCurrentDAGException [hive]

abstractdog commented on code in PR #5103: URL: https://github.com/apache/hive/pull/5103#discussion_r1505906262 ## ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecuteLostAMQueryPlugin.java: ## @@ -44,15 +50,28 @@ public void run(HookContext hookContext) throws Exception {

Re: [PR] HIVE-28093: Re-execute DAG in case of NoCurrentDAGException [hive]

abstractdog commented on code in PR #5103: URL: https://github.com/apache/hive/pull/5103#discussion_r1505901461 ## ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecuteLostAMQueryPlugin.java: ## @@ -44,15 +50,28 @@ public void run(HookContext hookContext) throws Exception {

Re: [PR] HIVE-28083: Enable HMS client cache and HMS query cache for Explain p… [hive]

zabetak closed pull request #5092: HIVE-28083: Enable HMS client cache and HMS query cache for Explain p… URL: https://github.com/apache/hive/pull/5092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HIVE-28094: Improve HMS client cache and query cache performance for … [hive]

sonarcloud[bot] commented on PR #5102: URL: https://github.com/apache/hive/pull/5102#issuecomment-1968732069 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27848 - TestCrudCompactorOnTez.secondCompactionShouldBeRefusedBe… [hive]

zabetak commented on code in PR #4859: URL: https://github.com/apache/hive/pull/4859#discussion_r1505717881 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorUtil.java: ## @@ -295,4 +324,230 @@ public static LockRequest createLockRequest(HiveConf conf,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505610108 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -370,7 +371,8 @@ private InputSplit[] getCombineSplits(JobConf job, int numSplits,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505609448 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505607838 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505607087 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -147,18 +171,23 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505606712 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -254,18 +286,26 @@ private void generateActualTasks(HiveConf conf, List>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505606288 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -125,6 +133,22 @@ public ListBucketingCtx getLbCtx() { public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505604310 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505603811 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader

Re: [PR] HIVE-28084: Iceberg: COW fix for Merge operation [hive]

deniskuzZ merged PR #5088: URL: https://github.com/apache/hive/pull/5088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505602500 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505602116 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505601391 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505599549 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505595228 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +744,42 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505593646 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505593646 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505593646 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505590111 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -512,7 +555,30 @@ private void setupWorkWhenUsingManifestFile(MapWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505587606 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505587079 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505586021 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void