okumin commented on code in PR #6029:
URL: https://github.com/apache/hive/pull/6029#discussion_r2280266965
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java:
##
@@ -78,33 +70,14 @@ public String[] getLocations() {
// getLocations() w
sonarqubecloud[bot] commented on PR #6032:
URL: https://github.com/apache/hive/pull/6032#issuecomment-3193429921
## [](https://sonarcl
Neer393 opened a new pull request, #6032:
URL: https://github.com/apache/hive/pull/6032
### What changes were proposed in this pull request?
Modified TableFetcher.getTables to lazily return Iterable
### Why are the changes needed?
TableFetcher.getTables used to r
soumyakanti3578 commented on code in PR #5790:
URL: https://github.com/apache/hive/pull/5790#discussion_r2280031956
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##
@@ -3288,6 +3291,190 @@ public List run(List in
sonarqubecloud[bot] commented on PR #6014:
URL: https://github.com/apache/hive/pull/6014#issuecomment-3192531479
## [](https://sonarcl
deniskuzZ commented on code in PR #6029:
URL: https://github.com/apache/hive/pull/6029#discussion_r2279500498
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java:
##
@@ -78,33 +70,14 @@ public String[] getLocations() {
// getLocations(
wecharyu commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2279393687
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws E
sonarqubecloud[bot] commented on PR #5779:
URL: https://github.com/apache/hive/pull/5779#issuecomment-3192011229
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5790:
URL: https://github.com/apache/hive/pull/5790#issuecomment-3191965432
## [](https://sonarcl
nrg4878 commented on code in PR #5701:
URL: https://github.com/apache/hive/pull/5701#discussion_r2279253455
##
beeline/src/java/org/apache/hive/beeline/BeeLine.java:
##
@@ -900,6 +900,8 @@ private boolean connectUsingArgs(BeelineParser
beelineParser, CommandLine cl) {
getO
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279143134
##
standalone-metastore/metastore-rest-catalog/src/test/java/org/apache/iceberg/rest/extension/HiveRESTCatalogServerExtension.java:
##
@@ -42,7 +43,7 @@ public class Hiv
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279141930
##
standalone-metastore/metastore-rest-catalog/src/test/java/org/apache/iceberg/rest/extension/RESTCatalogServer.java:
##
@@ -36,12 +37,17 @@ public class RESTCatalogSer
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279140850
##
standalone-metastore/pom.xml:
##
@@ -116,6 +116,8 @@
1.7.30
4.4.13
4.5.13
+5.3.1
Review Comment:
why do we need this?
--
This is an automat
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279136935
##
itests/hive-unit-iceberg/src/test/java/iceberg/TestHiveRESTCatalogClientIT.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279136497
##
ql/pom.xml:
##
@@ -872,6 +872,18 @@
RoaringBitmap
${roaringbit.version}
+
+ org.apache.httpcomponents.client5
Review Comment:
why do
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279134122
##
itests/hive-unit-iceberg/src/test/java/iceberg/HiveUnitMetaStoreCatalogSchemaInfo.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279133018
##
itests/hive-unit-iceberg/pom.xml:
##
@@ -0,0 +1,150 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLoc
sonarqubecloud[bot] commented on PR #6031:
URL: https://github.com/apache/hive/pull/6031#issuecomment-3191685165
## [](https://sonarcl
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279122388
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##
@@ -441,7 +441,8 @@ public void
appendFiles(org.apache.hadoop.hiv
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279121143
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -1140,6 +1162,9 @@ public void
postGetTable(org.apache.hadoop.hive.m
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279120750
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -1097,13 +1116,16 @@ private void
setOrcOnlyFilesParam(org.apache.ha
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279118555
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -1097,13 +1116,16 @@ private void
setOrcOnlyFilesParam(org.apache.ha
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279117317
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -1089,6 +1105,9 @@ private Type.PrimitiveType
getPrimitiveTypeOrThro
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279118555
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -1097,13 +1116,16 @@ private void
setOrcOnlyFilesParam(org.apache.ha
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279116624
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -923,15 +938,16 @@ private static PartitionSpec spec(Configuration
c
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279110242
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -753,7 +777,7 @@ public void
preTruncateTable(org.apache.hadoop.hive
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279109411
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -363,7 +383,8 @@ public void
preDropTable(org.apache.hadoop.hive.met
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279107418
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -492,6 +513,9 @@ private void
doPreAlterTable(org.apache.hadoop.hive
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279052857
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -324,6 +332,12 @@ public void
rollbackCreateTable(org.apache.hadoop.
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279045850
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -324,6 +332,12 @@ public void
rollbackCreateTable(org.apache.hadoop.
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279045850
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -324,6 +332,12 @@ public void
rollbackCreateTable(org.apache.hadoop.
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279043608
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -276,10 +280,18 @@ public void preCreateTable(CreateTableRequest requ
sonarqubecloud[bot] commented on PR #6022:
URL: https://github.com/apache/hive/pull/6022#issuecomment-3191567918
## [](https://sonarcl
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279040475
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##
@@ -69,23 +69,16 @@ private InputFormatConfig() {
public static final int CO
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279039392
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##
@@ -69,23 +69,16 @@ private InputFormatConfig() {
public static final int CO
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279036322
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##
@@ -289,7 +283,9 @@ private static Map
getCatalogProperties(Configuration conf, Stri
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279034899
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##
@@ -272,12 +265,13 @@ static Optional loadCatalog(Configuration conf,
String catalogNam
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279029723
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279028010
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279026728
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279025040
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279021299
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279002309
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279002309
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279002309
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279001373
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278997557
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278995232
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278989134
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278989134
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278989134
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
Neer393 commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278986385
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws Ex
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278983710
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278981918
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278975614
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
kasakrisz merged PR #6023:
URL: https://github.com/apache/hive/pull/6023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278973193
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278971305
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278969609
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278969609
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278962474
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278962474
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
sonarqubecloud[bot] commented on PR #6028:
URL: https://github.com/apache/hive/pull/6028#issuecomment-3191456264
## [](https://sonarcl
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278945078
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278928484
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##
@@ -131,20 +134,68 @@ public static void updateHmsTableForIcebergTable(
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278914372
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##
@@ -77,21 +94,13 @@ private HMSTablePropertyHelper() {
public static
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278916546
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##
@@ -102,14 +111,8 @@ public static void updateHmsTableForIcebergTable(
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2278904908
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##
@@ -58,12 +66,21 @@ public class HMSTablePropertyHelper {
GC_ENAB
sonarqubecloud[bot] commented on PR #5950:
URL: https://github.com/apache/hive/pull/5950#issuecomment-3191372168
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #6024:
URL: https://github.com/apache/hive/pull/6024#issuecomment-3191325773
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #6029:
URL: https://github.com/apache/hive/pull/6029#issuecomment-3191278579
## [](https://sonarcl
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278783110
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278783110
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278783110
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278783110
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278783110
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278783110
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278783110
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
github-actions[bot] commented on PR #6031:
URL: https://github.com/apache/hive/pull/6031#issuecomment-3191231135
# @check-spelling-bot Report
### :red_circle: Please review
See the [files](6031/files/) view or the [action
log](https://github.com/apache/hive/actions/runs/16988374551
Aggarwal-Raghav commented on PR #6031:
URL: https://github.com/apache/hive/pull/6031#issuecomment-3191229948
only the following are retained:
```
filename: hcatalog/src/test/e2e/templeton/README.txt
https://cwiki.apache.org/confluence/display/PIG/HowToTest
filename:
kafka
Aggarwal-Raghav opened a new pull request, #6031:
URL: https://github.com/apache/hive/pull/6031
### What changes were proposed in this pull request?
Replace cwiki URL with hive website
### Why are the changes needed?
Check [HIVE-29102](https://issues.apache.org/jira/browse/HI
Neer393 commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278769345
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws Ex
Neer393 commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278767539
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws Ex
Neer393 commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278767539
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws Ex
DanielZhu58 commented on code in PR #5950:
URL: https://github.com/apache/hive/pull/5950#discussion_r2278640093
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MsckInfo.java:
##
@@ -33,6 +36,8 @@ public class MsckInfo {
private final bo
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278589972
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
sonarqubecloud[bot] commented on PR #6030:
URL: https://github.com/apache/hive/pull/6030#issuecomment-3191014287
## [](https://sonarcl
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278589972
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278589972
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
deniskuzZ commented on code in PR #6020:
URL: https://github.com/apache/hive/pull/6020#discussion_r2278589972
##
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##
@@ -102,21 +104,47 @@ public List getTables() throws
mszurap commented on PR #5701:
URL: https://github.com/apache/hive/pull/5701#issuecomment-3190884555
@nrg4878 @abstractdog do you have suggestions how to proceed further?
Do you have objections agains removing all the spaces from the URL? (by
definition, URLs cannot contain spaces, they
Neer393 opened a new pull request, #6030:
URL: https://github.com/apache/hive/pull/6030
### What changes were proposed in this pull request?
This PR added support for pattern based catalog retrieval. The change is
that the definition of ```getCatalogs()``` was updated to ```getCat
soumyakanti3578 commented on PR #6027:
URL: https://github.com/apache/hive/pull/6027#issuecomment-3190855413
@kasakrisz
Sorry I should have clarified it in more detail. The bug was fixed by this:
```
if (longColVector.isRepeating) {
if (longColVector.noNulls || !longCol
sonarqubecloud[bot] commented on PR #6029:
URL: https://github.com/apache/hive/pull/6029#issuecomment-3190809442
## [](https://sonarcl
kasakrisz commented on PR #6027:
URL: https://github.com/apache/hive/pull/6027#issuecomment-3190809344
@soumyakanti3578
Could you please share some details and an example about the bug you fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
95 matches
Mail list logo