Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya merged PR #5076: URL: https://github.com/apache/hive/pull/5076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-2011466388 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-2010270454 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-2009115691 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-2006996386 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1529973262 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -8145,9 +8145,20 @@ protected Operator genFileSinkPlan(String dest, QB qb, Operator input)

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1529969082 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergMergeTaskProperties.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1529953727 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-1999642628 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525846051 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -527,4 +591,22 @@ private Map> getManifestDirs(FileSystem inpFs, List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525845819 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -208,14 +235,17 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525845305 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525845136 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -370,7 +371,8 @@ private InputSplit[] getCombineSplits(JobConf job, int numSplits,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525844869 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525844607 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525844470 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525844329 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,29 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525841834 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1525735283 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523074119 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -512,7 +553,30 @@ private void setupWorkWhenUsingManifestFile(MapWork mapWork,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523076497 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -527,4 +591,22 @@ private Map> getManifestDirs(FileSystem inpFs, List }

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523074119 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -512,7 +553,30 @@ private void setupWorkWhenUsingManifestFile(MapWork mapWork,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523065083 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -208,14 +235,17 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523065083 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -208,14 +235,17 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523065083 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -208,14 +235,17 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523058156 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -125,6 +133,22 @@ public ListBucketingCtx getLbCtx() { public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523057516 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -125,6 +133,22 @@ public ListBucketingCtx getLbCtx() { public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523054231 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath, MoveWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523054231 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath, MoveWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523052133 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath, MoveWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523047140 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath, MoveWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523047140 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath, MoveWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523034205 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -370,7 +371,8 @@ private InputSplit[] getCombineSplits(JobConf job, int numSplits,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523022157 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523022157 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523022157 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1523018546 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522794964 ## ql/src/java/org/apache/hadoop/hive/ql/plan/StorageHandlerMergeProperties.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522792841 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522793217 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522790927 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522789753 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,29 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522787165 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,29 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522783053 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,29 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522779763 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522765893 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522765893 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522765893 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522770882 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522765893 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +725,65 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1522434597 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-1988200535 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1512393832 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1512388735 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader> getRecordReader(InputSplit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1512384810 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-1972537661 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5076: URL: https://github.com/apache/hive/pull/5076#issuecomment-1969109963 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505610108 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -370,7 +371,8 @@ private InputSplit[] getCombineSplits(JobConf job, int numSplits,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505609448 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505607838 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505607087 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -147,18 +171,23 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505606712 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -254,18 +286,26 @@ private void generateActualTasks(HiveConf conf, List>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505606288 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -125,6 +133,22 @@ public ListBucketingCtx getLbCtx() { public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505604310 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505603811 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505602500 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505602116 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505601391 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505599549 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505595228 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +744,42 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505593646 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505593646 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505593646 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java: ## @@ -178,7 +178,7 @@ public RecordReader>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505590111 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -512,7 +555,30 @@ private void setupWorkWhenUsingManifestFile(MapWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505587606 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505587079 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

SourabhBadhya commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1505586021 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -163,6 +167,26 @@ public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500852533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500818017 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -720,4 +744,42 @@ private static FilesForCommit

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500895017 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -254,18 +286,26 @@ private void generateActualTasks(HiveConf conf, List>

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500872749 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500889203 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500871964 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500868679 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500884580 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -147,18 +171,23 @@ public List> getTasks(HiveConf conf, Object objCtx) {

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500880192 ## ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java: ## @@ -125,6 +133,22 @@ public ListBucketingCtx getLbCtx() { public void

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500878277 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java: ## @@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path condInputPath, MoveWork

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500872749 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500871964 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500868679 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -747,4 +750,18 @@ default List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500862337 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500857349 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) { public RecordReader

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500854772 ## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ## @@ -370,7 +371,8 @@ private InputSplit[] getCombineSplits(JobConf job, int numSplits,

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500852533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500851164 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500851164 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500848177 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500832533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500832533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List

Re: [PR] HIVE-28069: Iceberg: Implement Merge task functionality for Iceberg tables [hive]

deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500832533 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2021,4 +2023,34 @@ public List

  1   2   >