[GitHub] [hive] kgyrtkirk merged pull request #1205: HIVE-23800: Add hooks when HiveServer2 stops due to OutOfMemoryError

2020-10-14 Thread GitBox
kgyrtkirk merged pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] kgyrtkirk merged pull request #1456: HIVE-24106: Abort polling on the operation state when the current thr…

2020-10-14 Thread GitBox
kgyrtkirk merged pull request #1456: URL: https://github.com/apache/hive/pull/1456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] abstractdog merged pull request #1182: HIVE-23712: metadata-only queries return incorrect results with empty acid partition

2020-10-14 Thread GitBox
abstractdog merged pull request #1182: URL: https://github.com/apache/hive/pull/1182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1544: HIVE-24221: Use vectorizable expression to combine multiple columns in semijoin bloom filters

2020-10-14 Thread GitBox
kgyrtkirk commented on a change in pull request #1544: URL: https://github.com/apache/hive/pull/1544#discussion_r504482010 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java ## @@ -233,6 +235,23 @@ public static ExprNodeGenericFuncDesc and(List exp

[GitHub] [hive] pvary commented on a change in pull request #1576: HIVE-24266

2020-10-14 Thread GitBox
pvary commented on a change in pull request #1576: URL: https://github.com/apache/hive/pull/1576#discussion_r504534912 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ## @@ -1156,13 +1157,36 @@ public BISplitStrategy(Context context, FileSystem fs

[GitHub] [hive] szlta commented on a change in pull request #1576: HIVE-24266

2020-10-14 Thread GitBox
szlta commented on a change in pull request #1576: URL: https://github.com/apache/hive/pull/1576#discussion_r504549035 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ## @@ -1156,13 +1157,36 @@ public BISplitStrategy(Context context, FileSystem fs

[GitHub] [hive] kasakrisz commented on a change in pull request #1561: [WIP] Alternative materialized view rewriting

2020-10-14 Thread GitBox
kasakrisz commented on a change in pull request #1561: URL: https://github.com/apache/hive/pull/1561#discussion_r504609534 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java ## @@ -1871,6 +1876,17 @@ public RelNode apply(RelOptCluster cluster, RelOptS

[GitHub] [hive] fsilent opened a new pull request #1579: fix HIVE-24273 grouping key is case sensitive

2020-10-14 Thread GitBox
fsilent opened a new pull request #1579: URL: https://github.com/apache/hive/pull/1579 ### What changes were proposed in this pull request? fix HIVE-24273 grouping key is case sensitive ### Why are the changes needed? i think this function should case insensitive

[GitHub] [hive] zabetak commented on a change in pull request #1544: HIVE-24221: Use vectorizable expression to combine multiple columns in semijoin bloom filters

2020-10-14 Thread GitBox
zabetak commented on a change in pull request #1544: URL: https://github.com/apache/hive/pull/1544#discussion_r504638460 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java ## @@ -233,6 +235,23 @@ public static ExprNodeGenericFuncDesc and(List exps)

[GitHub] [hive] szehonCriteo commented on pull request #1537: HIVE-19253 : HMS ignores tableType property for external tables

2020-10-14 Thread GitBox
szehonCriteo commented on pull request #1537: URL: https://github.com/apache/hive/pull/1537#issuecomment-708377965 HI Vihang, thanks for looking at the review. I took a look at failing test TestHiveMetastoreTransformation, I'm not at all familiar with the new feature, looked a bit fo

[GitHub] [hive] sankarh commented on pull request #1570: HIVE-24257: Wrong check constraint naming in Hivemetastore

2020-10-14 Thread GitBox
sankarh commented on pull request #1570: URL: https://github.com/apache/hive/pull/1570#issuecomment-708389751 I think, this change breaks the backward compatibility and HMS client interface will be impacted. We cannot change it now.

[GitHub] [hive] yongzhi opened a new pull request #1580: HIVE-24253: HMS and HS2 needs to support keystore/truststores types b…

2020-10-14 Thread GitBox
yongzhi opened a new pull request #1580: URL: https://github.com/apache/hive/pull/1580 …esides JKS by config HiveServer2: Add new properties: hive.server2.keystore.type JDBC: Remove hard-coded SSL_TRUST_STORE_TYPE(JKS) from jdbc connection for HS2 Add trustStore

[GitHub] [hive] szlta merged pull request #1576: HIVE-24266

2020-10-14 Thread GitBox
szlta merged pull request #1576: URL: https://github.com/apache/hive/pull/1576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hive] rajkrrsingh opened a new pull request #1581: Hive 24276: HiveServer2 loggerconf jsp Cross-Site Scripting (XSS) Vulnerability

2020-10-14 Thread GitBox
rajkrrsingh opened a new pull request #1581: URL: https://github.com/apache/hive/pull/1581 ### What changes were proposed in this pull request? The changes includes the js changes which sanitize the user input after escaping the special chars. ### Why are the changes n

[GitHub] [hive] jcamachor commented on a change in pull request #1542: HIVE-24217. HMS storage backend for HPL/SQL stored procedures (amagyar)

2020-10-14 Thread GitBox
jcamachor commented on a change in pull request #1542: URL: https://github.com/apache/hive/pull/1542#discussion_r504964132 ## File path: standalone-metastore/metastore-server/src/main/resources/package.jdo ## @@ -1549,6 +1549,83 @@ + + + +

[GitHub] [hive] risdenk commented on a change in pull request #1580: HIVE-24253: HMS and HS2 needs to support keystore/truststores types b…

2020-10-14 Thread GitBox
risdenk commented on a change in pull request #1580: URL: https://github.com/apache/hive/pull/1580#discussion_r504976602 ## File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java ## @@ -136,6 +136,12 @@ public void onClosed(Connection connecti

[GitHub] [hive] mustafaiman commented on a change in pull request #1577: HIVE-24270: Move scratchdir cleanup to background

2020-10-14 Thread GitBox
mustafaiman commented on a change in pull request #1577: URL: https://github.com/apache/hive/pull/1577#discussion_r505043441 ## File path: ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ## @@ -1852,6 +1863,9 @@ public void close() throws IOException { cl

[GitHub] [hive] hliu-robinhood opened a new pull request #1582: [hive][audit_log] change hive audit log format to be compatible with flink-based rh event logging pipeline

2020-10-14 Thread GitBox
hliu-robinhood opened a new pull request #1582: URL: https://github.com/apache/hive/pull/1582 change hive audit log format(unformatted -> json) to be compatible with flink-based rh event logging pipeline This is an automated

[GitHub] [hive] hliu-robinhood closed pull request #1582: [hive][audit_log] change hive audit log format to be compatible with flink-based rh event logging pipeline

2020-10-14 Thread GitBox
hliu-robinhood closed pull request #1582: URL: https://github.com/apache/hive/pull/1582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] yongzhi commented on a change in pull request #1580: HIVE-24253: HMS and HS2 needs to support keystore/truststores types b…

2020-10-14 Thread GitBox
yongzhi commented on a change in pull request #1580: URL: https://github.com/apache/hive/pull/1580#discussion_r505082133 ## File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java ## @@ -136,6 +136,12 @@ public void onClosed(Connection connecti

[GitHub] [hive] github-actions[bot] closed pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

2020-10-14 Thread GitBox
github-actions[bot] closed pull request #1358: URL: https://github.com/apache/hive/pull/1358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] github-actions[bot] commented on pull request #1406: HIVE-24042: Fix typo in MetastoreConf.java

2020-10-14 Thread GitBox
github-actions[bot] commented on pull request #1406: URL: https://github.com/apache/hive/pull/1406#issuecomment-708794434 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach o

[GitHub] [hive] github-actions[bot] closed pull request #1214: HIVE-23811: deleteReader SARG rowId/bucketId are not getting validated properly

2020-10-14 Thread GitBox
github-actions[bot] closed pull request #1214: URL: https://github.com/apache/hive/pull/1214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] github-actions[bot] commented on pull request #1407: HIVE-24043: Retain original path info in Warehouse.makeSpecFromName()'s logger

2020-10-14 Thread GitBox
github-actions[bot] commented on pull request #1407: URL: https://github.com/apache/hive/pull/1407#issuecomment-708794402 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach o

[GitHub] [hive] yongzhi commented on a change in pull request #1580: HIVE-24253: HMS and HS2 needs to support keystore/truststores types b…

2020-10-14 Thread GitBox
yongzhi commented on a change in pull request #1580: URL: https://github.com/apache/hive/pull/1580#discussion_r505131640 ## File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java ## @@ -136,6 +136,12 @@ public void onClosed(Connection connecti