Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4748: URL: https://github.com/apache/hive/pull/4748#issuecomment-1763871575 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27169: New Locked List to prevent configuration change at runtime without throwing error [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4731: URL: https://github.com/apache/hive/pull/4731#issuecomment-1763885645 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27784: Backport of HIVE-20364, HIVE-20549 to branch-3 [hive]

2023-10-16 Thread via GitHub
sankarh merged PR #4789: URL: https://github.com/apache/hive/pull/4789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

Re: [PR] HIVE-27509: query-executors fail to start: java.lang.NoSuchFieldError… [hive]

2023-10-16 Thread via GitHub
abstractdog commented on code in PR #4758: URL: https://github.com/apache/hive/pull/4758#discussion_r1360283228 ## common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java: ## @@ -95,6 +97,142 @@ public void testConfProperties() throws Exception { // Test HiveConf pr

Re: [PR] HIVE-27695: Intermittent OOM when running TestMiniTezCliDriver [hive]

2023-10-16 Thread via GitHub
zabetak closed pull request #4792: HIVE-27695: Intermittent OOM when running TestMiniTezCliDriver URL: https://github.com/apache/hive/pull/4792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] HIVE-27798: Corrected wrong hive-site.xml [hive]

2023-10-16 Thread via GitHub
ayushtkn merged PR #4803: URL: https://github.com/apache/hive/pull/4803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-16 Thread via GitHub
abstractdog commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1360314764 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java: ## @@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception { .getParamet

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-16 Thread via GitHub
abstractdog commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1360314764 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java: ## @@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception { .getParamet

Re: [PR] HIVE-27686 ORC upgraded to 1.8.5. [hive]

2023-10-16 Thread via GitHub
abstractdog merged PR #4690: URL: https://github.com/apache/hive/pull/4690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-16 Thread via GitHub
zabetak commented on code in PR #4777: URL: https://github.com/apache/hive/pull/4777#discussion_r1360398549 ## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ## @@ -3860,6 +3860,17 @@ public static enum ConfVars { "is discouraged. It suffers from known bugs

Re: [PR] HIVE-27745 : Create a test which validates Schematool sanity [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4791: URL: https://github.com/apache/hive/pull/4791#issuecomment-1764238222 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27783: Iceberg: Implement Copy-On-Write for Update queries [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4781: URL: https://github.com/apache/hive/pull/4781#issuecomment-1764253384 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-16 Thread via GitHub
zabetak commented on code in PR #4777: URL: https://github.com/apache/hive/pull/4777#discussion_r1360511958 ## ql/src/test/queries/clientpositive/test_unixtimestamp_for_invaild_dates.q: ## @@ -0,0 +1,20 @@ +DESCRIBE FUNCTION UNIX_TIMESTAMP; Review Comment: There is a small i

[PR] HIVE-27802: Simplify TestTezSessionState.testSymlinkedLocalFilesAreLocalizedOnce [hive]

2023-10-16 Thread via GitHub
abstractdog opened a new pull request, #4804: URL: https://github.com/apache/hive/pull/4804 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the

Re: [PR] HIVE-27802: Simplify TestTezSessionState.testSymlinkedLocalFilesAreLocalizedOnce [hive]

2023-10-16 Thread via GitHub
abstractdog commented on PR #4804: URL: https://github.com/apache/hive/pull/4804#issuecomment-1764282668 @ayushtkn : can you please take a quick look? small change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] HIVE-27786: Iceberg: Eliminate engine.hive.enabled table property. [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4793: URL: https://github.com/apache/hive/pull/4793#issuecomment-1764295220 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4748: URL: https://github.com/apache/hive/pull/4748#issuecomment-1764354746 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-16 Thread via GitHub
zabetak closed pull request #4777: HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates URL: https://github.com/apache/hive/pull/4777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] HIVE-27772: Hive UNIX_TIMESTAMP() should return null for invalid dates [hive]

2023-10-16 Thread via GitHub
zabetak commented on PR #4777: URL: https://github.com/apache/hive/pull/4777#issuecomment-1764505680 I applied some minor changes before committing: * Simplify the description of the new property by referencing the `ResolverStyle` API. * Drop test cases around the case sensitivity of r

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-16 Thread via GitHub
tarak271 commented on code in PR #4577: URL: https://github.com/apache/hive/pull/4577#discussion_r1360787412 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/InitiatorBase.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-16 Thread via GitHub
tarak271 commented on code in PR #4577: URL: https://github.com/apache/hive/pull/4577#discussion_r1360787960 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/InitiatorBase.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-16 Thread via GitHub
tarak271 commented on code in PR #4577: URL: https://github.com/apache/hive/pull/4577#discussion_r1360788501 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/InitiatorBase.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-16 Thread via GitHub
tarak271 commented on code in PR #4577: URL: https://github.com/apache/hive/pull/4577#discussion_r1360788940 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/InitiatorBase.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] HIVE-27802: Simplify TestTezSessionState.testSymlinkedLocalFilesAreLocalizedOnce [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4804: URL: https://github.com/apache/hive/pull/4804#issuecomment-1764731502 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27169: New Locked List to prevent configuration change at runtime without throwing error [hive]

2023-10-16 Thread via GitHub
pkumarsinha merged PR #4731: URL: https://github.com/apache/hive/pull/4731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27481: TxnHandler cleanup [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4566: URL: https://github.com/apache/hive/pull/4566#issuecomment-1764852806 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27783: Iceberg: Implement Copy-On-Write for Update queries [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4781: URL: https://github.com/apache/hive/pull/4781#issuecomment-1764877242 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27682: AlterTableAlterPartitionOperation cannot change the colum… [hive]

2023-10-16 Thread via GitHub
saihemanth-cloudera commented on code in PR #4684: URL: https://github.com/apache/hive/pull/4684#discussion_r1360974185 ## ql/src/test/results/clientpositive/llap/alter_partition_coltype.q.out: ## @@ -453,6 +453,16 @@ POSTHOOK: Input: default@src POSTHOOK: Output: pt@alterdynam

Re: [PR] HIVE-27682: AlterTableAlterPartitionOperation cannot change the colum… [hive]

2023-10-16 Thread via GitHub
dengzhhu653 merged PR #4684: URL: https://github.com/apache/hive/pull/4684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4748: URL: https://github.com/apache/hive/pull/4748#issuecomment-1765624666 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27509: query-executors fail to start: java.lang.NoSuchFieldError… [hive]

2023-10-16 Thread via GitHub
mayankkunwar commented on code in PR #4758: URL: https://github.com/apache/hive/pull/4758#discussion_r1361522245 ## common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java: ## @@ -95,6 +97,142 @@ public void testConfProperties() throws Exception { // Test HiveConf p

Re: [PR] HIVE-27509: query-executors fail to start: java.lang.NoSuchFieldError… [hive]

2023-10-16 Thread via GitHub
mayankkunwar commented on code in PR #4758: URL: https://github.com/apache/hive/pull/4758#discussion_r1361522245 ## common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java: ## @@ -95,6 +97,142 @@ public void testConfProperties() throws Exception { // Test HiveConf p

Re: [PR] HIVE-27802: Simplify TestTezSessionState.testSymlinkedLocalFilesAreLocalizedOnce [hive]

2023-10-16 Thread via GitHub
abstractdog merged PR #4804: URL: https://github.com/apache/hive/pull/4804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #4748: URL: https://github.com/apache/hive/pull/4748#issuecomment-1765756146 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality