abstractdog commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1360314764
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##########
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"1", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"4", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"704", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"705", parameters.get("totalSize"));
Review Comment:
okay, makes sense, so we can agree to remove totalSize checks here from
every place that were affected by this ORC upgrade and do the rest in
subsequent patches, like
[HIVE-27791](https://issues.apache.org/jira/browse/HIVE-27791)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
