subject:"Re\: \[PR\] ARTEMIS\-4680 \- Upgrade the console to use HawtIO 4 \[activemq\-artemis\-console\]"

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-29 Thread via GitHub



gemmellr commented on PR #17:
URL: 
https://github.com/apache/activemq-artemis-console/pull/17#issuecomment-2137267999

   Pushed a small fixup, then merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-29 Thread via GitHub



gemmellr merged PR #17:
URL: https://github.com/apache/activemq-artemis-console/pull/17


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-29 Thread via GitHub



andytaylor commented on PR #17:
URL: 
https://github.com/apache/activemq-artemis-console/pull/17#issuecomment-2137212380

   updated as per comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-29 Thread via GitHub



gemmellr commented on code in PR #17:
URL: 
https://github.com/apache/activemq-artemis-console/pull/17#discussion_r1618584239


##
LICENSE:
##
@@ -201,150 +201,10 @@
See the License for the specific language governing permissions and
limitations under the License.
 
-
-= For The Node cjs file for yarn under 
artemis-extension/.yarn/releases/yarn-.cjs =
-
-
-*
- * Copyright (c) 2014-present, Jon Schlinkert.
- * Licensed under the MIT License.
- */
-/*!
- * is-extglob 
- *
- * Copyright (c) 2014-2016, Jon Schlinkert.
- * Licensed under the MIT License.
- */
-/*!
- * is-glob 
- *
- * Copyright (c) 2014-2017, Jon Schlinkert.
- * Released under the MIT License.
- */
-/*!
- * is-number 
- *
- * Copyright (c) 2014-present, Jon Schlinkert.
- * Released under the MIT License.
- */
-/*!
- * is-windows 
- *
- * Copyright © 2015-2018, Jon Schlinkert.
- * Released under the MIT License.
- */
-/*!
- * to-regex-range 
- *
- * Copyright (c) 2015-present, Jon Schlinkert.
- * Released under the MIT License.
- */
-/**
-  @license
-  Copyright (c) 2015, Rebecca Turner
-
-  Permission to use, copy, modify, and/or distribute this software for any
-  purpose with or without fee is hereby granted, provided that the above
-  copyright notice and this permission notice appear in all copies.
-
-  THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
-  REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY 
AND
-  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
-  INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
-  LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
-  OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
-  PERFORMANCE OF THIS SOFTWARE.
- */
-/**
-  @license
-  Copyright Joyent, Inc. and other Node contributors.
-
-  Permission is hereby granted, free of charge, to any person obtaining a
-  copy of this software and associated documentation files (the
-  "Software"), to deal in the Software without restriction, including
-  without limitation the rights to use, copy, modify, merge, publish,
-  distribute, sublicense, and/or sell copies of the Software, and to permit
-  persons to whom the Software is furnished to do so, subject to the
-  following conditions:
-
-  The above copyright notice and this permission notice shall be included
-  in all copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
-  OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-  MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
-  NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
-  DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
-  OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
-  USE OR OTHER DEALINGS IN THE SOFTWARE.
-*/
-/**
-  @license
-  Copyright Node.js contributors. All rights reserved.
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to
-  deal in the Software without restriction, including without limitation the
-  rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
-  sell copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in
-  all copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-  FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
-  IN THE SOFTWARE.
-*/
-/**
-  @license
-  The MIT License (MIT)
-
-  Copyright (c) 2014 Blake Embrey (he...@blakeembrey.com)
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-28 Thread via GitHub



gemmellr merged PR #16:
URL: https://github.com/apache/activemq-artemis-console/pull/16


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-15 Thread via GitHub



gemmellr merged PR #15:
URL: https://github.com/apache/activemq-artemis-console/pull/15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-15 Thread via GitHub



andytaylor commented on PR #15:
URL: 
https://github.com/apache/activemq-artemis-console/pull/15#issuecomment-2112011157

   > All looks good to me! Checking out this PR gave me the opportunity to run 
the hawtio console for the first time.
   > 
   > Maybe it would be worth it to split the PR into a few commits though, I 
feel that there is space for at least one commit for the dependencies update 
and one commit for the UI fixes.
   
   I have split it into 2 commits as suggested


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-02 Thread via GitHub



gemmellr merged PR #14:
URL: https://github.com/apache/activemq-artemis-console/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-02 Thread via GitHub



gemmellr merged PR #11:
URL: https://github.com/apache/activemq-artemis-console/pull/11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



gemmellr commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2088688383

   Seems good to me now, and given its been over a month across 2 repos without 
a single comment from anybody else...merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



gemmellr merged PR #2:
URL: https://github.com/apache/activemq-artemis-console/pull/2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1586246683


##
pom.xml:
##
@@ -0,0 +1,226 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache
+apache
+31
+org.apache:apache
+
+
+org.apache.activemq
+artemis-console-project
+pom
+1.0.0-SNAPSHOT
+
+
+
+artemis-console-extension
+artemis-console-war
+artemis-console-distribution
+
+
+ActiveMQ Artemis Console Plugin
+https://activemq.apache.org/components/artemis/
+
+
+11
+11
+11
+4.0.0
+5.0.0
+2.0.12
+2.22.1
+11.0.20
+v20.9.0
+v1.22.21
+1.15.0
+
+artemis-extension
+
2024-03-27T00:00:01Z
+
+
+
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  https://github.com/apache/activemq-artemis-console-plugin
+  HEAD
+
+
+
+  JIRA
+  https://issues.apache.org/jira/browse/ARTEMIS
+
+
+
+  
+ The Apache ActiveMQ Team
+ d...@activemq.apache.org
+ http://activemq.apache.org
+ Apache Software Foundation
+ http://apache.org/
+  
+   
+   
+  
+ User List
+ users-subscr...@activemq.apache.org
+ users-unsubscr...@activemq.apache.org
+ us...@activemq.apache.org
+  
+  
+ Development List
+ dev-subscr...@activemq.apache.org
+ dev-unsubscr...@activemq.apache.org
+ d...@activemq.apache.org
+  
+   
+
+
+
+release
+
+
+
+org.apache.rat
+apache-rat-plugin
+
+
+compile
+
+check
+
+
+
+
+
+org.apache.maven.plugins
+maven-checkstyle-plugin
+
+
+compile
+
+check
+
+
+
+
+
+
+
+
+
+apache-release
+
+
+
+maven-assembly-plugin
+
+
+source-release-assembly
+
+true
+
+
+
+
+
+
+
+
+
+
+
+
+
+io.hawt
+hawtio-system
+${hawtio.version}
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+${jakarta.servlet-api.version}
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+${slf4j.version}
+
+

Review Comment:
   I have done the former



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



gemmellr commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1586077228


##
artemis-console-extension/pom.xml:
##
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-extension
+pom
+
+
+ActiveMQ Artemis Console

Review Comment:
   ActiveMQ Artemis Console Extension?



##
NOTICE:
##
@@ -0,0 +1,5 @@
+Apache ActiveMQ Artemis Console Plugin

Review Comment:
   Drop the "Plugin" now ?



##
pom.xml:
##
@@ -0,0 +1,226 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache
+apache
+31
+org.apache:apache
+
+
+org.apache.activemq
+artemis-console-project
+pom
+1.0.0-SNAPSHOT
+
+
+
+artemis-console-extension
+artemis-console-war
+artemis-console-distribution
+
+
+ActiveMQ Artemis Console Plugin
+https://activemq.apache.org/components/artemis/
+
+
+11
+11
+11
+4.0.0
+5.0.0
+2.0.12
+2.22.1
+11.0.20
+v20.9.0
+v1.22.21
+1.15.0
+
+artemis-extension
+
2024-03-27T00:00:01Z
+
+
+
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  https://github.com/apache/activemq-artemis-console-plugin

Review Comment:
   Still needs updated to drop 'plugin' to reflect the renamed repo.



##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,118 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+org.apache.activemq
+artemis-console-extension
+pom
+${project.version}
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+${slf4j.version}
+
+
+org.apache.logging.log4j
+log4j-slf4j2-impl
+${log4j.version}

Review Comment:
   Should drop the versions and use the dependencyManagement from parent (need 
to add the log4j-slf4j2-impl dep there)



##
pom.xml:
##
@@ -0,0 +1,226 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache
+apache
+31
+org.apache:apache
+
+
+org.apache.activemq
+artemis-console-project
+pom
+1.0.0-SNAPSHOT
+
+
+
+artemis-console-extension
+artemis-console-war
+artemis-console-distribution
+
+
+ActiveMQ Artemis Console Plugin
+https://activemq.apache.org/components/artemis/
+
+
+11
+11
+11
+4.0.0
+5.0.0
+2.0.12
+2.22.1
+11.0.20
+v20.9.0
+v1.22.21
+1.15.0
+
+artemis-extension
+
2024-03-27T00:00:01Z
+
+
+
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  https://github.com/apache/activemq-artemis-console-plugin
+  HEAD
+
+
+
+  JIRA
+  https://issues.apache.org/jira/browse/ARTEMIS
+
+
+
+  
+ The Apache ActiveMQ Team
+ d...@activemq.apache.org
+ http://activemq.apache.org
+ Apache Software Foundation
+ http://apache.org/
+  
+   
+   
+  
+ User List
+ users-subscr...@activemq.apache.org
+ users-unsubscr...@activemq.apache.org
+ us...@activemq.apache.org
+  
+  
+ Development List
+ dev-subscr...@activemq.apache.org
+ dev-unsubscr...@activemq.apache.org
+ d...@activemq.apache.org
+  
+   
+
+
+

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585945469


##
artemis-console-extension/artemis-extension/src/artemis-extension/artemis/brokers/BrokerTopology.tsx:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import * as React from 'react';
+
+import { RegionsIcon as Icon1 } from '@patternfly/react-icons';
+import { FolderOpenIcon as Icon2 } from '@patternfly/react-icons';
+import { ClusterIcon } from '@patternfly/react-icons';
+
+import {
+  ColaLayout,
+  ComponentFactory,
+  DefaultEdge,
+  DefaultGroup,
+  DefaultNode,
+  DragObjectWithType,
+  Edge,
+  EdgeModel,
+  EdgeStyle,
+  Graph,
+  GraphComponent,
+  graphDropTargetSpec,
+  GRAPH_LAYOUT_END_EVENT,
+  groupDropTargetSpec,
+  Layout,
+  LayoutFactory,
+  Model,
+  ModelKind,
+  Node,
+  nodeDragSourceSpec,
+  nodeDropTargetSpec,
+  NodeModel,
+  NodeShape,
+  NodeStatus,
+  observer,
+  SELECTION_EVENT,
+  TopologyView,
+  Visualization,
+  VisualizationProvider,
+  VisualizationSurface,
+  withDndDrop,
+  WithDndDropProps,
+  withDragNode,
+  WithDragNodeProps,
+  withPanZoom,
+  withSelection,
+  WithSelectionProps,
+  withTargetDrag
+} from '@patternfly/react-topology';
+import { useEffect, useState } from 'react';
+import { artemisService, BrokerInfo } from '../artemis-service';
+import { eventService } from '@hawtio/react';
+import { ToolbarItem, Select, SelectVariant, SelectOption } from 
'@patternfly/react-core';
+
+
+const BadgeColors = [
+  {
+name: 'A',
+badgeColor: '#ace12e',
+badgeTextColor: '#0f280d',
+badgeBorderColor: '#486b00'
+  },
+  {
+name: 'B',
+badgeColor: '#F2F0FC',
+badgeTextColor: '#5752d1',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Broker',
+badgeColor: '#c12766',
+badgeTextColor: 'white',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Address',
+badgeColor: '#3e489f',
+badgeTextColor: 'white',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Queue',
+badgeColor: '#50621d',
+badgeTextColor: 'white',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Internal Address',
+badgeColor: 'white',
+badgeTextColor: 'black',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Internal Queue',
+badgeColor: 'white',
+badgeTextColor: 'black',
+badgeBorderColor: '#CBC1FF'
+  }
+];
+
+interface ControllerState {
+  selectedIds: string[];
+  viewOptions: ViewOptions;
+}
+
+type CustomNodeProps = {
+  element: Node;
+} & WithDragNodeProps;
+
+const CustomNode: React.FC = ({ element, onSelect, selected, ...rest 
 }) => {
+
+  const data = element.getData();
+  const Icon = data.isAlternate ? Icon2 : Icon1;
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+
+  return (  
+
+  
+
+  
+
+  );
+};
+
+const BrokerCustomNode: React.FC = observer(({ element, onSelect, 
selected, ...rest }) => {
+  const data = element.getData();
+  const Icon = ClusterIcon;
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+  const { viewOptions } = element.getController().getState();
+
+  return (
+
+  
+
+  
+
+  );
+});
+
+const AddressCustomNode: React.FC = ({ element, onSelect, selected, ...rest 
 }) => {
+  const data = element.getData();
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+  const { viewOptions } = element.getController().getState();
+
+  return (
+
+
+  );
+};
+
+const InternalAddressCustomNode: React.FC = ({ element, onSelect, selected, 
...rest  }) => {
+  const data = element.getData();
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+  const { viewOptions } = element.getController().getState();
+
+  return (
+
+
+  );
+};
+
+
+const QueueCustomNode: React.FC = ({ element, onSelect, selected, ...rest 
 }) => {
+  const data = element.getData();
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+  const { viewOptions } = element.getController().getState();
+
+  return (
+
+
+  );
+};
+
+const

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585945246


##
README.md:
##
@@ -1 +1,62 @@
-# activemq-artemis-console
+# Apache ActiveMQ Artemis Console
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `artemis-console-extension` frontend 
project and then compiles and packages 
+the main Java project Web Archive in `artemis-console-war`.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+cd artemis-console-war
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 


Review Comment:
   Ive added some docs explaining how to use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585945037


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+
+

Review Comment:
   added a dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-05-01 Thread via GitHub



andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585944729


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+
+
+
+
+${project.artifactId}

Review Comment:
   removed and fixed jetty to pick up fully qualified name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-25 Thread via GitHub



gemmellr commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1579378435


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+
+
+
+
+${project.artifactId}
+
+
+
+
+org.apache.maven.plugins
+maven-war-plugin
+
+
+
+woff2
+woff
+
+
+
+
+true
+
../artemis-console-extension/artemis-extension/build
+
+**/*.*
+
+
+log4j.properties
+
+
+
+
+
+
+
+org.eclipse.jetty
+jetty-maven-plugin
+${jetty-version}

Review Comment:
   Sounds good



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-25 Thread via GitHub



andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1579368288


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+
+
+
+
+${project.artifactId}
+
+
+
+
+org.apache.maven.plugins
+maven-war-plugin
+
+
+
+woff2
+woff
+
+
+
+
+true
+
../artemis-console-extension/artemis-extension/build
+
+**/*.*
+
+
+log4j.properties
+
+
+
+
+
+
+
+org.eclipse.jetty
+jetty-maven-plugin
+${jetty-version}

Review Comment:
   It also omits logging from the webapp itself, I will add log4j which is what 
we use in Artemis and then remove it in Artemis, this will then default to the 
artemis logger and is consistent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-24 Thread via GitHub



gemmellr commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1578032690


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+
+
+
+
+${project.artifactId}
+
+
+
+
+org.apache.maven.plugins
+maven-war-plugin
+
+
+
+woff2
+woff
+

Review Comment:
   This bit is misaligned.



##
README.md:
##
@@ -1 +1,62 @@
-# activemq-artemis-console
+# Apache ActiveMQ Artemis Console
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `artemis-console-extension` frontend 
project and then compiles and packages 
+the main Java project Web Archive in `artemis-console-war`.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+cd artemis-console-war
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 


Review Comment:
   When I try this, I see Jetty starting, and can load a Hawtio console by 
visiting the link, but there is nothing about Artemis in it...there are 
Connect, JMX, and Runtime tabs in the left menu. After a bit of blind prodding 
and looking at my broker console I figured out I needed to 'Connect' it to 
'http://localhost:8161/console/jolokia; ...maybe need some more doc here? Such 
as referencing the _later_ doc that I only then noticed is at the bottom of the 
readme for the _other_ way of doing a local startup for dev (which I haven't 
tried as I don't have yarn system installed, and didn't try to figure out how 
to use the ones from the maven build)



##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+
+
+
+
+${project.artifactId}
+
+
+
+
+org.apache.maven.plugins
+maven-war-plugin
+
+
+
+woff2
+woff
+
+
+
+
+true
+
../artemis-console-extension/artemis-extension/build
+
+**/*.*
+
+
+log4j.properties
+
+
+
+
+
+
+
+org.eclipse.jetty
+

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-24 Thread via GitHub



andytaylor commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2074679300

   Yes it is expected


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-24 Thread via GitHub



gemmellr commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2074654002

   Ok. To be clear though, it does also happen in CI:
   ```
   [INFO] Installing node version v20.9.0
   [INFO] Downloading 
https://nodejs.org/dist/v20.9.0/node-v20.9.0-linux-x64.tar.gz to 
/home/runner/.m2/repository/com/github/eirslett/node/20.9.0/node-20.9.0-linux-x64.tar.gz
   [INFO] No proxies configured
   [INFO] No proxy was configured, downloading directly
   [INFO] Unpacking 
/home/runner/.m2/repository/com/github/eirslett/node/20.9.0/node-20.9.0-linux-x64.tar.gz
 into 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/tmp
   [INFO] Copying node binary from 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/tmp/node-v20.9.0-linux-x64/bin/node
 to 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/node
   [INFO] Installed node locally.
   [INFO] Installing Yarn version v1.22.21
   [INFO] Downloading 
https://github.com/yarnpkg/yarn/releases/download/v1.22.21/yarn-v1.22.21.tar.gz 
to 
/home/runner/.m2/repository/com/github/eirslett/yarn/1.22.21/yarn-1.22.21.tar.gz
   [INFO] No proxies configured
   [INFO] No proxy was configured, downloading directly
   [INFO] Unpacking 
/home/runner/.m2/repository/com/github/eirslett/yarn/1.22.21/yarn-1.22.21.tar.gz
 into 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/yarn
   [INFO] Installed Yarn locally.
   ```
   
   https://github.com/apache/activemq-artemis-console/pull/2/checks#step:4:1308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-24 Thread via GitHub



andytaylor commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2074183992

   If your project is using Yarn Berry (2.x or above), the Yarn version is 
handled per project but a Yarn 1.x install is still needed as a "bootstrap". 
The plugin will try to detect .yarnrc.yml file in the current Maven 
project/module folder, at the root of the multi-module project if relevant, and 
in the folder from which the mvn command was run. If detected, the plugin will 
assume your project is using Yarn Berry. It will install the 1.x Yarn version 
you specify with yarnVersion as bootstrap, then hand over to your 
project-specific version.
   
   It has detected an older version in your env which doesnt happen in CI. In 
short this is expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-23 Thread via GitHub



andytaylor commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2072395564

   The check builds dont show that, Im wondering if its environmental, let me 
do some checking and I will see if this is something we need to address
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console]

2024-04-23 Thread via GitHub



gemmellr commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2072309300

   I havent had a chance to look over the latest changes yet, or actually try 
it, but I did get as far as running the build...and noticed something I wasnt 
expecting in the output. It seems to install an old version of yarn, is that 
expected?
   ```
   [INFO] --- frontend:1.15.0:install-node-and-yarn (install node and yarn) @ 
artemis-console-extension ---
   [INFO] Node v20.9.0 is already installed.
   [INFO] Yarn 3.5.0 was installed, but we need version v1.22.21
   [INFO] Installing Yarn version v1.22.21
   [INFO] Unpacking 
/path/to/.m2/repository/com/github/eirslett/yarn/1.22.21/yarn-1.22.21.tar.gz 
into 
/path/to/activemq-artemis-console/artemis-console-extension/artemis-extension/node/yarn
   [INFO] Installed Yarn locally.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-22 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1574724547


##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Apache ActiveMQ Artemis Console Plugin
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 

+
+## Faster plugin development
+
+You could run `mvn install` or `mvn jetty:run` every time to incrementally 
develop the `activemq-artemis-console` 
+frontend project while checking its behaviour in the browser. But this is not 
suitable for running the fast development feedback cycle.

Review Comment:
   Ive fixed that as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-22 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1574581049


##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Apache ActiveMQ Artemis Console Plugin
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 

+
+## Faster plugin development
+
+You could run `mvn install` or `mvn jetty:run` every time to incrementally 
develop the `activemq-artemis-console` 
+frontend project while checking its behaviour in the browser. But this is not 
suitable for running the fast development feedback cycle.

Review Comment:
   and the other bit? `activemq-artemis-console frontend project` vs earlier 
`frontend project artemis-console-extension`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-22 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1574575303


##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Apache ActiveMQ Artemis Console Plugin
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 

+
+## Faster plugin development
+
+You could run `mvn install` or `mvn jetty:run` every time to incrementally 
develop the `activemq-artemis-console` 
+frontend project while checking its behaviour in the browser. But this is not 
suitable for running the fast development feedback cycle.

Review Comment:
   it is still correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1571109296


##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Apache ActiveMQ Artemis Console Plugin
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 

Review Comment:
   Name seems off



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Apache ActiveMQ Artemis Console Plugin
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 

+
+## Faster plugin development
+
+You could run `mvn install` or `mvn jetty:run` every time to incrementally 
develop the `activemq-artemis-console` 
+frontend project while checking its behaviour in the browser. But this is not 
suitable for running the fast development feedback cycle.
+
+As shown below, a faster development cycle can be achieved by directly running 
the `activemq-artemis-console-plugin` 

Review Comment:
   another plugin mention



##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api

Review Comment:
   Would set it as provided scope here rather than relying on the 
dependencyManagement scope, its clearer..especially given the comment above it.



##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,92 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+apache-artemis-console
+pom
+
+
+ActiveMQ Artemis Console Source Distribution
+
+
+${project.basedir}/..
+
+
+
+
+
+apache-release
+
+
+
+maven-assembly-plugin
+
+
+source
+
+
+
src/main/assembly/source-assembly.xml
+
+posix
+
+package
+
+single
+
+
+
+

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570901599


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   Sounds good, that would be my preference also.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570867354


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I will use artemis-console-extension as this is actually what it is. I think 
artemis-console-war is fine, starting at a 1.0.0 seems the right thing to do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570614130


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   Renaming `artemis-console-war` to `artemis-console` would be less strange 
though, since both are wars people might referencebut again we would need 
to use a higher version than will ever be used for the existing war. Which then 
initially might have a broker-versioned number by coincidence and diverge later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570614130


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   Renaming artemis-console-war to artemis-console would be less strange 
though, since both are wars people might referencebut again we would need 
to use a higher version than will ever be used for the existing war. Which then 
initially might have a broker-versioned number by coincidence and diverge later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570604745


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   As before, we should probably avoid `artemis-console`, because it does 
clash, and though its only a pom it is still going to be published.
   
   We cant 'go backwards' for versions as it creates a significant reporting 
problem for bugs and CVEs around what is/isnt affected...there are also many 
newer broker-versioned released of an '`artemis-console`' that already exist 
with a higher version, so we would never be able to use those versions and 
would have a right mess when that time came. The only way we can use 
`artemis-console` as a module would be to start this repo's releases at a 
version above the range that will ever be occupied by those still-ongoing 
releases of the existing `artemis-console` module.  
https://repo1.maven.org/maven2/org/apache/activemq/artemis-console/
   
   Since it is really a different artifact entirely, that is not actually 
having any jar etc deployed for it (unlike previously), and is being released 
independently of the broker going forward and so wont use matching 
broker-versions...just avoiding the already-used `artemis-console` name seems 
to make more sense than version foolery. Someone today might reference 
`artemis-console` as a module...it doesnt seem like anyone should want to in 
future., however they might be confused into by reuse of the module name for 
something different than before.
   
   My comment was that it doesnt really matter what we call it, as its just a 
pom for doing some local build, and not a module users will refer to...what 
about `artemis-console-build`? `artemis-console-extension`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570604745


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   As before, we should probably avoid artemis-console, because it does clash, 
and though its only a pom it is still going to be published.
   
   We cant 'go backwards' for versions as it creates a significant reporting 
problem for bugs and CVEs around what is/isnt affected...there are also many 
newer broker-versioned released of an 'artemis-console' that already exist with 
a higher version, so we would never be able to use those versions and would 
have a right mess when that time came. The only way we can use artemis-console 
as a module would be to start this repo's releases at a version above the range 
that will ever be occupied by those still-ongoing releases of the existing 
artemis-console module.  
https://repo1.maven.org/maven2/org/apache/activemq/artemis-console/
   
   Since it is really a different artifact entirely, that is not actually 
having any jar etc deployed for it (unlike previously), and is being released 
independently of the broker going forward and so wont use matching 
broker-versions...just avoiding the already-used artemis-console name seems to 
make more sense than version foolery. Someone today might reference 
artemis-console as a module...it doesnt seem like anyone should want to in 
future., however they might be confused into by reuse of the module name for 
something different than before.
   
   My comment was that it doesnt really matter what we call it, as its just a 
pom for doing some local build, and not a module users will refer to...what 
about artemis-console-build? artemis-console-extension?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570522054


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I have renamed it to artemis-console which makes more sense but will it 
still clash if we publish nothing or does the pom still get published? I could 
change it to artemis-console- hawtio, artemis-console-web or something similar. 
wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570522054


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I have renamed it to artemis-console which makes more sense but will it 
still clash if we publish nothing or does the pom still get published, I could 
change it to artemis-console- hawtio, artemis-console-web or something similar. 
wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570513459


##
artemis-console-war/src/main/resources/logback.xml:
##
@@ -0,0 +1,33 @@
+
+
+
+
+
+  
+  
+
+  
+
+  %d{HH:mm:ss} %level {%thread} %-30.30c{1} : %msg%n
+
+  
+
+  
+
+  
+

Review Comment:
   yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570513766


##
pom.xml:
##
@@ -0,0 +1,197 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+artemis-console-project
+pom
+1.0.0-SNAPSHOT
+
+
+org.apache
+apache
+31
+org.apache:apache
+
+
+
+artemis-console-plugin
+artemis-console-war
+artemis-console-distribution
+
+
+ActiveMQ Artemis Console Plugin
+https://activemq.apache.org/components/artemis/
+
+
+11
+11
+11
+4.0.0
+5.0.0
+2.0.11
+11.0.18
+v20.9.0
+v1.22.21
+1.15.0
+
+artemis-plugin
+
2024-03-27T00:00:01Z
+
+
+
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  
scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git
+  https://github.com/apache/activemq-artemis-console-plugin
+  HEAD
+
+
+
+  JIRA
+  https://issues.apache.org/jira/browse/ARTEMIS
+
+
+
+  
+ The Apache ActiveMQ Team
+ d...@activemq.apache.org
+ http://activemq.apache.org
+ Apache Software Foundation
+ http://apache.org/
+  
+   
+   
+  
+ User List
+ users-subscr...@activemq.apache.org
+ users-unsubscr...@activemq.apache.org
+ us...@activemq.apache.org
+  
+  
+ Development List
+ dev-subscr...@activemq.apache.org
+ dev-unsubscr...@activemq.apache.org
+ d...@activemq.apache.org
+  
+   
+
+
+
+
+apache-release
+
+
+
+maven-assembly-plugin
+
+
+source-release-assembly
+
+true
+
+
+
+
+
+
+
+
+
+
+
+
+io.hawt
+hawtio-system
+${hawtio.version}
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+${jakarta.servlet-api.version}
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+${slf4j.version}
+
+
+
+
+
+
+
+org.apache.rat
+apache-rat-plugin
+
+
+compile
+
+check
+
+
+
+
**/artemis-plugin/src/artemis-plugin/artemis/help.md
+
artemis-console/artemis-plugin/package.json
+
artemis-console/artemis-plugin/tsconfig.json
+
artemis-console/artemis-plugin/yarn.lock
+README.md
+
artemis-console/artemis-plugin/public/hawtconfig.json
+
+
+**/node/**
+**/node_modules/**
+**/package.json
+**/package-lock.json
+
+
+**/.yarn/**
+**/yarn.lock
+
**/artemis-plugin/build/**
+
artemis-console/artemis-plugin/yarn.lock
+
+
+
+
+
+
+

Review Comment:
   added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570437951


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh
+
+
+**/artemis-plugin/node/**
+**/artemis-plugin/node_modules/**
+**/artemis-plugin/build/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/install-state.gz

Review Comment:
   yeah, I will do that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570432266


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh
+
+
+**/artemis-plugin/node/**
+**/artemis-plugin/node_modules/**
+**/artemis-plugin/build/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/install-state.gz

Review Comment:
   I'd guess it may need to be a separate fileSet, as adding an inclusion would 
probably mean this fileSet isnt then 'including everything'. Whatever way works 
seems fine though.
   
   Its pretty standard practice to 'exclude wider area then include only the 
things you want from it' versus 'include wider area and exclude all the things 
you dont want'. Depends which is simpler and safer. It seems more likely here 
that there will be additional things we dont want to include, that we dont 
currently know about (especially as we aren't the ones creating them), than it 
does that there will be additional things we do want to include that we wont 
know about (as we are the ones including them).
   
   (Considerations like this were another part of why I originally queried it 
being in the repo at all)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570370040


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh
+
+
+**/artemis-plugin/node/**
+**/artemis-plugin/node_modules/**
+**/artemis-plugin/build/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/install-state.gz

Review Comment:
   Do you mean as a separate Fileset or just add includes to the current one 
like
   
   
   **/artemis-plugin/.yarn/releases/yarn*.cjs
   **
   
   The latter just seems messy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570370040


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh
+
+
+**/artemis-plugin/node/**
+**/artemis-plugin/node_modules/**
+**/artemis-plugin/build/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/install-state.gz

Review Comment:
   Do you mean as a separate Fileset or just add includes to the current one 
like
   
   
   **/artemis-plugin/.yarn/releases/yarn*.cjs
   **

   
   The latter just seems messy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570367927


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   > > I do think we should rename the repo to 
activemq-[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console),
 how do we get that done?
   > 
   > First, discuss and agree it on the listthen if agreed, we could either 
create the new repo and then ask infra to delete this old one, or else ask if 
infra will rename this one. They might want a vote as assurance before the 
rename or delete.
   > 
   
   Ok, I will send out an email to discuss
   
   > > I did think about changing the 
[artemis-console-plugin](https://issues.apache.org/jira/browse/ARTEMIS-console-plugin)
 to [artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) 
but I thought that would clash with the 
[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) module 
currently in activemq-artemis at some point, wdyt?
   > 
   > Yeah we definitely need to avoid clashing with existing artemis module 
GAVs for anything published, which is most easily done by avoiding the same 
module name (we could play with increased versions, but...still messy when both 
are still around).
   > 
   > From what I see, it looks like the `artemis-console-plugin` module is just 
a pom that doesnt actually deploy anything except itself, and rather just 
builds stuff locally into a dir currently that other stuff then uses. So its 
name actually seems largely inconsequential, seems like noone is really likely 
to reference the deployed module itself currently (but rather, reference the 
war instead)? Or am I missing something?
   
   no you are correct
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570361047


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   > I do think we should rename the repo to 
activemq-[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console),
 how do we get that done?
   > 
   
   First, discuss and agree it on the listthen if agreed, we could either 
create the new repo and then ask infra to delete this old one, or else ask if 
infra will rename this one. They might want a vote as assurance before the 
rename or delete.
   
   > I did think about changing the 
[artemis-console-plugin](https://issues.apache.org/jira/browse/ARTEMIS-console-plugin)
 to [artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) 
but I thought that would clash with the 
[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) module 
currently in activemq-artemis at some point, wdyt?
   
   Yeah we definitely need to avoid clashing with existing artemis module GAVs 
for anything published, which is most easily done by avoiding the same module 
name (we could play with increased versions, but...still messy when both are 
still around).
   
   From what I see, it looks like the `artemis-console-plugin` module is just a 
pom that doesnt actually deploy anything except itself, and rather just builds 
stuff locally into a dir currently that other stuff then uses. So its name 
actually seems largely inconsequential, seems like noone is really likely to 
reference the deployed module itself currently (but rather, reference the war 
instead)? Or am I missing something?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570361047


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   > I do think we should rename the repo to 
activemq-[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console),
 how do we get that done?
   > 
   
   First, discuss and agree it on the listthen if agreed, we could either 
create the new repo and then ask infra to delete this old one, or else ask if 
infra will rename this one. They might want a vote as assurance before the 
rename or delete.
   
   > I did think about changing the 
[artemis-console-plugin](https://issues.apache.org/jira/browse/ARTEMIS-console-plugin)
 to [artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) 
but I thought that would clash with the 
[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) module 
currently in activemq-artemis at some point, wdyt?
   
   Yeah we definitely need to avoid clashing with existing artemis module GAVs 
for anything published, which is most easily done by avoiding the same module 
name (we could play with increased versions, but...still messy when both are 
still around).
   
   From what I see, it looks like the artemis-console-plugin module is just a 
pom that doesnt actually deploy anything except itself, and rather just builds 
stuff locally into a dir currently that other stuff then uses. So its name 
actually seems largely inconsequential, seems like noone is really likely to 
reference the deployed module itself currently (but rather, reference the war 
instead)? Or am I missing something?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570304328


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh
+
+
+**/artemis-plugin/node/**
+**/artemis-plugin/node_modules/**
+**/artemis-plugin/build/**

Review Comment:
   ignore that, I see why now, will change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570229666


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh
+
+
+**/artemis-plugin/node/**
+**/artemis-plugin/node_modules/**
+**/artemis-plugin/build/**

Review Comment:
   neither
   
   artemis-plugin/node/**
   
   or
   
   /artemis-plugin/node/**
   
   seem to work, Im not sure why



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-18 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570200077


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I do think we should rename the repo to activemq-artemis-console, how do we 
get that done?
   
   I did think about changing the artemis-console-plugin to artemis-console but 
I thought that would clash with the artemis-console module currently in 
activemq-artemis at some point, wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-17 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1568739101


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh

Review Comment:
   Presumably you got these from the main artemis repo equivalent. It also has 
a matching _include_ that pulls in the scripts with the correct fileMode. I 
dont think you have any scripts dir, or possibly scripts at all, so you 
shouldnt need these excludes...and dont have the related includes.



##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+  
+  
+ ..
+ ${file.separator}
+ true
+ 0755
+ 0644
+ 
+scripts/*.sh
+**/**/*.sh
+
+
+**/artemis-plugin/node/**
+**/artemis-plugin/node_modules/**
+**/artemis-plugin/build/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/cache/**
+**/artemis-plugin/.yarn/install-state.gz

Review Comment:
   Rather than exclude specific items, which is fragile in terms of allowing 
new stuff in later that shouldnt be there...can you just exclude the entire 
parent dir and then include the bit you do want inside it?



##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   The module dir is called _`artemis-console-distribution`_ but this overall 
repo is for _`artemis-console-plugin`_. I'd expect them to be more aligned, 
especially as this seems to be a source-only distribution module anyway.
   
   Is it not really 'just the plugin'and if so, should we be renaming the 
repo to activemq-artemis-console after all?



##
.gitignore:
##
@@ -0,0 +1,25 @@
+.github/workflows/build.yml

Review Comment:
   I dont think we would want to ignore changes to the CI job?



##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+artemis-console-war
+war
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+ActiveMQ Artemis Console War
+
+
+
+
+io.hawt
+hawtio-system
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+
+

Review Comment:
   This is dependencyManagement...but there are no dependencies that I can see 
that would use it. Is this superfluous, or is there magic happening?
   
   (EDIT: ah, see later comment about deps in root pom)



##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+apache-artemis-console
+pom
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+

Review Comment:
   Parent is more usually declared after the pom model version, then the GA[V] 
etc.  (Same comment for other modules too).
   
   The module name and parent name also both add to the 'does repo need 
renamed?' question.
   
   ```suggestion
   4.0.0
   
   
   org.apache.activemq
   artemis-console-project
   1.0.0-SNAPSHOT
   
   
   org.apache.activemq
   apache-artemis-console
   pom
   ```



##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-12 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1562659257


##
pom.xml:
##
@@ -0,0 +1,253 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+artemis-console-plugin
+war

Review Comment:
   I have added a root pom and also a source assembly



##
pom.xml:
##
@@ -0,0 +1,253 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+artemis-console-plugin
+war
+1.0.0-SNAPSHOT
+
+
+org.apache
+apache
+23
+org.apache:apache
+
+
+ActiveMQ Artemis Console Plugin
+
+
+
+11
+11
+
+artemis-plugin
+4.0.0-RC1
+5.0.0
+1.4.14
+2.0.11
+11.0.18
+v20.9.0
+v1.22.21
+1.15.0
+
+
+
+
+
+io.hawt
+hawtio-plugin-mbean
+${hawtio.version}
+
+
+
+
+jakarta.servlet
+jakarta.servlet-api
+${jakarta.servlet-api.version}
+provided
+
+
+
+
+org.slf4j
+slf4j-api
+${slf4j.version}
+
+
+ch.qos.logback
+logback-classic
+${logback-version}
+

Review Comment:
   I have removed this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-11 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1561070218


##
artemis-plugin/craco.config.js:
##
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ const { ModuleFederationPlugin } = require('webpack').container
+const CracoEsbuildPlugin = require('craco-esbuild')
+const { hawtioBackend } = require('@hawtio/backend-middleware')
+const { dependencies } = require('./package.json')
+
+module.exports = {
+  plugins: [{ plugin: CracoEsbuildPlugin }],
+  webpack: {
+plugins: {
+  add: [
+new ModuleFederationPlugin({
+  // The container name corresponds to 'scope' passed to HawtioPlugin
+  name: 'artemisPlugin',
+  filename: 'remoteEntry.js',
+  // The key in exposes corresponds to 'remote' passed to HawtioPlugin
+  exposes: {
+'./plugin': './src/artemis-plugin',
+  },
+  shared: {
+...dependencies,
+react: {
+  singleton: true,
+  requiredVersion: dependencies['react'],
+},
+'react-dom': {
+  singleton: true,
+  requiredVersion: dependencies['react-dom'],
+},
+'react-router-dom': {
+  singleton: true,
+  requiredVersion: dependencies['react-router-dom'],
+},
+'@hawtio/react': {
+  singleton: true,
+  requiredVersion: dependencies['@hawtio/react'],
+},
+  },
+}),
+  ],
+},
+configure: webpackConfig => {
+  // Required for Module Federation
+  webpackConfig.output.publicPath = 'auto'
+
+  webpackConfig.module.rules.push({
+test: /\.md/,
+type: 'asset/source',
+  })
+
+  // For suppressing sourcemap warnings from dependencies
+  webpackConfig.ignoreWarnings = [/Failed to parse source map/]
+
+   // To resolve errors for @module-federation/utilities 2.x
+  // https://github.com/module-federation/universe/issues/827
+  webpackConfig.resolve = {
+...webpackConfig.resolve,
+fallback: {
+  path: require.resolve('path-browserify'),
+  os: require.resolve('os-browserify'),
+},
+  }
+
+  // MiniCssExtractPlugin - Ignore order as otherwise conflicting order 
warning is raised
+  const miniCssExtractPlugin = webpackConfig.plugins.find(p => 
p.constructor.name === 'MiniCssExtractPlugin')
+  if (miniCssExtractPlugin) {
+miniCssExtractPlugin.options.ignoreOrder = true
+  }
+
+  return webpackConfig
+},
+  },
+  // For plugin development
+  devServer: {
+setupMiddlewares: (middlewares, devServer) => {
+   // Enabling branding in dev mode
+   devServer.app.use((req, _, next) => {
+if (req.url.startsWith('/artemis-plugin')) {
+  req.url = req.url.replace(/\/artemis-plugin(.*)/, '/hawtio$1')
+}
+next()
+  })
+   // Redirect / or /console to /console/
+   devServer.app.get('/', (_, res) => res.redirect('/console/'))
+   devServer.app.get('/console$', (_, res) => res.redirect('/console/'))
+
+  const username = 'developer'
+  const proxyEnabled = true
+  const plugin = []
+  const hawtconfig = {}
+
+  /**const keycloakEnabled = false
+  const keycloakClientConfig = {
+  }
+  const keycloakClientConfig = {
+realm: 'artemis-keycloak-demo',
+clientId: 'artemis-console',
+url: 'http://localhost:8080/',
+jaas: false,
+pkceMethod: 'S256',
+  }*/

Review Comment:
   removed



##
artemis-plugin/craco.config.js:
##
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-11 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1561069126


##
LICENSE:
##
@@ -0,0 +1,326 @@
+
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  copyright license to reproduce, prepare Derivative Works of,
+  publicly display, publicly perform, sublicense, and distribute the
+  Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  (except as stated in this section) patent license to make, have made,
+  use, offer to sell, sell, import, and otherwise transfer the Work,
+  where such license applies only to those patent claims licensable
+  by such Contributor that are necessarily infringed by their
+  Contribution(s) alone or by combination of their Contribution(s)
+  with the Work to which such Contribution(s) was submitted. If You
+  institute patent litigation against any entity (including a
+  cross-claim or counterclaim in a lawsuit) alleging that the Work
+  or a Contribution

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-03 Thread via GitHub



gemmellr commented on PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#issuecomment-2034075218

   Commented on latest changes. Resolved some of the prior comments that have 
been addressed. Various earlier things still look to remain (see the "12 hidden 
conversations"  / "Load More" bit in the initial group).
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-04-03 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1549315131


##
pom.xml:
##
@@ -0,0 +1,247 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+artemis-console-plugin
+war
+1.0.0-SNAPSHOT
+
+
+org.apache
+apache
+23
+org.apache:apache
+
+
+ActiveMQ Artemis Console Plugin
+
+
+
+11
+11
+11
+4.0.0-RC2
+5.0.0
+1.4.14
+2.0.11
+11.0.18
+v20.9.0
+v1.22.21
+1.15.0
+
+artemis-plugin
+
2024-03-27T00:00:01Z
+
+
+
+
+  

Review Comment:
   New comment at the bottom is out of alignment, and has a typo in _hawito_.
   
   Is the comment at the top accurate anymore? The dependency it is above was 
just changed and is no longer about mbeans. Seems like maybe it could just be 
removed?



##
LICENSE:
##
@@ -0,0 +1,326 @@
+
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1541080258


##
LICENSE:
##
@@ -0,0 +1,220 @@
+
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  copyright license to reproduce, prepare Derivative Works of,
+  publicly display, publicly perform, sublicense, and distribute the
+  Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  (except as stated in this section) patent license to make, have made,
+  use, offer to sell, sell, import, and otherwise transfer the Work,
+  where such license applies only to those patent claims licensable
+  by such Contributor that are necessarily infringed by their
+  Contribution(s) alone or by combination of their Contribution(s)
+  with the Work to which such Contribution(s) was submitted. If You
+  institute patent litigation against any entity (including a
+  cross-claim or counterclaim in a lawsuit) alleging that the Work
+  or a Contribution

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1540935060


##
NOTICE:
##
@@ -0,0 +1,5 @@
+Apache ActiveMQ Artemis
+Copyright [2014-2024] The Apache Software Foundation

Review Comment:
   looks good



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1540933968


##
LICENSE:
##
@@ -0,0 +1,220 @@
+
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  copyright license to reproduce, prepare Derivative Works of,
+  publicly display, publicly perform, sublicense, and distribute the
+  Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  (except as stated in this section) patent license to make, have made,
+  use, offer to sell, sell, import, and otherwise transfer the Work,
+  where such license applies only to those patent claims licensable
+  by such Contributor that are necessarily infringed by their
+  Contribution(s) alone or by combination of their Contribution(s)
+  with the Work to which such Contribution(s) was submitted. If You
+  institute patent litigation against any entity (including a
+  cross-claim or counterclaim in a lawsuit) alleging that the Work
+  or a Contribution

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1540928688


##
NOTICE:
##
@@ -0,0 +1,5 @@
+Apache ActiveMQ Artemis
+Copyright [2014-2024] The Apache Software Foundation

Review Comment:
   I thought it would come under the parent component, I will change it to:
   
   Apache ActiveMQ Artemis Console Plugin
   Copyright 2024 The Apache Software Foundation
   
   wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1540915862


##
pom.xml:
##
@@ -0,0 +1,251 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+artemis-console-plugin
+war
+1.0.0-SNAPSHOT
+
+
+org.apache
+apache
+23
+org.apache:apache
+
+
+ActiveMQ Artemis Console Plugin
+
+
+
+11
+11
+11
+4.0.0-RC1
+5.0.0
+1.4.14
+2.0.11
+11.0.18
+v20.9.0
+v1.22.21
+1.15.0
+
+artemis-plugin
+

Review Comment:
   This should have a project.build.outputTimestamp property added so that the 
release plugin can update it and avoid inheriting the parent one.
   
   E.g see https://github.com/apache/activemq-artemis/blob/2.33.0/pom.xml#L268, 
perhaps copy it and change to todays date as the initial value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1540901021


##
NOTICE:
##
@@ -0,0 +1,5 @@
+Apache ActiveMQ Artemis
+Copyright [2014-2024] The Apache Software Foundation

Review Comment:
   Apache ActiveMQ Artemis Console Plugin?
   
   Years seem off if this is a new component.



##
LICENSE:
##
@@ -0,0 +1,220 @@
+
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  copyright license to reproduce, prepare Derivative Works of,
+  publicly display, publicly perform, sublicense, and distribute the
+  Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  (except as stated in this section) patent license to make, have made,
+  use, offer to sell, sell, import, and otherwise transfer the Work,
+  where such license applies only to those patent claims licensable
+  by such Contributor that are necessarily infringed by their
+  Contribution(s) alone or by combination of their Contribution(s)
+

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



gemmellr commented on PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#issuecomment-2022510267

   > All comments addressed
   
   Think you might have not expanded the list or something, several remain :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-27 Thread via GitHub



andytaylor commented on PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#issuecomment-2022429599

   All comments addressed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] ARTEMIS-4680 - Upgrade the console to use HawtIO 4 [activemq-artemis-console-plugin]

2024-03-26 Thread via GitHub



gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1539396574


##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).

Review Comment:
   ActiveMQ again. Would probably add a link to the website.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin

Review Comment:
   ActiveMQ rather than Activemq. I'd probably go with Apache ActiveMQ.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The War file created by this project is consumed by ActiveMQ-Artemis but can 
be developled and run standalone.

Review Comment:
   WAR rather than War. ActiveMQ Artemis rather than ActiveMQ-Artemis.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The War file created by this project is consumed by ActiveMQ-Artemis but can 
be developled and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project can take time, so if you build it once and make 
no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploy the plugin WAR application, as well as the main 
`hawtio.war`.
+
+```console
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 

+
+## Faster plugin development
+
+You could run `mvn install` or `mvn jetty:run` every time to incrementally 
develop the `activemq-artemis-console-plugin` 
+frontend project while checking its behaviour in the browser. But this is not 
suitable for running the fast development feedback cycle.
+
+As shown below, a faster development cycle can be achieved by directly running 
the `activemq-artemis-console-plugin` 
+frontend project itself in development mode with `yarn start`,
+
+### Development
+Start the plugin project in development mode:
+
+```console
+cd artemis-plugin
+yarn start
+```
+
+Now you should be able to preview the plugins under development at 
. However, since it still 
+hasn't been connected to a backend JVM, You can then connect to a running 
Artemis instance using the connect tab using for 

Review Comment:
   "You" shouldn't be capitalised.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The War file created by this project is consumed by ActiveMQ-Artemis but can 
be developled and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project can take time, so if you build it once and make 
no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploy the plugin WAR application, as well as the main 
`hawtio.war`.

Review Comment:
   deploys



##
artemis-plugin/craco.config.js:
##
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the

64 matches

Mail list logo