[GitHub] [hive] ashish-kumar-sharma edited a comment on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma edited a comment on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-830789617 @kishendas Can you please review the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hive] wangyum opened a new pull request #2251: HIVE-21563: Improve Table#getEmptyTable performance by disabling registerAllFunctionsOnce

wangyum opened a new pull request #2251: URL: https://github.com/apache/hive/pull/2251 ### What changes were proposed in this pull request? Improve `Table#getEmptyTable` performance by disabling `registerAllFunctionsOnce`. ### Why are the changes needed?

[GitHub] [hive] wangyum commented on pull request #2251: HIVE-21563: Improve Table#getEmptyTable performance by disabling registerAllFunctionsOnce

wangyum commented on pull request #2251: URL: https://github.com/apache/hive/pull/2251#issuecomment-833144629 cc @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626336640 ## File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java ## @@ -777,13 +777,14 @@ public ValidTxnList getValidTxns(List

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626393549 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -740,7 +752,9 @@ struct

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626394973 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -5838,10 +5838,20 @@ public void dropConstraint(String dbName,

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626395557 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ## @@ -1572,9 +1579,20 @@ void

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626395244 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ## @@ -1230,7

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626396870 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -2584,57

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626396989 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ## @@ -1588,10 +1606,22 @@

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626394008 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java ## @@ -9479,43 +9479,38 @@

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-832539913 > Where are the tests to ensure that we are sending tableId and validWriteIdList to get constraint APIs ? This PR is more around changing signature of various

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626395719 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java ## @@ -9479,43 +9479,38 @@

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-832540166 > Sending ValidWriteIdList and tableId as part of get_*_constraints HMS api to validate _whether_ data stored in HMS cached Store is stale or latest. ( You don't need

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626411104 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -11978,8 +12027,26 @@

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626411212 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -11565,11 +11579,21

[GitHub] [hive] scarlin-cloudera opened a new pull request #2250: HIVE-23756: Add foreign keys to jdo file

scarlin-cloudera opened a new pull request #2250: URL: https://github.com/apache/hive/pull/2250 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [hive] scarlin-cloudera closed pull request #2250: HIVE-23756: Add foreign keys to jdo file

scarlin-cloudera closed pull request #2250: URL: https://github.com/apache/hive/pull/2250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,