[GitHub] [arrow] kiszk commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

kiszk commented on pull request #6729: URL: https://github.com/apache/arrow/pull/6729#issuecomment-644546508 I see. Since `ArrowBuf` package name is changed, IMHO, a PR for this change in Spark should include upgrading Arrow from 0.15.1 to 0.17.1. Since Spark 3.0 branch is already

[GitHub] [arrow] emkornfield commented on pull request #7231: ARROW-6839: [Java] Add APIs to read and write "custom_metadata" field of IPC file footer

emkornfield commented on pull request #7231: URL: https://github.com/apache/arrow/pull/7231#issuecomment-644543412 No please go ahead and merge. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] rongma1997 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

rongma1997 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-644536052 Hi, I have a question... probably not related to what this PR focus on. What if the compressor / decompressor for the codec will have JNI call for compression /

[GitHub] [arrow] wesm edited a comment on pull request #7442: ARROW-9075: [C++] Optimized Filter implementation: faster performance + compilation, smaller code size

wesm edited a comment on pull request #7442: URL: https://github.com/apache/arrow/pull/7442#issuecomment-644513681 To show some simple numbers to show the perf before and after in Python, this example has a high selectivity (all but one value selected) and low selectivity filter (1/100

[GitHub] [arrow] wesm commented on pull request #7442: ARROW-9075: [C++] Optimized Filter implementation: faster performance + compilation, smaller code size

wesm commented on pull request #7442: URL: https://github.com/apache/arrow/pull/7442#issuecomment-644513681 To show some simple numbers to show the perf before and after in Python, this example has a high selectivity (all but one value selected) and low selectivity filter (only 1% of

[GitHub] [arrow] github-actions[bot] commented on pull request #7442: ARROW-9075: [C++] Optimized Filter implementation: faster performance + compilation, smaller code size

github-actions[bot] commented on pull request #7442: URL: https://github.com/apache/arrow/pull/7442#issuecomment-644510405 https://issues.apache.org/jira/browse/ARROW-9075 This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on a change in pull request #7442: ARROW-9075: [C++] Optimized Filter implementation: faster performance + compilation, smaller code size

wesm commented on a change in pull request #7442: URL: https://github.com/apache/arrow/pull/7442#discussion_r440565678 ## File path: cpp/src/arrow/testing/random.cc ## @@ -84,7 +84,7 @@ std::shared_ptr RandomArrayGenerator::Boolean(int64_t size, double probab

[GitHub] [arrow] wesm edited a comment on pull request #7442: ARROW-9075: [C++] Optimized Filter implementation: faster performance + compilation, smaller code size

wesm edited a comment on pull request #7442: URL: https://github.com/apache/arrow/pull/7442#issuecomment-644509797 Here's benchmark runs on my machine * BEFORE: https://gist.github.com/wesm/857a3179e7dbc928d3325b1e7f687086 * AFTER:

[GitHub] [arrow] wesm commented on pull request #7442: ARROW-9075: [C++] Optimized Filter implementation: faster performance + compilation, smaller code size

wesm commented on pull request #7442: URL: https://github.com/apache/arrow/pull/7442#issuecomment-644509797 Here's benchmark runs on my machine * BEFORE: https://gist.github.com/wesm/857a3179e7dbc928d3325b1e7f687086 * AFTER:

[GitHub] [arrow] wesm opened a new pull request #7442: ARROW-9075: [C++] Optimized Filter implementation: faster performance + compilation, smaller code size

wesm opened a new pull request #7442: URL: https://github.com/apache/arrow/pull/7442 NOTE: the diff is artificially larger due to some code rearranging (that was necessitated because of how some data selection code is shared between the Take and Filter implementations). Summary:

[GitHub] [arrow] andygrove commented on pull request #7297: ARROW-6945: [Rust][Integration] Run rust integration tests

andygrove commented on pull request #7297: URL: https://github.com/apache/arrow/pull/7297#issuecomment-644505701 @nealrichardson I think that would be a reasonable assumption to make at this point. I'd be happy with this merged even if only a small number of tests are passing and we can

[GitHub] [arrow] zhztheplayer edited a comment on pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer edited a comment on pull request #7030: URL: https://github.com/apache/arrow/pull/7030#issuecomment-644494295 @fsaintjacques Rebased now. As we have a unresolved [discussion](https://github.com/apache/arrow/pull/7030#discussion_r440075959) about memory management of

[GitHub] [arrow] zhztheplayer commented on pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer commented on pull request #7030: URL: https://github.com/apache/arrow/pull/7030#issuecomment-644494295 @fsaintjacques Rebased now. As we have a unresolved [discussion](https://github.com/apache/arrow/pull/7030#discussion_r440075959) about memory management of native

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r440075959 ## File path: java/dataset/src/main/java/org/apache/arrow/memory/NativeUnderlingMemory.java ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] ctring commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

ctring commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644468486 I believe you need to regenerate and reupload the trimmed Boost bundle. This failed due to the same reason I mentioned above since it is still downloading the faulty bundle.

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644468001 Failed. Do we need to re-generate our Boost archive? This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644450282 OK. Let's try it in this pull request. If it doesn't increase build time much, we can change the current job. This

[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644413986 I suspect it wouldn't increase build time much, at least not enough to block things. Where would you prefer to run the test? Do we run windows nightlies on crossbow?

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644412255 It will work but it may increase CI time for "C++ / AMD64 Windows 2019 C++". Increasing CI time may not be acceptable.

[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644410813 Maybe adding `BOOST_SOURCE: BUNDLED` around [here](https://github.com/apache/arrow/blob/master/.github/workflows/cpp.yml#L179) would be sufficient? The job is already

[GitHub] [arrow] kou commented on a change in pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

kou commented on a change in pull request #7436: URL: https://github.com/apache/arrow/pull/7436#discussion_r440463018 ## File path: python/manylinux1/scripts/build_boost.sh ## @@ -16,12 +16,12 @@ # specific language governing permissions and limitations # under the License.

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644397052 > Since the builds have been green, we must not have any CI jobs that test building with bundled boost and thrift on MSVC. Should we add one (nightly perhaps)? @kou thoughts?

[GitHub] [arrow] kou commented on pull request #7433: ARROW-9129: [Python][JPype] Remove JPype version check

kou commented on pull request #7433: URL: https://github.com/apache/arrow/pull/7433#issuecomment-644393428 @xhochy Could you take a look the https://github.com/apache/arrow/pull/7433#issuecomment-643824491 error? This is an

[GitHub] [arrow] kou commented on pull request #7335: ARROW-9018: [C++] Remove APIs that were marked as deprecated in 0.17.0 and prior

kou commented on pull request #7335: URL: https://github.com/apache/arrow/pull/7335#issuecomment-644392554 Great! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kou commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

kou commented on pull request #6729: URL: https://github.com/apache/arrow/pull/6729#issuecomment-644387504 @liyafan82 OK. Could you open an JIRA issue for Spark to notify this to Spark developers? https://issues.apache.org/jira/browse/SPARK FYI:

[GitHub] [arrow] github-actions[bot] commented on pull request #7441: ARROW-3446: [R] Document mapping of Arrow <-> R types

github-actions[bot] commented on pull request #7441: URL: https://github.com/apache/arrow/pull/7441#issuecomment-644380381 https://issues.apache.org/jira/browse/ARROW-3446 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson opened a new pull request #7441: ARROW-3446: [R] Document mapping of Arrow <-> R types

nealrichardson opened a new pull request #7441: URL: https://github.com/apache/arrow/pull/7441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] ctring commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

ctring commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644373157 @nealrichardson Once I made all the changes in the CMake file, I could pass the boost_ep build phase but failed at thrift_ep with the error that

[GitHub] [arrow] github-actions[bot] commented on pull request #7440: ARROW-8631: [C++][Dataset][Python] Raise in discovery on unparsable partition expression

github-actions[bot] commented on pull request #7440: URL: https://github.com/apache/arrow/pull/7440#issuecomment-644356263 https://issues.apache.org/jira/browse/ARROW-8631 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz opened a new pull request #7440: ARROW-8631: [C++][Dataset][Python] Raise in discovery on unparsable partition expression

bkietz opened a new pull request #7440: URL: https://github.com/apache/arrow/pull/7440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] pitrou commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

pitrou commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644335590 (I cancelled the GHA builds since they shouldn't affected by this PR's changes) This is an automated message from

[GitHub] [arrow] github-actions[bot] commented on pull request #7439: ARROW-4309: [Documentation] Add a docker-compose entry which builds the documentation with CUDA enabled

github-actions[bot] commented on pull request #7439: URL: https://github.com/apache/arrow/pull/7439#issuecomment-644329406 https://issues.apache.org/jira/browse/ARROW-4309 This is an automated message from the Apache Git

[GitHub] [arrow] kszucs commented on pull request #7439: ARROW-4309: [Documentation] Add a docker-compose entry which builds the documentation with CUDA enabled

kszucs commented on pull request #7439: URL: https://github.com/apache/arrow/pull/7439#issuecomment-644326074 I'm going to add some extra hack to compile the `docker-compose run` command directly to `docker run`, just needs to merge #6512 to prevent conflicts.

[GitHub] [arrow] kszucs commented on pull request #6512: ARROW-8430: [CI] Configure self-hosted runners for Github Actions

kszucs commented on pull request #6512: URL: https://github.com/apache/arrow/pull/6512#issuecomment-644325417 Sure, updating to use never ubuntu versions. This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] kszucs opened a new pull request #7439: ARROW-4309: [Documentation] Add a docker-compose entry which builds the documentation with CUDA enabled

kszucs opened a new pull request #7439: URL: https://github.com/apache/arrow/pull/7439 Currently testing it, sadly docker-compose doesn't support nvidia runtime so some additional documentation and/or archery development is required.

[GitHub] [arrow] kszucs commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

kszucs commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644320852 > @kszucs What is the procedure to push the updated docker images? The nightlies running from master branch automatically push the updated images.

[GitHub] [arrow] github-actions[bot] commented on pull request #7438: ARROW-9105: [C++][Dataset][Python] Infer partition schema from partition expression

github-actions[bot] commented on pull request #7438: URL: https://github.com/apache/arrow/pull/7438#issuecomment-644317249 https://issues.apache.org/jira/browse/ARROW-9105 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

pitrou commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644316784 @kszucs What is the procedure to push the updated docker images? This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on a change in pull request #7415: ARROW-7028: [R] Date roundtrip results in different R storage mode

nealrichardson commented on a change in pull request #7415: URL: https://github.com/apache/arrow/pull/7415#discussion_r440371130 ## File path: r/tests/testthat/test-Array.R ## @@ -202,6 +202,8 @@ test_that("array supports Date (ARROW-3340)", { expect_array_roundtrip(d2,

[GitHub] [arrow] fsaintjacques commented on pull request #7435: ARROW-8779: [R] Implement conversion to List

fsaintjacques commented on pull request #7435: URL: https://github.com/apache/arrow/pull/7435#issuecomment-644308992 I also updated ARROW-7798 with comments to avoid builder in the conversion. This is an automated message

[GitHub] [arrow] bkietz opened a new pull request #7438: ARROW-9105: [C++][Dataset][Python] Infer partition schema from partition expression

bkietz opened a new pull request #7438: URL: https://github.com/apache/arrow/pull/7438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] nealrichardson commented on pull request #7415: ARROW-7028: [R] Date roundtrip results in different R storage mode

nealrichardson commented on pull request #7415: URL: https://github.com/apache/arrow/pull/7415#issuecomment-644306996 It turns out we don't ever, AFAICT, move data from Arrow to R with zero copy (https://issues.apache.org/jira/browse/ARROW-9140), so I don't have any objections to making

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7435: ARROW-8779: [R] Implement conversion to List

fsaintjacques commented on a change in pull request #7435: URL: https://github.com/apache/arrow/pull/7435#discussion_r440369138 ## File path: r/src/array_from_vector.cpp ## @@ -201,6 +201,39 @@ struct VectorToArrayConverter { return Status::OK(); } + template +

[GitHub] [arrow] github-actions[bot] commented on pull request #7437: ARROW-8943: [C++][Python][Dataset] Add partitioning support to ParquetDatasetFactory

github-actions[bot] commented on pull request #7437: URL: https://github.com/apache/arrow/pull/7437#issuecomment-644304497 https://issues.apache.org/jira/browse/ARROW-8943 This is an automated message from the Apache Git

[GitHub] [arrow] fsaintjacques opened a new pull request #7437: ARROW-8943: [C++][Python][Dataset] Add partitioning support to ParquetDatasetFactory

fsaintjacques opened a new pull request #7437: URL: https://github.com/apache/arrow/pull/7437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

github-actions[bot] commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644291915 Revision: 93a3ffe43d7d6c0f3377cfe5ec63b0969923e6d7 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] pitrou commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

pitrou commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644291011 @github-actions crossbow submit -g wheel This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

github-actions[bot] commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644290997 https://issues.apache.org/jira/browse/ARROW-9094 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

github-actions[bot] commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644286546 Revision: a48f8064906bb8f4f6344680efd4884c3963b9a9 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] pitrou commented on a change in pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

pitrou commented on a change in pull request #7436: URL: https://github.com/apache/arrow/pull/7436#discussion_r440353321 ## File path: cpp/cmake_modules/FindgRPCAlt.cmake ## @@ -169,13 +169,14 @@ if(gRPCAlt_FOUND)

[GitHub] [arrow] pitrou commented on pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

pitrou commented on pull request #7436: URL: https://github.com/apache/arrow/pull/7436#issuecomment-644285628 @github-actions crossbow submit -g wheel This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] pitrou opened a new pull request #7436: ARROW-9094: [Python] Bump versions of compiled dependencies in manylinux wheels

pitrou opened a new pull request #7436: URL: https://github.com/apache/arrow/pull/7436 Also remove unnecessary builds such as LLVM. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] zeapo commented on pull request #7309: ARROW-8993: [Rust] support reading non-seekable sources

zeapo commented on pull request #7309: URL: https://github.com/apache/arrow/pull/7309#issuecomment-644261323 I'll fix the build tonight. Le lun. 15 juin 2020 à 18:21, Wakahisa a écrit : > Hi @zeapo , can you please rebase to fix the > merge

[GitHub] [arrow] kszucs commented on pull request #7420: ARROW-9022: [C++] Add/Sub/Mul arithmetic kernels with overflow check

kszucs commented on pull request #7420: URL: https://github.com/apache/arrow/pull/7420#issuecomment-644258425 Shall we have benchmarks for the new operators? This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kszucs commented on a change in pull request #7420: ARROW-9022: [C++] Add/Sub/Mul arithmetic kernels with overflow check

kszucs commented on a change in pull request #7420: URL: https://github.com/apache/arrow/pull/7420#discussion_r440322018 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -60,6 +68,42 @@ struct Add { } }; +struct AddChecked { +#if

[GitHub] [arrow] wesm commented on pull request #7284: ARROW-7409: [C++][Python] Windows link error LNK1104: cannot open file 'python37_d.lib'

wesm commented on pull request #7284: URL: https://github.com/apache/arrow/pull/7284#issuecomment-644241777 @raulbocanegra ping This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] fsaintjacques commented on pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

fsaintjacques commented on pull request #7030: URL: https://github.com/apache/arrow/pull/7030#issuecomment-644238932 Tests are still failing, looks like orc is failing, did you rebase with master? This is an automated

[GitHub] [arrow] nevi-me closed pull request #7428: ARROW-9124: [Rust][Datafusion] optimize DFParser::parse_sql to take query string as

nevi-me closed pull request #7428: URL: https://github.com/apache/arrow/pull/7428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nevi-me commented on pull request #7309: ARROW-8993: [Rust] support reading non-seekable sources

nevi-me commented on pull request #7309: URL: https://github.com/apache/arrow/pull/7309#issuecomment-644233988 Hi @zeapo, can you please rebase to fix the merge conflict? I'll merge this PR after that This is an automated

[GitHub] [arrow] nevi-me closed pull request #7324: ARROW-9005: [Rust] [Datafusion] support sort expression

nevi-me closed pull request #7324: URL: https://github.com/apache/arrow/pull/7324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nevi-me commented on pull request #7324: ARROW-9005: [Rust] [Datafusion] support sort expression

nevi-me commented on pull request #7324: URL: https://github.com/apache/arrow/pull/7324#issuecomment-644232183 We can address any queries in follow up Jiras This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nevi-me closed pull request #7432: ARROW-9127: [Rust] Update thrift dependency to 0.13 (latest)

nevi-me closed pull request #7432: URL: https://github.com/apache/arrow/pull/7432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644207536 Thanks @ctring! Since the builds have been green, we must not have any CI jobs that test building with bundled boost and thrift on MSVC. Should we add one (nightly

[GitHub] [arrow] nealrichardson commented on a change in pull request #7423: ARROW-8942: [R] Detect compression in reading CSV/JSON

nealrichardson commented on a change in pull request #7423: URL: https://github.com/apache/arrow/pull/7423#discussion_r440263928 ## File path: r/tests/testthat/test-csv.R ## @@ -168,3 +168,15 @@ test_that("read_csv_arrow() respects col_select", { tib <- read_csv_arrow(tf,

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r44024 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440239175 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440231899 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440225706 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440220181 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440206424 ## File path: cpp/src/arrow/compute/kernels/test_util.h ## @@ -97,5 +99,63 @@ using TestingStringTypes = static constexpr random::SeedType kRandomSeed =

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440205745 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] wesm commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

wesm commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644158423 It shouldn't be a problem. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440202771 ## File path: cpp/src/arrow/compute/kernels/scalar_validity.cc ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] maartenbreddels commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

maartenbreddels commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644153016 > Can we use [d...@arrow.apache.org](mailto:d...@arrow.apache.org) so everyone can see the discussion and it's searchable via Google later? I'm ok with that if not

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440197092 ## File path: cpp/src/arrow/testing/random.h ## @@ -250,6 +250,9 @@ class ARROW_EXPORT RandomArrayGenerator {

[GitHub] [arrow] wesm edited a comment on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

wesm edited a comment on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644149831 > PS2: Are there alternative channels for quick/small questions, or is this fine? Can we use d...@arrow.apache.org so everyone can see the discussion and it's

[GitHub] [arrow] wesm commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

wesm commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644149831 > PS2: Are there alternative channels for quick/small questions, or is this fine? Can we use d...@arrow.apache.org so everyone can see the discussion and it's searchable via

[GitHub] [arrow] romainfrancois commented on pull request #7435: ARROW-8779: [R] Implement conversion to List

romainfrancois commented on pull request #7435: URL: https://github.com/apache/arrow/pull/7435#issuecomment-644147517 @github-actions autotune everything This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] maartenbreddels commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

maartenbreddels commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644146353 > I think the current approach (implement kernels one-by-one) is reasonable and manageable for us (and for you as well I hope). No, this is fine. >

[GitHub] [arrow] pitrou commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

pitrou commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644144990 I think the current approach (implement kernels one-by-one) is reasonable and manageable for us (and for you as well I hope). I don't think there's much documentation for

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440185720 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] maartenbreddels commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

maartenbreddels commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644142377 Thanks, let me know if my workflow is ok, or if I can make things go smoother. PS: I am looking for a document describing the kernel design. I see these two cases

[GitHub] [arrow] bkietz commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

bkietz commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440182319 ## File path: cpp/src/arrow/compute/kernels/scalar_validity.cc ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] github-actions[bot] commented on pull request #7435: ARROW-8779: [R] Implement conversion to List

github-actions[bot] commented on pull request #7435: URL: https://github.com/apache/arrow/pull/7435#issuecomment-644128787 https://issues.apache.org/jira/browse/ARROW-8779 This is an automated message from the Apache Git

[GitHub] [arrow] romainfrancois opened a new pull request #7435: ARROW-8779: [R] Implement conversion to List

romainfrancois opened a new pull request #7435: URL: https://github.com/apache/arrow/pull/7435 ``` r library(arrow) #> #> Attaching package: 'arrow' #> The following object is masked from 'package:utils': #> #> timestamp Array$create(list(data.frame(a = 1:3, b =

[GitHub] [arrow] pitrou closed pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

pitrou closed pull request #7434: URL: https://github.com/apache/arrow/pull/7434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] pitrou commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

pitrou commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644106486 Thank you @maartenbreddels ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] pitrou commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

pitrou commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644104830 Travis-CI failure is unrelated. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] pitrou commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

pitrou commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440130579 ## File path: cpp/src/arrow/testing/random.h ## @@ -250,6 +250,9 @@ class ARROW_EXPORT RandomArrayGenerator {

[GitHub] [arrow] pitrou commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

pitrou commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644084984 It's ok, there's no need to further optimize those functions. This is an automated message from the Apache Git

[GitHub] [arrow] kszucs commented on pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

kszucs commented on pull request #7417: URL: https://github.com/apache/arrow/pull/7417#issuecomment-644083982 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] maartenbreddels commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

maartenbreddels commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644075652 I also thought that we could do a bit check instead of the range check, e.g. `code_unit & 0b1110) == 0b0110`, but that would also transform the backtick for

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r440098238 ## File path: java/dataset/src/main/java/org/apache/arrow/dataset/jni/NativeScanner.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software

[GitHub] [arrow] pitrou commented on a change in pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

pitrou commented on a change in pull request #7434: URL: https://github.com/apache/arrow/pull/7434#discussion_r440095501 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -64,77 +64,30 @@ void StringDataTransform(KernelContext* ctx, const ExecBatch& batch,

[GitHub] [arrow] xhochy commented on pull request #7335: ARROW-9018: [C++] Remove APIs that were marked as deprecated in 0.17.0 and prior

xhochy commented on pull request #7335: URL: https://github.com/apache/arrow/pull/7335#issuecomment-644053464 @kou Thanks for the heads-up, made a PR: https://github.com/blue-yonder/turbodbc/pull/270 This is an automated

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r440076921 ## File path: java/dataset/src/main/java/org/apache/arrow/dataset/jni/NativeScanner.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r440075959 ## File path: java/dataset/src/main/java/org/apache/arrow/memory/NativeUnderlingMemory.java ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r440053169 ## File path: java/dataset/src/main/java/org/apache/arrow/memory/Ownerships.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] [arrow] github-actions[bot] commented on pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

github-actions[bot] commented on pull request #7434: URL: https://github.com/apache/arrow/pull/7434#issuecomment-644017246 https://issues.apache.org/jira/browse/ARROW-9131 This is an automated message from the Apache Git

[GitHub] [arrow] maartenbreddels opened a new pull request #7434: ARROW-9131: [C++] Faster ascii_lower and ascii_upper.

maartenbreddels opened a new pull request #7434: URL: https://github.com/apache/arrow/pull/7434 Following up on #7418 I tried and benchmarked a different way for * ascii_lower * ascii_upper Before (lower is similar): ```

  1   2   >