jorgecarleitao opened a new pull request #8408:
URL: https://github.com/apache/arrow/pull/8408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
projjal commented on pull request #8096:
URL: https://github.com/apache/arrow/pull/8096#issuecomment-705977368
> Would it be possible to add an example to cause SIGSEGV?
I have added java tests that causes crashes
projjal commented on pull request #8158:
URL: https://github.com/apache/arrow/pull/8158#issuecomment-705958047
Thanks @wesm
This is an automated message from the Apache Git Service.
To respond to the message, please log on
arw2019 commented on pull request #8244:
URL: https://github.com/apache/arrow/pull/8244#issuecomment-705951731
@jorisvandenbossche @emkornfield This is ready to go:
- [x] addressed comments
- [x] updated title & description
- [x] rebased (CI green)
nealrichardson commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705945270
Yeah I saw that, will clean that up. Thanks for taking care of this!
This is an automated message from the
jorgecarleitao closed pull request #8316:
URL: https://github.com/apache/arrow/pull/8316
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jorgecarleitao commented on pull request #8316:
URL: https://github.com/apache/arrow/pull/8316#issuecomment-705944089
Closing in favor of #8401
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #8389:
URL: https://github.com/apache/arrow/pull/8389#issuecomment-705943321
Done.
+1 on the GLib part.
This is an automated message from the Apache Git Service.
To respond to the
kou closed pull request #8406:
URL: https://github.com/apache/arrow/pull/8406
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705942879
+1
I'll merge this.
This is an automated message from the Apache Git Service.
To respond to the message, please
kou commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705942635
Thanks.
It seems that this change works well.
The failure of centos-7 job is unrelated.
We need to remove `-DARROW_S3=ON` from the job because gcc on CentOS 7 is
old to
emkornfield commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502157792
##
File path: cpp/src/arrow/flight/client.h
##
@@ -90,6 +90,8 @@ class ARROW_FLIGHT_EXPORT FlightWriteSizeStatusDetail :
public arrow::StatusDeta
emkornfield commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502156886
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -835,6 +843,31 @@ class GrpcMetadataReader : public FlightMetadataReader {
std::shared_ptr
bkietz closed pull request #8403:
URL: https://github.com/apache/arrow/pull/8403
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705931636
@kou I made a branch to have it test building from your fork:
https://github.com/ursa-labs/arrow-r-nightly/commit/938da99c0c59213b3841df779c1766780a463f30
Running
cyb70289 commented on pull request #8407:
URL: https://github.com/apache/arrow/pull/8407#issuecomment-705930517
appveyor ci failure not related
This is an automated message from the Apache Git Service.
To respond to the
liyafan82 commented on pull request #8363:
URL: https://github.com/apache/arrow/pull/8363#issuecomment-70592
> @liyafan82 do you have time to review?
@emkornfield Sure. I will take a look in one or two days.
This
eerhardt closed pull request #8404:
URL: https://github.com/apache/arrow/pull/8404
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cyb70289 commented on pull request #8407:
URL: https://github.com/apache/arrow/pull/8407#issuecomment-705927270
Tested on Xeon Gold 5218, clang-9.
```
$ release/arrow-compute-aggregate-benchmark --benchmark_filter="^Variance"
github-actions[bot] commented on pull request #8407:
URL: https://github.com/apache/arrow/pull/8407#issuecomment-705923975
https://issues.apache.org/jira/browse/ARROW-10241
This is an automated message from the Apache Git
cyb70289 opened a new pull request #8407:
URL: https://github.com/apache/arrow/pull/8407
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705908061
https://issues.apache.org/jira/browse/ARROW-10239
This is an automated message from the Apache Git
kou commented on pull request #8389:
URL: https://github.com/apache/arrow/pull/8389#issuecomment-705903570
I'll take a look it and push a fix.
This is an automated message from the Apache Git Service.
To respond to the
bkietz commented on pull request #8389:
URL: https://github.com/apache/arrow/pull/8389#issuecomment-705901241
@kou not sure how to idiomatically propagate this change to GLib; it seems
there's no way to raise an exception when setting a property?
github-actions[bot] commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705896055
Revision: 8bbdba5fb1ab690d47aeebc16693af9de731e0f3
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705895553
@github-actions crossbow submit -g linux
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #8406:
URL: https://github.com/apache/arrow/pull/8406#issuecomment-705895390
@nealrichardson How do we test this with
https://github.com/ursa-labs/arrow-r-nightly ?
This is an automated message
kou opened a new pull request #8406:
URL: https://github.com/apache/arrow/pull/8406
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8346:
URL: https://github.com/apache/arrow/pull/8346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8222:
URL: https://github.com/apache/arrow/pull/8222
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8370:
URL: https://github.com/apache/arrow/pull/8370
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou closed pull request #8394:
URL: https://github.com/apache/arrow/pull/8394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #8394:
URL: https://github.com/apache/arrow/pull/8394#issuecomment-705882909
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jduo commented on pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#issuecomment-705866472
> > The files in try_compile shouldn't be built as part of the project --
they should only be invoked by CMake for assessing grpc-cpp version information.
>
> Right, but the
wesm commented on pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#issuecomment-705861730
> The files in try_compile shouldn't be built as part of the project -- they
should only be invoked by CMake for assessing grpc-cpp version information.
Right, but the
jduo commented on pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#issuecomment-705858448
> There's some broken stuff for me locally with clang-8, I'm trying to fix
>
> ```
> In file included from
bkietz commented on a change in pull request #8403:
URL: https://github.com/apache/arrow/pull/8403#discussion_r502047888
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2689,6 +2689,26 @@ TEST(TestArrowReadWrite, DictionaryColumnChunkedWrite) {
pitrou commented on a change in pull request #8403:
URL: https://github.com/apache/arrow/pull/8403#discussion_r502044409
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2689,6 +2689,26 @@ TEST(TestArrowReadWrite, DictionaryColumnChunkedWrite) {
wesm edited a comment on pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#issuecomment-705851235
There's some broken stuff for me locally with clang-8, I'm trying to fix
```
In file included from
wesm commented on pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#issuecomment-705851235
There's some broken stuff for me locally with clang-8
```
In file included from
/home/wesm/code/arrow/cpp/src/arrow/flight/try_compile/check_tls_opts_127.cc:24:
In file
wesm commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502040232
##
File path: python/pyarrow/_flight.pyx
##
@@ -1106,13 +1114,15 @@ cdef class FlightClient(_Weakrefable):
@classmethod
def connect(cls, location,
pgovind commented on a change in pull request #8404:
URL: https://github.com/apache/arrow/pull/8404#discussion_r502039001
##
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
github-actions[bot] commented on pull request #8394:
URL: https://github.com/apache/arrow/pull/8394#issuecomment-705844409
Revision: bd7815fc5e10342f0b2436e4d3d7a8b4db69b5b9
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8394:
URL: https://github.com/apache/arrow/pull/8394#issuecomment-705841329
@github-actions crossbow submit -g linux
This is an automated message from the Apache Git Service.
To respond to the
jduo commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502020189
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -845,18 +878,52 @@ class FlightClient::FlightClientImpl {
if (scheme == kSchemeGrpc || scheme ==
jduo commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502020136
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -845,18 +878,52 @@ class FlightClient::FlightClientImpl {
if (scheme == kSchemeGrpc || scheme ==
chrish42 commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-705827477
Hiya folks. I am still working on this somewhat regularly. I have code for
ToJson too... except I get a crash there, and most of the work is understanding
Flatbuffers and why
github-actions[bot] commented on pull request #8404:
URL: https://github.com/apache/arrow/pull/8404#issuecomment-705823615
https://issues.apache.org/jira/browse/ARROW-10238
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8405:
URL: https://github.com/apache/arrow/pull/8405#issuecomment-705823515
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
github-actions[bot] commented on pull request #8394:
URL: https://github.com/apache/arrow/pull/8394#issuecomment-705823044
Revision: cc8aa5d2371cc3fc61f00f920c1a3ea057219e65
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8394:
URL: https://github.com/apache/arrow/pull/8394#issuecomment-705821982
@github-actions crossbow submit centos-*
This is an automated message from the Apache Git Service.
To respond to the
jduo commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502009940
##
File path: python/pyarrow/_flight.pyx
##
@@ -1106,13 +1114,15 @@ cdef class FlightClient(_Weakrefable):
@classmethod
def connect(cls, location,
carols10cents opened a new pull request #8405:
URL: https://github.com/apache/arrow/pull/8405
Hey @nevi-me, before I go write a bunch of these, is this what would be
useful for testing levels? Is there an easier way to create the arrays?
I'm basing these on [tests in the C++
eerhardt commented on a change in pull request #8404:
URL: https://github.com/apache/arrow/pull/8404#discussion_r502007523
##
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
pgovind commented on a change in pull request #8404:
URL: https://github.com/apache/arrow/pull/8404#discussion_r502005704
##
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
pgovind commented on a change in pull request #8404:
URL: https://github.com/apache/arrow/pull/8404#discussion_r502005704
##
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
pgovind commented on a change in pull request #8404:
URL: https://github.com/apache/arrow/pull/8404#discussion_r502005704
##
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
wesm commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502002471
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -845,18 +878,52 @@ class FlightClient::FlightClientImpl {
if (scheme == kSchemeGrpc || scheme ==
wesm commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502002828
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -845,18 +878,52 @@ class FlightClient::FlightClientImpl {
if (scheme == kSchemeGrpc || scheme ==
wesm closed issue #8384:
URL: https://github.com/apache/arrow/issues/8384
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on issue #8384:
URL: https://github.com/apache/arrow/issues/8384#issuecomment-705811182
You can run the vignette examples, or the unit test suite, I think. If you
wanted something more integrated with the install you could open a JIRA issue
to describe exactly what you
nealrichardson commented on a change in pull request #8351:
URL: https://github.com/apache/arrow/pull/8351#discussion_r501998550
##
File path: r/R/feather.R
##
@@ -24,9 +24,8 @@
#' and the version 2 specification, which is the Apache Arrow IPC file format.
#'
#' @param x
github-actions[bot] commented on pull request #8403:
URL: https://github.com/apache/arrow/pull/8403#issuecomment-705808504
https://issues.apache.org/jira/browse/ARROW-10237
This is an automated message from the Apache Git
bkietz opened a new pull request #8403:
URL: https://github.com/apache/arrow/pull/8403
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb commented on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-705805870
> The only one that remains is the necessity to prepare for async, but I
have digged a little bit into and I think that tackling this properly will
require work that is not really
jhorstmann commented on pull request #8370:
URL: https://github.com/apache/arrow/pull/8370#issuecomment-705803005
@andygrove seems there is a lot else going on in that query and the sum
aggregation is just a small part. I'll try to setup the benchmarks myself and
have a look. Would be
github-actions[bot] commented on pull request #8402:
URL: https://github.com/apache/arrow/pull/8402#issuecomment-705795175
https://issues.apache.org/jira/browse/ARROW-8426
This is an automated message from the Apache Git
carols10cents opened a new pull request #8402:
URL: https://github.com/apache/arrow/pull/8402
This adds more support for:
- When converting Arrow -> Parquet containing an Arrow Dictionary,
materialize the Dictionary values and send to Parquet to be encoded with
a dictionary or
github-actions[bot] commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-705764977
https://issues.apache.org/jira/browse/ARROW-10220
This is an automated message from the Apache Git
quinnj commented on pull request #8393:
URL: https://github.com/apache/arrow/pull/8393#issuecomment-705764895
> To get started, here's a link to the Apache CLA:
https://www.apache.org/licenses/contributor-agreements.html
Ok, filled out the form and emailed the CLA.
bkietz edited a comment on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705748359
unfortunately `cpp11::r_vector::const_iterator::operator*` is not marked
const, but MSVC's impl of `std::copy` marks its [arguments
bkietz commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705748359
unfortunately `cpp11::r_vector::const_iterator::operator*` is not marked
const, but MSVC's impl of `std::copy` marks its [arguments
andygrove commented on pull request #8370:
URL: https://github.com/apache/arrow/pull/8370#issuecomment-705747085
I'm planning on running TPC-H benchmarks later today with and without this
patch.
This is an automated message
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705728943
It's actually clang-with-MSVC headers ;)
This is an automated message from the Apache Git Service.
To respond to
jorgecarleitao commented on a change in pull request #8374:
URL: https://github.com/apache/arrow/pull/8374#discussion_r501874856
##
File path: docs/source/developers/contributing.rst
##
@@ -304,3 +304,40 @@ to your branch, which they sometimes do to help move a
pull request
jorgecarleitao commented on a change in pull request #8374:
URL: https://github.com/apache/arrow/pull/8374#discussion_r501874856
##
File path: docs/source/developers/contributing.rst
##
@@ -304,3 +304,40 @@ to your branch, which they sometimes do to help move a
pull request
terencehonles edited a comment on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-705697163
> Note that Numpy doesn't provide [pre-compiled
wheels](https://pypi.org/project/numpy/#files) for 3.9 currently.
>
> Also, conda-forge doesn't seem to be
terencehonles edited a comment on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-705697163
> Note that Numpy doesn't provide [pre-compiled
wheels](https://pypi.org/project/numpy/#files) for 3.9 currently.
>
> Also, conda-forge doesn't seem to be
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-705697163
> Note that Numpy doesn't provide [pre-compiled
wheels](https://pypi.org/project/numpy/#files) for 3.9 currently.
>
> Also, conda-forge doesn't seem to be ready
nealrichardson commented on pull request #8393:
URL: https://github.com/apache/arrow/pull/8393#issuecomment-705695770
@quinnj I can help you with the IP clearance process.
To get started, here's a link to the Apache CLA:
https://www.apache.org/licenses/contributor-agreements.html
wesm commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r501865414
##
File path: python/pyarrow/parquet.py
##
@@ -301,6 +301,45 @@ def read_row_groups(self, row_groups, columns=None,
use_threads=True,
quinnj commented on pull request #8393:
URL: https://github.com/apache/arrow/pull/8393#issuecomment-705688058
> We'll need to document the authors of the code
The code included in this PR was done exclusively by me; I initially put the
code under the MIT license, but recently
github-actions[bot] commented on pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#issuecomment-705685197
https://issues.apache.org/jira/browse/ARROW-10109
This is an automated message from the Apache Git
rdettai commented on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-705682739
@alamb I think I addressed most of your concerns. The only one that remains
is the necessity to prepare for async, but I have digged a little bit into and
I think that tackling
nevi-me commented on a change in pull request #8400:
URL: https://github.com/apache/arrow/pull/8400#discussion_r501851945
##
File path: rust/datafusion/src/physical_plan/type_casting.rs
##
@@ -0,0 +1,218 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
nevi-me commented on a change in pull request #8400:
URL: https://github.com/apache/arrow/pull/8400#discussion_r501850814
##
File path: rust/datafusion/src/physical_plan/type_casting.rs
##
@@ -0,0 +1,218 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
jorgecarleitao opened a new pull request #8401:
URL: https://github.com/apache/arrow/pull/8401
This PR is a proposal to add support to the [C data
interface](https://arrow.apache.org/docs/format/CDataInterface.html) by
implementing the necessary functionality to both consume and produce
wesm commented on pull request #8393:
URL: https://github.com/apache/arrow/pull/8393#issuecomment-705663389
I think it would be best to conduct the IP clearance process for this
codebase. The first step is to have a vote on the mailing list about accepting
the code donation. We'll need to
jhorstmann commented on a change in pull request #8262:
URL: https://github.com/apache/arrow/pull/8262#discussion_r501813151
##
File path: rust/arrow/src/buffer.rs
##
@@ -369,120 +394,171 @@ where
result.freeze()
}
+/// Apply a bitwise operation `op` to two inputs and
alamb commented on a change in pull request #8400:
URL: https://github.com/apache/arrow/pull/8400#discussion_r501812661
##
File path: rust/datafusion/src/physical_plan/type_casting.rs
##
@@ -0,0 +1,218 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
github-actions[bot] commented on pull request #8398:
URL: https://github.com/apache/arrow/pull/8398#issuecomment-705641941
Revision: b1ef5438a46892d8ee826bb6095291ad2685bebc
Submitted crossbow builds: [ursa-labs/crossbow @
nealrichardson commented on pull request #8398:
URL: https://github.com/apache/arrow/pull/8398#issuecomment-705640747
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jorgecarleitao commented on a change in pull request #8400:
URL: https://github.com/apache/arrow/pull/8400#discussion_r501802894
##
File path: rust/datafusion/src/physical_plan/type_casting.rs
##
@@ -0,0 +1,218 @@
+// Licensed to the Apache Software Foundation (ASF) under one
alamb commented on pull request #8346:
URL: https://github.com/apache/arrow/pull/8346#issuecomment-705636603
I am rebasing to pick up
https://github.com/apache/arrow/commit/4bbb74713c6883e8523eeeb5ac80a1e1f8521674
-- note however, that the tests in this PR use string comparisons (not
nevi-me commented on pull request #8388:
URL: https://github.com/apache/arrow/pull/8388#issuecomment-705636359
Merged
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alamb commented on a change in pull request #8340:
URL: https://github.com/apache/arrow/pull/8340#discussion_r501797053
##
File path: rust/datafusion/src/logical_plan/mod.rs
##
@@ -323,21 +322,19 @@ impl Expr {
///
/// # Errors
///
-/// This function errors
github-actions[bot] commented on pull request #8400:
URL: https://github.com/apache/arrow/pull/8400#issuecomment-705633631
https://issues.apache.org/jira/browse/ARROW-10236
This is an automated message from the Apache Git
alamb commented on a change in pull request #8400:
URL: https://github.com/apache/arrow/pull/8400#discussion_r501795062
##
File path: rust/datafusion/src/logical_plan/mod.rs
##
@@ -323,12 +324,13 @@ impl Expr {
///
/// # Errors
///
-/// This function errors
alamb opened a new pull request #8400:
URL: https://github.com/apache/arrow/pull/8400
This is a proposed approach - if people like this approach I will write
proper tests (to ensure that the cast kernel support and this function remain
in sync).
This PR brings DataFusion to parity
jorgecarleitao closed pull request #8397:
URL: https://github.com/apache/arrow/pull/8397
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
1 - 100 of 159 matches
Mail list logo
