[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080981598 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080981598 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
tustvold commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080984521 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow] github-actions[bot] commented on pull request #33781: re2::RE2::RE2() result must be checked

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #33781: URL: https://github.com/apache/arrow/pull/33781#issuecomment-1396656366 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an

[GitHub] [arrow] Ziy1-Tan opened a new pull request, #33781: re2::RE2::RE2() result must be checked

2023-01-19 Thread GitBox
Ziy1-Tan opened a new pull request, #33781: URL: https://github.com/apache/arrow/pull/33781 ### Rationale for this change closes https://github.com/apache/arrow/issues/33723 ### What changes are included in this PR? ### Are these changes tested?

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080981598 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080981598 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080981598 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080981598 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
tustvold commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080978777 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
tustvold commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080978777 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
tustvold commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080978777 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-19 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080977374 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow] github-actions[bot] commented on pull request #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #33780: URL: https://github.com/apache/arrow/pull/33780#issuecomment-1396644079 Revision: 13bcdda82ae4b1c4ef2eb3d0953b1fc9222ecb8f Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #33780: URL: https://github.com/apache/arrow/pull/33780#issuecomment-1396641338 * Closes: #33779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] thisisnic commented on pull request #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-19 Thread GitBox
thisisnic commented on PR #33780: URL: https://github.com/apache/arrow/pull/33780#issuecomment-1396641320 @github-actions crossbow submit test-r-versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] thisisnic opened a new pull request, #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-19 Thread GitBox
thisisnic opened a new pull request, #33780: URL: https://github.com/apache/arrow/pull/33780 This PR fixes a test which is failing on R versions < 4.0 due to the use of the function `data.frame()` which had a change in default parameter value for `stringsAsFactors` (from `TRUE` to `FALSE`)

[GitHub] [arrow] kou commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package

2023-01-19 Thread GitBox
kou commented on issue #33701: URL: https://github.com/apache/arrow/issues/33701#issuecomment-1396633315 BTW, is LTO support important in R? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package

2023-01-19 Thread GitBox
kou commented on issue #33701: URL: https://github.com/apache/arrow/issues/33701#issuecomment-1396632780 Ah, it seems that we have more places that construct `arrow::DataType` directly instead of using type construct function such as `arrow::int32()`. The following patch uses type

[GitHub] [arrow] chrisirhc commented on pull request #33735: GH-33734: [Go] make compatible with grpc < 1.45

2023-01-19 Thread GitBox
chrisirhc commented on PR #33735: URL: https://github.com/apache/arrow/pull/33735#issuecomment-1396620671 Addressed comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] chrisirhc commented on a diff in pull request #33735: GH-33734: [Go] make compatible with grpc < 1.45

2023-01-19 Thread GitBox
chrisirhc commented on code in PR #33735: URL: https://github.com/apache/arrow/pull/33735#discussion_r1080950208 ## go/arrow/flight/server.go: ## @@ -64,6 +63,24 @@ func RegisterFlightServiceServer(s grpc.ServiceRegistrar, srv FlightServer) {

[GitHub] [arrow-datafusion] mustafasrepo opened a new issue, #4980: Return Vec instead of bool in ExecutionPlan::maintains_input_order

2023-01-19 Thread GitBox
mustafasrepo opened a new issue, #4980: URL: https://github.com/apache/arrow-datafusion/issues/4980 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Currently API of `maintains_input_order` is as follows `fn

[GitHub] [arrow] github-actions[bot] commented on pull request #33778: GH-33777: [R] Nightly builds failing due to dataset test not being skipped on builds without datasets module

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #33778: URL: https://github.com/apache/arrow/pull/33778#issuecomment-1396601967 Revision: de1d764d08c6d051e9577ac4144ac4476f79a88c Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] thisisnic commented on pull request #33778: GH-33777: [R] Nightly builds failing due to dataset test not being skipped on builds without datasets module

2023-01-19 Thread GitBox
thisisnic commented on PR #33778: URL: https://github.com/apache/arrow/pull/33778#issuecomment-1396599413 @github-actions crossbow submit test-r-minimal-build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #33778: GH-33777: [R] Nightly builds failing due to dataset test not being skipped on builds without datasets module

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #33778: URL: https://github.com/apache/arrow/pull/33778#issuecomment-1396596284 * Closes: #33777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-datafusion] mustafasrepo opened a new issue, #4979: Add support for linear range search

2023-01-19 Thread GitBox
mustafasrepo opened a new issue, #4979: URL: https://github.com/apache/arrow-datafusion/issues/4979 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** During range calculation for window frames, we can use linear search instead

[GitHub] [arrow-datafusion] viirya closed issue #4962: Change count field from unsigned integer to signed integer in Sum

2023-01-19 Thread GitBox
viirya closed issue #4962: Change count field from unsigned integer to signed integer in Sum URL: https://github.com/apache/arrow-datafusion/issues/4962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow-datafusion] viirya closed pull request #4963: Change count field from unsigned integer to signed integer in Sum

2023-01-19 Thread GitBox
viirya closed pull request #4963: Change count field from unsigned integer to signed integer in Sum URL: https://github.com/apache/arrow-datafusion/pull/4963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion] viirya commented on pull request #4963: Change count field from unsigned integer to signed integer in Sum

2023-01-19 Thread GitBox
viirya commented on PR #4963: URL: https://github.com/apache/arrow-datafusion/pull/4963#issuecomment-1396589937 For the integration purpose, we need the second state field to be a `bool`. But due to `retract_batch`, seems it is not possible. We may think of another approach to deal with

[GitHub] [arrow-datafusion] mustafasrepo opened a new issue, #4978: Add support for bounded execution when window query involves UNBOUNDED PRECEDING

2023-01-19 Thread GitBox
mustafasrepo opened a new issue, #4978: URL: https://github.com/apache/arrow-datafusion/issues/4978 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Currently, the query below ```sql SELECT SUM(c1) OVER (ORDER BY c3

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4767: Move subquery alias assignment onto rules

2023-01-19 Thread GitBox
mingmwang commented on PR #4767: URL: https://github.com/apache/arrow-datafusion/pull/4767#issuecomment-1396575697 @jackwener Do you have some idea ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4767: Move subquery alias assignment onto rules

2023-01-18 Thread GitBox
mingmwang commented on PR #4767: URL: https://github.com/apache/arrow-datafusion/pull/4767#issuecomment-1396574575 One question regarding the Subquery Alias generation logic: Why does the `InSubquery` generate a Subquery Alias, but the `Exists` Subquery does not ? -- This is an

[GitHub] [arrow] mapleFU commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396555264 I generate a test file, and update it here: https://github.com/apache/parquet-testing/pull/34 You can merge that. And after that, we can run testing here. -- This is an

[GitHub] [arrow] ursabot commented on pull request #33728: GH-33726: [CI][Go] Set host name in Go benchmarks

2023-01-18 Thread GitBox
ursabot commented on PR #33728: URL: https://github.com/apache/arrow/pull/33728#issuecomment-1396552408 Benchmark runs are scheduled for baseline = 7319250597b0f4e3b5f859eb073264ce3c72a1bd and contender = 705e04bb15f481e476c9e7a8e2ac92460890ad0c. 705e04bb15f481e476c9e7a8e2ac92460890ad0c

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4969: refactor: display input partitions for `RepartitionExec`

2023-01-18 Thread GitBox
mingmwang commented on PR #4969: URL: https://github.com/apache/arrow-datafusion/pull/4969#issuecomment-1396543284 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow] Treize44 commented on issue #33759: [Python][C++] How to limit the memory consumption of to_batches()

2023-01-18 Thread GitBox
Treize44 commented on issue #33759: URL: https://github.com/apache/arrow/issues/33759#issuecomment-1396539880 I use pyarrow 10.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-rs] Sach1nAgarwal commented on issue #53: [Parquet] Reading parquet file into an ndarray

2023-01-18 Thread GitBox
Sach1nAgarwal commented on issue #53: URL: https://github.com/apache/arrow-rs/issues/53#issuecomment-1396513788 Parallel column is increasing the performance. I checked by creating multiple `ParquetRecordBatchStream` for each column and all `ParquetRecordBatchStream` reading parallely,

[GitHub] [arrow-datafusion] viirya commented on pull request #4963: Replace count with is_empty in Sum

2023-01-18 Thread GitBox
viirya commented on PR #4963: URL: https://github.com/apache/arrow-datafusion/pull/4963#issuecomment-1396475988 No, you're correct. The change at `retract_batch` is wrong. I don't follow how `retract_batch` works correctly. -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] jackwener commented on pull request #14351: GH-33115: [C++] Parquet Implement crc in reading and writing Page for DATA_PAGE (v1)

2023-01-18 Thread GitBox
jackwener commented on PR #14351: URL: https://github.com/apache/arrow/pull/14351#issuecomment-1396469562 It's a good feature. Can someone push the progress of this PR?❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] mapleFU commented on issue #15173: [Parquet][C++] ByteStreamSplitDecoder broken in presence of nulls

2023-01-18 Thread GitBox
mapleFU commented on issue #15173: URL: https://github.com/apache/arrow/issues/15173#issuecomment-1396461820 https://github.com/apache/arrow/issues/15173#issuecomment-1385858560 can be reproduce like this: ``` diff --git a/cpp/examples/parquet/low_level_api/reader_writer.cc

[GitHub] [arrow] ursabot commented on pull request #14814: GH-14875: [C++] C Data Interface: check imported buffer for non-null

2023-01-18 Thread GitBox
ursabot commented on PR #14814: URL: https://github.com/apache/arrow/pull/14814#issuecomment-1396438935 Benchmark runs are scheduled for baseline = 627caf3fe63ef3eebd9a3eb25367e5f05cb20c00 and contender = 7319250597b0f4e3b5f859eb073264ce3c72a1bd. 7319250597b0f4e3b5f859eb073264ce3c72a1bd

[GitHub] [arrow] kou commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
kou commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396433386 > What is needed for authentication? Integration with user information in PostgreSQL. We should not require users to configure additional authentication related things. > Could

[GitHub] [arrow] kou commented on a diff in pull request #33660: GH-33659: [Developer Tools] Add definition of Breaking Change and Critical Fix

2023-01-18 Thread GitBox
kou commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1080797181 ## docs/source/developers/reviewing.rst: ## @@ -255,3 +255,43 @@ Social aspects * Like any communication, code reviews are governed by the Apache `Code of Conduct

[GitHub] [arrow] bkmgit commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
bkmgit commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396397369 What is needed for authentication? Could pluggable authentication modules be used? How often could authentication be required - in particular are there performance requirements? --

[GitHub] [arrow] mapleFU commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396387844 Well, why should I have a assignee but I cannot edit the description of patch? Should someone be assignee or assign this task to me? ╮( ̄▽ ̄"")╭ -- This is an automated message from the

[GitHub] [arrow] wjones127 commented on a diff in pull request #33660: GH-33659: [Developer Tools] Add definition of Breaking Change and Critical Fix

2023-01-18 Thread GitBox
wjones127 commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1080767036 ## docs/source/developers/reviewing.rst: ## @@ -255,3 +255,43 @@ Social aspects * Like any communication, code reviews are governed by the Apache `Code of

[GitHub] [arrow-julia] quinnj commented on issue #375: Make recursive iteration to get dictionaries more defensive for interop

2023-01-18 Thread GitBox
quinnj commented on issue #375: URL: https://github.com/apache/arrow-julia/issues/375#issuecomment-1396384853 that looks like a good fix to me; if you make a PR, that'd be great. If you have an example arrow file that exhibits the problem that we can use to test it with, even better. --

[GitHub] [arrow] mapleFU commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396382437 @pitrou @wjones127 @emkornfield Mind take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-julia] quinnj commented on pull request #381: Tag new version dev/release/release.sh

2023-01-18 Thread GitBox
quinnj commented on PR #381: URL: https://github.com/apache/arrow-julia/pull/381#issuecomment-1396382366 This seems fine to me, but @ericphanson, are we not able to get TagBot to run for the repo? The advantages of TagBot are: * automated once the release is published in the General

[GitHub] [arrow] ziggythehamster commented on issue #33733: [Packaging] Amazon Linux 2 RPMs - openssl-devel cannot coexist with openssl11-devel and breaks installing arrow-devel

2023-01-18 Thread GitBox
ziggythehamster commented on issue #33733: URL: https://github.com/apache/arrow/issues/33733#issuecomment-1396381666 In my case, no, because I would first have to uninstall openssl11-devel (and anything already installed in my base image that depends on it) and then put it back when I'm

[GitHub] [arrow] github-actions[bot] commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396378871 * Closes: #15164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] mapleFU opened a new pull request, #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU opened a new pull request, #33776: URL: https://github.com/apache/arrow/pull/33776 ### Rationale for this change Previously, C++ BloomFilter is implemented in 2019, but standard change in BloomFilter, which could be seen here:

[GitHub] [arrow] vibhatha commented on pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
vibhatha commented on PR #33725: URL: https://github.com/apache/arrow/pull/33725#issuecomment-1396374820 @westonpace seems like the CI's are unrelated to this modification. Reviews are addressed. Thank you for working on this. -- This is an automated message from the Apache Git Service.

[GitHub] [arrow] vibhatha commented on a diff in pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
vibhatha commented on code in PR #33725: URL: https://github.com/apache/arrow/pull/33725#discussion_r1080759071 ## docs/source/cpp/streaming_execution.rst: ## @@ -113,12 +109,12 @@ Read Relations * The ``projection`` property is not supported and plans containing this

[GitHub] [arrow-rs] Frankonly commented on a diff in pull request #3544: Update pyarrow method call to avoid warning

2023-01-18 Thread GitBox
Frankonly commented on code in PR #3544: URL: https://github.com/apache/arrow-rs/pull/3544#discussion_r1080755836 ## arrow/src/pyarrow.rs: ## @@ -196,7 +196,8 @@ impl PyArrowConvert for RecordBatch { let module = py.import("pyarrow")?; let class =

[GitHub] [arrow-rs] Frankonly opened a new pull request, #3560: Update pyarrow method call with kwargs

2023-01-18 Thread GitBox
Frankonly opened a new pull request, #3560: URL: https://github.com/apache/arrow-rs/pull/3560 # Which issue does this PR close? Closes #3543 # Rationale for this change A follow up PR of #3544 # What changes are included in this PR? Pass

[GitHub] [arrow] assignUser commented on pull request #33751: WIP: [Release] Verify release-11.0.0-rc0

2023-01-18 Thread GitBox
assignUser commented on PR #33751: URL: https://github.com/apache/arrow/pull/33751#issuecomment-1396368957 The pytest seg fault is also happening in verification https://github.com/ursacomputing/crossbow/actions/runs/3954649758/jobs/6772203240#step:5:2810 -- This is an automated message

[GitHub] [arrow] lidavidm commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
lidavidm commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396367552 Yes, the ADBC driver wraps libpq and should let you work with other databases that use the PostgreSQL wire protocol, with the caveat that it has to convert the data (of course).

[GitHub] [arrow] kou commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
kou commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396362498 @alamb @jacobmarble Thanks for your comments! > It might help to start this document with an expected usecase. It makes sense. I'll add it. > I originally thought it was

[GitHub] [arrow] github-actions[bot] commented on pull request #33751: WIP: [Release] Verify release-11.0.0-rc0

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #33751: URL: https://github.com/apache/arrow/pull/33751#issuecomment-1396348454 Revision: f10f5cfd1376fb0e602334588b3f3624d41dee7d Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ursabot commented on pull request #33682: GH-33681: [JS] Update flatbuffers

2023-01-18 Thread GitBox
ursabot commented on PR #33682: URL: https://github.com/apache/arrow/pull/33682#issuecomment-1396348022 Benchmark runs are scheduled for baseline = 85a111f8d5cef3a668c9cf8c47ccb943048e50f6 and contender = 627caf3fe63ef3eebd9a3eb25367e5f05cb20c00. 627caf3fe63ef3eebd9a3eb25367e5f05cb20c00

[GitHub] [arrow] kou commented on pull request #33751: WIP: [Release] Verify release-11.0.0-rc0

2023-01-18 Thread GitBox
kou commented on PR #33751: URL: https://github.com/apache/arrow/pull/33751#issuecomment-1396345063 @github-actions crossbow submit --group verify-rc-binaries --group verify-rc-wheels --param release=11.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] westonpace commented on pull request #33738: GH-33737: [C++] simplify exec plan tracing

2023-01-18 Thread GitBox
westonpace commented on PR #33738: URL: https://github.com/apache/arrow/pull/33738#issuecomment-1396340861 Here's a trace from a dataset write. There are still things that could be cleaned up here. Pretty much all of the `DatasetWriter::` traces are a mix of active CPU time and idle I/O

[GitHub] [arrow] kou commented on issue #33733: [Packaging] Amazon Linux 2 RPMs - openssl-devel cannot coexist with openssl11-devel and breaks installing arrow-devel

2023-01-18 Thread GitBox
kou commented on issue #33733: URL: https://github.com/apache/arrow/issues/33733#issuecomment-1396338565 OK. We can remove `arrow-devel` after we install `red-arrow` gem. Does `gem install red-arrow && yum remove -y arrow-devel` work with your use case? -- This is an automated message

[GitHub] [arrow] ava6969 commented on issue #33747: [C++] Published new library panda-apache

2023-01-18 Thread GitBox
ava6969 commented on issue #33747: URL: https://github.com/apache/arrow/issues/33747#issuecomment-1396337269 thanks just did -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou commented on issue #33773: [Docs][Release] Add vcpkg-port update script to release magement guide

2023-01-18 Thread GitBox
kou commented on issue #33773: URL: https://github.com/apache/arrow/issues/33773#issuecomment-1396333470 Ah, sorry. I forgot this. Could you work on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion-python] andygrove opened a new issue, #138: Add example that calls a Python UDF from SQL

2023-01-18 Thread GitBox
andygrove opened a new issue, #138: URL: https://github.com/apache/arrow-datafusion-python/issues/138 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Add example that calls a Python UDF from SQL **Describe the solution

[GitHub] [arrow] kou commented on a diff in pull request #33660: GH-33659: [Developer Tools] Add definition of Breaking Change and Critical Fix

2023-01-18 Thread GitBox
kou commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1080723781 ## docs/source/developers/reviewing.rst: ## @@ -255,3 +255,43 @@ Social aspects * Like any communication, code reviews are governed by the Apache `Code of Conduct

[GitHub] [arrow-datafusion-python] andygrove closed issue #134: Add script for Python linting

2023-01-18 Thread GitBox
andygrove closed issue #134: Add script for Python linting URL: https://github.com/apache/arrow-datafusion-python/issues/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow-datafusion-python] andygrove merged pull request #115: Upgrade to DataFusion 16.0.0

2023-01-18 Thread GitBox
andygrove merged PR #115: URL: https://github.com/apache/arrow-datafusion-python/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow-datafusion-python] andygrove opened a new pull request, #137: Add simple examples

2023-01-18 Thread GitBox
andygrove opened a new pull request, #137: URL: https://github.com/apache/arrow-datafusion-python/pull/137 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing

[GitHub] [arrow] kou commented on issue #33747: [C++] Published new library panda-apache

2023-01-18 Thread GitBox
kou commented on issue #33747: URL: https://github.com/apache/arrow/issues/33747#issuecomment-1396316487 Yes. But you need to subscribe the mailing list before you send an e-mail. See https://arrow.apache.org/community/ how to subscribe. -- This is an automated message from the Apache

[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #115: Upgrade to DataFusion 16.0.0

2023-01-18 Thread GitBox
jdye64 commented on PR #115: URL: https://github.com/apache/arrow-datafusion-python/pull/115#issuecomment-1396315054 LGTM. That was a bear. Thanks for tackling it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] anjakefala commented on issue #33618: [C++] Improve arrow::fs::FileSelect performance for `IsFile()` and `IsDirectory()`

2023-01-18 Thread GitBox
anjakefala commented on issue #33618: URL: https://github.com/apache/arrow/issues/33618#issuecomment-1396304799 > If local filesystems are the odd one out, perhaps it doesn't make sense in the filesystem API and we should instead recommend a work around for that special case. Since

[GitHub] [arrow] westonpace commented on pull request #33738: GH-33737: [C++] simplify exec plan tracing

2023-01-18 Thread GitBox
westonpace commented on PR #33738: URL: https://github.com/apache/arrow/pull/33738#issuecomment-1396299760 > In the figure, why does WaitForFinish(SinkNode:) end earlier than the ScalarAggregate? The code looks roughly like: ``` void SinkNode::ReceiveLastBatch(batch) {

[GitHub] [arrow] EpsilonPrime commented on pull request #33775: ARROW-18425: [Substrait] Add Substrait→Acero mapping for round operationMajor:

2023-01-18 Thread GitBox
EpsilonPrime commented on PR #33775: URL: https://github.com/apache/arrow/pull/33775#issuecomment-1396295962 This replaces PR 14956. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #33775: ARROW-18425: [Substrait] Add Substrait→Acero mapping for round operationMajor:

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #33775: URL: https://github.com/apache/arrow/pull/33775#issuecomment-1396295419 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an

[GitHub] [arrow] EpsilonPrime opened a new pull request, #33775: ARROW-18425: [Substrait] Add Substrait→Acero mapping for round operationMajor:

2023-01-18 Thread GitBox
EpsilonPrime opened a new pull request, #33775: URL: https://github.com/apache/arrow/pull/33775 Adds binary round kernel for float types. Provides fallback for binary round from int types to double. Does not provide fallback for binary round for decimal types. Minor: Fixes

[GitHub] [arrow] EpsilonPrime closed pull request #33774: GH-15200: [C++] Add specific ndigits value for round

2023-01-18 Thread GitBox
EpsilonPrime closed pull request #33774: GH-15200: [C++] Add specific ndigits value for round URL: https://github.com/apache/arrow/pull/33774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] EpsilonPrime commented on pull request #33774: GH-15200: [C++] Add specific ndigits value for round

2023-01-18 Thread GitBox
EpsilonPrime commented on PR #33774: URL: https://github.com/apache/arrow/pull/33774#issuecomment-1396292787 Wrong bug, I'll try again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] EpsilonPrime commented on pull request #33774: GH-15200: [C++] Add specific ndigits value for round

2023-01-18 Thread GitBox
EpsilonPrime commented on PR #33774: URL: https://github.com/apache/arrow/pull/33774#issuecomment-1396292123 Replaces PR 30309. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] github-actions[bot] commented on pull request #33774: GH-15200: [C++] Add specific ndigits value for round

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #33774: URL: https://github.com/apache/arrow/pull/33774#issuecomment-1396292270 * Closes: #15200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] EpsilonPrime opened a new pull request, #33774: GH-15200: [C++] Add specific ndigits value for round

2023-01-18 Thread GitBox
EpsilonPrime opened a new pull request, #33774: URL: https://github.com/apache/arrow/pull/33774 Adds binary round kernel for float types. Provides fallback for binary round from int types to double. Does not provide fallback for binary round for decimal types. Minor: Fixes

[GitHub] [arrow] westonpace commented on a diff in pull request #33738: GH-33737: [C++] simplify exec plan tracing

2023-01-18 Thread GitBox
westonpace commented on code in PR #33738: URL: https://github.com/apache/arrow/pull/33738#discussion_r1080703912 ## cpp/src/arrow/compute/exec/filter_node.cc: ## @@ -103,17 +103,9 @@ class FilterNode : public MapNode { } void InputReceived(ExecNode* input, ExecBatch

[GitHub] [arrow] westonpace commented on pull request #14867: GH-14866: [C++] Remove internal GroupBy implementation

2023-01-18 Thread GitBox
westonpace commented on PR #14867: URL: https://github.com/apache/arrow/pull/14867#issuecomment-1396289231 I've rebased this and will merge if CI is still passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ava6969 commented on issue #33747: [C++] Published new library panda-apache

2023-01-18 Thread GitBox
ava6969 commented on issue #33747: URL: https://github.com/apache/arrow/issues/33747#issuecomment-1396287943 how does mailing list discussion work, do i email d...@arrow.apache.org -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] assignUser commented on pull request #14610: ARROW-18289: [Release][vcpkg] Add a script to update vcpkg's arrow port

2023-01-18 Thread GitBox
assignUser commented on PR #14610: URL: https://github.com/apache/arrow/pull/14610#issuecomment-1396287665 Oh I totally missed this! Very nice! We should add this to the release guide! I will open an issue. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] westonpace merged pull request #33648: GH-33640: [C++] Add backpressure to asof join node

2023-01-18 Thread GitBox
westonpace merged PR #33648: URL: https://github.com/apache/arrow/pull/33648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] kou commented on pull request #33751: WIP: [Release] Verify release-11.0.0-rc0

2023-01-18 Thread GitBox
kou commented on PR #33751: URL: https://github.com/apache/arrow/pull/33751#issuecomment-1396286922 Passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [arrow] westonpace commented on a diff in pull request #33738: GH-33737: [C++] simplify exec plan tracing

2023-01-18 Thread GitBox
westonpace commented on code in PR #33738: URL: https://github.com/apache/arrow/pull/33738#discussion_r1080701548 ## cpp/src/arrow/compute/exec/sink_node.cc: ## @@ -335,19 +327,13 @@ class ConsumingSinkNode : public ExecNode, public BackpressureControl { void Resume()

[GitHub] [arrow] ava6969 commented on issue #33747: [C++] Published new library panda-apache

2023-01-18 Thread GitBox
ava6969 commented on issue #33747: URL: https://github.com/apache/arrow/issues/33747#issuecomment-1396285442 that would be great if it could be integrated as i had to copy some internal files. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] westonpace commented on pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
westonpace commented on PR #33725: URL: https://github.com/apache/arrow/pull/33725#issuecomment-1396284268 Thanks @felipecrv / @vibhatha . I believe I have addressed the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] westonpace commented on a diff in pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
westonpace commented on code in PR #33725: URL: https://github.com/apache/arrow/pull/33725#discussion_r1080700095 ## docs/source/cpp/streaming_execution.rst: ## @@ -86,25 +86,21 @@ Plans ^ * A plan should have a single top-level relation. - * The consumer is currently

[GitHub] [arrow] westonpace commented on a diff in pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
westonpace commented on code in PR #33725: URL: https://github.com/apache/arrow/pull/33725#discussion_r1080699744 ## docs/source/cpp/streaming_execution.rst: ## @@ -86,25 +86,21 @@ Plans ^ * A plan should have a single top-level relation. - * The consumer is currently

[GitHub] [arrow-datafusion-python] andygrove opened a new issue, #136: Release version 0.8.0

2023-01-18 Thread GitBox
andygrove opened a new issue, #136: URL: https://github.com/apache/arrow-datafusion-python/issues/136 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** We should release a new version based on DataFusion 16 **Describe the

[GitHub] [arrow] westonpace commented on a diff in pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
westonpace commented on code in PR #33725: URL: https://github.com/apache/arrow/pull/33725#discussion_r1080698976 ## docs/source/cpp/streaming_execution.rst: ## @@ -113,12 +109,12 @@ Read Relations * The ``projection`` property is not supported and plans containing this

[GitHub] [arrow-adbc] kou commented on a diff in pull request #356: feat(go/adbc/driver/pkg/cmake): cmake build for Go shared library drivers

2023-01-18 Thread GitBox
kou commented on code in PR #356: URL: https://github.com/apache/arrow-adbc/pull/356#discussion_r1080698782 ## c/driver/flightsql/adbc-driver-flightsql.pc.in: ## @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [arrow-datafusion-python] andygrove opened a new issue, #135: window_lead test appears to be non-deterministic

2023-01-18 Thread GitBox
andygrove opened a new issue, #135: URL: https://github.com/apache/arrow-datafusion-python/issues/135 **Describe the bug** The test works for me locally but fails in CI/ ``` 2023-01-19T00:06:25.0267445Z df = 2023-01-19T00:06:25.0268026Z 2023-01-19T00:06:25.0268336Z

[GitHub] [arrow] emkornfield commented on pull request #14879: PARQUET-2201: [parquet-cpp] Add stress test for RecordReader ReadRecords and SkipRecords.

2023-01-18 Thread GitBox
emkornfield commented on PR #14879: URL: https://github.com/apache/arrow/pull/14879#issuecomment-1396267669 Looks like ASAN/UBSAN are still potentially real: `61 - parquet-reader-test (Failed)` -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] emkornfield commented on a diff in pull request #17877: PARQUET-2225:[C++][Parquet] Allow reading dense with RecordReader

2023-01-18 Thread GitBox
emkornfield commented on code in PR #17877: URL: https://github.com/apache/arrow/pull/17877#discussion_r1080690591 ## cpp/src/parquet/column_reader_test.cc: ## @@ -757,6 +760,63 @@ TEST_F(RecordReaderTest, BasicReadRepeatedField) { /*levels_position=*/0); } +//

<    2   3   4   5   6   7   8   9   10   11   >