[GitHub] [arrow-rs] alamb commented on a change in pull request #406: Add Decimal to CsvWriter and improve debug display

2021-06-06 Thread GitBox
alamb commented on a change in pull request #406: URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646114701 ## File path: arrow/src/util/display.rs ## @@ -192,18 +194,34 @@ macro_rules! make_string_from_list { }}; } -macro_rules! make_string_from_decimal {

[GitHub] [arrow-rs] alamb commented on a change in pull request #406: Add Decimal to CsvWriter and improve debug display

2021-06-06 Thread GitBox
alamb commented on a change in pull request #406: URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646117403 ## File path: arrow/benches/csv_writer.rs ## @@ -28,14 +28,14 @@ use arrow::record_batch::RecordBatch; use std::fs::File; use std::sync::Arc; -fn

[GitHub] [arrow-rs] alamb commented on a change in pull request #406: Add Decimal to CsvWriter and improve debug display

2021-06-06 Thread GitBox
alamb commented on a change in pull request #406: URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646114701 ## File path: arrow/src/util/display.rs ## @@ -192,18 +194,34 @@ macro_rules! make_string_from_list { }}; } -macro_rules! make_string_from_decimal {

[GitHub] [arrow-rs] alamb commented on a change in pull request #406: Add Decimal to CsvWriter and improve debug display

2021-06-04 Thread GitBox
alamb commented on a change in pull request #406: URL: https://github.com/apache/arrow-rs/pull/406#discussion_r645843861 ## File path: arrow/src/csv/writer.rs ## @@ -242,6 +245,14 @@ impl Writer { }; format!("{}",

[GitHub] [arrow-rs] alamb commented on a change in pull request #406: Add Decimal to CsvWriter and improve debug display

2021-06-04 Thread GitBox
alamb commented on a change in pull request #406: URL: https://github.com/apache/arrow-rs/pull/406#discussion_r645843369 ## File path: arrow/src/array/array_binary.rs ## @@ -728,8 +730,11 @@ impl From for DecimalArray { impl fmt::Debug for DecimalArray { fn fmt(, f: