Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#issuecomment-2577808383 Thanks again everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-08 Thread via GitHub
alamb merged PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-06 Thread via GitHub
XiangpengHao commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1904647227 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +//

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-06 Thread via GitHub
alamb commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1904636445 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// This

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-06 Thread via GitHub
XiangpengHao commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1904432071 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +//

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-06 Thread via GitHub
XiangpengHao commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1904429426 ## parquet/src/arrow/array_reader/byte_view_array.rs: ## @@ -308,18 +308,29 @@ impl ByteViewArrayDecoderPlain { validate_utf8: bool, ) -> Self {

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
alamb commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903109137 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// This

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
alamb commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903096035 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// This

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
tustvold commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903094459 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// Th

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
tustvold commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903094459 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// Th

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
alamb commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903093809 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// This

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
tustvold commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903046691 ## parquet/src/arrow/array_reader/byte_view_array.rs: ## @@ -308,18 +308,29 @@ impl ByteViewArrayDecoderPlain { validate_utf8: bool, ) -> Self {

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
tustvold commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903046691 ## parquet/src/arrow/array_reader/byte_view_array.rs: ## @@ -308,18 +308,29 @@ impl ByteViewArrayDecoderPlain { validate_utf8: bool, ) -> Self {

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
tustvold commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903042130 ## parquet/src/arrow/array_reader/byte_view_array.rs: ## @@ -308,18 +308,29 @@ impl ByteViewArrayDecoderPlain { validate_utf8: bool, ) -> Self {

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-04 Thread via GitHub
tustvold commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903037478 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// Th

Re: [PR] [Parquet] Reuse buffer in `ByteViewArrayDecoderPlain` [arrow-rs]

2025-01-03 Thread via GitHub
alamb commented on code in PR #6930: URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1901674152 ## arrow-buffer/src/buffer/immutable.rs: ## @@ -79,6 +79,21 @@ impl Buffer { } } +/// Auxiliary method to create a new Buffer +/// +/// This