[GitHub] [arrow] wesm commented on pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

wesm commented on pull request #7030: URL: https://github.com/apache/arrow/pull/7030#issuecomment-656352612 I think @jacques-n may be on vacation, so responses could be delayed -- this needs nother rebase in the meantime, though

[GitHub] [arrow] wesm commented on pull request #7176: ARROW-8796: [Rust] feat: Allow writers to use &mut Vec

wesm commented on pull request #7176: URL: https://github.com/apache/arrow/pull/7176#issuecomment-656352940 Can this be merged? This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow] wesm commented on pull request #7193: ARROW-7924: [Rust] Add sort for float types

wesm commented on pull request #7193: URL: https://github.com/apache/arrow/pull/7193#issuecomment-656353086 Can this be merged or are there more changes to make? This is an automated message from the Apache Git Service. To re

[GitHub] [arrow] wesm commented on a change in pull request #7555: ARROW-9238: [C++][CI][FlightRPC] increase test coverage of round-robin under IPC and Flight

wesm commented on a change in pull request #7555: URL: https://github.com/apache/arrow/pull/7555#discussion_r452494159 ## File path: cpp/src/arrow/testing/gtest_util.cc ## @@ -389,6 +406,28 @@ void CompareBatch(const RecordBatch& left, const RecordBatch& right, } } +void

[GitHub] [arrow] rymurr commented on pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchanged

rymurr commented on pull request #6402: URL: https://github.com/apache/arrow/pull/6402#issuecomment-656355715 > @rymurr could you take another look at this? sure! Will check first thing my am This is an automated messa

[GitHub] [arrow] wesm commented on a change in pull request #7555: ARROW-9238: [C++][CI][FlightRPC] increase test coverage of round-robin under IPC and Flight

wesm commented on a change in pull request #7555: URL: https://github.com/apache/arrow/pull/7555#discussion_r452503703 ## File path: cpp/src/arrow/testing/gtest_util.cc ## @@ -389,6 +406,28 @@ void CompareBatch(const RecordBatch& left, const RecordBatch& right, } } +void

[GitHub] [arrow] wesm commented on pull request #7555: ARROW-9238: [C++][CI][FlightRPC] increase test coverage of round-robin under IPC and Flight

wesm commented on pull request #7555: URL: https://github.com/apache/arrow/pull/7555#issuecomment-656363828 +1. Will merge on green This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [arrow] wesm closed pull request #7697: ARROW-9393: [Doc] update supported types documentation for Java

wesm closed pull request #7697: URL: https://github.com/apache/arrow/pull/7697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm closed pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

wesm closed pull request #7664: URL: https://github.com/apache/arrow/pull/7664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm commented on pull request #7657: ARROW-8886: [C#] Resize to negative length no longer permitted

wesm commented on pull request #7657: URL: https://github.com/apache/arrow/pull/7657#issuecomment-656369641 @eerhardt? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [arrow] nealrichardson commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so

nealrichardson commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656371696 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To respond t

[GitHub] [arrow] github-actions[bot] commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static libra

github-actions[bot] commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656372428 Revision: 199af083138858c96f1c7cd8a063b165f3c46a5e Submitted crossbow builds: [ursa-labs/crossbow @ actions-395](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656373613 @tobim FYI, this approach should be less offensive than what I was doing previously (hacking libarrow.a directly) Th

[GitHub] [arrow] wesm commented on pull request #7630: ARROW-9317: [Java] add few testcases for arrow-memory

wesm commented on pull request #7630: URL: https://github.com/apache/arrow/pull/7630#issuecomment-656375897 @rymurr I assume this needs to be rebased / refactored? This is an automated message from the Apache Git Service. To

[GitHub] [arrow] wesm commented on pull request #7643: ARROW-9331: [C++] Improve the performance of Tensor-to-SparseTensor conversion

wesm commented on pull request #7643: URL: https://github.com/apache/arrow/pull/7643#issuecomment-656375576 @mrkn would you like someone to look at this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] wesm commented on pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

wesm commented on pull request #7604: URL: https://github.com/apache/arrow/pull/7604#issuecomment-656376374 ping @BryanCutler, would be good to merge this for the release if possible This is an automated message from the Apac

[GitHub] [arrow] wesm closed pull request #7607: ARROW-8996: [C++] Add AVX version for aggregate sum/mean with runtime dispatch

wesm closed pull request #7607: URL: https://github.com/apache/arrow/pull/7607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656383933 @nealrichardson the "test-conda-r-4.0" failure doesn't appear to be related to this patch This is an automated messa

[GitHub] [arrow] emkornfield commented on pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

emkornfield commented on pull request #7604: URL: https://github.com/apache/arrow/pull/7604#issuecomment-656384231 @jorisvandenbossche Is there a way to skip specific tests, I thought all of the live in spark code? This is a

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

folders/nz/vv4_9tw56nv9k3tkvyszvwg8gn/T/hbtmp/apache-arrow-20200709-78324-1gv9ydo/build/jemalloc_ep-prefix/src/jemalloc_ep && /private/var/folders/nz/vv4_9tw56nv9k3tkvyszvwg8gn/T/build-apache-arrow/Cellar/cmake/3.12.2/bin/cmake -P /private/var/folders/nz/vv4_9tw56nv9k3tkvyszvwg8000

[GitHub] [arrow] mrkn commented on pull request #7643: ARROW-9331: [C++] Improve the performance of Tensor-to-SparseTensor conversion

mrkn commented on pull request #7643: URL: https://github.com/apache/arrow/pull/7643#issuecomment-656385805 @wesm Yes, currently I’ve almost done for SparseCOOTensor. I think merging this before finishing for all the sparse format is better than nothing to be merged before 1.0. -

[GitHub] [arrow] wesm opened a new pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL

wesm opened a new pull request #7698: URL: https://github.com/apache/arrow/pull/7698 A few interrelated fixes: * The `is_null` kernel was returning a slightly malformed `ArrayData` with the null_count set to -1 even though the validity bitmap is null. * Adds `ArrayData::MayHaveNul

[GitHub] [arrow] wesm commented on pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL

wesm commented on pull request #7698: URL: https://github.com/apache/arrow/pull/7698#issuecomment-656390655 @nealrichardson thanks for finding these issues This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] nealrichardson commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so

nealrichardson commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656391160 Linux seems to be working smoothly; I'll poke at macOS autobrew. On mingw, looks like there's an issue compiling mimalloc: https://github.com/apache/arrow/pull/7696/checks?

[GitHub] [arrow] github-actions[bot] commented on pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL

github-actions[bot] commented on pull request #7698: URL: https://github.com/apache/arrow/pull/7698#issuecomment-656392177 https://issues.apache.org/jira/browse/ARROW-9380 This is an automated message from the Apache Git Serv

[GitHub] [arrow] lidavidm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

lidavidm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452537636 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMet

[GitHub] [arrow] lidavidm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

lidavidm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452537636 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMet

[GitHub] [arrow] nealrichardson commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so

nealrichardson commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656394655 @github-actions crossbow submit homebrew-r-autobrew This is an automated message from the Apache Git Servic

[GitHub] [arrow] wesm commented on pull request #7682: ARROW-9373: [C++] Fix Parquet crash on invalid input (OSS-Fuzz)

wesm commented on pull request #7682: URL: https://github.com/apache/arrow/pull/7682#issuecomment-656395097 Rebased to https://github.com/apache/arrow-testing/commit/b6a2fc5fef8fe44cf815be4f7961a4fee5d08367. Will merge this and then update the other --

[GitHub] [arrow] github-actions[bot] commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static libra

github-actions[bot] commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656395197 Revision: 706e50be600ee8d8ee33cffdb9611720e1dcd05c Submitted crossbow builds: [ursa-labs/crossbow @ actions-396](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] wesm commented on pull request #7477: ARROW-4221: [C++][Python] Add canonical flag in COO sparse index

wesm commented on pull request #7477: URL: https://github.com/apache/arrow/pull/7477#issuecomment-656396021 @mrkn this needs a rebase -- I can review and then merge this once the build is passing? This is an automated messa

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656399304 The mimalloc issue seems to only affect the DLL, which we don't need, so I disabled it This is an automated message

[GitHub] [arrow] wesm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

wesm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452544857 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMetadat

[GitHub] [arrow] wesm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

wesm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452544857 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMetadat

[GitHub] [arrow] wesm closed pull request #7682: ARROW-9373: [C++] Fix Parquet crash on invalid input (OSS-Fuzz)

wesm closed pull request #7682: URL: https://github.com/apache/arrow/pull/7682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] nealrichardson commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so

nealrichardson commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656402960 @github-actions crossbow submit homebrew-r-autobrew This is an automated message from the Apache Git Servic

[GitHub] [arrow] github-actions[bot] commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static libra

github-actions[bot] commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656403426 Revision: aeb3830e5935904a8a719a4aaf6c8131d2dbc141 Submitted crossbow builds: [ursa-labs/crossbow @ actions-397](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] mrkn commented on pull request #7643: ARROW-9331: [C++] Improve the performance of Tensor-to-SparseTensor conversion

mrkn commented on pull request #7643: URL: https://github.com/apache/arrow/pull/7643#issuecomment-656411938 @wesm I'm working on fixing the problems on VC++. Please wait a moment. This is an automated message from the Apache

[GitHub] [arrow] lidavidm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

lidavidm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452558073 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMet

[GitHub] [arrow] wesm edited a comment on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so th

wesm edited a comment on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656414016 @nealrichardson try adding `-lbcrypt -lpsapi` to the linker setup, it seems like those might be required by mimalloc on Windows/MinGW

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656414016 @nealrichardson try adding `-lbcrypt -lpsapi` to the linker setup, it seems like those might be required by mimalloc

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656419165 Confirming the new transitive dependencies from mimalloc: ```cmake if(WIN32) list(APPEND mi_libraries psapi shell32 user32 bcrypt) else() ``` https://github

[GitHub] [arrow] BryanCutler commented on pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

BryanCutler commented on pull request #7604: URL: https://github.com/apache/arrow/pull/7604#issuecomment-656420297 > @jorisvandenbossche Is there a way to skip specific tests, I thought all of the live in spark code? The script selects all Spark tests that use Arrow. I'm pretty sure

[GitHub] [arrow] wesm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

wesm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452564868 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMetadat

[GitHub] [arrow] jianxind commented on a change in pull request #7607: ARROW-8996: [C++] Add AVX version for aggregate sum/mean with runtime dispatch

jianxind commented on a change in pull request #7607: URL: https://github.com/apache/arrow/pull/7607#discussion_r452564982 ## File path: cpp/src/arrow/compute/registry.cc ## @@ -115,6 +116,19 @@ static std::unique_ptr CreateBuiltInRegistry() { RegisterVectorNested(registry.

[GitHub] [arrow] wesm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

wesm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452565269 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMetadat

[GitHub] [arrow] wesm commented on a change in pull request #7664: ARROW-9265: [C++] Allow writing and reading V4-compliant IPC data

wesm commented on a change in pull request #7664: URL: https://github.com/apache/arrow/pull/7664#discussion_r452565638 ## File path: python/pyarrow/ipc.pxi ## @@ -18,6 +18,32 @@ import warnings +cpdef enum MetadataVersion: +V1 = CMetadataVersion_V1 +V2 = CMetadat

[GitHub] [arrow] wesm commented on pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL

wesm commented on pull request #7698: URL: https://github.com/apache/arrow/pull/7698#issuecomment-656421460 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] wesm closed pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL

wesm closed pull request #7698: URL: https://github.com/apache/arrow/pull/7698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm closed pull request #7689: ARROW-9384: [C++] Avoid memory blowup on invalid IPC input

wesm closed pull request #7689: URL: https://github.com/apache/arrow/pull/7689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm commented on pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

wesm commented on pull request #7656: URL: https://github.com/apache/arrow/pull/7656#issuecomment-656424086 I added this issue to the 1.0.0 milestone so we can try to get this merged in the next few days This is an automated

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656424943 I'm having a hard time reading the Homebrew job output -- was the prior failure a flake? This is an automated messag

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656440573 @github-actions crossbow submit homebrew-r-autobrew This is an automated message from the Apache Git Service. To resp

[GitHub] [arrow] github-actions[bot] commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static libra

github-actions[bot] commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656440995 Revision: da68e097ad07c0b9036e8175349bad2ba30787be Submitted crossbow builds: [ursa-labs/crossbow @ actions-398](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so

nealrichardson commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656447670 IDK why the first autobrew job failed but the last (third) succeeded. Don't think that turning on verbosity should have fixed it. I think the second one failed because you

[GitHub] [arrow] nealrichardson commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so

nealrichardson commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656452167 Windows Rtools builds are green now and autobrew passed again, so should we revert https://github.com/apache/arrow/pull/7696/commits/12c7803bfdea34655615276aa6681112164d55f

[GitHub] [arrow] nealrichardson opened a new pull request #7699: ARROW-9303: [R] Linux static build should always bundle dependencies

nealrichardson opened a new pull request #7699: URL: https://github.com/apache/arrow/pull/7699 Also adds a cmake minimum version check, per the original user report. This is an automated message from the Apache Git Service. T

[GitHub] [arrow] github-actions[bot] commented on pull request #7699: ARROW-9303: [R] Linux static build should always bundle dependencies

github-actions[bot] commented on pull request #7699: URL: https://github.com/apache/arrow/pull/7699#issuecomment-656457336 https://issues.apache.org/jira/browse/ARROW-9303 This is an automated message from the Apache Git Serv

[GitHub] [arrow] mrkn commented on a change in pull request #7477: ARROW-4221: [C++][Python] Add canonical flag in COO sparse index

mrkn commented on a change in pull request #7477: URL: https://github.com/apache/arrow/pull/7477#discussion_r452605554 ## File path: python/pyarrow/tensor.pxi ## @@ -270,8 +279,10 @@ shape: {0.shape}""".format(self) &out_data, &out

[GitHub] [arrow] projjal commented on a change in pull request #7641: ARROW-9328: [C++][Gandiva] Add LTRIM, RTRIM, BTRIM functions for string

projjal commented on a change in pull request #7641: URL: https://github.com/apache/arrow/pull/7641#discussion_r452613034 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -320,6 +385,143 @@ const char* trim_utf8(gdv_int64 context, const char* data, gdv_int32 data_

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656473474 Yes that sounds good. @kou do you have any concerns about this? Let’s wait a bit for more comments This is an autom

[GitHub] [arrow] jianxind opened a new pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

jianxind opened a new pull request #7700: URL: https://github.com/apache/arrow/pull/7700 Enable simd_level feature of kernel and use it in DispatchExactImpl. Also expand sum/mean test case to cover BitBlockCounter method. Signed-off-by: Frank Du -

[GitHub] [arrow] projjal commented on a change in pull request #7641: ARROW-9328: [C++][Gandiva] Add LTRIM, RTRIM, BTRIM functions for string

projjal commented on a change in pull request #7641: URL: https://github.com/apache/arrow/pull/7641#discussion_r452615768 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -284,10 +285,74 @@ const char* reverse_utf8(gdv_int64 context, const char* data, gdv_int32 da

[GitHub] [arrow] github-actions[bot] commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

github-actions[bot] commented on pull request #7700: URL: https://github.com/apache/arrow/pull/7700#issuecomment-656476370 https://issues.apache.org/jira/browse/ARROW-9398 This is an automated message from the Apache Git Serv

[GitHub] [arrow] jianxind commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

jianxind commented on pull request #7700: URL: https://github.com/apache/arrow/pull/7700#issuecomment-656479567 Follow up https://github.com/apache/arrow/pull/7607, delegate the SIMD dispatch to kernel level inside the function instance. @wesm -

[GitHub] [arrow] jianxind commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

jianxind commented on pull request #7700: URL: https://github.com/apache/arrow/pull/7700#issuecomment-656480294 @ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark This is an automated message from the Apache

[GitHub] [arrow] ursabot commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

ursabot commented on pull request #7700: URL: https://github.com/apache/arrow/pull/7700#issuecomment-656481223 [AMD64 Ubuntu 18.04 C++ Benchmark (#118393)](https://ci.ursalabs.org/#builders/73/builds/94) builder failed. Revision: 7c449cee21e96ae22979c159c053b954cb482047 Archer

[GitHub] [arrow] mrkn commented on pull request #7477: ARROW-4221: [C++][Python] Add canonical flag in COO sparse index

mrkn commented on pull request #7477: URL: https://github.com/apache/arrow/pull/7477#issuecomment-656481697 @wesm I've finished rebase and adding tests for zero tensor cases. Please review this and then merge it if possible. ---

[GitHub] [arrow] kou commented on a change in pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library s

kou commented on a change in pull request #7696: URL: https://github.com/apache/arrow/pull/7696#discussion_r452624987 ## File path: cpp/examples/minimal_build/CMakeLists.txt ## @@ -19,10 +19,31 @@ cmake_minimum_required(VERSION 3.0) project(ArrowMinimalExample) +option(ARR

[GitHub] [arrow] kou commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stati

kou commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656486317 @github-actions crossbow submit -g linux This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] github-actions[bot] commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static libra

github-actions[bot] commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656486761 Revision: da68e097ad07c0b9036e8175349bad2ba30787be Submitted crossbow builds: [ursa-labs/crossbow @ actions-399](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] emkornfield commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

emkornfield commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-656491324 @tianchen92 rereading, after rereading all the comments. I think we should 1. Remove setReaderWriterIndeces in getFieldBuffers 2. Deprecate getBuffers 3. Introduc

[GitHub] [arrow] jorisvandenbossche commented on pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

jorisvandenbossche commented on pull request #7604: URL: https://github.com/apache/arrow/pull/7604#issuecomment-656499067 > Is there a way to skip specific tests, I thought all of the live in spark code? With pytest you can deselect a single test by name (that's also what we do with

[GitHub] [arrow] jorisvandenbossche edited a comment on pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

jorisvandenbossche edited a comment on pull request #7604: URL: https://github.com/apache/arrow/pull/7604#issuecomment-656499067 > Is there a way to skip specific tests, I thought all of the live in spark code? With pytest you can deselect a single test by name (that's also what we d

[GitHub] [arrow] dota17 commented on pull request #7630: ARROW-9317: [Java] add few testcases for arrow-memory

dota17 commented on pull request #7630: URL: https://github.com/apache/arrow/pull/7630#issuecomment-656514160 @wesm Hi Wes, it has been refactored and the has been rebased. This is an automated message from the Apache Git Ser

[GitHub] [arrow] dota17 edited a comment on pull request #7630: ARROW-9317: [Java] add few testcases for arrow-memory

dota17 edited a comment on pull request #7630: URL: https://github.com/apache/arrow/pull/7630#issuecomment-656514160 @wesm Hi Wes, it has been refactored and then has been rebased. This is an automated message from the Apache

<    1   2