kou closed pull request #7842:
URL: https://github.com/apache/arrow/pull/7842
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
emkornfield commented on a change in pull request #7815:
URL: https://github.com/apache/arrow/pull/7815#discussion_r466162890
##
File path:
java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java
##
@@ -277,6 +278,20 @@ public void doByteBufferTest() {
cli
arw2019 commented on pull request #7822:
URL: https://github.com/apache/arrow/pull/7822#issuecomment-669656466
thanks @wesm @emkornfield for reviewing!!
This is an automated message from the Apache Git Service.
To respond to
offthewall123 commented on pull request #7815:
URL: https://github.com/apache/arrow/pull/7815#issuecomment-669629818
> LGTM
Hi @rymurr ,will you merge this PR?
This is an automated message from the Apache Git Service.
trxcllnt commented on pull request #7909:
URL: https://github.com/apache/arrow/pull/7909#issuecomment-669551982
cc: @bkietz
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
github-actions[bot] commented on pull request #7909:
URL: https://github.com/apache/arrow/pull/7909#issuecomment-669549486
https://issues.apache.org/jira/browse/ARROW-9659
This is an automated message from the Apache Git Serv
trxcllnt opened a new pull request #7909:
URL: https://github.com/apache/arrow/pull/7909
Related JIRA: [ARROW-9659](https://issues.apache.org/jira/browse/ARROW-9659)
Prior to 1.0.0, the `RecordBatchStreamReader` was capable of reading source
CudaBuffers wrapped in a `CudaBufferReader
github-actions[bot] commented on pull request #7908:
URL: https://github.com/apache/arrow/pull/7908#issuecomment-669522949
https://issues.apache.org/jira/browse/ARROW-9358
This is an automated message from the Apache Git Serv
lidavidm opened a new pull request #7908:
URL: https://github.com/apache/arrow/pull/7908
This should speed up integration tests by moving the expensive large batch
test to the individual Flight implementations.
This is an au
github-actions[bot] commented on pull request #7907:
URL: https://github.com/apache/arrow/pull/7907#issuecomment-669516018
https://issues.apache.org/jira/browse/ARROW-9644
This is an automated message from the Apache Git Serv
bkietz opened a new pull request #7907:
URL: https://github.com/apache/arrow/pull/7907
I still apply ignore_prefixes to all segments of paths yielded by a selector
which lie *outside* an explicit partition base directory.
Th
bkietz closed pull request #7869:
URL: https://github.com/apache/arrow/pull/7869
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on pull request #7784:
URL: https://github.com/apache/arrow/pull/7784#issuecomment-669322336
Or perhaps @bkietz .
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pitrou commented on pull request #7784:
URL: https://github.com/apache/arrow/pull/7784#issuecomment-66933
Rebased. @wesm could you perhaps review this?
This is an automated message from the Apache Git Service.
To respond
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465839089
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_p
jhorstmann commented on a change in pull request #7876:
URL: https://github.com/apache/arrow/pull/7876#discussion_r465857294
##
File path: rust/arrow/src/compute/kernels/length.rs
##
@@ -0,0 +1,185 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
github-actions[bot] commented on pull request #7906:
URL: https://github.com/apache/arrow/pull/7906#issuecomment-669289126
https://issues.apache.org/jira/browse/ARROW-9652
This is an automated message from the Apache Git Serv
alamb commented on a change in pull request #7906:
URL: https://github.com/apache/arrow/pull/7906#discussion_r465840928
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -195,43 +169,6 @@ impl ExecutionContext {
&self.scalar_functions
}
-fn build_
alamb opened a new pull request #7906:
URL: https://github.com/apache/arrow/pull/7906
This PR builds on https://github.com/apache/arrow/pull/7905 to do two things:
1. Make better error messages for CREATE EXTERNAL TABLE commands that are
not semantically valid and prevents a subsequent p
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465839089
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_p
pitrou commented on a change in pull request #7868:
URL: https://github.com/apache/arrow/pull/7868#discussion_r465810996
##
File path: python/pyarrow/table.pxi
##
@@ -425,31 +438,35 @@ def chunked_array(arrays, type=None):
Array arr
vector[shared_ptr[CArray]]
pitrou commented on a change in pull request #7868:
URL: https://github.com/apache/arrow/pull/7868#discussion_r46580
##
File path: python/pyarrow/table.pxi
##
@@ -226,24 +226,34 @@ cdef class ChunkedArray(_PandasConvertible):
def _to_pandas(self, options, **kwargs):
pitrou commented on pull request #7868:
URL: https://github.com/apache/arrow/pull/7868#issuecomment-669257856
@kszucs Can you rebase this PR? Hopefully it will fix AppVeyor.
This is an automated message from the Apache Git Se
bkietz commented on a change in pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#discussion_r465751971
##
File path: cpp/src/arrow/util/formatting.cc
##
@@ -36,38 +31,29 @@ const char digit_pairs[] =
"6061626364656667686970717273747576777879"
"808182
github-actions[bot] commented on pull request #7905:
URL: https://github.com/apache/arrow/pull/7905#issuecomment-669247235
https://issues.apache.org/jira/browse/ARROW-9656
This is an automated message from the Apache Git Serv
bkietz commented on a change in pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#discussion_r465750819
##
File path: cpp/src/arrow/util/formatting.cc
##
@@ -36,38 +31,29 @@ const char digit_pairs[] =
"6061626364656667686970717273747576777879"
"808182
bkietz commented on a change in pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#discussion_r465748964
##
File path: cpp/src/arrow/util/formatting.h
##
@@ -40,12 +40,51 @@ namespace arrow {
namespace internal {
/// \brief The entry point for conversion to
pitrou commented on a change in pull request #7866:
URL: https://github.com/apache/arrow/pull/7866#discussion_r465747920
##
File path: python/pyarrow/tests/test_convert_builtin.py
##
@@ -182,6 +182,19 @@ def test_sequence_numpy_boolean(seq):
assert arr.to_pylist() == expec
pitrou commented on a change in pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#discussion_r465746913
##
File path: ci/docker/conda-python-kartothek.dockerfile
##
@@ -32,7 +32,14 @@ RUN conda install -c conda-forge -q \
storefact \
toolz \
pitrou commented on a change in pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#discussion_r465734624
##
File path: cpp/src/arrow/util/formatting.h
##
@@ -40,12 +40,51 @@ namespace arrow {
namespace internal {
/// \brief The entry point for conversion to
alamb opened a new pull request #7905:
URL: https://github.com/apache/arrow/pull/7905
Previously, the error message for an invalid CREATE EXTERNAL TABLE command
told the user there was a problem but not how to fix it. This PR improves the
error message and adds some parser tests.
Be
pitrou commented on a change in pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#discussion_r465781641
##
File path: python/pyarrow/_s3fs.pyx
##
@@ -81,9 +81,9 @@ cdef class S3FileSystem(FileSystem):
cdef:
CS3FileSystem* s3fs
-def __init__(
pitrou commented on a change in pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#discussion_r465782709
##
File path: python/pyarrow/_s3fs.pyx
##
@@ -105,9 +105,14 @@ cdef class S3FileSystem(FileSystem):
raise ValueError(
'
pitrou commented on pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#issuecomment-669219582
It seems that micro-benchmark performance is regressing with this PR, at
least here (clang 9.0, AMD Ryzen):
* before:
```
IntegerParsing2396 ns
pitrou commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r465764598
##
File path: cpp/src/arrow/util/compression_lz4.cc
##
@@ -349,6 +351,96 @@ class Lz4Codec : public Codec {
const char* name() const override { return "lz
andygrove commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-669233005
@vertexclique I pulled your branch and was able to reproduce the issue by
trying to run the datafusion example. The issue is that you changed the
datafusion crate to use parquet
pitrou commented on a change in pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#discussion_r465753604
##
File path: cpp/src/arrow/util/formatting.h
##
@@ -40,12 +40,51 @@ namespace arrow {
namespace internal {
/// \brief The entry point for conversion to
github-actions[bot] commented on pull request #7904:
URL: https://github.com/apache/arrow/pull/7904#issuecomment-669188509
https://issues.apache.org/jira/browse/ARROW-9577
This is an automated message from the Apache Git Serv
pitrou opened a new pull request #7904:
URL: https://github.com/apache/arrow/pull/7904
posix_madvise() gives its error status as return value, not as errno, so the
error message would look like "[errno 0] Success".
This doesn't fix the issue reported in ARROW-9577, but should at leas
romainfrancois removed a comment on pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#issuecomment-668608898
I somehow lost the ability to lint locally:
```
r % CLANG_FORMAT=$(which clang-format) ./lint.sh
Traceback (most recent call last):
File
"/Users/r
liyafan82 commented on pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#issuecomment-669150653
@rymurr Thanks a lot for your feedback.
We have added support for LargeList. Do you have any more comments?
vertexclique commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-669145958
I don't see these errors when I ran all these tests locally. I am unsure why
this is happening. @andygrove
```
error[E0432]: unresolved import `parquet::arrow`
-->
nevi-me commented on pull request #7319:
URL: https://github.com/apache/arrow/pull/7319#issuecomment-669128126
@maxburke there's been some interest from other people on this PR. I haven't
been able to continue working on it because where I have a bit of free time
I've been looking at the I
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465621351
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java
##
@@ -403,16 +421,29 @@ public static ArrowRecordBatc
liyafan82 commented on pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#issuecomment-669111978
> At the very least I think this needs more comments as to why it appears
that manual serializion of flatbuffer data is being used.
>
> It would also be nice to avoid intr
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465622563
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowBodyCompression.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465622358
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowBodyCompression.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465621861
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java
##
@@ -353,6 +361,23 @@ private InputStream asInputStream(B
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465621532
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Soft
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465621351
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java
##
@@ -403,16 +421,29 @@ public static ArrowRecordBatc
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465619410
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java
##
@@ -266,8 +266,15 @@ public static ArrowBlock seria
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465619212
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java
##
@@ -266,8 +266,15 @@ public static ArrowBlock seria
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465618946
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.java
##
@@ -232,6 +252,12 @@ public long computeBodyLength()
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465613604
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Soft
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r465613822
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionUtility.java
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache So
jianxind commented on a change in pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#discussion_r465600581
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -396,11 +397,16 @@ void RegisterScalarAggregateBasic(FunctionRegistry*
registry) {
cyb70289 commented on a change in pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#discussion_r465597132
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -396,11 +397,16 @@ void RegisterScalarAggregateBasic(FunctionRegistry*
registry) {
cyb70289 commented on pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#issuecomment-669078062
Validated okay on Haswell
This is an automated message from the Apache Git Service.
To respond to the message, pl
jianxind commented on pull request #7871:
URL: https://github.com/apache/arrow/pull/7871#issuecomment-669047527
Need a rebase after https://github.com/apache/arrow/pull/7903
This is an automated message from the Apache Git Se
github-actions[bot] commented on pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#issuecomment-669047146
https://issues.apache.org/jira/browse/ARROW-9643
This is an automated message from the Apache Git Serv
jianxind commented on pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#issuecomment-669045010
cc @cyb70289 @wesm
This is an automated message from the Apache Git Service.
To respond to the message, please l
jianxind opened a new pull request #7903:
URL: https://github.com/apache/arrow/pull/7903
Compiler may use advanced instruction just for a register routine.
Signed-off-by: Frank Du
This is an automated message from the
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r465505197
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset(
const flatbuf::RecordBatch* metadata, const std::shared_p
63 matches
Mail list logo
