[GitHub] [arrow] emkornfield commented on pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

emkornfield commented on pull request #8219: URL: https://github.com/apache/arrow/pull/8219#issuecomment-696503073 @xhochy did you want to review? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] emkornfield commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

emkornfield commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492465434 ## File path: cpp/src/parquet/arrow/path_internal.cc ## @@ -871,6 +877,8 @@ class MultipathLevelBuilderImpl : public MultipathLevelBuilder {

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

jorgecarleitao commented on a change in pull request #8222: URL: https://github.com/apache/arrow/pull/8222#discussion_r491530453 ## File path: rust/datafusion/src/physical_plan/distinct_expressions.rs ## @@ -0,0 +1,303 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] lidavidm commented on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

lidavidm commented on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-696458726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] andygrove closed pull request #8102: ARROW-9902: [Rust] [DataFusion] Add array() built-in function

andygrove closed pull request #8102: URL: https://github.com/apache/arrow/pull/8102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] xhochy commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

xhochy commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695829727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] trxcllnt commented on a change in pull request #8216: ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+

trxcllnt commented on a change in pull request #8216: URL: https://github.com/apache/arrow/pull/8216#discussion_r492260498 ## File path: .env ## @@ -30,7 +30,7 @@ LLVM=10 CLANG_TOOLS=8 RUST=nightly-2020-04-22 GO=1.12 -NODE=11 +NODE=14 Review comment: No we still

[GitHub] [arrow] github-actions[bot] commented on pull request #8226: ARROW-10048: [Rust] Fixed error in computing min/max with null entries.

github-actions[bot] commented on pull request #8226: URL: https://github.com/apache/arrow/pull/8226#issuecomment-695813753 https://issues.apache.org/jira/browse/ARROW-10048 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou commented on pull request #8205: URL: https://github.com/apache/arrow/pull/8205#issuecomment-696085494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] kszucs commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries

kszucs commented on pull request #8218: URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098116 Seems so, but that's a different issue. This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491890396 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,348 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] pitrou closed pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries

pitrou closed pull request #8218: URL: https://github.com/apache/arrow/pull/8218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] jacques-n edited a comment on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

jacques-n edited a comment on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-696459730 > I think there are two opportunities here - simply optimizing setSafe, which can be done by either specializing for the power-of-two size where possible, or by caching

[GitHub] [arrow] kou commented on a change in pull request #8234: ARROW-10035: [C++] Update vendored libraries

kou commented on a change in pull request #8234: URL: https://github.com/apache/arrow/pull/8234#discussion_r492378032 ## File path: LICENSE.txt ## @@ -849,9 +849,9 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

[GitHub] [arrow] vertexclique edited a comment on pull request #8233: ARROW-10055: [Rust] DoubleEndedIterator implementation for NullableIter

vertexclique edited a comment on pull request #8233: URL: https://github.com/apache/arrow/pull/8233#issuecomment-696146358 Hi! Would be nice if I can merge this into upstream, there is a dependent implementation I am currently working on. Is it possible to review it? @paddyhoran

[GitHub] [arrow] github-actions[bot] commented on pull request #8227: ARROW-9946: [R] Check `sink` argument class in `ParquetFileWriter`

github-actions[bot] commented on pull request #8227: URL: https://github.com/apache/arrow/pull/8227#issuecomment-695821544 https://issues.apache.org/jira/browse/ARROW-9946 This is an automated message from the Apache Git

[GitHub] [arrow] emkornfield commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write

emkornfield commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492259759 ## File path: cpp/src/parquet/arrow/path_internal.cc ## @@ -838,10 +841,13 @@ class PathBuilder { #undef NOT_IMPLEMENTED_VISIT std::vector& paths()

[GitHub] [arrow] emkornfield commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet

emkornfield commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-696146448 Thank you for the PR this will likely need a great deal of review from both code and design perspective. Before it is reviewed it should have thorough unit tests. And since

[GitHub] [arrow] winningsix commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet

winningsix commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-696193668 @pitrou @emkornfield FYI. This is Java side PR. https://github.com/apache/parquet-mr/pull/803/files This

[GitHub] [arrow] andygrove commented on pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

andygrove commented on pull request #8222: URL: https://github.com/apache/arrow/pull/8222#issuecomment-695804292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] liyafan82 closed pull request #8194: ARROW-10017: [Java] Fix LargeMemoryUtil long conversion

liyafan82 closed pull request #8194: URL: https://github.com/apache/arrow/pull/8194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nealrichardson commented on a change in pull request #8227: ARROW-9946: [R] Check `sink` argument class in `ParquetFileWriter`

nealrichardson commented on a change in pull request #8227: URL: https://github.com/apache/arrow/pull/8227#discussion_r492109660 ## File path: r/R/parquet.R ## @@ -373,6 +380,9 @@ ParquetFileWriter$create <- function(schema, sink,

[GitHub] [arrow] andygrove closed pull request #8233: ARROW-10055: [Rust] DoubleEndedIterator implementation for NullableIter

andygrove closed pull request #8233: URL: https://github.com/apache/arrow/pull/8233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] emkornfield commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

emkornfield commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492461706 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) { 3);

[GitHub] [arrow] pitrou edited a comment on pull request #8052: ARROW-9761: [C/C++] Add experimental C stream inferface

pitrou edited a comment on pull request #8052: URL: https://github.com/apache/arrow/pull/8052#issuecomment-696276591 Would `rewind` go back to the start of stream always? This is an automated message from the Apache Git

[GitHub] [arrow] andygrove closed pull request #8221: ARROW-9338: [Rust] Add clippy instructions

andygrove closed pull request #8221: URL: https://github.com/apache/arrow/pull/8221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] t829702 commented on pull request #2035: ARROW-2116: [JS] implement IPC writers

t829702 commented on pull request #2035: URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501 > Providing a separate utility in Arrow to parse dates I didn't mean to duplicate JS parsing code, but a way to provide a special parser function to the constructor,

[GitHub] [arrow] andygrove closed pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

andygrove closed pull request #8172: URL: https://github.com/apache/arrow/pull/8172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] emkornfield commented on a change in pull request #8177: ARROW-8494: [C++][Parquet] Full support for reading mixed list and structs

emkornfield commented on a change in pull request #8177: URL: https://github.com/apache/arrow/pull/8177#discussion_r492160325 ## File path: cpp/src/parquet/CMakeLists.txt ## @@ -202,6 +203,19 @@ set(PARQUET_SRCS stream_writer.cc types.cc) +if(CXX_SUPPORTS_AVX2) +

[GitHub] [arrow] pitrou commented on a change in pull request #8177: ARROW-8494: [C++][Parquet] Full support for reading mixed list and structs

pitrou commented on a change in pull request #8177: URL: https://github.com/apache/arrow/pull/8177#discussion_r492084011 ## File path: cpp/src/parquet/CMakeLists.txt ## @@ -202,6 +203,19 @@ set(PARQUET_SRCS stream_writer.cc types.cc) +if(CXX_SUPPORTS_AVX2) + #

[GitHub] [arrow] wesm commented on pull request #8219: ARROW-9603: [C++] Fix parquet write

wesm commented on pull request #8219: URL: https://github.com/apache/arrow/pull/8219#issuecomment-696248994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] andygrove commented on a change in pull request #8224: ARROW-10044: [Rust] Improved Arrow's README.

andygrove commented on a change in pull request #8224: URL: https://github.com/apache/arrow/pull/8224#discussion_r492069938 ## File path: rust/arrow/README.md ## @@ -21,10 +21,62 @@ [![Coverage

[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695803865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] pitrou commented on a change in pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou commented on a change in pull request #8205: URL: https://github.com/apache/arrow/pull/8205#discussion_r492005479 ## File path: cpp/src/arrow/util/atomic_shared_ptr.h ## @@ -89,5 +89,25 @@ inline void atomic_store( *p = r; } +template +inline bool

[GitHub] [arrow] github-actions[bot] commented on pull request #8234: ARROW-10035: [C++] Update vendored libraries

github-actions[bot] commented on pull request #8234: URL: https://github.com/apache/arrow/pull/8234#issuecomment-696300434 https://issues.apache.org/jira/browse/ARROW-10035 This is an automated message from the Apache Git

[GitHub] [arrow] cyb70289 commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable

cyb70289 commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-695913785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] xhochy removed a comment on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

xhochy removed a comment on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695904892 @github-actions crossbow submit conda-linux-gcc-py36-cpu -- This is an automated

[GitHub] [arrow] hannesmuehleisen commented on pull request #8052: ARROW-9761: [C/C++] Add experimental C stream inferface

hannesmuehleisen commented on pull request #8052: URL: https://github.com/apache/arrow/pull/8052#issuecomment-696276127 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] kszucs commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries

kszucs commented on a change in pull request #8218: URL: https://github.com/apache/arrow/pull/8218#discussion_r491975704 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -2697,6 +2703,10 @@ if(ARROW_S3) sts) endif() +

[GitHub] [arrow] pitrou commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet

pitrou commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-696176912 Hmm, reading the mailing-list discussion again, I don't think we had agreed on a design. The first question for me is what the end-user API should be. * should the user calling

[GitHub] [arrow] pitrou closed pull request #8178: ARROW-9969: [C++] Fix RecordBatchBuilder with dictionary types

pitrou closed pull request #8178: URL: https://github.com/apache/arrow/pull/8178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] wesm commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write

wesm commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492407465 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) { 3); }

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

jorisvandenbossche commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r488714572 ## File path: python/pyarrow/tests/test_types.py ## @@ -280,6 +284,13 @@ def test_tzinfo_to_string_errors():

[GitHub] [arrow] vertexclique commented on pull request #8233: ARROW-10055: [Rust] DoubleEndedIterator implementation for NullableIter

vertexclique commented on pull request #8233: URL: https://github.com/apache/arrow/pull/8233#issuecomment-696146358 Hi! Would be nice if I can put this into upstream, there is a dependent implementation I am currently working on. Is it possible to review? @paddyhoran @andygrove

[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

zeroshade commented on pull request #8175: URL: https://github.com/apache/arrow/pull/8175#issuecomment-695894267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] wesm commented on pull request #8052: ARROW-9761: [C/C++] Add experimental C stream inferface

wesm commented on pull request #8052: URL: https://github.com/apache/arrow/pull/8052#issuecomment-696357318 Another thing that occurred to me is whether we want to enable batch-level metadata (which would be implementation-defined). This is supported in Flight for example

[GitHub] [arrow] lidavidm commented on pull request #8196: ARROW-10013: [FlightRPC][C++] fix setting generic client options

lidavidm commented on pull request #8196: URL: https://github.com/apache/arrow/pull/8196#issuecomment-696331234 CC @pitrou, this will finally let AppVeyor pass again :) This is an automated message from the Apache Git

[GitHub] [arrow] andygrove closed pull request #8118: ARROW-9922: [Rust] Add StructArray::TryFrom (+40%)

andygrove closed pull request #8118: URL: https://github.com/apache/arrow/pull/8118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] jorgecarleitao closed pull request #8215: ARROW-9977: [Rust] Added min/max of [Large]StringArray

jorgecarleitao closed pull request #8215: URL: https://github.com/apache/arrow/pull/8215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #8236: ARROW-10060: [Rust] [DataFusion] Fixed error on which Err were discarded in MergeExec.

github-actions[bot] commented on pull request #8236: URL: https://github.com/apache/arrow/pull/8236#issuecomment-696484939 https://issues.apache.org/jira/browse/ARROW-10060 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries

pitrou commented on pull request #8218: URL: https://github.com/apache/arrow/pull/8218#issuecomment-696096983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable

github-actions[bot] commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-695918114 https://issues.apache.org/jira/browse/ARROW-10051 This is an automated message from the Apache Git

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8188: ARROW-9924: [C++][Dataset] Enable per-column parallelism for single ParquetFileFragment scans

jorisvandenbossche commented on a change in pull request #8188: URL: https://github.com/apache/arrow/pull/8188#discussion_r492271433 ## File path: python/pyarrow/_dataset.pyx ## @@ -1013,27 +1013,38 @@ cdef class ParquetReadOptions(_Weakrefable): dictionary_columns : list

[GitHub] [arrow] pitrou commented on pull request #8052: ARROW-9761: [C/C++] Add experimental C stream inferface

pitrou commented on pull request #8052: URL: https://github.com/apache/arrow/pull/8052#issuecomment-696183147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] jorgecarleitao commented on pull request #8226: ARROW-10048: [Rust] Fixed error in computing min/max with null entries.

jorgecarleitao commented on pull request #8226: URL: https://github.com/apache/arrow/pull/8226#issuecomment-695813581 fyi @andygrove : I pushed this to #8215, but I did not rebase #8172 against #8215, and thus the error remained. I found this as I was rebasing PRs against master.

[GitHub] [arrow] pitrou commented on pull request #8177: ARROW-8494: [C++][Parquet] Full support for reading mixed list and structs

pitrou commented on pull request #8177: URL: https://github.com/apache/arrow/pull/8177#issuecomment-696148961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #8230: ARROW-10050: [C++][Gandiva] Implement concat() in Gandiva for up to 10 arguments

github-actions[bot] commented on pull request #8230: URL: https://github.com/apache/arrow/pull/8230#issuecomment-695901406 https://issues.apache.org/jira/browse/ARROW-10050 This is an automated message from the Apache Git

[GitHub] [arrow] t829702 edited a comment on pull request #2035: ARROW-2116: [JS] implement IPC writers

t829702 edited a comment on pull request #2035: URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] pitrou commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries

pitrou commented on a change in pull request #8218: URL: https://github.com/apache/arrow/pull/8218#discussion_r491975226 ## File path: cpp/cmake_modules/ThirdpartyToolchain.cmake ## @@ -2697,6 +2703,10 @@ if(ARROW_S3) sts) endif() +

[GitHub] [arrow] pitrou commented on pull request #8145: ARROW-9967: [Python] Add compute module documentation

pitrou commented on pull request #8145: URL: https://github.com/apache/arrow/pull/8145#issuecomment-696105647 Cython generally doesn't convert implicitly between arbitrary Python objects and C/C++ types, you have to type your code explicitly. Also, it is

[GitHub] [arrow] TheNeuralBit commented on a change in pull request #8216: ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+

TheNeuralBit commented on a change in pull request #8216: URL: https://github.com/apache/arrow/pull/8216#discussion_r492096757 ## File path: js/src/interfaces.ts ## @@ -356,48 +356,48 @@ type TypeToBuilder = { /** @ignore */ type DataTypeToBuilder = { -[key: number

[GitHub] [arrow] wesm commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

wesm commented on pull request #8175: URL: https://github.com/apache/arrow/pull/8175#issuecomment-696254425 Agree it would be good for this to be reviewed / merged. Can you rebase and get a more complete CI build? This is

[GitHub] [arrow] arw2019 commented on pull request #8145: ARROW-9967: [Python] Add compute module documentation

arw2019 commented on pull request #8145: URL: https://github.com/apache/arrow/pull/8145#issuecomment-696328909 > Cython generally doesn't convert implicitly between arbitrary Python objects and C/C++ types, you have to type your code explicitly. Thanks @pitrou! That was the problem

[GitHub] [arrow] github-actions[bot] commented on pull request #8235: ARROW-10059: [R][Doc] Give more advice on how to set up C++ build

github-actions[bot] commented on pull request #8235: URL: https://github.com/apache/arrow/pull/8235#issuecomment-696431010 https://issues.apache.org/jira/browse/ARROW-10059 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou closed pull request #8177: ARROW-8494: [C++][Parquet] Full support for reading mixed list and structs

pitrou closed pull request #8177: URL: https://github.com/apache/arrow/pull/8177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] wesm commented on issue #8217: How to transform the Arrow data column to array of array efficiently?

wesm commented on issue #8217: URL: https://github.com/apache/arrow/issues/8217#issuecomment-696156173 This would be best discussed further on u...@arrow.apache.org This is an automated message from the Apache Git Service.

[GitHub] [arrow] emkornfield commented on pull request #8219: ARROW-9603: [C++] Fix parquet write

emkornfield commented on pull request #8219: URL: https://github.com/apache/arrow/pull/8219#issuecomment-696287071 @wesm hmm, I think you might be the only once familiar with the write path. But maybe @pitrou could give a more general review? Anyone else you would suggest?

[GitHub] [arrow] nevi-me commented on a change in pull request #8199: ARROW-10019: [Rust] Add substring kernel

nevi-me commented on a change in pull request #8199: URL: https://github.com/apache/arrow/pull/8199#discussion_r491702713 ## File path: rust/arrow/src/compute/kernels/substring.rs ## @@ -0,0 +1,226 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] andygrove commented on a change in pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

andygrove commented on a change in pull request #8222: URL: https://github.com/apache/arrow/pull/8222#discussion_r492074780 ## File path: rust/datafusion/src/physical_plan/hash_aggregate.rs ## @@ -48,9 +48,12 @@ use fnv::FnvHashMap; /// Hash aggregate modes #[derive(Debug,

[GitHub] [arrow] bkietz commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

bkietz commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r492217469 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,296 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8236: ARROW-10060: [Rust] [DataFusion] Fixed error on which Err were discarded in MergeExec.

jorgecarleitao commented on a change in pull request #8236: URL: https://github.com/apache/arrow/pull/8236#discussion_r492447876 ## File path: rust/datafusion/src/physical_plan/merge.rs ## @@ -111,9 +111,9 @@ impl ExecutionPlan for MergeExec { let

[GitHub] [arrow] jacques-n commented on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

jacques-n commented on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-696361215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] emkornfield commented on pull request #8177: ARROW-8494: [C++][Parquet] Full support for reading mixed list and structs

emkornfield commented on pull request #8177: URL: https://github.com/apache/arrow/pull/8177#issuecomment-696200184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] liyafan82 commented on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

liyafan82 commented on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-695873809 @josiahyan Thank you for the additional details. I think one of your concern is that, the underlying buffers can be changed unintentionally, which lefts the vector in an

[GitHub] [arrow] bkietz commented on pull request #8052: ARROW-9761: [C/C++] Add experimental C stream inferface

bkietz commented on pull request #8052: URL: https://github.com/apache/arrow/pull/8052#issuecomment-696303007 Rewinding doesn't strike me as something which needs to be part of the C stream protocol. APIs can still provide rewind and other semantics while using a simple-as-possible stream

[GitHub] [arrow] github-actions[bot] commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

github-actions[bot] commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695829873 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] pitrou closed pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou closed pull request #8205: URL: https://github.com/apache/arrow/pull/8205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] jhorstmann commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

jhorstmann commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-695831200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] wesm closed issue #8217: How to transform the Arrow data column to array of array efficiently?

wesm closed issue #8217: URL: https://github.com/apache/arrow/issues/8217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] emkornfield commented on pull request #8052: ARROW-9761: [C/C++] Add experimental C stream inferface

emkornfield commented on pull request #8052: URL: https://github.com/apache/arrow/pull/8052#issuecomment-696286568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] jorgecarleitao commented on issue #8217: How to transform the Arrow data column to array of array efficiently?

jorgecarleitao commented on issue #8217: URL: https://github.com/apache/arrow/issues/8217#issuecomment-695783084 Hi @Zarca, 1. In any particular language? 2. Arrow is a columnar format. Thus, it is already formatted like you wrote. If you mean is the transpose (i.e. `array[i]`

[GitHub] [arrow] xhochy commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries

xhochy commented on a change in pull request #8218: URL: https://github.com/apache/arrow/pull/8218#discussion_r492031242 ## File path: ci/conda_env_cpp.yml ## @@ -17,7 +17,7 @@ aws-sdk-cpp benchmark=1.4.1 -boost-cpp>=1.68.0 Review comment: The lower-limit is no

[GitHub] [arrow] github-actions[bot] commented on pull request #8225: ARROW-10046: [Rust] [DataFusion] Made `*Iterator` implement Iterator

github-actions[bot] commented on pull request #8225: URL: https://github.com/apache/arrow/pull/8225#issuecomment-695772272 https://issues.apache.org/jira/browse/ARROW-10046 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet

github-actions[bot] commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-695862390 https://issues.apache.org/jira/browse/ARROW-9579 This is an automated message from the Apache Git

[GitHub] [arrow] andygrove commented on a change in pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

andygrove commented on a change in pull request #8172: URL: https://github.com/apache/arrow/pull/8172#discussion_r491702697 ## File path: rust/datafusion/src/sql/planner.rs ## @@ -343,7 +343,7 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> { match *limit {

[GitHub] [arrow] liyafan82 commented on pull request #8194: ARROW-10017: [Java] Fix LargeMemoryUtil long conversion

liyafan82 commented on pull request #8194: URL: https://github.com/apache/arrow/pull/8194#issuecomment-695884515 Merging. Thanks for the PR @pwoody This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] nealrichardson closed pull request #8227: ARROW-9946: [R] Check `sink` argument class in `ParquetFileWriter`

nealrichardson closed pull request #8227: URL: https://github.com/apache/arrow/pull/8227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] josiahyan commented on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-696065926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] xhochy commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries

xhochy commented on pull request #8218: URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098976 > Uh... was Boost upgraded in the meantime? There are compile errors on AppVeyor: >

[GitHub] [arrow] jorgecarleitao commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

jorgecarleitao commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695805702 @andygrove , that is great news! Really good to know that this stands a stronger benchmark. Thanks a lot for taking the time to run it. I rebased against master and

[GitHub] [arrow] andygrove closed pull request #8226: ARROW-10048: [Rust] Fixed error in computing min/max with null entries.

andygrove closed pull request #8226: URL: https://github.com/apache/arrow/pull/8226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove commented on a change in pull request #8118: ARROW-9922: [Rust] Add StructArray::TryFrom (+40%)

andygrove commented on a change in pull request #8118: URL: https://github.com/apache/arrow/pull/8118#discussion_r492065611 ## File path: rust/arrow/src/array/array.rs ## @@ -834,7 +840,7 @@ impl From>> for BooleanArray { fn from(data: Vec>) -> Self { let

[GitHub] [arrow] jhorstmann commented on a change in pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

jhorstmann commented on a change in pull request #8222: URL: https://github.com/apache/arrow/pull/8222#discussion_r491869035 ## File path: rust/datafusion/src/physical_plan/distinct_expressions.rs ## @@ -0,0 +1,303 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [arrow] github-actions[bot] commented on pull request #8233: ARROW-10055: [Rust] DoubleEndedIterator implementation for NullableIter

github-actions[bot] commented on pull request #8233: URL: https://github.com/apache/arrow/pull/8233#issuecomment-696149597 https://issues.apache.org/jira/browse/ARROW-10055 This is an automated message from the Apache Git

[GitHub] [arrow] josiahyan edited a comment on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan edited a comment on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-696381588 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] t829702 edited a comment on pull request #2035: ARROW-2116: [JS] implement IPC writers

t829702 edited a comment on pull request #2035: URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501 > Providing a separate utility in Arrow to parse dates I didn't mean to duplicate JS parsing code, but a way to provide a special parser function to the constructor,

[GitHub] [arrow] t829702 edited a comment on pull request #2035: ARROW-2116: [JS] implement IPC writers

t829702 edited a comment on pull request #2035: URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501 > Providing a separate utility in Arrow to parse dates I didn't mean to duplicate JS parsing code, but a way to provide a special parser function to the constructor,

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8236: ARROW-10060: [Rust] [DataFusion] Fixed error on which Err were discarded in MergeExec.

jorgecarleitao commented on a change in pull request #8236: URL: https://github.com/apache/arrow/pull/8236#discussion_r492447876 ## File path: rust/datafusion/src/physical_plan/merge.rs ## @@ -111,9 +111,9 @@ impl ExecutionPlan for MergeExec { let

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8236: ARROW-10060: [Rust] [DataFusion] Fixed error on which Err were discarded in MergeExec.

jorgecarleitao commented on a change in pull request #8236: URL: https://github.com/apache/arrow/pull/8236#discussion_r492447876 ## File path: rust/datafusion/src/physical_plan/merge.rs ## @@ -111,9 +111,9 @@ impl ExecutionPlan for MergeExec { let

[GitHub] [arrow] jorgecarleitao opened a new pull request #8236: ARROW-10060: [Rust] [DataFusion] Fixed error on which Err were discarded in MergeExec.

jorgecarleitao opened a new pull request #8236: URL: https://github.com/apache/arrow/pull/8236 Just found this sneaky error while working on UDAFs... This is an automated message from the Apache Git Service. To respond to

  1   2   3   >