[GitHub] [arrow] github-actions[bot] commented on pull request #8269: ARROW-10070: [C++][Compute] Implement stdev aggregate kernel

github-actions[bot] commented on pull request #8269: URL: https://github.com/apache/arrow/pull/8269#issuecomment-698714057 https://issues.apache.org/jira/browse/ARROW-10070 This is an automated message from the Apache Git

[GitHub] [arrow] liyafan82 commented on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

liyafan82 commented on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-698713708 @jacques-n Do you have any more comments? This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] cyb70289 opened a new pull request #8269: ARROW-10070: [C++][Compute] Implement stdev aggregate kernel

cyb70289 opened a new pull request #8269: URL: https://github.com/apache/arrow/pull/8269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #8268: Archery C++ round trip working. Java disabled. Fix c-bridge

github-actions[bot] commented on pull request #8268: URL: https://github.com/apache/arrow/pull/8268#issuecomment-698712466 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] emkornfield opened a new pull request #8268: Archery C++ round trip working. Java disabled. Fix c-bridge

emkornfield opened a new pull request #8268: URL: https://github.com/apache/arrow/pull/8268 For merging into DECIMAL256 branch only (NOT master) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] josiahyan commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494721759 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494721296 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] josiahyan commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494713588 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494713164 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494713260 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] josiahyan commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494710549 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] josiahyan commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494709994 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] josiahyan commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494709392 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494707070 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] josiahyan commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494705840 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494705115 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] wesm closed pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

wesm closed pull request #8175: URL: https://github.com/apache/arrow/pull/8175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] MingyuZhong commented on a change in pull request #8266: Refactor BasicDecimal128 Multiplication to use unsigned helper

MingyuZhong commented on a change in pull request #8266: URL: https://github.com/apache/arrow/pull/8266#discussion_r494673844 ## File path: cpp/src/arrow/util/basic_decimal.cc ## @@ -248,40 +247,50 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t bits) { return

[GitHub] [arrow] josiahyan commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

josiahyan commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494670200 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java ## @@ -48,7 +48,8 @@ implements FixedWidthVector,

[GitHub] [arrow] dhirschfeld commented on pull request #8255: ARROW-9518: [Python] Deprecate pyarrow serialization

dhirschfeld commented on pull request #8255: URL: https://github.com/apache/arrow/pull/8255#issuecomment-698636329 Thanks for the ping. I was using that functionality. So I'm interested to see how I can replace it. My goal is to pass objects (mapping of arrays, dataframes and

[GitHub] [arrow] github-actions[bot] commented on pull request #8267: ARROW-10087: [CI] Fix nightly docs job

github-actions[bot] commented on pull request #8267: URL: https://github.com/apache/arrow/pull/8267#issuecomment-698632532 Revision: b7b630f216df3cbf0618291f5906498a6eb6854c Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #8267: ARROW-10087: [CI] Fix nightly docs job

github-actions[bot] commented on pull request #8267: URL: https://github.com/apache/arrow/pull/8267#issuecomment-698632166 https://issues.apache.org/jira/browse/ARROW-10087 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #8267: ARROW-10087: [CI] Fix nightly docs job

nealrichardson commented on pull request #8267: URL: https://github.com/apache/arrow/pull/8267#issuecomment-698632120 @github-actions crossbow submit *docs This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] nealrichardson opened a new pull request #8267: ARROW-10087: [CI] Fix nightly docs job

nealrichardson opened a new pull request #8267: URL: https://github.com/apache/arrow/pull/8267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #8266: Refactor BasicDecimal128 Multiplication to use unsigned helper

github-actions[bot] commented on pull request #8266: URL: https://github.com/apache/arrow/pull/8266#issuecomment-698619108 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] nealrichardson closed pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

nealrichardson closed pull request #8187: URL: https://github.com/apache/arrow/pull/8187 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] Luminarys opened a new pull request #8266: Refactor BasicDecimal128 Multiplication to use unsigned helper

Luminarys opened a new pull request #8266: URL: https://github.com/apache/arrow/pull/8266 This should handle all no overflow behavior fine, but it's less clear to me what the appropriate behavior should be if overflow could occur. If we're assuming it can be UB then I believe this change

[GitHub] [arrow] bkietz commented on pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

bkietz commented on pull request #8187: URL: https://github.com/apache/arrow/pull/8187#issuecomment-698590587 Non-Apache Travis: https://travis-ci.org/github/bkietz/arrow/builds/730077798 This is an automated message from

[GitHub] [arrow] bkietz commented on pull request #8188: ARROW-9924: [C++][Dataset] Enable per-column parallelism for single ParquetFileFragment scans

bkietz commented on pull request #8188: URL: https://github.com/apache/arrow/pull/8188#issuecomment-698590377 Passing Travis: https://travis-ci.org/github/bkietz/arrow/builds/730077738 This is an automated message from the

[GitHub] [arrow] bkietz closed pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

bkietz closed pull request #8261: URL: https://github.com/apache/arrow/pull/8261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] bkietz commented on pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

bkietz commented on pull request #8261: URL: https://github.com/apache/arrow/pull/8261#issuecomment-698588161 Passing Travis: https://travis-ci.org/github/pitrou/arrow/builds/730048965 This is an automated message from the

[GitHub] [arrow] github-actions[bot] commented on pull request #8265: ARROW-9586: [FlightRPC][Java] implement per-call allocator

github-actions[bot] commented on pull request #8265: URL: https://github.com/apache/arrow/pull/8265#issuecomment-698569882 https://issues.apache.org/jira/browse/ARROW-9586 This is an automated message from the Apache Git

[GitHub] [arrow] lidavidm commented on pull request #8265: ARROW-9586: [FlightRPC][Java] implement per-call allocator

lidavidm commented on pull request #8265: URL: https://github.com/apache/arrow/pull/8265#issuecomment-698565344 CC @rymurr, this is the other half of the earlier PR. This is an automated message from the Apache Git Service.

[GitHub] [arrow] lidavidm opened a new pull request #8265: ARROW-9586: [FlightRPC][Java] implement per-call allocator

lidavidm opened a new pull request #8265: URL: https://github.com/apache/arrow/pull/8265 This allows gRPC servers to be configured such that every DoGet, DoPut, or DoExchange call gets its own child allocator that is closed when the RPC ends. This includes temporary allocations made by

[GitHub] [arrow] github-actions[bot] commented on pull request #8264: ARROW-8618: [C++] Clean up some redundant std::move()s

github-actions[bot] commented on pull request #8264: URL: https://github.com/apache/arrow/pull/8264#issuecomment-698561533 https://issues.apache.org/jira/browse/ARROW-8618 This is an automated message from the Apache Git

[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

zeroshade commented on pull request #8175: URL: https://github.com/apache/arrow/pull/8175#issuecomment-698560159 @wesm @sbinet @stuartcarnie @mindhash bump This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] bkietz opened a new pull request #8264: ARROW-8618: [C++] Clean up some redundant std::move()s

bkietz opened a new pull request #8264: URL: https://github.com/apache/arrow/pull/8264 ARROW_ASSIGN_OR_RAISE and friends move their RHS, so calling move on those is unnecessary. This is an automated message from the Apache

[GitHub] [arrow] jorgecarleitao opened a new pull request #8263: ARROW-10086: [Rust] Renamed min/max_large_string kernels

jorgecarleitao opened a new pull request #8263: URL: https://github.com/apache/arrow/pull/8263 With the new representation of string arrays as generics, we no longer need to give different names to kernels. This PR addresses this (and makes the implementation to be a generic instead of a

[GitHub] [arrow] github-actions[bot] commented on pull request #8263: ARROW-10086: [Rust] Renamed min/max_large_string kernels

github-actions[bot] commented on pull request #8263: URL: https://github.com/apache/arrow/pull/8263#issuecomment-698551795 https://issues.apache.org/jira/browse/ARROW-10086 This is an automated message from the Apache Git

[GitHub] [arrow] kiszk commented on pull request #8245: ARROW-10069: [Java] Support running Java benchmarks from command line

kiszk commented on pull request #8245: URL: https://github.com/apache/arrow/pull/8245#issuecomment-698541508 Looks good. In my environment, while `benchmark.forks` works, `benchmark.warmups` and `benchmark.runs` do not work. In other words, the following command executes the

[GitHub] [arrow] kiszk edited a comment on pull request #8245: ARROW-10069: [Java] Support running Java benchmarks from command line

kiszk edited a comment on pull request #8245: URL: https://github.com/apache/arrow/pull/8245#issuecomment-698541508 Thank you. Looks good. In my environment, while `benchmark.forks` works, `benchmark.warmups` and `benchmark.runs` do not work. In other words, the following command

[GitHub] [arrow] pitrou commented on a change in pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou commented on a change in pull request #8261: URL: https://github.com/apache/arrow/pull/8261#discussion_r494551627 ## File path: cpp/src/arrow/filesystem/s3fs.cc ## @@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client { } }; +// In AWS SDK < 1.8,

[GitHub] [arrow] bkietz commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

bkietz commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494537039 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] bkietz commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

bkietz commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494537039 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] bkietz commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

bkietz commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494537039 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] bkietz commented on a change in pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

bkietz commented on a change in pull request #8261: URL: https://github.com/apache/arrow/pull/8261#discussion_r494532469 ## File path: cpp/src/arrow/filesystem/s3fs.cc ## @@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client { } }; +// In AWS SDK < 1.8,

[GitHub] [arrow] github-actions[bot] commented on pull request #8262: ARROW-10040 Iterate over and combine boolean buffers with arbitrary offsets

github-actions[bot] commented on pull request #8262: URL: https://github.com/apache/arrow/pull/8262#issuecomment-698514562 https://issues.apache.org/jira/browse/ARROW-10040 This is an automated message from the Apache Git

[GitHub] [arrow] jhorstmann opened a new pull request #8262: ARROW-10040 Iterate over and combine boolean buffers with arbitrary offsets

jhorstmann opened a new pull request #8262: URL: https://github.com/apache/arrow/pull/8262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] github-actions[bot] commented on pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

github-actions[bot] commented on pull request #8261: URL: https://github.com/apache/arrow/pull/8261#issuecomment-698500867 Revision: e199de165efb6b388e422364718bd1342c4fd868 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

nealrichardson commented on pull request #8261: URL: https://github.com/apache/arrow/pull/8261#issuecomment-698499743 @github-actions crossbow submit homebrew-r-autobrew This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou commented on pull request #8261: URL: https://github.com/apache/arrow/pull/8261#issuecomment-698492518 cc @nealrichardson This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] pitrou commented on a change in pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou commented on a change in pull request #8261: URL: https://github.com/apache/arrow/pull/8261#discussion_r494496745 ## File path: cpp/src/arrow/filesystem/s3fs.cc ## @@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client { } }; +// In AWS SDK < 1.8,

[GitHub] [arrow] pitrou commented on a change in pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou commented on a change in pull request #8261: URL: https://github.com/apache/arrow/pull/8261#discussion_r494494733 ## File path: cpp/src/arrow/filesystem/s3fs.cc ## @@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client { } }; +// In AWS SDK < 1.8,

[GitHub] [arrow] pitrou commented on a change in pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou commented on a change in pull request #8261: URL: https://github.com/apache/arrow/pull/8261#discussion_r494492980 ## File path: cpp/src/arrow/filesystem/s3fs.cc ## @@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client { } }; +// In AWS SDK < 1.8,

[GitHub] [arrow] bkietz commented on a change in pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

bkietz commented on a change in pull request #8261: URL: https://github.com/apache/arrow/pull/8261#discussion_r494491830 ## File path: cpp/src/arrow/filesystem/s3fs.cc ## @@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client { } }; +// In AWS SDK < 1.8,

[GitHub] [arrow] pitrou commented on pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou commented on pull request #8261: URL: https://github.com/apache/arrow/pull/8261#issuecomment-698479206 CI failures are unrelated. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] bkietz commented on a change in pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

bkietz commented on a change in pull request #8256: URL: https://github.com/apache/arrow/pull/8256#discussion_r494467875 ## File path: r/src/compute.cpp ## @@ -123,19 +123,19 @@ arrow::Datum as_cpp(SEXP x) { SEXP from_datum(arrow::Datum datum) { Review comment:

[GitHub] [arrow] pitrou commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

pitrou commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494465714 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] pitrou commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

pitrou commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494464587 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] github-actions[bot] commented on pull request #8260: ARROW-10084: [Rust] [DataFusion] Added length of LargeStringArray and fixed undefined behavior.

github-actions[bot] commented on pull request #8260: URL: https://github.com/apache/arrow/pull/8260#issuecomment-698461216 https://issues.apache.org/jira/browse/ARROW-10084 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

github-actions[bot] commented on pull request #8261: URL: https://github.com/apache/arrow/pull/8261#issuecomment-698461217 https://issues.apache.org/jira/browse/ARROW-10085 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

pitrou commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494463542 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] pitrou commented on a change in pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou commented on a change in pull request #8261: URL: https://github.com/apache/arrow/pull/8261#discussion_r494460508 ## File path: cpp/src/arrow/filesystem/s3fs.cc ## @@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client { } }; +// In AWS SDK < 1.8,

[GitHub] [arrow] pitrou opened a new pull request #8261: ARROW-10085: [C++] Fix S3 region resolution on Windows

pitrou opened a new pull request #8261: URL: https://github.com/apache/arrow/pull/8261 Avoid trying to following redirects when resolving a region, as that can fail (at least on Windows with certain AWS SDK versions). Also skip a test that's failing because of a bug in the AWS SDK

[GitHub] [arrow] jorgecarleitao opened a new pull request #8260: ARROW-10084: [Rust] [DataFusion] Added length of LargeStringArray and fixed undefined behavior.

jorgecarleitao opened a new pull request #8260: URL: https://github.com/apache/arrow/pull/8260 This PR adds length to `LargeStringArray` and fixes undefined behavior. The undefined behavior was introduced in #7878. Specifically, we were (unsafely) interpreting a `i32` buffer as

[GitHub] [arrow] bkietz commented on a change in pull request #8246: ARROW-10071: [R] segfault with ArrowObject from previous session, or saved

bkietz commented on a change in pull request #8246: URL: https://github.com/apache/arrow/pull/8246#discussion_r494456605 ## File path: r/src/arrow_cpp11.h ## @@ -157,8 +157,15 @@ struct ns { template Pointer r6_to_pointer(SEXP self) { - return reinterpret_cast( -

[GitHub] [arrow] pitrou commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

pitrou commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494453811 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] bkietz commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

bkietz commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494451602 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] pitrou commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

pitrou commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494450952 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -487,15 +489,27 @@ Status CopyFiles(const std::shared_ptr& source_fs,

[GitHub] [arrow] nealrichardson commented on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

nealrichardson commented on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-698445894 > So in short we would create the R6 object in C++ and don't have to manipulate the external pointers in R ? Ideally, right? > We would retain the same

[GitHub] [arrow] romainfrancois commented on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

romainfrancois commented on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-698439528 > I love this and I want this everywhere :) I sort of assumed you would go there, as I was working on #8246 too. So in short we would create the R6 object in C++ and

[GitHub] [arrow] nealrichardson closed pull request #8259: ARROW-10083: [C++] Improve Parquet fuzz seed corpus

nealrichardson closed pull request #8259: URL: https://github.com/apache/arrow/pull/8259 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nealrichardson closed pull request #8122: ARROW-9557: [R] Iterating over parquet columns is slow in R

nealrichardson closed pull request #8122: URL: https://github.com/apache/arrow/pull/8122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] emkornfield commented on pull request #8259: ARROW-10083: [C++] Improve Parquet fuzz seed corpus

emkornfield commented on pull request #8259: URL: https://github.com/apache/arrow/pull/8259#issuecomment-698423036 +1. Not in front my personal computer but I can merge later if you don't get to it first. This is an

[GitHub] [arrow] pitrou commented on pull request #8257: ARROW-10081: [C++/Python] Fix bash syntax in drone.io conda builds

pitrou commented on pull request #8257: URL: https://github.com/apache/arrow/pull/8257#issuecomment-698422412 Feel free to merge when done @xhochy This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] nealrichardson commented on a change in pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

nealrichardson commented on a change in pull request #8256: URL: https://github.com/apache/arrow/pull/8256#discussion_r494402171 ## File path: r/R/compute.R ## @@ -127,15 +127,15 @@ match_arrow.Array <- function(x, table, ...) { if (!inherits(table, c("Array",

[GitHub] [arrow] nealrichardson commented on a change in pull request #8197: ARROW-9869: [R] Implement full S3FileSystem/S3Options constructor

nealrichardson commented on a change in pull request #8197: URL: https://github.com/apache/arrow/pull/8197#discussion_r494396737 ## File path: r/R/ipc_stream.R ## @@ -90,16 +90,18 @@ write_to_raw <- function(x, format = c("stream", "file")) { #' open. #' @param as_data_frame

[GitHub] [arrow] github-actions[bot] commented on pull request #8259: ARROW-10083: [C++] Improve Parquet fuzz seed corpus

github-actions[bot] commented on pull request #8259: URL: https://github.com/apache/arrow/pull/8259#issuecomment-698405495 https://issues.apache.org/jira/browse/ARROW-10083 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #8259: ARROW-10083: [C++] Improve Parquet fuzz seed corpus

pitrou commented on pull request #8259: URL: https://github.com/apache/arrow/pull/8259#issuecomment-698402396 Related PR to OSS-Fuzz: https://github.com/google/oss-fuzz/pull/4478 This is an automated message from the Apache

[GitHub] [arrow] nealrichardson commented on a change in pull request #8246: ARROW-10071: [R] segfault with ArrowObject from previous session, or saved

nealrichardson commented on a change in pull request #8246: URL: https://github.com/apache/arrow/pull/8246#discussion_r494391841 ## File path: r/src/arrow_cpp11.h ## @@ -157,8 +157,15 @@ struct ns { template Pointer r6_to_pointer(SEXP self) { - return reinterpret_cast( -

[GitHub] [arrow] pitrou commented on pull request #8259: ARROW-10083: [C++] Improve Parquet fuzz seed corpus

pitrou commented on pull request #8259: URL: https://github.com/apache/arrow/pull/8259#issuecomment-698400806 I chose to still use a single seed Parquet file. I'm not sure splitting those examples in several files would make a concrete difference.

[GitHub] [arrow] pitrou opened a new pull request #8259: ARROW-10083: [C++] Improve Parquet fuzz seed corpus

pitrou opened a new pull request #8259: URL: https://github.com/apache/arrow/pull/8259 Add nested columns, as well as a Brotli-compressed column. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] bkietz commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

bkietz commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494388617 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -457,18 +458,52 @@ Status CopyFiles(const std::vector& sources,

[GitHub] [arrow] nevi-me closed pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)

nevi-me closed pull request #8242: URL: https://github.com/apache/arrow/pull/8242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #8258: ARROW-9769: [Python] Un-skip tests with fsspec in-memory filesystems

github-actions[bot] commented on pull request #8258: URL: https://github.com/apache/arrow/pull/8258#issuecomment-698378613 https://issues.apache.org/jira/browse/ARROW-9769 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #8253: ARROW-10077: [C++] Fix possible integer multiplication overflow

pitrou commented on pull request #8253: URL: https://github.com/apache/arrow/pull/8253#issuecomment-698371744 Ah, thank you. Does it work differently from OSS-Fuzz, or use a different seed corpus? This is an automated

[GitHub] [arrow] pitrou opened a new pull request #8258: ARROW-9769: [Python] Un-skip tests with fsspec in-memory filesystems

pitrou opened a new pull request #8258: URL: https://github.com/apache/arrow/pull/8258 The issue which caused us to skip those tests was fixed somewhere between fsspec 0.8.0 and 0.8.2. This is an automated message from the

[GitHub] [arrow] emkornfield commented on pull request #8253: ARROW-10077: [C++] Fix possible integer multiplication overflow

emkornfield commented on pull request #8253: URL: https://github.com/apache/arrow/pull/8253#issuecomment-698371159 It was found with our internal fuzzer. Unfortunately do to how it works there are concerns over sharing the actual file.

[GitHub] [arrow] kiszk commented on pull request #8254: [CI][Python] Try Travis-CI fix for missing setuptools

kiszk commented on pull request #8254: URL: https://github.com/apache/arrow/pull/8254#issuecomment-698358583 Good point. you are right. When I visited travis-ci forum, I found the interesting

[GitHub] [arrow] romainfrancois commented on a change in pull request #8197: ARROW-9869: [R] Implement full S3FileSystem/S3Options constructor

romainfrancois commented on a change in pull request #8197: URL: https://github.com/apache/arrow/pull/8197#discussion_r494325934 ## File path: r/R/ipc_stream.R ## @@ -90,16 +90,18 @@ write_to_raw <- function(x, format = c("stream", "file")) { #' open. #' @param as_data_frame

[GitHub] [arrow] pitrou commented on a change in pull request #8187: ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles

pitrou commented on a change in pull request #8187: URL: https://github.com/apache/arrow/pull/8187#discussion_r494324838 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -457,18 +458,52 @@ Status CopyFiles(const std::vector& sources,

[GitHub] [arrow] github-actions[bot] commented on pull request #8257: ARROW-10081: [C++/Python] Fix bash syntax in drone.io conda builds

github-actions[bot] commented on pull request #8257: URL: https://github.com/apache/arrow/pull/8257#issuecomment-698321520 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] romainfrancois commented on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

romainfrancois commented on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-698321096 Turns out we just don't need to keep track of the result_type anymore I think. This is an automated

[GitHub] [arrow] xhochy commented on pull request #8257: ARROW-10081: [C++/Python] Fix bash syntax in drone.io conda builds

xhochy commented on pull request #8257: URL: https://github.com/apache/arrow/pull/8257#issuecomment-698320564 @github-actions crossbow submit conda-linux-*-aarch64 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] xhochy opened a new pull request #8257: ARROW-10081: [C++/Python] Fix bash syntax in drone.io conda builds

xhochy opened a new pull request #8257: URL: https://github.com/apache/arrow/pull/8257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] pitrou commented on pull request #8252: ARROW-10076: [C++] Use temporary directory facility in all unit tests

pitrou commented on pull request #8252: URL: https://github.com/apache/arrow/pull/8252#issuecomment-698310908 Thank you @emkornfield ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] pitrou closed pull request #8252: ARROW-10076: [C++] Use temporary directory facility in all unit tests

pitrou closed pull request #8252: URL: https://github.com/apache/arrow/pull/8252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] pitrou commented on pull request #8254: [CI][Python] Try Travis-CI fix for missing setuptools

pitrou commented on pull request #8254: URL: https://github.com/apache/arrow/pull/8254#issuecomment-698310336 Is this a new issue? It worked before. Also, in which file would the shebang be missing? This is an automated

[GitHub] [arrow] kiszk commented on pull request #8254: [CI][Python] Try Travis-CI fix for missing setuptools

kiszk commented on pull request #8254: URL: https://github.com/apache/arrow/pull/8254#issuecomment-698309732 According to [this](https://stackoverflow.com/questions/55786898/standard-init-linux-go190-exec-user-process-caused-exec-format-error-when-ru), shebang may be missing.

[GitHub] [arrow] github-actions[bot] commented on pull request #8255: ARROW-9518: [Python] Deprecate pyarrow serialization

github-actions[bot] commented on pull request #8255: URL: https://github.com/apache/arrow/pull/8255#issuecomment-698302399 https://issues.apache.org/jira/browse/ARROW-9518 This is an automated message from the Apache Git

  1   2   >