andygrove opened a new issue, #4985:
URL: https://github.com/apache/arrow-datafusion/issues/4985
**Describe the bug**
I could not get the changelog script to generate an accurate changelog for
the maint-16.x branch. It showed changes from the master branch that are not in
maint-16.x
AlenkaF commented on PR #33761:
URL: https://github.com/apache/arrow/pull/33761#issuecomment-1397108286
Great work so far @akshaysu12 !
Looking at the code from the binding for `CSVStreamingReader` and the work
done on the C++ side for the JSON stream reader I would say this PR is
alamb commented on PR #33716:
URL: https://github.com/apache/arrow/pull/33716#issuecomment-1397104567
> Ok. And those clients use the wire protocol directly(ish), so they can't
take advantage of the JDBC or ODBC Flight SQL drivers, presumably?
That is correct. In the ideal future
jdye64 opened a new issue, #140:
URL: https://github.com/apache/arrow-datafusion-python/issues/140
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
PyO3 recently had a release and there seems to be several features we could
andygrove commented on PR #4975:
URL:
https://github.com/apache/arrow-datafusion/pull/4975#issuecomment-1397101686
@jonmmease @alamb PTAL
I could not get the changelog script to generate an accurate changelog for
this patch release and do not have time to debug that right now.
--
alamb commented on code in PR #4972:
URL: https://github.com/apache/arrow-datafusion/pull/4972#discussion_r1081382689
##
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##
@@ -219,91 +221,76 @@ impl GroupedHashAggregateStream {
batch_size,
andygrove opened a new issue, #139:
URL: https://github.com/apache/arrow-datafusion-python/issues/139
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
DataFrame.collect returns a list of PyArrow record batches. Each batch can
be
ursabot commented on PR #4923:
URL:
https://github.com/apache/arrow-datafusion/pull/4923#issuecomment-1397098405
Benchmark runs are scheduled for baseline =
19f6f19c1d4783f9bcfde83744ee436f8e984154 and contender =
dde23efed94704044822bcefe49c0af7f9260088.
jorisvandenbossche commented on issue #33769:
URL: https://github.com/apache/arrow/issues/33769#issuecomment-1397094509
I think also for that reason (quantile by default always returns floats), we
might not want to add support for quantile to temporal types (not sure if we
actually ever
andygrove merged PR #137:
URL: https://github.com/apache/arrow-datafusion-python/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mbrobbel opened a new pull request, #33788:
URL: https://github.com/apache/arrow/pull/33788
### Rationale for this change
Linking directly to the IPC section makes it easier to find what people are
looking for.
### What changes are included in this PR?
Adds a link to
jdye64 commented on PR #137:
URL:
https://github.com/apache/arrow-datafusion-python/pull/137#issuecomment-1397088728
FYI - I'm working on adding support for compressed file reading and will
update the examples to show that as well once completed.
--
This is an automated message from the
thisisnic commented on code in PR #33748:
URL: https://github.com/apache/arrow/pull/33748#discussion_r1081369004
##
r/NEWS.md:
##
@@ -19,6 +19,92 @@
# arrow 10.0.1.9000
+## New features
+
+### Docs
+
+* A substantial reorganisation, rewrite of and addition to, many of the
thisisnic commented on code in PR #33748:
URL: https://github.com/apache/arrow/pull/33748#discussion_r1081366249
##
r/NEWS.md:
##
@@ -19,6 +19,92 @@
# arrow 10.0.1.9000
+## New features
+
+### Docs
+
+* A substantial reorganisation, rewrite of and addition to, many of the
alamb commented on code in PR #4923:
URL: https://github.com/apache/arrow-datafusion/pull/4923#discussion_r1081365754
##
datafusion/core/tests/sqllogictests/test_files/join.slt:
##
@@ -42,3 +42,42 @@ SELECT s.*, g.grade FROM students s join grades g on s.mark
between g.min and
thisisnic commented on code in PR #33748:
URL: https://github.com/apache/arrow/pull/33748#discussion_r1081366249
##
r/NEWS.md:
##
@@ -19,6 +19,92 @@
# arrow 10.0.1.9000
+## New features
+
+### Docs
+
+* A substantial reorganisation, rewrite of and addition to, many of the
alamb merged PR #4923:
URL: https://github.com/apache/arrow-datafusion/pull/4923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ursabot commented on PR #4969:
URL:
https://github.com/apache/arrow-datafusion/pull/4969#issuecomment-1397085822
Benchmark runs are scheduled for baseline =
96cf046be57bf09548d51f50d0bc964904bcec7d and contender =
19f6f19c1d4783f9bcfde83744ee436f8e984154.
alamb commented on PR #4908:
URL:
https://github.com/apache/arrow-datafusion/pull/4908#issuecomment-1397083616
> What do you think about having a single method which only takes a list of
paths? For a single path, the callee can create a slice/Vec. This would be a
lot simpler to do.
eitsupi commented on issue #18487:
URL: https://github.com/apache/arrow/issues/18487#issuecomment-1397083374
Note that this has not worked since `readr` 2.0.0.
``` r
readr::read_csv(c("a,b", "1,2", "3,4"))
#> Error: 'a,b' does not exist in current working directory
jorisvandenbossche merged PR #33764:
URL: https://github.com/apache/arrow/pull/33764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cyborne100 commented on issue #33758:
URL: https://github.com/apache/arrow/issues/33758#issuecomment-1397075519
Ahh, I understand now. Thanks for helping a NOOB. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb merged PR #4969:
URL: https://github.com/apache/arrow-datafusion/pull/4969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
alamb closed issue #4964: `RepartitionExec`: print number of input partitions
in text representation
URL: https://github.com/apache/arrow-datafusion/issues/4964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
eitsupi commented on code in PR #33748:
URL: https://github.com/apache/arrow/pull/33748#discussion_r1081343959
##
r/NEWS.md:
##
@@ -19,6 +19,92 @@
# arrow 10.0.1.9000
+## New features
+
+### Docs
+
+* A substantial reorganisation, rewrite of and addition to, many of the
+
alamb commented on code in PR #4903:
URL: https://github.com/apache/arrow-datafusion/pull/4903#discussion_r1081347231
##
README.md:
##
@@ -57,9 +75,31 @@ a foundation for building new systems. Here are some example
use cases:
- _Easy to Embed_: Allowing extension at almost
lidavidm commented on PR #33716:
URL: https://github.com/apache/arrow/pull/33716#issuecomment-1397066936
Ok. And those clients use the wire protocol directly(ish), so they can't
take advantage of the JDBC or ODBC Flight SQL drivers, presumably?
ADBC may not help there, unless they're
alamb commented on code in PR #4984:
URL: https://github.com/apache/arrow-datafusion/pull/4984#discussion_r1081344325
##
.github/workflows/dev.yml:
##
@@ -42,8 +42,7 @@ jobs:
node-version: "14"
- name: Prettier check
run: |
- # if you
alamb commented on code in PR #4984:
URL: https://github.com/apache/arrow-datafusion/pull/4984#discussion_r1081343683
##
docs/source/user-guide/sql/data_types.md:
##
@@ -25,13 +25,26 @@ execution. The SQL types from
are mapped to [Arrow data
thisisnic merged PR #33780:
URL: https://github.com/apache/arrow/pull/33780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
alamb commented on code in PR #4984:
URL: https://github.com/apache/arrow-datafusion/pull/4984#discussion_r1081343250
##
docs/source/user-guide/sql/data_types.md:
##
@@ -52,11 +65,12 @@ This mapping occurs when defining the schema in a `CREATE
EXTERNAL TABLE` comman
##
alamb opened a new pull request, #4984:
URL: https://github.com/apache/arrow-datafusion/pull/4984
# Which issue does this PR close?
N/A
# Rationale for this change
https://arrow.apache.org/datafusion/user-guide/sql/data_types.html is out of
date, as we discovered while
paleolimbot commented on code in PR #33748:
URL: https://github.com/apache/arrow/pull/33748#discussion_r1081335626
##
r/NEWS.md:
##
@@ -33,62 +33,57 @@
functionality, but allow for readr-style options to be supplied, making it
simpler to switch between individual
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1397052533
CRAN runs an LTO build as part of its check suite...if there are warnings
during the linking, we get an email saying that we need to fix them in two
weeks to "safely retain our
github-actions[bot] commented on PR #33778:
URL: https://github.com/apache/arrow/pull/33778#issuecomment-1397052029
Revision: de1d764d08c6d051e9577ac4144ac4476f79a88c
Submitted crossbow builds: [ursacomputing/crossbow @
paleolimbot commented on PR #33778:
URL: https://github.com/apache/arrow/pull/33778#issuecomment-1397048335
@github-actions crossbow submit test-r-offline-minimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb opened a new issue, #3565:
URL: https://github.com/apache/arrow-rs/issues/3565
**Which part is this question about**
We often write DataFusion
https://arrow.apache.org/blog/2023/01/19/datafusion-16.0.0/ updates as a way
to help grow the community and awareness about arrow.
alamb commented on issue #53:
URL: https://github.com/apache/arrow-rs/issues/53#issuecomment-1397036453
> Instead of creating multiple readers can it be done by single reader?
That is an interesting question @Sach1nAgarwal -- I think @tustvold has
some ideas on parallelized decode
alamb commented on PR #33716:
URL: https://github.com/apache/arrow/pull/33716#issuecomment-1397033386
> Yes, the ADBC driver wraps libpq and should let you work with other
databases that use the PostgreSQL wire protocol, with the caveat that it has to
convert the data (of course).
I
jorisvandenbossche commented on code in PR #33660:
URL: https://github.com/apache/arrow/pull/33660#discussion_r1081303563
##
docs/source/developers/reviewing.rst:
##
@@ -255,3 +255,43 @@ Social aspects
* Like any communication, code reviews are governed by the Apache
`Code
jorisvandenbossche commented on code in PR #33660:
URL: https://github.com/apache/arrow/pull/33660#discussion_r1081303563
##
docs/source/developers/reviewing.rst:
##
@@ -255,3 +255,43 @@ Social aspects
* Like any communication, code reviews are governed by the Apache
`Code
lidavidm merged PR #15223:
URL: https://github.com/apache/arrow/pull/15223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ursabot commented on PR #33614:
URL: https://github.com/apache/arrow/pull/33614#issuecomment-1396971858
Benchmark runs are scheduled for baseline =
04ffb1f740f1e868c08313fa9043070345d9b6f0 and contender =
444dcb6779755fc33f3f81d647c188cf31abd23c.
444dcb6779755fc33f3f81d647c188cf31abd23c
rok commented on issue #33782:
URL: https://github.com/apache/arrow/issues/33782#issuecomment-1396971891
GraphQL API is another option:
```
curl -H 'Content-Type: application/json' -H "Authorization: bearer
GITHUB_TOKEN" -X POST -d '{"query": "query {search(query: \"repo:apache/arrow
ursabot commented on PR #15213:
URL: https://github.com/apache/arrow/pull/15213#issuecomment-1396971385
Benchmark runs are scheduled for baseline =
2b50694c10e09e4a1343b62c6b5f44ad4403d0e1 and contender =
04ffb1f740f1e868c08313fa9043070345d9b6f0.
04ffb1f740f1e868c08313fa9043070345d9b6f0
ozankabak commented on code in PR #4972:
URL: https://github.com/apache/arrow-datafusion/pull/4972#discussion_r1081247158
##
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##
@@ -219,91 +221,76 @@ impl GroupedHashAggregateStream {
batch_size,
github-actions[bot] commented on PR #33781:
URL: https://github.com/apache/arrow/pull/33781#issuecomment-1396950828
* Closes: #33723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mustafasrepo closed pull request #4982: Use arrow concat_batches instead of
custom non-owning merge_batches
URL: https://github.com/apache/arrow-datafusion/pull/4982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lidavidm commented on code in PR #355:
URL: https://github.com/apache/arrow-adbc/pull/355#discussion_r1081224490
##
docs/source/driver/go/flight_sql.rst:
##
@@ -25,10 +25,19 @@ The Flight SQL Driver provides access to any database
implementing a
Installation
alamb commented on issue #4804:
URL:
https://github.com/apache/arrow-datafusion/issues/4804#issuecomment-1396922128
Rendered site: Rendered:
https://arrow.apache.org/blog/2023/01/19/datafusion-16.0.0/
--
This is an automated message from the Apache Git Service.
To respond to the
alamb closed issue #4804: Blog post about datafusion 16 release
URL: https://github.com/apache/arrow-datafusion/issues/4804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
DDtKey opened a new pull request, #4983:
URL: https://github.com/apache/arrow-datafusion/pull/4983
# Which issue does this PR close?
Closes #4981
# Rationale for this change
# What changes are included in this PR?
# Are these changes tested?
ygf11 commented on PR #4944:
URL:
https://github.com/apache/arrow-datafusion/pull/4944#issuecomment-1396904416
> Looks like the method's comment is out of date. Could you please also fix
them in this PR ?
Fixed.
--
This is an automated message from the Apache Git Service.
To
OfekShilon commented on issue #33784:
URL: https://github.com/apache/arrow/issues/33784#issuecomment-1396903597
A repro with no use of `tibble`:
```r
df <- data.frame(a=I(list(list(1), list(8
class(df$a[[1]])
# [1] "list"
tmpf <- tempfile()
arrow::write_feather(df,
github-actions[bot] commented on PR #33785:
URL: https://github.com/apache/arrow/pull/33785#issuecomment-1396903229
* Closes: #33741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
AlenkaF opened a new pull request, #33785:
URL: https://github.com/apache/arrow/pull/33785
### Rationale for this change
Ensure docstrings for [Data Types Factory
Functions](https://arrow.apache.org/docs/python/api/datatypes.html#factory-functions)
have an Examples section.
###
mustafasrepo opened a new pull request, #4982:
URL: https://github.com/apache/arrow-datafusion/pull/4982
# Which issue does this PR close?
Closes #.
# Rationale for this change
With recent change in arrow `concat_batches`, `merge_batches` and
ursabot commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1396885272
Benchmark runs are scheduled for baseline =
e6a050058bd704f73b38106b7abf21dc4539eebc and contender =
96cf046be57bf09548d51f50d0bc964904bcec7d.
alamb commented on code in PR #4972:
URL: https://github.com/apache/arrow-datafusion/pull/4972#discussion_r1081176906
##
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##
@@ -115,6 +106,14 @@ struct GroupedHashAggregateStreamInner {
indices: [Vec>; 2],
}
alamb commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1396866343
Thanks again -- this is going to be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb merged PR #4924:
URL: https://github.com/apache/arrow-datafusion/pull/4924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
alamb closed issue #2723: Consolidate GroupByHash implementations
`row_hash.rs` and `hash.rs` (remove duplication)
URL: https://github.com/apache/arrow-datafusion/issues/2723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tustvold commented on code in PR #3563:
URL: https://github.com/apache/arrow-rs/pull/3563#discussion_r1081165909
##
arrow-array/src/builder/generic_bytes_dictionary_builder.rs:
##
@@ -255,12 +255,34 @@ where
Ok(key)
}
+/// Infallibly append a value to this
alamb commented on code in PR #3514:
URL: https://github.com/apache/arrow-rs/pull/3514#discussion_r1081145188
##
arrow-cast/src/display.rs:
##
@@ -309,9 +379,10 @@ fn append_map_field_string(
///
/// Note this function is quite inefficient and is unlikely to be
/// suitable
alamb commented on code in PR #3514:
URL: https://github.com/apache/arrow-rs/pull/3514#discussion_r1081145188
##
arrow-cast/src/display.rs:
##
@@ -309,9 +379,10 @@ fn append_map_field_string(
///
/// Note this function is quite inefficient and is unlikely to be
/// suitable
MarcoGorelli commented on PR #14662:
URL: https://github.com/apache/arrow/pull/14662#issuecomment-1396842946
Hi - is there still interest in addressing
https://issues.apache.org/jira/browse/ARROW-16544 ?
If not, I'll close, no worries
--
This is an automated message from the
thisisnic commented on PR #33748:
URL: https://github.com/apache/arrow/pull/33748#issuecomment-1396828704
I've added in the URLS (this won't work automatically yet as things are
configured to work with JIRA), ditched the "other" subsection and moved some
items up in the hierarchy to "new
ygf11 commented on PR #4923:
URL:
https://github.com/apache/arrow-datafusion/pull/4923#issuecomment-1396823473
> Maybe we can add some error cases shpwing that SELECT t1.id FROM t1 SEMI
JOIN t2 ON (t1.id = t2.id) WHERE t2.value = 5 generates an error
> It would also be good to cover
joosthooz commented on PR #33738:
URL: https://github.com/apache/arrow/pull/33738#issuecomment-1396819003
Nice, I think the WriteAndCheckBackpressure span is important because that's
where the backpressure is checked and also it performs some work combining
staged batches (in
ericphanson commented on PR #381:
URL: https://github.com/apache/arrow-julia/pull/381#issuecomment-1396815064
TagBot is enabled/running here, but is having issues across many repos those
days (lots of 502 errors from GitHub), including this one, so it is not very
reliable at present
tustvold opened a new pull request, #3564:
URL: https://github.com/apache/arrow-rs/pull/3564
# Which issue does this PR close?
Closes #139
# Rationale for this change
# What changes are included in this PR?
Adds a panic message instead of
alamb commented on issue #3562:
URL: https://github.com/apache/arrow-rs/issues/3562#issuecomment-1396798368
My personal opinion is that the client code should be able to avoid panic's
if the user desires, but that doesn't mean the API needs to be fallible.
For example, as long as it
DDtKey opened a new issue, #4981:
URL: https://github.com/apache/arrow-datafusion/issues/4981
**Describe the bug**
[This line of
code](https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/src/physical_plan/joins/utils.rs#L695)
makes impossible to get real reason of
joosthooz commented on code in PR #33738:
URL: https://github.com/apache/arrow/pull/33738#discussion_r1081097788
##
cpp/src/arrow/compute/exec/sink_node.cc:
##
@@ -335,19 +327,13 @@ class ConsumingSinkNode : public ExecNode, public
BackpressureControl {
void Resume()
tustvold opened a new pull request, #3563:
URL: https://github.com/apache/arrow-rs/pull/3563
_Draft pending #3562_
# Which issue does this PR close?
Closes #1841
# Rationale for this change
# What changes are included in this PR?
#
tustvold opened a new issue, #3562:
URL: https://github.com/apache/arrow-rs/issues/3562
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
I suspect this will be a controversial issue, but there a couple of reasons
for
pitrou commented on issue #15054:
URL: https://github.com/apache/arrow/issues/15054#issuecomment-1396772668
> …maybe we could just leak the S3 client as a workaround?
We can probably do that indeed. We just have to make sure to disable S3 on
ASAN and Valgrind CI jobs.
--
This is
tustvold commented on issue #1858:
URL: https://github.com/apache/arrow-rs/issues/1858#issuecomment-1396761193
I'm closing as these comparison kernels are now gated with feature flags,
and crates can also choose not to depend on arrow-ord at all. Feel free to
re-open if there is additional
tustvold closed issue #1858: Huge amount of llvm code generated by comparison
kernels, potentially slowing compile times
URL: https://github.com/apache/arrow-rs/issues/1858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
thisisnic commented on code in PR #33748:
URL: https://github.com/apache/arrow/pull/33748#discussion_r1081073855
##
r/NEWS.md:
##
@@ -19,6 +19,77 @@
# arrow 10.0.1.9000
+## New features
+
+### Docs
+
+* A substantial reorganisation, rewrite of and addition to, many of the
ursabot commented on PR #15210:
URL: https://github.com/apache/arrow/pull/15210#issuecomment-1396745891
Benchmark runs are scheduled for baseline =
705e04bb15f481e476c9e7a8e2ac92460890ad0c and contender =
2b50694c10e09e4a1343b62c6b5f44ad4403d0e1.
2b50694c10e09e4a1343b62c6b5f44ad4403d0e1
MMCMA commented on issue #15153:
URL: https://github.com/apache/arrow/issues/15153#issuecomment-1396725954
I can close the issue - I just discovered by chance that in very rare
circumstances two processes we writing to the same file at the same time. Sorry
about this.
--
This is an
raulcd merged PR #33751:
URL: https://github.com/apache/arrow/pull/33751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tustvold commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081032053
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
tustvold commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081032053
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
DDtKey commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081030906
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
raulcd commented on issue #15054:
URL: https://github.com/apache/arrow/issues/15054#issuecomment-1396706119
As suggested by @lidavidm this is causing release verification
(https://github.com/apache/arrow/pull/33751) to be a bit painful.
I had to retry the `wheel-manylinux2014-cp39-amd64`
DDtKey commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081030906
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
tustvold commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081025726
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
DDtKey commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081013622
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
DDtKey commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081013622
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
DDtKey commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081013622
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
DDtKey commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081004665
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ursabot commented on PR #3560:
URL: https://github.com/apache/arrow-rs/pull/3560#issuecomment-1396668572
Benchmark runs are scheduled for baseline =
de62808a9d65e052ff3e89550bf780d952c8ceae and contender =
d9802353f195979f7c6541143c7e849f5ac2d661.
d9802353f195979f7c6541143c7e849f5ac2d661
tustvold commented on code in PR #3561:
URL: https://github.com/apache/arrow-rs/pull/3561#discussion_r1080992940
##
arrow-cast/src/cast.rs:
##
@@ -4710,8 +4709,8 @@ mod tests {
assert_eq!(1, arr.value_length(2));
assert_eq!(1, arr.value_length(3));
tustvold opened a new pull request, #3561:
URL: https://github.com/apache/arrow-rs/pull/3561
# Which issue does this PR close?
Closes #.
# Rationale for this change
Returning an owned value not only result in unnecessary clones, but results
in poor
Ziy1-Tan commented on PR #33781:
URL: https://github.com/apache/arrow/pull/33781#issuecomment-1396660590
cc @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tustvold merged PR #3560:
URL: https://github.com/apache/arrow-rs/pull/3560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
DDtKey commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080981598
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
tustvold commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1080984521
##
arrow-csv/src/reader/records.rs:
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
501 - 600 of 172155 matches
Mail list logo
