[GitHub] [arrow] cyb70289 commented on a change in pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

2021-05-11 Thread GitBox
cyb70289 commented on a change in pull request #9758: URL: https://github.com/apache/arrow/pull/9758#discussion_r629950742 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -75,48 +75,55 @@ struct CountImpl : public ScalarAggregator { Status

[GitHub] [arrow] cyb70289 commented on a change in pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

2021-05-10 Thread GitBox
cyb70289 commented on a change in pull request #9758: URL: https://github.com/apache/arrow/pull/9758#discussion_r629837991 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -75,48 +75,55 @@ struct CountImpl : public ScalarAggregator { Status

[GitHub] [arrow] cyb70289 commented on a change in pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

2021-05-10 Thread GitBox
cyb70289 commented on a change in pull request #9758: URL: https://github.com/apache/arrow/pull/9758#discussion_r629837991 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -75,48 +75,55 @@ struct CountImpl : public ScalarAggregator { Status

[GitHub] [arrow] cyb70289 commented on a change in pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

2021-05-10 Thread GitBox
cyb70289 commented on a change in pull request #9758: URL: https://github.com/apache/arrow/pull/9758#discussion_r629221044 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic_internal.h ## @@ -256,8 +262,8 @@ struct MinMaxImpl : public ScalarAggregator { using

[GitHub] [arrow] cyb70289 commented on a change in pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

2021-05-10 Thread GitBox
cyb70289 commented on a change in pull request #9758: URL: https://github.com/apache/arrow/pull/9758#discussion_r629076290 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic_internal.h ## @@ -256,8 +262,8 @@ struct MinMaxImpl : public ScalarAggregator { using

[GitHub] [arrow] cyb70289 commented on a change in pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

2021-04-28 Thread GitBox
cyb70289 commented on a change in pull request #9758: URL: https://github.com/apache/arrow/pull/9758#discussion_r622698623 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic_internal.h ## @@ -72,44 +73,54 @@ struct SumImpl : public ScalarAggregator { Status