[GitHub] [beam] youngoli commented on issue #11443: [BEAM-9775] Add Go support for SDF StandardRequirements.

2020-04-16 Thread GitBox
youngoli commented on issue #11443: [BEAM-9775] Add Go support for SDF StandardRequirements. URL: https://github.com/apache/beam/pull/11443#issuecomment-615022600 R: @lostluck This is an automated message from the Apache

[GitHub] [beam] youngoli opened a new pull request #11443: [BEAM-9775] Add Go support for SDF StandardRequirements.

2020-04-16 Thread GitBox
youngoli opened a new pull request #11443: [BEAM-9775] Add Go support for SDF StandardRequirements. URL: https://github.com/apache/beam/pull/11443 This fills in just the SDF requirement for pipelines (defined in beam_runner_api.proto). The way it's implemented should be pretty simple

[GitHub] [beam] youngoli commented on issue #11443: [BEAM-9775] Add Go support for SDF StandardRequirements.

2020-04-16 Thread GitBox
youngoli commented on issue #11443: [BEAM-9775] Add Go support for SDF StandardRequirements. URL: https://github.com/apache/beam/pull/11443#issuecomment-615022471 Run Go PostCommit This is an automated message from the

[GitHub] [beam] suztomo closed pull request #11391: [BEAM-9444] Rebasing old version of PR 11156 (no need to review)

2020-04-16 Thread GitBox
suztomo closed pull request #11391: [BEAM-9444] Rebasing old version of PR 11156 (no need to review) URL: https://github.com/apache/beam/pull/11391 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit

2020-04-16 Thread GitBox
Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit URL: https://github.com/apache/beam/pull/11428#issuecomment-615007536 Run Python2_PVR_Flink PreCommit This is an

[GitHub] [beam] lukecwik commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J…

2020-04-16 Thread GitBox
lukecwik commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J… URL: https://github.com/apache/beam/pull/11442#issuecomment-615005670 retest this please This is an automated message

[GitHub] [beam] ihji commented on a change in pull request #10055: [BEAM-8603] Add Python SqlTransform

2020-04-16 Thread GitBox
ihji commented on a change in pull request #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#discussion_r409958523 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -1779,6 +1779,33 @@

[GitHub] [beam] lukecwik commented on issue #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write

2020-04-16 Thread GitBox
lukecwik commented on issue #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write URL: https://github.com/apache/beam/pull/11397#issuecomment-615005288 retest this please This is an automated message from the

[GitHub] [beam] lukemin89 commented on a change in pull request #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write

2020-04-16 Thread GitBox
lukemin89 commented on a change in pull request #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write URL: https://github.com/apache/beam/pull/11397#discussion_r409952691 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java ## @@

[GitHub] [beam] lukemin89 commented on a change in pull request #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write

2020-04-16 Thread GitBox
lukemin89 commented on a change in pull request #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write URL: https://github.com/apache/beam/pull/11397#discussion_r409952021 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java ## @@

[GitHub] [beam] lukemin89 commented on a change in pull request #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write

2020-04-16 Thread GitBox
lukemin89 commented on a change in pull request #11397: [BEAM-9743] Fix TFRecordCodec to try harder to read/write URL: https://github.com/apache/beam/pull/11397#discussion_r409952123 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/io/TFRecordIOTest.java ##

[GitHub] [beam] allenpradeep commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change

2020-04-16 Thread GitBox
allenpradeep commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change URL: https://github.com/apache/beam/pull/11392#issuecomment-614989387 Retest this please This is an automated message from the Apache

[GitHub] [beam] allenpradeep commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change

2020-04-16 Thread GitBox
allenpradeep commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change URL: https://github.com/apache/beam/pull/11392#issuecomment-614981384 Run Java PreCommit This is an automated message from the Apache

[GitHub] [beam] stale[bot] commented on issue #10206: [WIP] [Beam-3032] - Add RedshiftIO

2020-04-16 Thread GitBox
stale[bot] commented on issue #10206: [WIP] [Beam-3032] - Add RedshiftIO URL: https://github.com/apache/beam/pull/10206#issuecomment-614975164 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think

[GitHub] [beam] lukecwik merged pull request #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-16 Thread GitBox
lukecwik merged pull request #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319 This is an automated message from the Apache Git

[GitHub] [beam] lukecwik merged pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls.

2020-04-16 Thread GitBox
lukecwik merged pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls. URL: https://github.com/apache/beam/pull/11414 This is an automated message from the Apache Git Service. To

[GitHub] [beam] chamikaramj commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change

2020-04-16 Thread GitBox
chamikaramj commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change URL: https://github.com/apache/beam/pull/11392#issuecomment-614955150 Run Java PostCommit This is an automated message from the Apache

[GitHub] [beam] chamikaramj commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change

2020-04-16 Thread GitBox
chamikaramj commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change URL: https://github.com/apache/beam/pull/11392#issuecomment-614954744 Retest this please This is an automated message from the Apache

[GitHub] [beam] ibzib commented on issue #11362: [BEAM-9733] Always let ImpulseSourceFunction emit a final watermark

2020-04-16 Thread GitBox
ibzib commented on issue #11362: [BEAM-9733] Always let ImpulseSourceFunction emit a final watermark URL: https://github.com/apache/beam/pull/11362#issuecomment-614951136 What remains to be done on this PR? Test coverage? I'd like to get this merged as soon as possible to unblock the 2.21

[GitHub] [beam] scwhittle commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J…

2020-04-16 Thread GitBox
scwhittle commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J… URL: https://github.com/apache/beam/pull/11442#issuecomment-614949937 Thanks! I think that the description would be better if it included why the test passes without this change and

[GitHub] [beam] ibzib merged pull request #11435: [release-2.21.0][BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-16 Thread GitBox
ibzib merged pull request #11435: [release-2.21.0][BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11435 This is an automated message from the Apache Git Service.

[GitHub] [beam] stevekoonce commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J…

2020-04-16 Thread GitBox
stevekoonce commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J… URL: https://github.com/apache/beam/pull/11442#issuecomment-614942121 R: @scwhittle This is an automated message

[GitHub] [beam] stevekoonce commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J…

2020-04-16 Thread GitBox
stevekoonce commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J… URL: https://github.com/apache/beam/pull/11442#issuecomment-614941168 Run Dataflow ValidatesRunner This is an

[GitHub] [beam] stevekoonce opened a new pull request #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J…

2020-04-16 Thread GitBox
stevekoonce opened a new pull request #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J… URL: https://github.com/apache/beam/pull/11442 …ackson 2 This change updates the DebugCapture within the Dataflow runner to use the latest Google API client

[GitHub] [beam] lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-16 Thread GitBox
lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-614937833 Run Portable_Python PreCommit This

[GitHub] [beam] robertwb commented on issue #11431: [BEAM-8646] Fix external environment on OS X as well.

2020-04-16 Thread GitBox
robertwb commented on issue #11431: [BEAM-8646] Fix external environment on OS X as well. URL: https://github.com/apache/beam/pull/11431#issuecomment-614937771 Run Python PreCommit This is an automated message from the

[GitHub] [beam] lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-16 Thread GitBox
lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-614937874 Run PythonLint PreCommit This is

[GitHub] [beam] lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-16 Thread GitBox
lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-614937799 Run Python PreCommit This is an

[GitHub] [beam] robertwb commented on issue #11431: [BEAM-8646] Fix external environment on OS X as well.

2020-04-16 Thread GitBox
robertwb commented on issue #11431: [BEAM-8646] Fix external environment on OS X as well. URL: https://github.com/apache/beam/pull/11431#issuecomment-614937962 Run Python2_PVR_Flink PreCommit This is an automated message

[GitHub] [beam] Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit

2020-04-16 Thread GitBox
Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit URL: https://github.com/apache/beam/pull/11428#issuecomment-614937155 Run Python2_PVR_Flink PreCommit This is an

[GitHub] [beam] pabloem commented on issue #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.

2020-04-16 Thread GitBox
pabloem commented on issue #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-614935695 > For my edification - what happened here? Are bundles registered with the process bundle request? Robert has

[GitHub] [beam] lukecwik commented on issue #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls.

2020-04-16 Thread GitBox
lukecwik commented on issue #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls. URL: https://github.com/apache/beam/pull/11414#issuecomment-614934489 Run RAT PreCommit This is an automated

[GitHub] [beam] lukecwik merged pull request #11441: [BEAM-5379] Ignore go.sum files in RAT checks

2020-04-16 Thread GitBox
lukecwik merged pull request #11441: [BEAM-5379] Ignore go.sum files in RAT checks URL: https://github.com/apache/beam/pull/11441 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on issue #11441: [BEAM-5379] Ignore go.sum files in RAT checks

2020-04-16 Thread GitBox
lukecwik commented on issue #11441: [BEAM-5379] Ignore go.sum files in RAT checks URL: https://github.com/apache/beam/pull/11441#issuecomment-614932942 Since this only impacts the RAT check and is blocking all other PRs I suggest merging when that is green.

[GitHub] [beam] lostluck opened a new pull request #11441: [BEAM-5379] Ignore go.sum files in RAT checks

2020-04-16 Thread GitBox
lostluck opened a new pull request #11441: [BEAM-5379] Ignore go.sum files in RAT checks URL: https://github.com/apache/beam/pull/11441 R: @youngoli cc: @boyuanzz @lukecwik @damondouglas Thank you for your contribution! Follow this checklist to

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-16 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-614930497 R: @amaliujia This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-16 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-614921757 Run Website PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-16 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-614920456 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-16 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-614914483 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-16 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-614913280 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-16 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-614913238 Run Website PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] reuvenlax closed pull request #10767: Document Beam Schemas

2020-04-16 Thread GitBox
reuvenlax closed pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-16 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-614900277 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-16 Thread GitBox
chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614899392 We backported the transform into a library that we ship with our Dataflow jobs, I didn't know that there were Python

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409844505 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write URL: https://github.com/apache/beam/pull/11396#discussion_r409843690 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ##

[GitHub] [beam] rohdesamuel commented on issue #11440: [BEAM-9767] Add a timeout to the TestStream GRPC and fix the Streaming cache timeout

2020-04-16 Thread GitBox
rohdesamuel commented on issue #11440: [BEAM-9767] Add a timeout to the TestStream GRPC and fix the Streaming cache timeout URL: https://github.com/apache/beam/pull/11440#issuecomment-614891171 Looks like an unrelated error in the RAT (go learning katas have a bad license)

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409832148 ## File path:

[GitHub] [beam] boyuanzz commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-16 Thread GitBox
boyuanzz commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#issuecomment-614877141 There are 2 go.sum files without apache license header, which breaks RAT check. Could you please take a look at it?

[GitHub] [beam] boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409826545 ## File path:

[GitHub] [beam] lukecwik merged pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout

2020-04-16 Thread GitBox
lukecwik merged pull request #11275: [BEAM-9648]: DirectRunner should return null on timeout URL: https://github.com/apache/beam/pull/11275 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409824692 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409807914 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409818060 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409806889 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409820103 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r409819571 ## File path:

[GitHub] [beam] reuvenlax merged pull request #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax merged pull request #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] boyuanzz commented on issue #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
boyuanzz commented on issue #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#issuecomment-614853115 Run RAT PreCommit This is an automated message from the

[GitHub] [beam] pabloem commented on issue #11440: [BEAM-9767] Add a timeout to the TestStream GRPC and fix the Streaming cache timeout

2020-04-16 Thread GitBox
pabloem commented on issue #11440: [BEAM-9767] Add a timeout to the TestStream GRPC and fix the Streaming cache timeout URL: https://github.com/apache/beam/pull/11440#issuecomment-614844071 retest this please This is an

[GitHub] [beam] rohdesamuel commented on issue #11440: [BEAM-9767] Add a timeout to the TestStream GRPC and fix the Streaming cache timeout

2020-04-16 Thread GitBox
rohdesamuel commented on issue #11440: [BEAM-9767] Add a timeout to the TestStream GRPC and fix the Streaming cache timeout URL: https://github.com/apache/beam/pull/11440#issuecomment-614840044 R: @pabloem This is an

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-16 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614839093 @chunyang I reviewed the releases, and I saw that this is not in 2.20 - so I'm curious. Do you guys use Beam

[GitHub] [beam] pabloem commented on a change in pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-16 Thread GitBox
pabloem commented on a change in pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#discussion_r409783068 ## File path: sdks/python/apache_beam/io/gcp/bigquery_file_loads_test.py ## @@

[GitHub] [beam] pabloem merged pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-16 Thread GitBox
pabloem merged pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] allenpradeep commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change

2020-04-16 Thread GitBox
allenpradeep commented on issue #11392: [BEAM-9739] Retry SpannerIO write on Schema change URL: https://github.com/apache/beam/pull/11392#issuecomment-614812243 Run Java PostCommit This is an automated message from the

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614809782 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git

[GitHub] [beam] lostluck merged pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-16 Thread GitBox
lostluck merged pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] lostluck commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-16 Thread GitBox
lostluck commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#issuecomment-614808287 Thank you very much! I look forward to the next lessons. This can wait for a next PR, but having a small README on how to keep the go

[GitHub] [beam] udim commented on issue #11439: [BEAM-6860] Fix iobase non-global windows bug

2020-04-16 Thread GitBox
udim commented on issue #11439: [BEAM-6860] Fix iobase non-global windows bug URL: https://github.com/apache/beam/pull/11439#issuecomment-614800987 R: @chamikaramj @robertwb This is an automated message from the Apache Git

[GitHub] [beam] udim opened a new pull request #11439: [BEAM-6860] Fix iobase non-global windows bug

2020-04-16 Thread GitBox
udim opened a new pull request #11439: [BEAM-6860] Fix iobase non-global windows bug URL: https://github.com/apache/beam/pull/11439 WriteImpl writes elements to files and outputs `writer.close()` return values. It assumed (when num_shards=0) that the PCollection window was global.

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614799372 Run Website PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] ibzib commented on a change in pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-16 Thread GitBox
ibzib commented on a change in pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#discussion_r409736653 ## File path: sdks/python/apache_beam/io/gcp/bigquery_file_loads_test.py ## @@

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614792138 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git

[GitHub] [beam] rehmanmuradali commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-16 Thread GitBox
rehmanmuradali commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-614783089 R: @reuvenlax This is an automated message from the Apache

[GitHub] [beam] boyuanzz commented on issue #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-16 Thread GitBox
boyuanzz commented on issue #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#issuecomment-614781245 Run Java PreCommit This is an automated message from the

[GitHub] [beam] robertwb commented on issue #11432: [BEAM-9577] Small fixes to portable runner staging.

2020-04-16 Thread GitBox
robertwb commented on issue #11432: [BEAM-9577] Small fixes to portable runner staging. URL: https://github.com/apache/beam/pull/11432#issuecomment-614778828 Failure in `sdks:java:container:generateLicenseReport (Failed to retrieve artifacts for [group:com.google.zetasql,

[GitHub] [beam] Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit

2020-04-16 Thread GitBox
Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit URL: https://github.com/apache/beam/pull/11428#issuecomment-614771463 Run Python2_PVR_Flink PreCommit This is an

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614764893 Run CommunityMetrics PreCommit This is an automated message from the Apache Git

[GitHub] [beam] lukecwik merged pull request #11429: [BEAM-9765] Exclude module-info.class from vendored Calcite.

2020-04-16 Thread GitBox
lukecwik merged pull request #11429: [BEAM-9765] Exclude module-info.class from vendored Calcite. URL: https://github.com/apache/beam/pull/11429 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aaltay commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-16 Thread GitBox
aaltay commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-614754539 retest this please This is an automated message from the Apache Git

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614754751 @TheNeuralBit I was forced to fork this PR as I've been unable to fix the old branch. This should be the same content you approved.

[GitHub] [beam] aaltay removed a comment on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-16 Thread GitBox
aaltay removed a comment on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-614754706 retest this please This is an automated message from the

[GitHub] [beam] aaltay removed a comment on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-16 Thread GitBox
aaltay removed a comment on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-614754539 retest this please This is an automated message from the

[GitHub] [beam] aaltay commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-16 Thread GitBox
aaltay commented on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-614754706 retest this please This is an automated message from the Apache Git

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614754340 Run CommunityMetrics PreCommit This is an automated message from the Apache Git

[GitHub] [beam] reuvenlax commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-16 Thread GitBox
reuvenlax commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#discussion_r409681355 ## File path:

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-04-16 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-614750341 ping @robertwb @ihji This is an automated message from the Apache Git Service.

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614749762 Run CommunityMetrics PreCommit This is an automated message from the Apache Git

[GitHub] [beam] reuvenlax commented on issue #11436: Document Beam Schemas (forked PR)

2020-04-16 Thread GitBox
reuvenlax commented on issue #11436: Document Beam Schemas (forked PR) URL: https://github.com/apache/beam/pull/11436#issuecomment-614749664 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git

[GitHub] [beam] reuvenlax opened a new pull request #10767: Document Beam Schemas

2020-04-16 Thread GitBox
reuvenlax opened a new pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-16 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-614746001 Run Python2_PVR_Flink PreCommit This is an automated message

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-16 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-614742947 Run Java PreCommit This is an automated message from the

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-16 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-614738955 Run Java PreCommit This is an automated message from the

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-16 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-614739052 Run Python2_PVR_Flink PreCommit This is an automated message

[GitHub] [beam] reuvenlax commented on issue #10767: Document Beam Schemas

2020-04-16 Thread GitBox
reuvenlax commented on issue #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#issuecomment-614721937 @iemejia I'm still not sure what happened. I rebased my client and pushed, and that seemed to revert all my changes and automatically close the PR. This seems

[GitHub] [beam] jaketf commented on issue #11339: [BEAM-9468] Fhir io

2020-04-16 Thread GitBox
jaketf commented on issue #11339: [BEAM-9468] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-614713471 FhirIOReadIT was flaky due to stale data (from previously run tests) sticking around in pubsub topic. This causes the read to try to read a resource from a FHIR

[GitHub] [beam] rehmanmuradali commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-16 Thread GitBox
rehmanmuradali commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#discussion_r409602692 ## File path:

[GitHub] [beam] rehmanmuradali commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-16 Thread GitBox
rehmanmuradali commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#discussion_r409602437 ## File path:

[GitHub] [beam] echauchot merged pull request #11135: Add spark structured streaming runner to load tests

2020-04-16 Thread GitBox
echauchot merged pull request #11135: Add spark structured streaming runner to load tests URL: https://github.com/apache/beam/pull/11135 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] nielm commented on issue #11438: [BEAM-9505] Remove spurious error message in SpannerIO when streaming.

2020-04-16 Thread GitBox
nielm commented on issue #11438: [BEAM-9505] Remove spurious error message in SpannerIO when streaming. URL: https://github.com/apache/beam/pull/11438#issuecomment-614597327 @chamikaramj @allenpradeep Can you review please?

  1   2   >