[GitHub] [beam] mwalenia commented on pull request #11619: Compile and run tests on java 11 for PreCommit portability api

mwalenia commented on pull request #11619: URL: https://github.com/apache/beam/pull/11619#issuecomment-625668322 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] mwalenia commented on pull request #11619: Compile and run tests on java 11 for PreCommit portability api

mwalenia commented on pull request #11619: URL: https://github.com/apache/beam/pull/11619#issuecomment-625668101 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] mwalenia commented on pull request #11331: [BEAM-9646] Add Google Cloud vision integration transform

mwalenia commented on pull request #11331: URL: https://github.com/apache/beam/pull/11331#issuecomment-625667742 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] chamikaramj commented on a change in pull request #11210: [BEAM-8949] SpannerIO integration tests

chamikaramj commented on a change in pull request #11210: URL: https://github.com/apache/beam/pull/11210#discussion_r421958466 ## File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py ## @@ -1008,31 +1007,30 @@ def _reset_count(self): self._cells = 0 def

[GitHub] [beam] chamikaramj commented on a change in pull request #11210: [BEAM-8949] SpannerIO integration tests

chamikaramj commented on a change in pull request #11210: URL: https://github.com/apache/beam/pull/11210#discussion_r421958742 ## File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py ## @@ -1008,31 +1007,30 @@ def _reset_count(self): self._cells = 0 def

[GitHub] [beam] chamikaramj commented on a change in pull request #11210: [BEAM-8949] SpannerIO integration tests

chamikaramj commented on a change in pull request #11210: URL: https://github.com/apache/beam/pull/11210#discussion_r421958329 ## File path: sdks/python/apache_beam/io/gcp/experimental/spannerio_test.py ## @@ -499,6 +499,7 @@ def test_batch_byte_size( # and each bach sho

[GitHub] [beam] chamikaramj commented on pull request #11557: [BEAM-9845] Stage artifacts over expansion service.

chamikaramj commented on pull request #11557: URL: https://github.com/apache/beam/pull/11557#issuecomment-625639303 Thanks. Merging. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on pull request #11438: [BEAM-9505] Remove spurious error message in SpannerIO when streaming.

chamikaramj commented on pull request #11438: URL: https://github.com/apache/beam/pull/11438#issuecomment-625638111 Thanks. Will merge after tests. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [beam] chamikaramj commented on pull request #11438: [BEAM-9505] Remove spurious error message in SpannerIO when streaming.

chamikaramj commented on pull request #11438: URL: https://github.com/apache/beam/pull/11438#issuecomment-625638055 Retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] chamikaramj commented on a change in pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

chamikaramj commented on a change in pull request #11637: URL: https://github.com/apache/beam/pull/11637#discussion_r421945252 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -738,7 +738,7 @@ def _execute_query(self, bq): job_id=uuid.uuid4().hex,

[GitHub] [beam] chamikaramj commented on a change in pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

chamikaramj commented on a change in pull request #11637: URL: https://github.com/apache/beam/pull/11637#discussion_r421945252 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -738,7 +738,7 @@ def _execute_query(self, bq): job_id=uuid.uuid4().hex,

[GitHub] [beam] kmjung commented on a change in pull request #11580: [BEAM-9861] Reject fractional values outside of (0.0, 1.0)

kmjung commented on a change in pull request #11580: URL: https://github.com/apache/beam/pull/11580#discussion_r421945047 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java ## @@ -288,6 +288,11 @@

[GitHub] [beam] chamikaramj commented on pull request #11628: [BEAM-9911]Replace SpannerIO.write latency counter to distribution

chamikaramj commented on pull request #11628: URL: https://github.com/apache/beam/pull/11628#issuecomment-625635891 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] chamikaramj commented on a change in pull request #11580: [BEAM-9861] Reject fractional values outside of (0.0, 1.0)

chamikaramj commented on a change in pull request #11580: URL: https://github.com/apache/beam/pull/11580#discussion_r421942845 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java ## @@ -288,6 +288,

[GitHub] [beam] amaliujia commented on pull request #11636: [BEAM-9929] Support UNNEST(array_column) in ZetaSQL

amaliujia commented on pull request #11636: URL: https://github.com/apache/beam/pull/11636#issuecomment-625634819 Compliance testing passed. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-625633642 > > > Thanks! > > > In terms of naming, I found it surprising that union (for example) does deduplication. Maybe name them distinctUnion and multisetUnion or something like t

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r421940321 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [beam] pawelpasterz edited a comment on pull request #11619: Compile and run tests on java 11 for PreCommit portability api

pawelpasterz edited a comment on pull request #11619: URL: https://github.com/apache/beam/pull/11619#issuecomment-625624564 @iemejia > @pawelpasterz I am ok with the current version can you please squash and update so we can run the tests and see if everything work as expected befor

[GitHub] [beam] pawelpasterz commented on pull request #11619: Compile and run tests on java 11 for PreCommit portability api

pawelpasterz commented on pull request #11619: URL: https://github.com/apache/beam/pull/11619#issuecomment-625624564 > @pawelpasterz I am ok with the current version can you please squash and update so we can run the tests and see if everything work as expected before merge. > > Als

[GitHub] [beam] kennknowles opened a new pull request #11639: [BEAM-4440] Throw exception when file to stage is not found, instead of logging a warning

kennknowles opened a new pull request #11639: URL: https://github.com/apache/beam/pull/11639 Currently, if a file to stage is not found, the job will still launch, with no real chance of succeeding. The value of `filesToStage` pipeline option (which is universal/global, since all op

[GitHub] [beam] youngoli commented on a change in pull request #11605: [BEAM-9883] Refactor SDF test restrictions.

youngoli commented on a change in pull request #11605: URL: https://github.com/apache/beam/pull/11605#discussion_r421890378 ## File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers_test.go ## @@ -210,86 +229,154 @@ func TestInvokes(t *testing.T) { }) } -type Res

[GitHub] [beam] pabloem commented on pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

pabloem commented on pull request #11637: URL: https://github.com/apache/beam/pull/11637#issuecomment-625583009 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625581673 Webiste stage https://builds.apache.org/view/PreCommit%20Builds/job/beam_PreCommit_Website_Stage_GCS_Commit/3498/ ---

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625580713 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625580612 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] robertwb commented on a change in pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.

robertwb commented on a change in pull request #11521: URL: https://github.com/apache/beam/pull/11521#discussion_r421880710 ## File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java ## @@ -613,7 +620,7 @@ pub

[GitHub] [beam] robertwb commented on a change in pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataframe.*

robertwb commented on a change in pull request #11632: URL: https://github.com/apache/beam/pull/11632#discussion_r421878491 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -248,7 +261,12 @@ def _dict_union(dicts): return result -def _flatten(valueish,

[GitHub] [beam] TheNeuralBit commented on pull request #11638: [BEAM-9449] Pass PipelineOptions through expansion service

TheNeuralBit commented on pull request #11638: URL: https://github.com/apache/beam/pull/11638#issuecomment-625570399 R: @ihji This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] TheNeuralBit opened a new pull request #11638: [BEAM-9449] Pass PipelineOptions through expansion service

TheNeuralBit opened a new pull request #11638: URL: https://github.com/apache/beam/pull/11638 Roll-forward of #11574. Includes an additional commit that ensures ExpansionService will never pick up PipelineOptions from `sys.argv` (the cause of [BEAM-9907](https://issues.apache.org/jira/brow

[GitHub] [beam] robertwb commented on a change in pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataframe.*

robertwb commented on a change in pull request #11632: URL: https://github.com/apache/beam/pull/11632#discussion_r421871772 ## File path: sdks/python/apache_beam/dataframe/convert.py ## @@ -16,13 +16,23 @@ from __future__ import absolute_import +import typing + import ins

[GitHub] [beam] pabloem commented on pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

pabloem commented on pull request #11637: URL: https://github.com/apache/beam/pull/11637#issuecomment-625563108 Run Python 3.6 PostCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] pabloem opened a new pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

pabloem opened a new pull request #11637: URL: https://github.com/apache/beam/pull/11637 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickl

[GitHub] [beam] amaliujia commented on pull request #11636: [BEAM-9929] Support UNNEST(array_column) in ZetaSQL

amaliujia commented on pull request #11636: URL: https://github.com/apache/beam/pull/11636#issuecomment-625561994 R: @kennknowles @apilloud This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] amaliujia opened a new pull request #11636: [BEAM-9929] Support UNNEST(array_column) in ZetaSQL

amaliujia opened a new pull request #11636: URL: https://github.com/apache/beam/pull/11636 https://jira.apache.org/jira/browse/BEAM-9929 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and eas

[GitHub] [beam] chamikaramj commented on pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

chamikaramj commented on pull request #11039: URL: https://github.com/apache/beam/pull/11039#issuecomment-625546290 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421847633 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -472,24 +548,120 @@ public void ini

[GitHub] [beam] damondouglas commented on a change in pull request #11564: [Beam-9679] Add Core Transforms section / Map lesson to the Go SDK katas

damondouglas commented on a change in pull request #11564: URL: https://github.com/apache/beam/pull/11564#discussion_r421834698 ## File path: learning/katas/go/Core Transforms/Map/ParDo OneToMany/task.md ## @@ -0,0 +1,32 @@ + + +# ParDo - One to Many + +In the previous kata we

[GitHub] [beam] lostluck commented on a change in pull request #11564: [Beam-9679] Add Core Transforms section / Map lesson to the Go SDK katas

lostluck commented on a change in pull request #11564: URL: https://github.com/apache/beam/pull/11564#discussion_r421831198 ## File path: learning/katas/go/Core Transforms/Map/ParDo OneToMany/task.md ## @@ -0,0 +1,32 @@ + + +# ParDo - One to Many + +In the previous kata we lear

[GitHub] [beam] lostluck commented on a change in pull request #11564: [Beam-9679] Add Core Transforms section / Map lesson to the Go SDK katas

lostluck commented on a change in pull request #11564: URL: https://github.com/apache/beam/pull/11564#discussion_r421830719 ## File path: learning/katas/go/Core Transforms/Map/ParDo OneToMany/task.md ## @@ -0,0 +1,32 @@ + + +# ParDo - One to Many + +In the previous kata we lear

[GitHub] [beam] chamikaramj commented on a change in pull request #11607: [BEAM-9430] Fixes the bounds of initial watermark set to estimators instead of raising an error

chamikaramj commented on a change in pull request #11607: URL: https://github.com/apache/beam/pull/11607#discussion_r421830922 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimators.java ## @@ -37,14 +37,16 @@ private

[GitHub] [beam] lostluck commented on pull request #11564: [Beam-9679] Add Core Transforms section / Map lesson to the Go SDK katas

lostluck commented on pull request #11564: URL: https://github.com/apache/beam/pull/11564#issuecomment-625528370 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] pabloem commented on pull request #11634: Change TestStreamImpl to a producer/consumer pattern

pabloem commented on pull request #11634: URL: https://github.com/apache/beam/pull/11634#issuecomment-625527074 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421827964 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -472,24 +548,120 @@ public void ini

[GitHub] [beam] lukecwik commented on a change in pull request #11607: [BEAM-9430] Fixes the bounds of initial watermark set to estimators instead of raising an error

lukecwik commented on a change in pull request #11607: URL: https://github.com/apache/beam/pull/11607#discussion_r421827443 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimators.java ## @@ -37,14 +37,16 @@ private Ins

[GitHub] [beam] kennknowles commented on pull request #11633: [BEAM-9868] Remove tests of Java on Dataflows Java Runner Harness

kennknowles commented on pull request #11633: URL: https://github.com/apache/beam/pull/11633#issuecomment-625525541 Nevermind; seems I cannot reopen. See #11635 This is an automated message from the Apache Git Service. To re

[GitHub] [beam] rohdesamuel opened a new pull request #11634: Change TestStreamImpl to a producer/consumer pattern

rohdesamuel opened a new pull request #11634: URL: https://github.com/apache/beam/pull/11634 Change-Id: I832311ffdd22d246710b38db85c3ab805b0d43ca GRPC streaming RPCs are blocking with no non-blocking API. This changes the TestStreamImpl from RPC to a producer/consumer design with a t

[GitHub] [beam] kennknowles opened a new pull request #11635: [BEAM-9868] Remove tests of Java on Dataflows Java Runner Harness

kennknowles opened a new pull request #11635: URL: https://github.com/apache/beam/pull/11635 This configuration is not used or supported, never has been, never will be. It was a configuration that was useful for maturity the Java Runner Harness and the Java SDK harness. --

[GitHub] [beam] chamikaramj commented on a change in pull request #11607: [BEAM-9430] Fixes the bounds of initial watermark set to estimators instead of raising an error

chamikaramj commented on a change in pull request #11607: URL: https://github.com/apache/beam/pull/11607#discussion_r421826896 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimators.java ## @@ -37,14 +37,16 @@ private

[GitHub] [beam] lukecwik commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

lukecwik commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421826446 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java ## @@ -94,6 +94,9 @@ public void checkDo

[GitHub] [beam] kennknowles commented on pull request #11633: [BEAM-9868] Remove tests of Java on Dataflows Java Runner Harness

kennknowles commented on pull request #11633: URL: https://github.com/apache/beam/pull/11633#issuecomment-625524793 Please take a look now. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] kennknowles commented on pull request #11633: [BEAM-9868] Remove tests of Java on Dataflows Java Runner Harness

kennknowles commented on pull request #11633: URL: https://github.com/apache/beam/pull/11633#issuecomment-625524298 Ah, there's more to remove. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421825288 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OrderedTimeRange.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to the

[GitHub] [beam] pabloem commented on a change in pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

pabloem commented on a change in pull request #11582: URL: https://github.com/apache/beam/pull/11582#discussion_r421825128 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1641,3 +1644,314 @@ def process(self, unused_element, signal): *self._args

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421824462 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java ## @@ -94,6 +94,9 @@ public void checkDone

[GitHub] [beam] lukecwik commented on a change in pull request #11607: [BEAM-9430] Fixes the bounds of initial watermark set to estimators instead of raising an error

lukecwik commented on a change in pull request #11607: URL: https://github.com/apache/beam/pull/11607#discussion_r421824248 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimators.java ## @@ -37,14 +37,16 @@ private Ins

[GitHub] [beam] kennknowles opened a new pull request #11633: [BEAM-9868] Remove tests of Java on Dataflows Java Runner Harness

kennknowles opened a new pull request #11633: URL: https://github.com/apache/beam/pull/11633 This configuration is not used or supported, never has been, never will be. It was a configuration that was useful for maturity the Java Runner Harness and the Java SDK harness. --

[GitHub] [beam] lukecwik commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

lukecwik commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421819001 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OrderedTimeRange.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to t

[GitHub] [beam] lukecwik commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

lukecwik commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421813915 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -472,24 +548,120 @@ public void i

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421809510 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OrderedTimeRange.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to the

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421807059 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -472,24 +548,120 @@ public void ini

[GitHub] [beam] chadrik commented on a change in pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataflow.

chadrik commented on a change in pull request #11632: URL: https://github.com/apache/beam/pull/11632#discussion_r421799103 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -248,7 +261,12 @@ def _dict_union(dicts): return result -def _flatten(valueish,

[GitHub] [beam] lukecwik commented on pull request #11406: [BEAM-9748] Move Reparallelize transform to Reshuffle

lukecwik commented on pull request #11406: URL: https://github.com/apache/beam/pull/11406#issuecomment-625500222 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] chadrik commented on a change in pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataflow.

chadrik commented on a change in pull request #11632: URL: https://github.com/apache/beam/pull/11632#discussion_r421796648 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -248,7 +261,12 @@ def _dict_union(dicts): return result -def _flatten(valueish,

[GitHub] [beam] lukecwik commented on pull request #11453: Don't use protobuf toString for BQ storage API protos

lukecwik commented on pull request #11453: URL: https://github.com/apache/beam/pull/11453#issuecomment-625498997 Is this still an issue? This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [beam] lukecwik commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

lukecwik commented on a change in pull request #11396: URL: https://github.com/apache/beam/pull/11396#discussion_r421795105 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ## @@ -257,6 +258,28 @@ public boolean apply(SQLException e) {

[GitHub] [beam] lukecwik commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

lukecwik commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-625498060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] chadrik commented on a change in pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataflow.

chadrik commented on a change in pull request #11632: URL: https://github.com/apache/beam/pull/11632#discussion_r421790116 ## File path: sdks/python/apache_beam/dataframe/convert.py ## @@ -16,13 +16,23 @@ from __future__ import absolute_import +import typing + import insp

[GitHub] [beam] chadrik commented on a change in pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataflow.

chadrik commented on a change in pull request #11632: URL: https://github.com/apache/beam/pull/11632#discussion_r421789390 ## File path: sdks/python/apache_beam/dataframe/convert.py ## @@ -16,13 +16,23 @@ from __future__ import absolute_import +import typing + import insp

[GitHub] [beam] chadrik commented on pull request #11038: [BEAM-7746] More typing fixes

chadrik commented on pull request #11038: URL: https://github.com/apache/beam/pull/11038#issuecomment-625490803 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

lukecwik commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r421756445 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OrderedTimeRange.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to t

[GitHub] [beam] chamikaramj commented on pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

chamikaramj commented on pull request #11039: URL: https://github.com/apache/beam/pull/11039#issuecomment-625467377 Retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] lostluck commented on a change in pull request #11605: [BEAM-9883] Refactor SDF test restrictions.

lostluck commented on a change in pull request #11605: URL: https://github.com/apache/beam/pull/11605#discussion_r421731826 ## File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers_test.go ## @@ -210,86 +229,154 @@ func TestInvokes(t *testing.T) { }) } -type Res

[GitHub] [beam] pabloem commented on pull request #11631: [BEAM-9907] Revert "Pass pipeline options from caller to expansion service (#11574)"

pabloem commented on pull request #11631: URL: https://github.com/apache/beam/pull/11631#issuecomment-625452711 running the website stage to keep a copy of the current state of the website. please ignore : ) This is an autom

[GitHub] [beam] pabloem commented on pull request #11631: [BEAM-9907] Revert "Pass pipeline options from caller to expansion service (#11574)"

pabloem commented on pull request #11631: URL: https://github.com/apache/beam/pull/11631#issuecomment-625452579 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] sgraca commented on a change in pull request #11377: [BEAM-9439] Return split instead of total backlog size

sgraca commented on a change in pull request #11377: URL: https://github.com/apache/beam/pull/11377#discussion_r421740373 ## File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardRecordsIterator.java ## @@ -43,22 +42,23 @@ private final RecordFil

[GitHub] [beam] robertwb opened a new pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataflow.

robertwb opened a new pull request #11632: URL: https://github.com/apache/beam/pull/11632 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] robertwb commented on pull request #11632: [BEAM-7746] Fix type errors and enable checks for apache_beam.dataflow.

robertwb commented on pull request #11632: URL: https://github.com/apache/beam/pull/11632#issuecomment-625444026 R: @chadrik This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] pabloem commented on pull request #11624: [BEAM-9767] Make streaming_wordcount use a test timeout and increase from 5s to 30s

pabloem commented on pull request #11624: URL: https://github.com/apache/beam/pull/11624#issuecomment-625436791 LGTM - merging This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625433057 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] udim commented on a change in pull request #11070: [BEAM-8280] Blog post: Python typing changes

udim commented on a change in pull request #11070: URL: https://github.com/apache/beam/pull/11070#discussion_r421718341 ## File path: website/src/_posts/2020-03-06-python-typing.md ## @@ -0,0 +1,117 @@ +--- +layout: post +title: "Python SDK Typing Changes" +date: 2020-03-06

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625418934 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625414016 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] TheNeuralBit opened a new pull request #11631: [BEAM-9449] Revert "Pass pipeline options from caller to expansion service (#11574)"

TheNeuralBit opened a new pull request #11631: URL: https://github.com/apache/beam/pull/11631 This change makes python PreCommits flakey. Post-Commit Tests Status (on master branch)

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625412676 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625408966 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] tysonjh commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

tysonjh commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r421656607 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,157 @@ +/* +

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-625396106 Run SQL Postcommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-625395912 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] mxm commented on pull request #11557: [BEAM-9845] Stage artifacts over expansion service.

mxm commented on pull request #11557: URL: https://github.com/apache/beam/pull/11557#issuecomment-625395042 All green now. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] aaltay commented on pull request #11555: [BEAM-8134] Grafana dashboards for Load Tests and IO IT Performance Tests

aaltay commented on pull request #11555: URL: https://github.com/apache/beam/pull/11555#issuecomment-625391338 > The landing page will be created in a separate PR. I think this one can be closed now. Thanks! Thank you! Please cc me in the PR, I am interested in that change. --

[GitHub] [beam] aaltay commented on pull request #11624: [BEAM-9767] Make streaming_wordcount use a test timeout and increase from 5s to 30s

aaltay commented on pull request #11624: URL: https://github.com/apache/beam/pull/11624#issuecomment-625388635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [beam] tysonjh commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

tysonjh commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r421649639 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRuleSets.java ## @@ -133,7 +134,7 @@ /

[GitHub] [beam] tysonjh commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

tysonjh commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r421648744 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,157 @@ +/* +

[GitHub] [beam] Hannah-Jiang commented on pull request #11557: [BEAM-9845] Stage artifacts over expansion service.

Hannah-Jiang commented on pull request #11557: URL: https://github.com/apache/beam/pull/11557#issuecomment-625357723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-625351289 Well, I didn't see any principal "against" to make FluentBackoff public but I'm not sure that it will be moved to another package or `util` will become public soon. So for

[GitHub] [beam] mxm commented on a change in pull request #11608: Migration of Jekylle to Hugo

mxm commented on a change in pull request #11608: URL: https://github.com/apache/beam/pull/11608#discussion_r421619626 ## File path: website/src/_includes/flink_java_pipeline_options.html ## @@ -1,150 +0,0 @@ -

[GitHub] [beam] mxm commented on a change in pull request #11608: Migration of Jekylle to Hugo

mxm commented on a change in pull request #11608: URL: https://github.com/apache/beam/pull/11608#discussion_r421619626 ## File path: website/src/_includes/flink_java_pipeline_options.html ## @@ -1,150 +0,0 @@ -

[GitHub] [beam] kamilwu commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

kamilwu commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625344942 Run Website_Stage_GSC PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] mxm commented on a change in pull request #11608: Migration of Jekylle to Hugo

mxm commented on a change in pull request #11608: URL: https://github.com/apache/beam/pull/11608#discussion_r421617696 ## File path: website/src/_includes/flink_java_pipeline_options.html ## @@ -1,150 +0,0 @@ -

[GitHub] [beam] kamilwu commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

kamilwu commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-625344823 Run Website PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >