[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427758607 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1207,15 +1224,51 @@ private void output(Instant

[GitHub] [beam] chamikaramj commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

chamikaramj commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631254015 Have you run the linkage checker ? https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades

[GitHub] [beam] chamikaramj commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

chamikaramj commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631252696 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

chamikaramj commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631252638 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on a change in pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

chamikaramj commented on a change in pull request #11740: URL: https://github.com/apache/beam/pull/11740#discussion_r427755500 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -310,15 +312,15 @@ def __init__( environment_payload =

[GitHub] [beam] chamikaramj commented on pull request #11757: [BEAM-8019] Clarifies Dataflow execution environment model

chamikaramj commented on pull request #11757: URL: https://github.com/apache/beam/pull/11757#issuecomment-631251258 R: @robertwb @ihji This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj opened a new pull request #11757: [BEAM-8019] Clarifies Dataflow execution environment model

chamikaramj opened a new pull request #11757: URL: https://github.com/apache/beam/pull/11757 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] boyuanzz commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427750709 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1207,15 +1224,51 @@ private void output(Instant

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427738041 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1207,15 +1224,51 @@ private void output(Instant

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427737289 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -962,16 +971,25 @@ private Progress getProgress() {

[GitHub] [beam] tysonjh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

tysonjh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r427471127 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to

[GitHub] [beam] pabloem commented on pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

pabloem commented on pull request #11596: URL: https://github.com/apache/beam/pull/11596#issuecomment-631224035 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-631223098 Run Java Flink PortableValidatesRunner Streaming This is an automated message from the Apache Git Service. To

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-631223003 Run Java Flink PortableValidatesRunner Batch This is an automated message from the Apache Git Service. To

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-631220097 Run Java Flink PortableValidatesRunner Batch This is an automated message from the Apache Git Service. To

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-631219846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] boyuanzz closed pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz closed pull request #11756: URL: https://github.com/apache/beam/pull/11756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] boyuanzz commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427720451 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -962,16 +971,25 @@ private Progress getProgress() {

[GitHub] [beam] henryken commented on pull request #11734: [BEAM-9679] Add Core Transforms section / GroupByKey lesson to the Go SDK katas

henryken commented on pull request #11734: URL: https://github.com/apache/beam/pull/11734#issuecomment-631216779 @damondouglas, please help to update the Stepik course. Afterwards, we can merge this PR. This is an

[GitHub] [beam] jaketf edited a comment on pull request #11339: [BEAM-9468] Fhir io

jaketf edited a comment on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-631203002 The issue with FhirIOReadIT seems to be some misuse of

[GitHub] [beam] chamikaramj commented on a change in pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

chamikaramj commented on a change in pull request #11360: URL: https://github.com/apache/beam/pull/11360#discussion_r427718773 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -0,0 +1,735 @@ +/* + * Licensed to the

[GitHub] [beam] jaketf edited a comment on pull request #11339: [BEAM-9468] Fhir io

jaketf edited a comment on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-631203002 The issue with FhirIOReadIT seems to be some misuse of

[GitHub] [beam] boyuanzz commented on pull request #11715: [BEAM-9977] Implement GrowableOffsetRangeTracker

boyuanzz commented on pull request #11715: URL: https://github.com/apache/beam/pull/11715#issuecomment-631204566 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] jaketf edited a comment on pull request #11339: [BEAM-9468] Fhir io

jaketf edited a comment on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-631203002 The issue with FhirIOReadIT seems to be some misuse of

[GitHub] [beam] jaketf commented on pull request #11339: [BEAM-9468] Fhir io

jaketf commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-631203002 The issue with FhirIOReadIT seems to be some misuse of [TestPubsubSignal](https://beam.apache.org/releases/javadoc/2.20.0/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.html)

[GitHub] [beam] henryken commented on pull request #11736: Katas - Convert task description from HTML to Markdown

henryken commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-631201222 Thanks @pabloem! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

pabloem commented on pull request #11596: URL: https://github.com/apache/beam/pull/11596#issuecomment-631189470 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

pabloem commented on pull request #11596: URL: https://github.com/apache/beam/pull/11596#issuecomment-631189422 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427686703 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427686703 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427686974 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -427,29 +454,75 @@ private Message

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427686703 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] santhh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

santhh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r427684818 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java ## @@ -0,0 +1,215 @@ +/* + * Licensed to the

[GitHub] [beam] santhh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

santhh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r427683846 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java ## @@ -0,0 +1,215 @@ +/* + * Licensed to the

[GitHub] [beam] santhh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

santhh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r427683019 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the

[GitHub] [beam] y1chi opened a new pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi opened a new pull request #11756: URL: https://github.com/apache/beam/pull/11756 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] y1chi commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-631169795 R: @boyuanzz This is ready for review. This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] santhh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

santhh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r427681778 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPReidentifyText.java ## @@ -0,0 +1,206 @@ +/* + * Licensed to the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

TheNeuralBit commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427681580 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] santhh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

santhh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r427681156 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPReidentifyText.java ## @@ -0,0 +1,206 @@ +/* + * Licensed to the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11755: [BEAM-10038] Add script to mass-comment Jenkins triggers on PR

TheNeuralBit commented on a change in pull request #11755: URL: https://github.com/apache/beam/pull/11755#discussion_r427681057 ## File path: release/src/main/scripts/mass_comment.py ## @@ -0,0 +1,141 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427678727 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] y1chi closed pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi closed pull request #11753: URL: https://github.com/apache/beam/pull/11753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427678033 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] omarismail94 commented on pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on pull request #11754: URL: https://github.com/apache/beam/pull/11754#issuecomment-631165775 > Thank you @omarismail94! > > We should probably be running this continuously to make sure we don't break it again. Would you mind adding the gradle task for this to

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427678033 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427678033 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] omarismail94 commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427677681 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] ibzib opened a new pull request #11755: [BEAM-10038] Add script to mass-comment Jenkins triggers on PR

ibzib opened a new pull request #11755: URL: https://github.com/apache/beam/pull/11755 @Ardagan wrote most of this script a while back, I just generalized it a bit. Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

TheNeuralBit commented on a change in pull request #11754: URL: https://github.com/apache/beam/pull/11754#discussion_r427674472 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java ## @@ -66,38 +68,47 @@ public

[GitHub] [beam] omarismail94 opened a new pull request #11754: [BEAM-10037] BeamSqlExample.java fails to build

omarismail94 opened a new pull request #11754: URL: https://github.com/apache/beam/pull/11754 R: @TheNeuralBit In the `BeamSqlExample.java` class, the instructions state that to run the example, use: `./gradlew :sdks:java:extensions:sql:runBasicExample`. I tried

[GitHub] [beam] y1chi commented on pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi commented on pull request #11753: URL: https://github.com/apache/beam/pull/11753#issuecomment-631157957 Sorry, I should have marked PR as draft as I'm still testing it. Expecting a couple more minor fixes. This is an

[GitHub] [beam] boyuanzz commented on pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on pull request #11753: URL: https://github.com/apache/beam/pull/11753#issuecomment-631153847 Run Java Flink PortableValidatesRunner Batch This is an automated message from the Apache Git Service. To

[GitHub] [beam] ibzib commented on pull request #11403: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

ibzib commented on pull request #11403: URL: https://github.com/apache/beam/pull/11403#issuecomment-631152816 test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] ibzib commented on pull request #11403: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

ibzib commented on pull request #11403: URL: https://github.com/apache/beam/pull/11403#issuecomment-631149865 test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11701: [BEAM-9899] Fix some issues around storing schema `id` on user types

TheNeuralBit commented on a change in pull request #11701: URL: https://github.com/apache/beam/pull/11701#discussion_r427655332 ## File path: sdks/python/apache_beam/coders/row_coder.py ## @@ -134,19 +134,18 @@ def __init__(self, schema, components): def

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427654986 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -472,24 +551,118 @@ public void

[GitHub] [beam] boyuanzz commented on a change in pull request #11715: [BEAM-9977] Implement GrowableOffsetRangeTracker

boyuanzz commented on a change in pull request #11715: URL: https://github.com/apache/beam/pull/11715#discussion_r427654115 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java ## @@ -0,0 +1,115 @@ +/* + *

[GitHub] [beam] boyuanzz commented on pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

boyuanzz commented on pull request #11753: URL: https://github.com/apache/beam/pull/11753#issuecomment-631136771 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on pull request #11642: Replace call to .checkpoint() in SDF direct runner to .try_claim(0)

boyuanzz commented on pull request #11642: URL: https://github.com/apache/beam/pull/11642#issuecomment-631136611 Hi Ashwin, do you want me to start to review now? This is an automated message from the Apache Git Service. To

[GitHub] [beam] lukecwik commented on pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

lukecwik commented on pull request #11753: URL: https://github.com/apache/beam/pull/11753#issuecomment-631133371 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem merged pull request #11736: Katas - Convert task description from HTML to Markdown

pabloem merged pull request #11736: URL: https://github.com/apache/beam/pull/11736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11736: Katas - Convert task description from HTML to Markdown

pabloem commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-63117 alright RAT passing. Merging... This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on a change in pull request #11701: [BEAM-9899] Fix some issues around storing schema `id` on user types

robertwb commented on a change in pull request #11701: URL: https://github.com/apache/beam/pull/11701#discussion_r427648180 ## File path: sdks/python/apache_beam/coders/row_coder.py ## @@ -134,19 +134,18 @@ def __init__(self, schema, components): def encode_to_stream(self,

[GitHub] [beam] chamikaramj commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

chamikaramj commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631132405 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robertwb commented on a change in pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

robertwb commented on a change in pull request #11740: URL: https://github.com/apache/beam/pull/11740#discussion_r427646588 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -310,15 +312,15 @@ def __init__( environment_payload =

[GitHub] [beam] aaltay commented on a change in pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

aaltay commented on a change in pull request #11744: URL: https://github.com/apache/beam/pull/11744#discussion_r427645484 ## File path: sdks/python/apache_beam/runners/portability/portable_runner.py ## @@ -164,10 +165,19 @@ def add_runner_options(parser): all_options =

[GitHub] [beam] aaltay commented on a change in pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

aaltay commented on a change in pull request #11744: URL: https://github.com/apache/beam/pull/11744#discussion_r427645484 ## File path: sdks/python/apache_beam/runners/portability/portable_runner.py ## @@ -164,10 +165,19 @@ def add_runner_options(parser): all_options =

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427643888 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -415,10 +423,29 @@ private Message

[GitHub] [beam] tysonjh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

tysonjh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r427403454 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java ## @@ -0,0 +1,215 @@ +/* + * Licensed to the

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427643387 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -415,10 +423,29 @@ private Message

[GitHub] [beam] lukecwik commented on pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

lukecwik commented on pull request #11753: URL: https://github.com/apache/beam/pull/11753#issuecomment-631126898 R: @boyuanzz This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] lukecwik commented on pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

lukecwik commented on pull request #11753: URL: https://github.com/apache/beam/pull/11753#issuecomment-631126805 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427641350 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -415,10 +423,29 @@ private Message

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427640873 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -415,10 +423,29 @@ private Message

[GitHub] [beam] jaketf commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

jaketf commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427640111 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -415,10 +423,29 @@ private Message

[GitHub] [beam] lukecwik commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

lukecwik commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427618071 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -415,10 +423,29 @@ private

[GitHub] [beam] lukecwik commented on a change in pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

lukecwik commented on a change in pull request #11596: URL: https://github.com/apache/beam/pull/11596#discussion_r427616856 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -415,10 +423,29 @@ private

[GitHub] [beam] pabloem commented on pull request #11736: Katas - Convert task description from HTML to Markdown

pabloem commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-631112295 I don't know why the SQL precommit is running : ) All i care about is the RAT precommit - which should pass...

[GitHub] [beam] pabloem commented on pull request #11736: Katas - Convert task description from HTML to Markdown

pabloem commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-63401 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

chamikaramj commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631105532 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

chamikaramj commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631105651 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] veblush commented on a change in pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

veblush commented on a change in pull request #11651: URL: https://github.com/apache/beam/pull/11651#discussion_r427623777 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -489,6 +490,7 @@ class BeamModulePlugin implements Plugin {

[GitHub] [beam] y1chi opened a new pull request #11753: [BEAM-9603] Add timer family support to FnApiDoFnRunner

y1chi opened a new pull request #11753: URL: https://github.com/apache/beam/pull/11753 Implemented the missing pieces in FnApiDoFnRunner to support timer family. Also refactored a few function signatures to avoid confusion. Thank you for your

[GitHub] [beam] amaliujia merged pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

amaliujia merged pull request #11737: URL: https://github.com/apache/beam/pull/11737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-631081683 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj merged pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

chamikaramj merged pull request #11740: URL: https://github.com/apache/beam/pull/11740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

TheNeuralBit commented on a change in pull request #11744: URL: https://github.com/apache/beam/pull/11744#discussion_r427592587 ## File path: sdks/python/apache_beam/runners/portability/portable_runner.py ## @@ -164,10 +165,19 @@ def add_runner_options(parser):

[GitHub] [beam] chamikaramj commented on pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

chamikaramj commented on pull request #11740: URL: https://github.com/apache/beam/pull/11740#issuecomment-631075979 Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

TheNeuralBit commented on a change in pull request #11744: URL: https://github.com/apache/beam/pull/11744#discussion_r427586062 ## File path: sdks/python/apache_beam/runners/portability/portable_runner.py ## @@ -164,10 +165,19 @@ def add_runner_options(parser):

[GitHub] [beam] tvalentyn commented on pull request #11707: [BEAM-9810] Add a Tox (precommit) suite for Python 3.8

tvalentyn commented on pull request #11707: URL: https://github.com/apache/beam/pull/11707#issuecomment-631067325 The code change LGTM, thank you. We need to address BEAM-9994 before we can merge this. Would you have time to investigate & recommend a solution for that issue, @kamilwu ?

[GitHub] [beam] veblush commented on a change in pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

veblush commented on a change in pull request #11651: URL: https://github.com/apache/beam/pull/11651#discussion_r427581972 ## File path: sdks/java/io/google-cloud-platform/build.gradle ## @@ -56,11 +56,13 @@ dependencies { compile library.java.google_http_client compile

[GitHub] [beam] veblush commented on a change in pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

veblush commented on a change in pull request #11651: URL: https://github.com/apache/beam/pull/11651#discussion_r427581456 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -489,6 +490,7 @@ class BeamModulePlugin implements Plugin {

[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

veblush commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631065488 It turns out that `grpc-netty` and `grpc-netty-shaded` can coexist. So I'm trying to list those new dependencies in the build file to make gRPC component have the same version.

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11529: [BEAM-9822] Simplify pipeline when batching is disabled.

TheNeuralBit commented on a change in pull request #11529: URL: https://github.com/apache/beam/pull/11529#discussion_r427580795 ## File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOWriteTest.java ## @@ -263,6 +263,17 @@

[GitHub] [beam] chamikaramj commented on a change in pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

chamikaramj commented on a change in pull request #11651: URL: https://github.com/apache/beam/pull/11651#discussion_r427580442 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -489,6 +490,7 @@ class BeamModulePlugin implements Plugin

[GitHub] [beam] pabloem commented on pull request #11596: [BEAM-9856] Optimization/hl7v2 io list messages

pabloem commented on pull request #11596: URL: https://github.com/apache/beam/pull/11596#issuecomment-631064445 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-631062751 @chamikaramj All done, PTAL ;) This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] DariuszAniszewski commented on a change in pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

DariuszAniszewski commented on a change in pull request #11360: URL: https://github.com/apache/beam/pull/11360#discussion_r427577999 ## File path: sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/read/SnowflakeIOReadTest.java ## @@ -0,0 +1,268

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11529: [BEAM-9822] Simplify pipeline when batching is disabled.

TheNeuralBit commented on a change in pull request #11529: URL: https://github.com/apache/beam/pull/11529#discussion_r427576985 ## File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOWriteTest.java ## @@ -263,6 +263,17 @@

  1   2   3   >