[GitHub] [beam] rionmonster commented on pull request #11944: [BEAM-10210] Beam Katas for Kotlin Blog Post

rionmonster commented on pull request #11944: URL: https://github.com/apache/beam/pull/11944#issuecomment-641711018 @henryken, Is there anything else needed on this front? I didn’t know how some of the website oriented changes like the blog worked and if I’d need to take someone

[GitHub] [beam] darshanj closed pull request #11965: [BEAM-9992] | use Sets transform in BeamSQL

darshanj closed pull request #11965: URL: https://github.com/apache/beam/pull/11965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] reubenvanammers commented on pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

reubenvanammers commented on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641689222 Updated PR in response to comments. This is an automated message from the Apache Git Service. To

[GitHub] [beam] robertwb merged pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

robertwb merged pull request #11932: URL: https://github.com/apache/beam/pull/11932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

pabloem commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-641677744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] darshanj opened a new pull request #11965: [BEAM-9992] | use Sets transform in BeamSQL

darshanj opened a new pull request #11965: URL: https://github.com/apache/beam/pull/11965 Remove Sets tranform in BeamSQL code. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-641674257 Thanks all for patiently reviewing this PR and providing valuable feedback. This is an automated message from

[GitHub] [beam] reubenvanammers commented on pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

reubenvanammers commented on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641671697 Thanks for the comments @TheNeuralBit. Yeah, I was planning on working on BEAM-7624 after this one.

[GitHub] [beam] reubenvanammers commented on a change in pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

reubenvanammers commented on a change in pull request #11955: URL: https://github.com/apache/beam/pull/11955#discussion_r437814700 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowJson.java ## @@ -185,18 +186,25 @@ private RowJsonDeserializer(Schema

[GitHub] [beam] amaliujia commented on pull request #11960: [BEAM-9999] Remove Gearpump runner.

amaliujia commented on pull request #11960: URL: https://github.com/apache/beam/pull/11960#issuecomment-641667621 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rezarokni commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

rezarokni commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437807053 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +131,267 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] rezarokni commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

rezarokni commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437806981 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +157,65 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] aaltay merged pull request #11851: [BEAM-10144] Update PipelineOptions snippets for best practices

aaltay merged pull request #11851: URL: https://github.com/apache/beam/pull/11851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641652552 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

pabloem commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-641652307 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] JustineKoa commented on pull request #11964: [BEAM-9987] added instruction for converting maven project to gradle

JustineKoa commented on pull request #11964: URL: https://github.com/apache/beam/pull/11964#issuecomment-641651721 Review: @angoenka This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] JustineKoa opened a new pull request #11964: [BEAM-9987] added instruction for converting maven project to gradle

JustineKoa opened a new pull request #11964: URL: https://github.com/apache/beam/pull/11964 Added instructions for converting the example WordCount Maven project generated using the generate:archetype into a Gradle project. I've attached images of what it looks like when I run it locally.

[GitHub] [beam] robertwb commented on pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

robertwb commented on pull request #11932: URL: https://github.com/apache/beam/pull/11932#issuecomment-641650830 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robertwb commented on pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

robertwb commented on pull request #11932: URL: https://github.com/apache/beam/pull/11932#issuecomment-641650721 sdks:java:io:rabbitmq:test timed out This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] tvalentyn commented on pull request #11946: Fix VideoIntelligence IT tests

tvalentyn commented on pull request #11946: URL: https://github.com/apache/beam/pull/11946#issuecomment-641650596 I filed https://issues.apache.org/jira/browse/BEAM-10229 - is it already fixed by this change? This is an

[GitHub] [beam] TheNeuralBit commented on pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

TheNeuralBit commented on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641644986 FYI you can run `./gradlew spotlessApply` locally to apply required formatting changes. This is an

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

TheNeuralBit commented on a change in pull request #11955: URL: https://github.com/apache/beam/pull/11955#discussion_r437784412 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowJson.java ## @@ -362,6 +382,11 @@ private RowJsonSerializer(Schema schema) {

[GitHub] [beam] robertwb opened a new pull request #11963: Add relational GroupBy transform to Python.

robertwb opened a new pull request #11963: URL: https://github.com/apache/beam/pull/11963 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] robertwb commented on a change in pull request #11838: [BEAM-9322] Modify the TestStream to output a dict when no output_tags are specified

robertwb commented on a change in pull request #11838: URL: https://github.com/apache/beam/pull/11838#discussion_r437787906 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -291,10 +291,10 @@ def expand(self, pbegin): assert isinstance(pbegin,

[GitHub] [beam] rohdesamuel commented on a change in pull request #11838: [BEAM-9322] Modify the TestStream to output a dict when no output_tags are specified

rohdesamuel commented on a change in pull request #11838: URL: https://github.com/apache/beam/pull/11838#discussion_r437784983 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -291,10 +291,10 @@ def expand(self, pbegin): assert isinstance(pbegin,

[GitHub] [beam] TheNeuralBit commented on pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

TheNeuralBit commented on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641639457 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

TheNeuralBit commented on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641639519 Unfortunately only committers can trigger jenkins now :/ This is an automated message from the Apache Git

[GitHub] [beam] robertwb merged pull request #11901: Prototype schema-inferring Row constructor.

robertwb merged pull request #11901: URL: https://github.com/apache/beam/pull/11901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] apilloud commented on pull request #11957: [BEAM-10033] zetaSqlValueToJavaObject uses value.getType()

apilloud commented on pull request #11957: URL: https://github.com/apache/beam/pull/11957#issuecomment-641631947 Thanks! We have a bunch of nullness issues, investigating some of those is how I discovered this issue. This

[GitHub] [beam] reubenvanammers edited a comment on pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

reubenvanammers edited a comment on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641097493 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robinyqiu commented on pull request #11957: [BEAM-10033] zetaSqlValueToJavaObject uses value.getType()

robinyqiu commented on pull request #11957: URL: https://github.com/apache/beam/pull/11957#issuecomment-641627057 Well. Some tests are failing and I realized this turns out to be not that simple change. There are subtle differences between Beam schema and ZetaSQL struct that prevents this

[GitHub] [beam] aaltay commented on pull request #11851: [BEAM-10144] Update PipelineOptions snippets for best practices

aaltay commented on pull request #11851: URL: https://github.com/apache/beam/pull/11851#issuecomment-641621183 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rezarokni commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

rezarokni commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437764105 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +131,267 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] aaltay commented on pull request #11960: [BEAM-9999] Remove Gearpump runner.

aaltay commented on pull request #11960: URL: https://github.com/apache/beam/pull/11960#issuecomment-641619571 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rezarokni commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

rezarokni commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437762683 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +131,267 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] rezarokni commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

rezarokni commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437762165 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +131,267 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] rezarokni commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

rezarokni commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437760550 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +157,65 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] pabloem closed pull request #11850: [BEAM-1438] Allow 0 shards on WriteFiles streaming

pabloem closed pull request #11850: URL: https://github.com/apache/beam/pull/11850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641607885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] robertwb commented on a change in pull request #11901: Prototype schema-inferring Row constructor.

robertwb commented on a change in pull request #11901: URL: https://github.com/apache/beam/pull/11901#discussion_r437749540 ## File path: sdks/python/apache_beam/transforms/sql.py ## @@ -74,3 +77,8 @@ def __init__(self, query, dialect=None):

[GitHub] [beam] robertwb commented on a change in pull request #11901: Prototype schema-inferring Row constructor.

robertwb commented on a change in pull request #11901: URL: https://github.com/apache/beam/pull/11901#discussion_r437749425 ## File path: sdks/python/apache_beam/coders/row_coder.py ## @@ -82,8 +86,19 @@ def from_runner_api_parameter(schema, components, unused_context):

[GitHub] [beam] ibzib commented on pull request #11961: [BEAM-10225] Add log message when starting job server

ibzib commented on pull request #11961: URL: https://github.com/apache/beam/pull/11961#issuecomment-641605323 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pabloem commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

pabloem commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-641604325 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] pabloem commented on pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

pabloem commented on pull request #11950: URL: https://github.com/apache/beam/pull/11950#issuecomment-641604419 thanks. Looking once more... This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

pabloem commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-641604201 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641603355 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn opened a new pull request #11962: [BEAM-10227] Switches typing version modifier to python_full_version.

tvalentyn opened a new pull request #11962: URL: https://github.com/apache/beam/pull/11962 Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump

[GitHub] [beam] pabloem commented on pull request #11824: [BEAM-10101] Add HttpIO / HttpFileSystem (Python)

pabloem commented on pull request #11824: URL: https://github.com/apache/beam/pull/11824#issuecomment-641602134 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TheNeuralBit merged pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

TheNeuralBit merged pull request #11951: URL: https://github.com/apache/beam/pull/11951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] TheNeuralBit commented on pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

TheNeuralBit commented on pull request #11951: URL: https://github.com/apache/beam/pull/11951#issuecomment-641598227 Looks like SQL PostCommit finished successfully [including the new

[GitHub] [beam] annaqin418 opened a new pull request #11961: [BEAM-10225] Add log message when starting job server

annaqin418 opened a new pull request #11961: URL: https://github.com/apache/beam/pull/11961 R: @ibzib @robertwb Adds a log output message that clarifies when a newly-started job server is ready to receive jobs: `INFO org.apache.beam.runners.jobsubmission.JobServerDriver: Job

[GitHub] [beam] tysonjh opened a new pull request #11960: [BEAM-9999] Remove Gearpump runner.

tysonjh opened a new pull request #11960: URL: https://github.com/apache/beam/pull/11960 Remove Gearpump runner. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641588460 So, I think the last remaining issue was whether to have the `use_json_exports` flag or individual flags per columns. Are there other topics to discuss?

[GitHub] [beam] chamikaramj merged pull request #11928: [ BEAM-3788] Updates kafka.py pydocs

chamikaramj merged pull request #11928: URL: https://github.com/apache/beam/pull/11928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] chamikaramj commented on pull request #11928: [ BEAM-3788] Updates kafka.py pydocs

chamikaramj commented on pull request #11928: URL: https://github.com/apache/beam/pull/11928#issuecomment-641587073 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] ihji commented on a change in pull request #11930: [BEAM-10202] make cross-language testing scripts OSX-compatible

ihji commented on a change in pull request #11930: URL: https://github.com/apache/beam/pull/11930#discussion_r437722946 ## File path: sdks/python/scripts/run_expansion_services.sh ## @@ -133,4 +136,7 @@ case $STARTSTOP in fi ;; esac -flock -u 200 + +if [[

[GitHub] [beam] pabloem commented on a change in pull request #11702: [BEAM-9990] Add Conditional Update and Conditional Create to FhirIO

pabloem commented on a change in pull request #11702: URL: https://github.com/apache/beam/pull/11702#discussion_r437721434 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java ## @@ -155,17 +168,53 @@ *

[GitHub] [beam] pabloem commented on pull request #11850: [BEAM-1438] Allow 0 shards on WriteFiles streaming

pabloem commented on pull request #11850: URL: https://github.com/apache/beam/pull/11850#issuecomment-641570009 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem merged pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

pabloem merged pull request #11923: URL: https://github.com/apache/beam/pull/11923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

pabloem commented on pull request #11923: URL: https://github.com/apache/beam/pull/11923#issuecomment-641568293 thanks @chunyang This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r437719751 ## File path: sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py ## @@ -254,11 +256,36 @@ def test_big_query_new_types(self):

[GitHub] [beam] amaliujia commented on pull request #11821: [BEAM-10097, BEAM-5982, BEAM-3080] Use primitive views directly instead of transforming KV> to the view type via a naive m

amaliujia commented on pull request #11821: URL: https://github.com/apache/beam/pull/11821#issuecomment-641558615 Thanks for adding me as a reviewer. I tried to go through this PR and couldn't come up with valuable comments. (in fact, it was a good learning process for me to read these

[GitHub] [beam] robertwb commented on a change in pull request #11838: [BEAM-9322] Modify the TestStream to output a dict when no output_tags are specified

robertwb commented on a change in pull request #11838: URL: https://github.com/apache/beam/pull/11838#discussion_r437702523 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -291,10 +291,10 @@ def expand(self, pbegin): assert isinstance(pbegin,

[GitHub] [beam] robertwb commented on pull request #11838: [BEAM-9322] Modify the TestStream to output a dict when no output_tags are specified

robertwb commented on pull request #11838: URL: https://github.com/apache/beam/pull/11838#issuecomment-641555415 R: @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] stale[bot] closed pull request #10958: [BEAM] Submitting final communication strategy

stale[bot] closed pull request #10958: URL: https://github.com/apache/beam/pull/10958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] stale[bot] commented on pull request #10958: [BEAM] Submitting final communication strategy

stale[bot] commented on pull request #10958: URL: https://github.com/apache/beam/pull/10958#issuecomment-641555161 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[GitHub] [beam] udim commented on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

udim commented on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-641543855 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] TheNeuralBit commented on pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

TheNeuralBit commented on pull request #11951: URL: https://github.com/apache/beam/pull/11951#issuecomment-641543407 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

TheNeuralBit commented on pull request #11951: URL: https://github.com/apache/beam/pull/11951#issuecomment-641540376 Run SQL Postcommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

TheNeuralBit commented on pull request #11951: URL: https://github.com/apache/beam/pull/11951#issuecomment-641540296 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robertwb commented on pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

robertwb commented on pull request #11932: URL: https://github.com/apache/beam/pull/11932#issuecomment-641534358 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia merged pull request #11958: [BEAM-10198] Roll back changes

amaliujia merged pull request #11958: URL: https://github.com/apache/beam/pull/11958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] amaliujia commented on pull request #11958: [BEAM-10198] Roll back changes

amaliujia commented on pull request #11958: URL: https://github.com/apache/beam/pull/11958#issuecomment-641521023 @ihji This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] sabhyankar commented on pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

sabhyankar commented on pull request #11950: URL: https://github.com/apache/beam/pull/11950#issuecomment-641500443 @pabloem Thanks for the quick reviews! I have pushed a couple of commits with the mods you requested. This

[GitHub] [beam] sabhyankar commented on a change in pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

sabhyankar commented on a change in pull request #11950: URL: https://github.com/apache/beam/pull/11950#discussion_r437640982 ## File path: sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkIO.java ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache

[GitHub] [beam] pabloem commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

pabloem commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-641496977 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on pull request #11954: [Do not merge] Add a unit test exposing BEAM-10217

tvalentyn commented on pull request #11954: URL: https://github.com/apache/beam/pull/11954#issuecomment-641495342 The tests failed on Py3.6. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aaltay edited a comment on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

aaltay edited a comment on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-641482606 This looks nice. I have a few clarifiying questions: on pull_request: This is good. Would it trigger on every pull request. This may not be needed. I am not sure

[GitHub] [beam] aaltay commented on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

aaltay commented on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-641482606 This looks nice. I have a few clarifiying questions: on pull_request: This is good. Would it trigger on every pull request. This may not be needed. I am not sure what GH

[GitHub] [beam] aaltay commented on pull request #11851: [BEAM-10144] Update PipelineOptions snippets for best practices

aaltay commented on pull request #11851: URL: https://github.com/apache/beam/pull/11851#issuecomment-641482781 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] davidcavazos commented on pull request #11851: [BEAM-10144] Update PipelineOptions snippets for best practices

davidcavazos commented on pull request #11851: URL: https://github.com/apache/beam/pull/11851#issuecomment-641474784 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] davidcavazos commented on pull request #11851: [BEAM-10144] Update PipelineOptions snippets for best practices

davidcavazos commented on pull request #11851: URL: https://github.com/apache/beam/pull/11851#issuecomment-641474131 Forgot to use `argv` to parse the pipeline options in `pipeline_options_local`. Tests should pass now.

[GitHub] [beam] sabhyankar commented on a change in pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

sabhyankar commented on a change in pull request #11950: URL: https://github.com/apache/beam/pull/11950#discussion_r437606598 ## File path: sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEvent.java ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache

[GitHub] [beam] amaliujia opened a new pull request #11958: fixup! roll back changes

amaliujia opened a new pull request #11958: URL: https://github.com/apache/beam/pull/11958 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] jaketf commented on a change in pull request #11702: [BEAM-9990] Add Conditional Update and Conditional Create to FhirIO

jaketf commented on a change in pull request #11702: URL: https://github.com/apache/beam/pull/11702#discussion_r437590913 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java ## @@ -155,17 +168,53 @@ *

[GitHub] [beam] robinyqiu opened a new pull request #11957: [BEAM-10033] zetaSqlValueToJavaObject uses value.getType()

robinyqiu opened a new pull request #11957: URL: https://github.com/apache/beam/pull/11957 R: @apilloud Post-Commit Tests Status (on master branch) Lang | SDK | Apex |

[GitHub] [beam] robertwb merged pull request #11940: [BEAM-6215] Additional tests for FlatMap label.

robertwb merged pull request #11940: URL: https://github.com/apache/beam/pull/11940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb commented on pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

robertwb commented on pull request #11932: URL: https://github.com/apache/beam/pull/11932#issuecomment-641449939 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

aaltay commented on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-641409860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] lukecwik merged pull request #11941: [BEAM-2939] Fix splittable DoFn lifecycle.

lukecwik merged pull request #11941: URL: https://github.com/apache/beam/pull/11941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lukecwik commented on a change in pull request #11941: [BEAM-2939] Fix splittable DoFn lifecycle.

lukecwik commented on a change in pull request #11941: URL: https://github.com/apache/beam/pull/11941#discussion_r436891532 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -193,7 +193,21 @@ bundleFinalizer);

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11901: Prototype schema-inferring Row constructor.

TheNeuralBit commented on a change in pull request #11901: URL: https://github.com/apache/beam/pull/11901#discussion_r437536115 ## File path: sdks/python/apache_beam/transforms/sql.py ## @@ -74,3 +77,8 @@ def __init__(self, query, dialect=None):

[GitHub] [beam] iemejia commented on pull request #11909: [BEAM-8134] Grafana dashboards for Nexmark tests

iemejia commented on pull request #11909: URL: https://github.com/apache/beam/pull/11909#issuecomment-641060650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-640562379 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] amaliujia commented on a change in pull request #11948: [BEAM-10213] @Ignore: fix the test for testCastToDateWithCase.

amaliujia commented on a change in pull request #11948: URL: https://github.com/apache/beam/pull/11948#discussion_r436967724 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -3565,19

[GitHub] [beam] chamikaramj commented on a change in pull request #11834: [BEAM-10117] Correct erroneous Job Failed message

chamikaramj commented on a change in pull request #11834: URL: https://github.com/apache/beam/pull/11834#discussion_r436891884 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java ## @@ -137,8 +137,8 @@ void

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r435359001 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java ## @@ -906,19 +955,110 @@ public void

[GitHub] [beam] tvalentyn opened a new pull request #11954: [Do not merge] Add a unit test exposing BEAM-10217

tvalentyn opened a new pull request #11954: URL: https://github.com/apache/beam/pull/11954 Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink |

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r436922850 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache

[GitHub] [beam] robinyqiu commented on a change in pull request #11948: [BEAM-10213] @Ignore: fix the test for testCastToDateWithCase.

robinyqiu commented on a change in pull request #11948: URL: https://github.com/apache/beam/pull/11948#discussion_r436981137 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -3587,11

  1   2   >