kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642181079
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
ibzib commented on pull request #11949:
URL: https://github.com/apache/beam/pull/11949#issuecomment-642180751
> Do you think it's worth moving the version compatibility table lower in
case people want to see what changes when they toggle the tab? It's kind of out
of place here anyway.
amaliujia commented on pull request #11971:
URL: https://github.com/apache/beam/pull/11971#issuecomment-642176244
R: @robinyqiu
This is an automated message from the Apache Git Service.
To respond to the message, please log
amaliujia opened a new pull request #11971:
URL: https://github.com/apache/beam/pull/11971
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
udim commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642175471
> Seeing a failure in
PortableRunnerTestWithExternalEnv.test_error_traceback_includes_user_code, not
sure if related.
https://issues.apache.org/jira/browse/BEAM-8878
robertwb commented on pull request #11949:
URL: https://github.com/apache/beam/pull/11949#issuecomment-642170460
Clarified the tabs selection. (Do you think it's worth moving the version
compatibility table lower in case people want to see what changes when they
toggle the tab? It's kind
rehmanmuradali commented on a change in pull request #11924:
URL: https://github.com/apache/beam/pull/11924#discussion_r438307621
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
rehmanmuradali commented on a change in pull request #11924:
URL: https://github.com/apache/beam/pull/11924#discussion_r438307437
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##
@@ -4040,7 +4043,8 @@ public void onTimer(
rehmanmuradali commented on a change in pull request #11924:
URL: https://github.com/apache/beam/pull/11924#discussion_r438307281
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##
@@ -3938,10 +3939,11 @@ public void
rehmanmuradali commented on a change in pull request #11924:
URL: https://github.com/apache/beam/pull/11924#discussion_r438306969
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
tvalentyn commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642164503
Seeing a failure in
PortableRunnerTestWithExternalEnv.test_error_traceback_includes_user_code, not
sure if related.
The change LGTM and verified that it addresses
robertwb commented on a change in pull request #11765:
URL: https://github.com/apache/beam/pull/11765#discussion_r438299971
##
File path: sdks/python/apache_beam/transforms/ptransform.py
##
@@ -270,11 +256,19 @@ def get_named_nested_pvalues(pvalueish):
tagged_values =
amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-642159934
I will also try to run this PR against internal test suite since it is a big
change.
This is an automated
robertwb commented on a change in pull request #11894:
URL: https://github.com/apache/beam/pull/11894#discussion_r438299065
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
##
@@ -377,11 +377,6 @@ def process_timer(
robertwb commented on pull request #11838:
URL: https://github.com/apache/beam/pull/11838#issuecomment-642155990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #11969:
URL: https://github.com/apache/beam/pull/11969#issuecomment-642155193
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on a change in pull request #11916:
URL: https://github.com/apache/beam/pull/11916#discussion_r438296283
##
File path: sdks/python/apache_beam/transforms/userstate_test.py
##
@@ -452,6 +459,40 @@ def clear_values(self,
robertwb commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r438291777
##
File path: sdks/python/apache_beam/transforms/combiners_test.py
##
@@ -105,6 +109,16 @@ def test_builtin_combines(self):
purbanow edited a comment on pull request #11794:
URL: https://github.com/apache/beam/pull/11794#issuecomment-642150480
Hey @RyanSkraba , We answered for all your comments. Will you find a moment
to check again ?
This is
purbanow edited a comment on pull request #11794:
URL: https://github.com/apache/beam/pull/11794#issuecomment-642150480
Hey @RyanSkraba , We answered fo all your comments. Will you find a moment
to check again ?
This is an
purbanow commented on pull request #11794:
URL: https://github.com/apache/beam/pull/11794#issuecomment-642150480
Hey @RyanSkraba , will you find a moment to check again ?
This is an automated message from the Apache Git
kkucharc commented on a change in pull request #11794:
URL: https://github.com/apache/beam/pull/11794#discussion_r438289586
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -447,6 +494,346 @@ public void
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144427
Run Dataflow Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144324
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144102
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
tvalentyn merged pull request #11962:
URL: https://github.com/apache/beam/pull/11962
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ibzib merged pull request #11961:
URL: https://github.com/apache/beam/pull/11961
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tvalentyn commented on a change in pull request #11970:
URL: https://github.com/apache/beam/pull/11970#discussion_r438270807
##
File path: sdks/python/container/boot.go
##
@@ -38,7 +38,7 @@ import (
)
var (
- acceptableWhlSpecs =
tvalentyn commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-642131353
Run Python DockerBuild PreCommit
This is an automated message from the Apache Git Service.
To respond to the
tvalentyn commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-642131178
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-642130988
I think Jenkins hooks currently require a comment from a committer to get
triggered.
This is an automated
iemejia merged pull request #11909:
URL: https://github.com/apache/beam/pull/11909
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642116959
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kennknowles merged pull request #11820:
URL: https://github.com/apache/beam/pull/11820
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kennknowles commented on pull request #11820:
URL: https://github.com/apache/beam/pull/11820#issuecomment-642121612
Thanks for the review! Definitely made this simpler, better, more focused.
This is an automated message from
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642120033
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642119197
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642119592
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642116959
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
tysonjh commented on pull request #11960:
URL: https://github.com/apache/beam/pull/11960#issuecomment-642101579
> Looks like you have caught all the places. LGTM
Thanks Maximilian!
This is an automated message from
tysonjh commented on pull request #11960:
URL: https://github.com/apache/beam/pull/11960#issuecomment-642101341
R: @aaltay
This is an automated message from the Apache Git Service.
To respond to the message, please log on
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-642096389
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642093374
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642081794
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
henryken commented on pull request #11944:
URL: https://github.com/apache/beam/pull/11944#issuecomment-642079721
That looks good to me!
This is an automated message from the Apache Git Service.
To respond to the message,
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642072375
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
rionmonster commented on pull request #11944:
URL: https://github.com/apache/beam/pull/11944#issuecomment-642066925
@henryken
Yup, I tested through yesterday evening and things look as expected on my
local environment after building via Hugo:
lazylynx commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-642065184
`beam_PreCommit_Python_DockerBuild` is not working now?
This is an automated message from the Apache Git
lazylynx commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-642064890
R: @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the message, please log
lazylynx opened a new pull request #11970:
URL: https://github.com/apache/beam/pull/11970
Accept Py3 wheels in SDK harness container.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642060169
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tysonjh edited a comment on pull request #11960:
URL: https://github.com/apache/beam/pull/11960#issuecomment-642048043
R: @mxm
Are you able to review this for me please?
This is an automated message from the Apache
tysonjh commented on pull request #11960:
URL: https://github.com/apache/beam/pull/11960#issuecomment-642048043
R: @mxm
Are you able to review this for me?
This is an automated message from the Apache Git Service.
To
lastomato opened a new pull request #11969:
URL: https://github.com/apache/beam/pull/11969
…now that the schamatized parser is available publicly. Also removed a few
methods that are not used anywhere.
R: @pabloem @jaketf
Thank you for your
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642037822
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641927471
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642025383
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642025383
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642025600
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TobKed opened a new pull request #11968:
URL: https://github.com/apache/beam/pull/11968
dependent on https://github.com/apache/beam/pull/11877
Subtask of [BEAM-9388](https://issues.apache.org/jira/browse/BEAM-9388)
Example GitHub Action runs available on my fork:
TobKed edited a comment on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-641886596
@aaltay thank you for review. Answers for your questions:
> on pull_request:
> Can we trigger this with a phrase? And/Or limit it to python changes?
I
henryken commented on pull request #11944:
URL: https://github.com/apache/beam/pull/11944#issuecomment-641935550
Have you tested the blog post on your local?
There should be nothing extra you need to do. The build process should take
care of it once it gets merged.
Having
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641927471
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11909:
URL: https://github.com/apache/beam/pull/11909#issuecomment-641926095
FYI: https://github.com/apache/beam/pull/11956
This is an automated message from the Apache Git Service.
To
kamilwu commented on pull request #11909:
URL: https://github.com/apache/beam/pull/11909#issuecomment-641922547
> We should definitely have shorter views by default but stored data should
not disapear if there are no technical constraints that force us to do so
Ok, makes sense to
TobKed commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-641886596
@aaltay thank you for review. Answers for your questions:
> on pull_request:
> Can we trigger this with a phrase? And/Or limit it to python changes?
I added
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641867173
Run Spark Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641866913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641865785
Run Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641865155
Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641865155
Direct Runner Nexmark Tests
This is an automated message from the Apache Git Service.
To respond to the message,
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641864568
Run Java TextIO Performance Test
This is an automated message from the Apache Git Service.
To respond to the
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-641853251
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kamilwu commented on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-641851529
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nielm commented on pull request #11570:
URL: https://github.com/apache/beam/pull/11570#issuecomment-641849548
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
darshanj opened a new pull request #11967:
URL: https://github.com/apache/beam/pull/11967
Use Sets transforms from BeamSQL code
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
darshanj commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-641748346
R: @amaliujia
This is an automated message from the Apache Git Service.
To respond to the message, please log
101 - 177 of 177 matches
Mail list logo
