[GitHub] [beam] y1chi commented on pull request #12191: [BEAM-10419] Skip FhirIORead integration test due to flakiness

y1chi commented on pull request #12191: URL: https://github.com/apache/beam/pull/12191#issuecomment-655296773 R: @aaltay CC: @jaketf This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

pabloem commented on pull request #12151: URL: https://github.com/apache/beam/pull/12151#issuecomment-655286584 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

pabloem commented on pull request #12151: URL: https://github.com/apache/beam/pull/12151#issuecomment-655286374 sorry! Yes, I'll take a look.. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] tvalentyn commented on pull request #12194: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

tvalentyn commented on pull request #12194: URL: https://github.com/apache/beam/pull/12194#issuecomment-655260089 Run Samza ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] tvalentyn commented on pull request #12194: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

tvalentyn commented on pull request #12194: URL: https://github.com/apache/beam/pull/12194#issuecomment-655259903 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] tvalentyn commented on pull request #12194: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

tvalentyn commented on pull request #12194: URL: https://github.com/apache/beam/pull/12194#issuecomment-655257992 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] lukecwik edited a comment on pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik edited a comment on pull request #12192: URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038 R: @robertwb @chamikaramj Progress reporting needs to be able to see which window out of how many are being processed. Splitting needs to be able to see which

[GitHub] [beam] tvalentyn commented on pull request #12194: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

tvalentyn commented on pull request #12194: URL: https://github.com/apache/beam/pull/12194#issuecomment-655248020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] lukecwik closed pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik closed pull request #12192: URL: https://github.com/apache/beam/pull/12192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] tvalentyn opened a new pull request #12194: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

tvalentyn opened a new pull request #12194: URL: https://github.com/apache/beam/pull/12194 You can run many tests automatically using release/src/main/scripts/mass_comment.py. This is an automated message from the Apache

[GitHub] [beam] bamnet commented on pull request #12193: [BEAM-8472] get default GCP region option (Go)

bamnet commented on pull request #12193: URL: https://github.com/apache/beam/pull/12193#issuecomment-655241403 R: @lostluck /fyi @ibzib This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] lukecwik edited a comment on pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik edited a comment on pull request #12192: URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038 R: @robertwb @chamikaramj Progress reporting needs to be able to see which window out of how many are being processed. Splitting needs to be able to see which

[GitHub] [beam] danielxjd commented on a change in pull request #12106: [BEAM-9792] Fixing the IOException handling in InsertAll for BigQuery

danielxjd commented on a change in pull request #12106: URL: https://github.com/apache/beam/pull/12106#discussion_r451244400 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java ## @@ -893,6 +906,19 @@

[GitHub] [beam] bamnet opened a new pull request #12193: [BEAM-8472] get default GCP region option (Go)

bamnet opened a new pull request #12193: URL: https://github.com/apache/beam/pull/12193 If the region flag is unset, attempt to extract a region from $CLOUDSDK_COMPUTE_REGION and the gcloud SDK. This mirrors the

[GitHub] [beam] lukecwik commented on a change in pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik commented on a change in pull request #12192: URL: https://github.com/apache/beam/pull/12192#discussion_r451243088 ## File path: sdks/python/apache_beam/runners/direct/sdf_direct_runner.py ## @@ -464,19 +461,15 @@ def initiate_checkpoint(): with

[GitHub] [beam] lukecwik commented on a change in pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik commented on a change in pull request #12192: URL: https://github.com/apache/beam/pull/12192#discussion_r451242979 ## File path: sdks/python/apache_beam/runners/direct/sdf_direct_runner.py ## @@ -507,7 +500,6 @@ def initiate_checkpoint(): if

[GitHub] [beam] lukecwik edited a comment on pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik edited a comment on pull request #12192: URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038 R: @robertwb @chamikaramj Style-wise does it make sense to use the `kwargs` to pass these through or should I continue to make them explicit like the

[GitHub] [beam] lukecwik commented on pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik commented on pull request #12192: URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038 R: @robertwb @chamikaramj Style-wise does it make sense to use the `kwargs` to pass these through or should I continue to make them explicit like the

[GitHub] [beam] chamikaramj commented on a change in pull request #12106: [BEAM-9792] Fixing the IOException handling in InsertAll for BigQuery

chamikaramj commented on a change in pull request #12106: URL: https://github.com/apache/beam/pull/12106#discussion_r451242654 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java ## @@ -893,6 +906,19 @@

[GitHub] [beam] lukecwik opened a new pull request #12192: [BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik opened a new pull request #12192: URL: https://github.com/apache/beam/pull/12192 To be able to have the windowing optimization stay within the PerWindowInvoker, I needed to have it control the creation of the watermark estimator and the restriction tracker thus I supply the

[GitHub] [beam] danielxjd commented on a change in pull request #12106: [BEAM-9792] Fixing the IOException handling in InsertAll for BigQuery

danielxjd commented on a change in pull request #12106: URL: https://github.com/apache/beam/pull/12106#discussion_r451241677 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java ## @@ -893,6 +903,20 @@

[GitHub] [beam] udim commented on a change in pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

udim commented on a change in pull request #12009: URL: https://github.com/apache/beam/pull/12009#discussion_r451233193 ## File path: sdks/python/apache_beam/typehints/decorators.py ## @@ -378,6 +378,56 @@ def has_simple_output_type(self): self.output_types and

[GitHub] [beam] chamikaramj commented on a change in pull request #12106: [BEAM-9792] Fixing the IOException handling in InsertAll for BigQuery

chamikaramj commented on a change in pull request #12106: URL: https://github.com/apache/beam/pull/12106#discussion_r451237362 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java ## @@ -893,6 +903,20 @@

[GitHub] [beam] y1chi opened a new pull request #12191: [BEAM-10419] Skip FhirIORead integration test due to flakiness

y1chi opened a new pull request #12191: URL: https://github.com/apache/beam/pull/12191 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] jaketf commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

jaketf commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-655219973 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robertwb commented on pull request #11963: Add relational GroupBy transform to Python.

robertwb commented on pull request #11963: URL: https://github.com/apache/beam/pull/11963#issuecomment-655215071 R: @TheNeuralBit This is ready for review. This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655211272 > > Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but we explicitly don't drop the default value for ValueProvider arguments: > >

[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655209912 > Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but we explicitly don't drop the default value for ValueProvider arguments: > >

[GitHub] [beam] TheNeuralBit commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

TheNeuralBit commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655207778 Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but we explicitly don't drop the default value for ValueProvider arguments:

[GitHub] [beam] danielxjd commented on a change in pull request #12106: [BEAM-9792] Fixing the IOException handling in InsertAll for BigQuery

danielxjd commented on a change in pull request #12106: URL: https://github.com/apache/beam/pull/12106#discussion_r451213408 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java ## @@ -893,6 +903,20 @@

[GitHub] [beam] lukecwik commented on pull request #12184: [BEAM-10392] Make sure that messages that are unroutable are returned to the sender and redelivered.

lukecwik commented on pull request #12184: URL: https://github.com/apache/beam/pull/12184#issuecomment-655203055 LGTM? This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] jaketf commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

jaketf commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-655202173 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] KevinGG commented on pull request #12107: Interactive Environment Inspector for messaging

KevinGG commented on pull request #12107: URL: https://github.com/apache/beam/pull/12107#issuecomment-655194772 > left just two comments. Please respond (address if you think it's worth addressing) - and we can merge Thanks, @pabloem ! I've made corresponding changes.

[GitHub] [beam] TheNeuralBit commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

TheNeuralBit commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655192320 Looks like the CI failure is actually another flake due to BEAM-10006. It can be replicated reliably locally with ``` $ pytest

[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655189985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] robertwb merged pull request #12182: [BEAM-4605] Remove portable runner GBK hack.

robertwb merged pull request #12182: URL: https://github.com/apache/beam/pull/12182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] aaltay commented on pull request #12128: [BEAM-10417] - Move Shared object from tfx_bsl

aaltay commented on pull request #12128: URL: https://github.com/apache/beam/pull/12128#issuecomment-655188903 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on a change in pull request #12106: [BEAM-9792] Fixing the IOException handling in InsertAll for BigQuery

chamikaramj commented on a change in pull request #12106: URL: https://github.com/apache/beam/pull/12106#discussion_r451179908 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java ## @@ -793,6 +795,14 @@

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12132: [BEAM-10371] Run dependency check script with Python 3

TheNeuralBit commented on a change in pull request #12132: URL: https://github.com/apache/beam/pull/12132#discussion_r451186550 ## File path: sdks/python/tox.ini ## @@ -287,3 +287,12 @@ deps = commands = yapf --version time yapf --diff --parallel --recursive apache_beam

[GitHub] [beam] chamikaramj commented on a change in pull request #12164: [BEAM-10397] add missing environment in windowing strategy for Dataflow

chamikaramj commented on a change in pull request #12164: URL: https://github.com/apache/beam/pull/12164#discussion_r451184245 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12132: [BEAM-10371] Run dependency check script with Python 3

TheNeuralBit commented on a change in pull request #12132: URL: https://github.com/apache/beam/pull/12132#discussion_r451181865 ## File path: sdks/python/tox.ini ## @@ -287,3 +287,12 @@ deps = commands = yapf --version time yapf --diff --parallel --recursive apache_beam

[GitHub] [beam] TheNeuralBit merged pull request #12067: [BEAM-10308] Make component ID assignments consistent across PipelineContext instances

TheNeuralBit merged pull request #12067: URL: https://github.com/apache/beam/pull/12067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] robinyqiu commented on pull request #11456: [BEAM-7554] Add MillisInstant logical type to replace DATETIME

robinyqiu commented on pull request #11456: URL: https://github.com/apache/beam/pull/11456#issuecomment-655169701 cc: @robinyqiu @ZijieSong946 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] annaqin418 commented on pull request #12157: [BEAM-7587] Spark portable streaming

annaqin418 commented on pull request #12157: URL: https://github.com/apache/beam/pull/12157#issuecomment-655169602 R: @robertwb This PR is still a while from being ready, but just wanted to tag you as well in my progress.

[GitHub] [beam] robertwb merged pull request #12186: Fix threading issue with default artifact resolver registration.

robertwb merged pull request #12186: URL: https://github.com/apache/beam/pull/12186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] amaliujia merged pull request #12169: [BEAM-9953[SQL][ZetaSQL] Support Pure SQL user-defined table-valued function.

amaliujia merged pull request #12169: URL: https://github.com/apache/beam/pull/12169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] kennknowles merged pull request #12162: [BEAM-10402] Enable checker framework, disabled everywhere since every module has errors. Eliminate some errors (but no complete modules)

kennknowles merged pull request #12162: URL: https://github.com/apache/beam/pull/12162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] pabloem commented on a change in pull request #12107: Interactive Environment Inspector for messaging

pabloem commented on a change in pull request #12107: URL: https://github.com/apache/beam/pull/12107#discussion_r448112826 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@ -204,3 +205,23 @@ def run_within_progress_indicator(*args, **kwargs):

[GitHub] [beam] pabloem commented on pull request #12107: Interactive Environment Inspector for messaging

pabloem commented on pull request #12107: URL: https://github.com/apache/beam/pull/12107#issuecomment-655161085 left just two comments. Please respond (address if you think it's worth addressing) - and we can merge This is

[GitHub] [beam] y1chi commented on pull request #11339: [BEAM-9468] Fhir io

y1chi commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-655160801 @jaketf the integration tests seem to be flaky and breaks postcommit sometimes, I opened https://issues.apache.org/jira/browse/BEAM-10419 do you mind take a look?

[GitHub] [beam] chamikaramj commented on pull request #12188: [BEAM-10411] Adds an example that use Python cross-language Kafka transforms.

chamikaramj commented on pull request #12188: URL: https://github.com/apache/beam/pull/12188#issuecomment-655159675 cc: @davidwrede This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on pull request #12067: [BEAM-10308] Make component ID assignments consistent across PipelineContext instances

chamikaramj commented on pull request #12067: URL: https://github.com/apache/beam/pull/12067#issuecomment-655155939 Took a look and confirmed that x-lang KafkaIO works with this change. LGTM from me. This is an automated

[GitHub] [beam] robertwb commented on pull request #12186: Fix threading issue with default artifact resolver registration.

robertwb commented on pull request #12186: URL: https://github.com/apache/beam/pull/12186#issuecomment-655145852 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] jaketf commented on pull request #11959: refactor HCLS IO ITs to support stores in other projects

jaketf commented on pull request #11959: URL: https://github.com/apache/beam/pull/11959#issuecomment-655145391 I have some level of access but I need additional permissions to modify IAM This is an automated message from the

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655122687 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] piotr-szuberski removed a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski removed a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655122687 Run XVR_Spark PostCommitRun XVR_Spark PostCommit This is an automated message from the Apache

[GitHub] [beam] lukecwik commented on a change in pull request #12184: [BEAM-10392] Make sure that messages that are unroutable are returned to the sender and redelivered.

lukecwik commented on a change in pull request #12184: URL: https://github.com/apache/beam/pull/12184#discussion_r451123739 ## File path: sdks/java/io/rabbitmq/src/test/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIOTest.java ## @@ -196,59 +200,74 @@ private void

[GitHub] [beam] lukecwik merged pull request #12089: [BEAM-10283] Add new overloads of withKeyRanges and withRowFilter met…

lukecwik merged pull request #12089: URL: https://github.com/apache/beam/pull/12089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lukecwik commented on a change in pull request #12089: [BEAM-10283] Add new overloads of withKeyRanges and withRowFilter met…

lukecwik commented on a change in pull request #12089: URL: https://github.com/apache/beam/pull/12089#discussion_r451120512 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java ## @@ -410,13 +417,22 @@ public Read

[GitHub] [beam] pabloem merged pull request #12190: Fix typos in programming guide

pabloem merged pull request #12190: URL: https://github.com/apache/beam/pull/12190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #12190: Fix typos in programming guide

pabloem commented on pull request #12190: URL: https://github.com/apache/beam/pull/12190#issuecomment-655092319 Thanks! LGTM. I'll merge after website precommit passes This is an automated message from the Apache Git

[GitHub] [beam] aaltay commented on pull request #12128: [BEAM-10417] - Move Shared object from tfx_bsl

aaltay commented on pull request #12128: URL: https://github.com/apache/beam/pull/12128#issuecomment-655091453 > Optional comments: > > * is there an associated BEAM jira issue that can be used for the commit? > * consider adding this to the CHANGES.md. Done. Thank you!

[GitHub] [beam] ceh commented on pull request #12190: Fix typos in programming guide

ceh commented on pull request #12190: URL: https://github.com/apache/beam/pull/12190#issuecomment-655090603 R: @aaltay, @pabloem This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rohdesamuel commented on pull request #12182: [BEAM-4605] Remove portable runner GBK hack.

rohdesamuel commented on pull request #12182: URL: https://github.com/apache/beam/pull/12182#issuecomment-655090706 LGTM, thanks for the cleanup! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ceh opened a new pull request #12190: Fix typos in programming guide

ceh opened a new pull request #12190: URL: https://github.com/apache/beam/pull/12190 Fix a couple of minor typos in the programming guide. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] TheNeuralBit merged pull request #12090: [BEAM-10336,BEAM-10337] Add SchemaIO abstraction and implement for PubSub

TheNeuralBit merged pull request #12090: URL: https://github.com/apache/beam/pull/12090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] aaltay commented on pull request #12128: Move Shared object from tfx_bsl

aaltay commented on pull request #12128: URL: https://github.com/apache/beam/pull/12128#issuecomment-655085033 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn merged pull request #12180: [BEAM-9754] Adds Python 3.8 ValidatesRunner tests for Dataflow.

tvalentyn merged pull request #12180: URL: https://github.com/apache/beam/pull/12180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] pabloem commented on pull request #12183: Fix a class cast bug: TupleTagList is not a collection.

pabloem commented on pull request #12183: URL: https://github.com/apache/beam/pull/12183#issuecomment-655066457 Thanks @lastomato ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem merged pull request #12183: Fix a class cast bug: TupleTagList is not a collection.

pabloem merged pull request #12183: URL: https://github.com/apache/beam/pull/12183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on a change in pull request #12143: [BEAM-10291] Adding full thread dump upon lull detection for Dataflow…

pabloem commented on a change in pull request #12143: URL: https://github.com/apache/beam/pull/12143#discussion_r451078998 ## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowOperationContext.java ## @@ -194,6

[GitHub] [beam] pabloem commented on pull request #12143: [BEAM-10291] Adding full thread dump upon lull detection for Dataflow…

pabloem commented on pull request #12143: URL: https://github.com/apache/beam/pull/12143#issuecomment-655059029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] robertwb commented on pull request #12186: Fix threading issue with default artifact resolver registration.

robertwb commented on pull request #12186: URL: https://github.com/apache/beam/pull/12186#issuecomment-655056238 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] apilloud merged pull request #12159: [BEAM-10093] Run ZetaSQL Nexmark in postcommit

apilloud merged pull request #12159: URL: https://github.com/apache/beam/pull/12159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] aaltay commented on pull request #12128: Move Shared object from tfx_bsl

aaltay commented on pull request #12128: URL: https://github.com/apache/beam/pull/12128#issuecomment-655056227 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TheNeuralBit commented on pull request #12090: [BEAM-10336,BEAM-10337] Add SchemaIO abstraction and implement for PubSub

TheNeuralBit commented on pull request #12090: URL: https://github.com/apache/beam/pull/12090#issuecomment-655052483 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] davidyan74 commented on pull request #12143: [BEAM-10291] Adding full thread dump upon lull detection for Dataflow…

davidyan74 commented on pull request #12143: URL: https://github.com/apache/beam/pull/12143#issuecomment-655047439 Looks like another test failed and looks unrelated again. @pabloem Do you think this PR could make the tests more flaky?

[GitHub] [beam] aaltay commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR

aaltay commented on a change in pull request #12166: URL: https://github.com/apache/beam/pull/12166#discussion_r451063093 ## File path: .github/workflows/cancel.yml ## @@ -16,7 +16,7 @@ # under the License. name: Cancel -on: [push] +on: [push, pull_request] Review

[GitHub] [beam] chamikaramj commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

chamikaramj commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-655044889 LGTM. Thanks. Could yo resolve the conflict ? Also, can we trigger tests from here to see if this works or are there more missing pieces ?

[GitHub] [beam] tvalentyn commented on pull request #12179: [BEAM-5414] - Update grpcio-tools to its latest version.

tvalentyn commented on pull request #12179: URL: https://github.com/apache/beam/pull/12179#issuecomment-655039855 cc: @robertwb @angoenka re: https://github.com/apache/beam/pull/12179#issuecomment-654548592. Do we need an AI to suppress such errors?

[GitHub] [beam] tvalentyn commented on pull request #12179: [BEAM-5414] - Update grpcio-tools to its latest version.

tvalentyn commented on pull request #12179: URL: https://github.com/apache/beam/pull/12179#issuecomment-655038045 If this happened during interpreter shutdown perhaps all bets are off? This is an automated message from the

[GitHub] [beam] chamikaramj commented on pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

chamikaramj commented on pull request #11919: URL: https://github.com/apache/beam/pull/11919#issuecomment-655035073 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #12183: Fix a class cast bug: TupleTagList is not a collection.

pabloem commented on pull request #12183: URL: https://github.com/apache/beam/pull/12183#issuecomment-655011572 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12143: [BEAM-10291] Adding full thread dump upon lull detection for Dataflow…

pabloem commented on pull request #12143: URL: https://github.com/apache/beam/pull/12143#issuecomment-655011390 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12183: Fix a class cast bug: TupleTagList is not a collection.

pabloem commented on pull request #12183: URL: https://github.com/apache/beam/pull/12183#issuecomment-655011463 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #12086: [BEAM-10322] allow only single assignment to producing stages by pcol…

pabloem commented on pull request #12086: URL: https://github.com/apache/beam/pull/12086#issuecomment-655006468 My bad. Heejong and I discussed it via chat last week. I forgot to add the LGTM when I merged. On Tue, Jul 7, 2020, 9:36 AM Ahmet Altay wrote: > Folks just

[GitHub] [beam] robertwb commented on pull request #12186: Fix threading issue with default artifact resolver registration.

robertwb commented on pull request #12186: URL: https://github.com/apache/beam/pull/12186#issuecomment-655002473 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robertwb commented on pull request #12186: Fix threading issue with default artifact resolver registration.

robertwb commented on pull request #12186: URL: https://github.com/apache/beam/pull/12186#issuecomment-655002395 This did come up in a test flake. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] davidyan74 commented on pull request #12143: [BEAM-10291] Adding full thread dump upon lull detection for Dataflow…

davidyan74 commented on pull request #12143: URL: https://github.com/apache/beam/pull/12143#issuecomment-654993643 Looks like the test didn't get triggered. This is an automated message from the Apache Git Service. To

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-654992334 Run XVR_Spark PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aaltay merged pull request #12179: [BEAM-5414] - Update grpcio-tools to its latest version.

aaltay merged pull request #12179: URL: https://github.com/apache/beam/pull/12179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] aaltay commented on pull request #12086: [BEAM-10322] allow only single assignment to producing stages by pcol…

aaltay commented on pull request #12086: URL: https://github.com/apache/beam/pull/12086#issuecomment-654982821 Folks just checking. I do not see an LGTM or an approval on this PR. Is everyone OK with it being merged? This

[GitHub] [beam] tvalentyn commented on pull request #12180: Adds Python 3.8 ValidatesRunner tests for Dataflow.

tvalentyn commented on pull request #12180: URL: https://github.com/apache/beam/pull/12180#issuecomment-654974496 R: @aaltay @kamilwu @lazylynx This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] tvalentyn commented on a change in pull request #12150: [BEAM-10398] Use GitHub Actions in wheels release process for Python

tvalentyn commented on a change in pull request #12150: URL: https://github.com/apache/beam/pull/12150#discussion_r450986594 ## File path: release/src/main/python-release/python_release_automation.sh ## @@ -19,7 +19,7 @@ source

[GitHub] [beam] tysonjh commented on pull request #12128: Move Shared object from tfx_bsl

tysonjh commented on pull request #12128: URL: https://github.com/apache/beam/pull/12128#issuecomment-654963681 Optional comments: * is there an associated BEAM jira issue that can be used for the commit? * consider adding this to the CHANGES.md.

[GitHub] [beam] tysonjh commented on pull request #12128: Move Shared object from tfx_bsl

tysonjh commented on pull request #12128: URL: https://github.com/apache/beam/pull/12128#issuecomment-654962545 LGTM - thank you! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lastomato commented on pull request #12183: Fix a class cast bug: TupleTagList is not a collection.

lastomato commented on pull request #12183: URL: https://github.com/apache/beam/pull/12183#issuecomment-654962111 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] mxm merged pull request #12133: [BEAM-10385] Integrate SQL expansion into Flink job server

mxm merged pull request #12133: URL: https://github.com/apache/beam/pull/12133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-654901752 Yeah, I noticed that it times out. Thanks that you tried to run the tests on your setup. Locally on my computer

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-654901752 Yeah, I noticed that it times out. Thanks that you tried to run the tests on your setup. Locally on my computer

  1   2   >