[GitHub] [beam] boyuanzz commented on a change in pull request #12430: [BEAM-10303] Scale progress with respect to windows observation.

2020-08-07 Thread GitBox
boyuanzz commented on a change in pull request #12430: URL: https://github.com/apache/beam/pull/12430#discussion_r467364484 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1029,12 +1040,35 @@ public double getProgress() {

[GitHub] [beam] boyuanzz merged pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-08-07 Thread GitBox
boyuanzz merged pull request #11749: URL: https://github.com/apache/beam/pull/11749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lukecwik merged pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik merged pull request #12488: URL: https://github.com/apache/beam/pull/12488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467358540 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java ## @@ -839,19 +845,20 @@ public ProcessContinuation pro

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467358540 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java ## @@ -839,19 +845,20 @@ public ProcessContinuation pro

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467358516 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java ## @@ -1499,6 +1504,146 @@ public void populateDisplayData(Build

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467358405 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/EvaluationContext.java ## @@ -183,6 +188,15 @@ public void initialize(

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670817702 Run Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670817089 run flink portable validatesrunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670817069 run spark validatesrunner This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670817062 run flink validatesrunner This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] stale[bot] commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-08-07 Thread GitBox
stale[bot] commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-670814577 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] stale[bot] commented on pull request #11804: Corrected the input to execute the Java JAR file

2020-08-07 Thread GitBox
stale[bot] commented on pull request #11804: URL: https://github.com/apache/beam/pull/11804#issuecomment-670814575 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] tvalentyn commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12239: URL: https://github.com/apache/beam/pull/12239#discussion_r467352823 ## File path: sdks/python/test-suites/gradle.properties ## @@ -0,0 +1,38 @@ +

[GitHub] [beam] tvalentyn commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12239: URL: https://github.com/apache/beam/pull/12239#discussion_r467352823 ## File path: sdks/python/test-suites/gradle.properties ## @@ -0,0 +1,38 @@ +

[GitHub] [beam] lukecwik commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670811848 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] robinyqiu opened a new pull request #12507: [WIP] Move value conversion logic out of ExpressionConverter

2020-08-07 Thread GitBox
robinyqiu opened a new pull request #12507: URL: https://github.com/apache/beam/pull/12507 Post-Commit Tests Status (on master branch) Lang | SDK | Dataflow | Flink | Samza | Spark

[GitHub] [beam] lazylynx commented on pull request #12239: [BEAM-9980] tests tied with Python versions configurable

2020-08-07 Thread GitBox
lazylynx commented on pull request #12239: URL: https://github.com/apache/beam/pull/12239#issuecomment-670809891 @tvalentyn updated. PTAL. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] lazylynx commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

2020-08-07 Thread GitBox
lazylynx commented on a change in pull request #12239: URL: https://github.com/apache/beam/pull/12239#discussion_r467349799 ## File path: build.gradle ## @@ -220,13 +220,12 @@ task pythonPreCommit() { dependsOn ":sdks:python:test-suites:tox:py36:preCommitPy36" dependsOn "

[GitHub] [beam] lazylynx commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

2020-08-07 Thread GitBox
lazylynx commented on a change in pull request #12239: URL: https://github.com/apache/beam/pull/12239#discussion_r467349765 ## File path: build.gradle ## @@ -248,9 +247,9 @@ task pythonFormatterPreCommit() { task python2PostCommit() { dependsOn ":sdks:python:test-suites:

[GitHub] [beam] tvalentyn commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12239: URL: https://github.com/apache/beam/pull/12239#discussion_r467346745 ## File path: build.gradle ## @@ -220,13 +220,12 @@ task pythonPreCommit() { dependsOn ":sdks:python:test-suites:tox:py36:preCommitPy36" dependsOn

[GitHub] [beam] tvalentyn commented on pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-07 Thread GitBox
tvalentyn commented on pull request #12452: URL: https://github.com/apache/beam/pull/12452#issuecomment-670805985 > @tvalentyn answering your question: > > > Also, all actions workflow run in parallel, right? so it takes roughly the same time as running a regular precommit? In such c

[GitHub] [beam] tvalentyn commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467345624 ## File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py ## @@ -92,23 +93,29 @@ def test_wrapper_pass_through(self): # We use a file to

[GitHub] [beam] tvalentyn commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467345624 ## File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py ## @@ -92,23 +93,29 @@ def test_wrapper_pass_through(self): # We use a file to

[GitHub] [beam] tvalentyn commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467345624 ## File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py ## @@ -92,23 +93,29 @@ def test_wrapper_pass_through(self): # We use a file to

[GitHub] [beam] tvalentyn commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467344934 ## File path: sdks/python/apache_beam/runners/worker/log_handler_test.py ## @@ -87,7 +87,8 @@ def _verify_fn_log_handler(self, num_log_entries):

[GitHub] [beam] tvalentyn commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-07 Thread GitBox
tvalentyn commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467342448 ## File path: sdks/python/apache_beam/io/parquetio_test.py ## @@ -296,8 +296,10 @@ def test_sink_transform_int96(self): path, self.SCHEMA9

[GitHub] [beam] damondouglas opened a new pull request #12506: [BEAM-9680] Add Filter with ParDo lesson to Go SDK Katas

2020-08-07 Thread GitBox
damondouglas opened a new pull request #12506: URL: https://github.com/apache/beam/pull/12506 This pull request adds a filter with ParDo lesson to the Go SDK katas. I would like to request the following reviewer: (R: @lostluck ) Thank you for y

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-07 Thread GitBox
TheNeuralBit commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r467339563 ## File path: sdks/python/apache_beam/io/jdbc.py ## @@ -168,41 +182,33 @@ def __init__( :param expansion_service: The address (host:port) of the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-07 Thread GitBox
TheNeuralBit commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r467335905 ## File path: sdks/python/apache_beam/io/jdbc.py ## @@ -168,41 +182,33 @@ def __init__( :param expansion_service: The address (host:port) of the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-07 Thread GitBox
TheNeuralBit commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r467112288 ## File path: settings.gradle ## @@ -181,3 +181,4 @@ include "beam-test-tools" project(":beam-test-tools").dir = file(".test-infra/tools") include "

[GitHub] [beam] yifanmai commented on pull request #12185: [BEAM-10409] Add combiner packing to graph optimizer phases

2020-08-07 Thread GitBox
yifanmai commented on pull request #12185: URL: https://github.com/apache/beam/pull/12185#issuecomment-670789207 @robertwb and @aaltay, gentle ping. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] amaliujia commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
amaliujia commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467331678 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java ## @@ -839,19 +845,20 @@ public ProcessContinuation pr

[GitHub] [beam] amaliujia commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
amaliujia commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467331551 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java ## @@ -1499,6 +1504,146 @@ public void populateDisplayData(Buil

[GitHub] [beam] TheNeuralBit commented on pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12481: URL: https://github.com/apache/beam/pull/12481#issuecomment-670788340 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] amaliujia commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
amaliujia commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467330787 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/EvaluationContext.java ## @@ -183,6 +188,15 @@ public void initialize(

[GitHub] [beam] amaliujia commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
amaliujia commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467330599 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java ## @@ -81,6 +89,22 @@ public DirectTimerInter

[GitHub] [beam] TheNeuralBit commented on pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12481: URL: https://github.com/apache/beam/pull/12481#issuecomment-670787524 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] lukecwik commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670785654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467328411 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/EvaluationContext.java ## @@ -183,6 +188,15 @@ public void initialize(

[GitHub] [beam] tvalentyn commented on pull request #12503: [BEAM-8460] Exclude category containing failing tests for spark/flink to restore green test signal.

2020-08-07 Thread GitBox
tvalentyn commented on pull request #12503: URL: https://github.com/apache/beam/pull/12503#issuecomment-670784808 [incubator-beam...](https://www.alamy.com/old-fork-image276307480.html) This is an automated message from the A

[GitHub] [beam] lukecwik commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670784538 Run Spark ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] lukecwik commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670784514 Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467326804 ## File path: runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java ## @@ -126,23 +12

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467326841 ## File path: runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java ## @@ -126,23 +12

[GitHub] [beam] tvalentyn merged pull request #12503: [BEAM-8460] Exclude category containing failing tests for spark/flink to restore green test signal.

2020-08-07 Thread GitBox
tvalentyn merged pull request #12503: URL: https://github.com/apache/beam/pull/12503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] tvalentyn commented on pull request #12503: [BEAM-8460] Exclude category containing failing tests for spark/flink to restore green test signal.

2020-08-07 Thread GitBox
tvalentyn commented on pull request #12503: URL: https://github.com/apache/beam/pull/12503#issuecomment-670783195 Both suites listed as 'Pending' on the PR have passed: https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_PR/286/ https://ci-beam.apache.org/job/be

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467324258 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java ## @@ -1499,6 +1504,146 @@ public void populateDisplayData(Build

[GitHub] [beam] lukecwik commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467324202 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java ## @@ -81,6 +89,22 @@ public DirectTimerIntern

[GitHub] [beam] emilymye opened a new pull request #12505: [WIP][BEAM-8106] Add version to java container image name

2020-08-07 Thread GitBox
emilymye opened a new pull request #12505: URL: https://github.com/apache/beam/pull/12505 Adding version number to Java image names (in anticipation of releasing java11 container) Thank you for your contribution! Follow this checklist to help us incor

[GitHub] [beam] lostluck merged pull request #12504: [BEAM-10289] Fixing bug in Go harness split response.

2020-08-07 Thread GitBox
lostluck merged pull request #12504: URL: https://github.com/apache/beam/pull/12504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] youngoli commented on pull request #12504: [BEAM-10289] Fixing bug in Go harness split response.

2020-08-07 Thread GitBox
youngoli commented on pull request #12504: URL: https://github.com/apache/beam/pull/12504#issuecomment-670774483 R: @lostluck This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] youngoli opened a new pull request #12504: [BEAM-10289] Fixing bug in Go harness split response.

2020-08-07 Thread GitBox
youngoli opened a new pull request #12504: URL: https://github.com/apache/beam/pull/12504 Should be checking for nil-ness in the primary/residual elements. Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] pabloem commented on pull request #12485: [BEAM-6064] Improvements to BQ streaming insert performance

2020-08-07 Thread GitBox
pabloem commented on pull request #12485: URL: https://github.com/apache/beam/pull/12485#issuecomment-670774285 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-08-07 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r467317077 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java ## @@ -1306,112 +1315,206 @@ public void populateDisplayData(Dis

[GitHub] [beam] rohdesamuel commented on pull request #12413: [BEAM-10603] Add max count to utils.to_element_list

2020-08-07 Thread GitBox
rohdesamuel commented on pull request #12413: URL: https://github.com/apache/beam/pull/12413#issuecomment-670773173 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] rohdesamuel commented on pull request #12413: [BEAM-10603] Add max count to utils.to_element_list

2020-08-07 Thread GitBox
rohdesamuel commented on pull request #12413: URL: https://github.com/apache/beam/pull/12413#issuecomment-670772725 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] rohdesamuel commented on pull request #12413: [BEAM-10603] Add max count to utils.to_element_list

2020-08-07 Thread GitBox
rohdesamuel commented on pull request #12413: URL: https://github.com/apache/beam/pull/12413#issuecomment-670772593 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] rohdesamuel commented on pull request #12413: [BEAM-10603] Add max count to utils.to_element_list

2020-08-07 Thread GitBox
rohdesamuel commented on pull request #12413: URL: https://github.com/apache/beam/pull/12413#issuecomment-670772413 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] rohdesamuel commented on pull request #12413: [BEAM-10603] Add max count to utils.to_element_list

2020-08-07 Thread GitBox
rohdesamuel commented on pull request #12413: URL: https://github.com/apache/beam/pull/12413#issuecomment-670772296 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] rohdesamuel commented on pull request #12413: [BEAM-10603] Add max count to utils.to_element_list

2020-08-07 Thread GitBox
rohdesamuel commented on pull request #12413: URL: https://github.com/apache/beam/pull/12413#issuecomment-670771070 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] pabloem commented on pull request #12485: [BEAM-6064] Improvements to BQ streaming insert performance

2020-08-07 Thread GitBox
pabloem commented on pull request #12485: URL: https://github.com/apache/beam/pull/12485#issuecomment-670770564 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] pabloem commented on pull request #12485: [BEAM-6064] Improvements to BQ streaming insert performance

2020-08-07 Thread GitBox
pabloem commented on pull request #12485: URL: https://github.com/apache/beam/pull/12485#issuecomment-670770499 r: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] ibzib commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
ibzib commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467313292 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java ## @@ -1499,6 +1504,146 @@ public void populateDisplayData(Builder

[GitHub] [beam] ibzib commented on a change in pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
ibzib commented on a change in pull request #12488: URL: https://github.com/apache/beam/pull/12488#discussion_r467307061 ## File path: runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java ## @@ -126,23 +128,3

[GitHub] [beam] TheNeuralBit merged pull request #12440: [BEAM-10619] Report ratio of implemented pandas tests

2020-08-07 Thread GitBox
TheNeuralBit merged pull request #12440: URL: https://github.com/apache/beam/pull/12440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] pabloem commented on pull request #12480: [BEAM-10647] Fixes get_query_location bug in BigQueryWrapper

2020-08-07 Thread GitBox
pabloem commented on pull request #12480: URL: https://github.com/apache/beam/pull/12480#issuecomment-670763547 thanks - this looks great fwiw : ) This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [beam] amaliujia commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
amaliujia commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670758669 Thanks @lukecwik Will take a look at this PR soon. This is an automated message from the Apache Git Ser

[GitHub] [beam] lukecwik commented on pull request #12503: [BEAM-8460] Exclude category containing failing tests for spark/flink to restore green test signal.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12503: URL: https://github.com/apache/beam/pull/12503#issuecomment-670747167 Run Spark ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] lukecwik commented on pull request #12503: [BEAM-8460] Exclude category containing failing tests for spark/flink to restore green test signal.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12503: URL: https://github.com/apache/beam/pull/12503#issuecomment-670747393 Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] lukecwik commented on pull request #11924: [BEAM-8543] Dataflow streaming timers are not strictly time ordered when set earlier mid-bundle

2020-08-07 Thread GitBox
lukecwik commented on pull request #11924: URL: https://github.com/apache/beam/pull/11924#issuecomment-670746244 This PR enabled new tests which are failing with some of the validates runner tests. for example: https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/77

[GitHub] [beam] lukecwik commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670746769 Expanded existing JIRA: https://issues.apache.org/jira/browse/BEAM-8460, opened #12503 to disable failing test category for spark and flink

[GitHub] [beam] lukecwik opened a new pull request #12503: [BEAM-8460] Exclude category containing failing tests for spark/flink to restore green test signal.

2020-08-07 Thread GitBox
lukecwik opened a new pull request #12503: URL: https://github.com/apache/beam/pull/12503 Tests were added as part of #11924 that fail on Spark and Flink. Thank you for your contribution! Follow this checklist to help us incorporate your contribution q

[GitHub] [beam] TheNeuralBit commented on pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12481: URL: https://github.com/apache/beam/pull/12481#issuecomment-670735024 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] TheNeuralBit edited a comment on pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-07 Thread GitBox
TheNeuralBit edited a comment on pull request #12481: URL: https://github.com/apache/beam/pull/12481#issuecomment-670704670 @mxm or @chadrik any chance you'd be able to review the Python changes in this PR? I'd like to get it merged before the 2.24.0 release cut on Aug 12

[GitHub] [beam] lukecwik commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670729248 The test failure is known issue, failing in postcommit https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/7773/testReport/ and https://ci-beam.apache.org

[GitHub] [beam] TheNeuralBit commented on pull request #12497: [BEAM-10361] upgrade Kotlin version in example

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12497: URL: https://github.com/apache/beam/pull/12497#issuecomment-670727799 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] Imfuyuwei commented on pull request #12502: [BEAM-9891] Added ZetaSQL planner support and uploaded 100G data

2020-08-07 Thread GitBox
Imfuyuwei commented on pull request #12502: URL: https://github.com/apache/beam/pull/12502#issuecomment-670727033 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on a change in pull request #12430: [BEAM-10303] Scale progress with respect to windows observation.

2020-08-07 Thread GitBox
boyuanzz commented on a change in pull request #12430: URL: https://github.com/apache/beam/pull/12430#discussion_r467296625 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1029,7 +1040,27 @@ public double getProgress() {

[GitHub] [beam] ettirapp commented on pull request #12487: Fixing Typos in GCS and S3 Filesystem Tests

2020-08-07 Thread GitBox
ettirapp commented on pull request #12487: URL: https://github.com/apache/beam/pull/12487#issuecomment-670726300 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] TheNeuralBit commented on pull request #12440: [BEAM-10619] Report ratio of implemented pandas tests

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12440: URL: https://github.com/apache/beam/pull/12440#issuecomment-670726192 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] TheNeuralBit commented on pull request #12440: [BEAM-10619] Report ratio of implemented pandas tests

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12440: URL: https://github.com/apache/beam/pull/12440#issuecomment-670726149 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-07 Thread GitBox
TheNeuralBit commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467293660 ## File path: sdks/python/apache_beam/testing/datatype_inference_test.py ## @@ -174,6 +175,7 @@ def test_infer_typehints_schema(self, _, data, schema)

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670725606 Run Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670725497 run flink portable validatesrunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670725554 run spark validatesrunner This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] ibzib merged pull request #12484: [BEAM-10653] Modularize BeamSqlDslUdfUdafTest.

2020-08-07 Thread GitBox
ibzib merged pull request #12484: URL: https://github.com/apache/beam/pull/12484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] ibzib commented on pull request #12486: [BEAM-9558] Remove usage of empty data/timers to signify last.

2020-08-07 Thread GitBox
ibzib commented on pull request #12486: URL: https://github.com/apache/beam/pull/12486#issuecomment-670725230 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [beam] reuvenlax commented on pull request #12474: [BEAM-10650] OrderedListState API

2020-08-07 Thread GitBox
reuvenlax commented on pull request #12474: URL: https://github.com/apache/beam/pull/12474#issuecomment-670725432 run flink validatesrunner This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik commented on pull request #12488: [BEAM-10656] Enable bundle finalization within the Java direct runner.

2020-08-07 Thread GitBox
lukecwik commented on pull request #12488: URL: https://github.com/apache/beam/pull/12488#issuecomment-670724401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] TheNeuralBit commented on pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12498: URL: https://github.com/apache/beam/pull/12498#issuecomment-670717056 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] lukecwik commented on a change in pull request #12430: [BEAM-10303] Scale progress with respect to windows observation.

2020-08-07 Thread GitBox
lukecwik commented on a change in pull request #12430: URL: https://github.com/apache/beam/pull/12430#discussion_r467272382 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1029,7 +1040,27 @@ public double getProgress() {

[GitHub] [beam] danielxjd commented on pull request #12223: [Beam-4379] Make ParquetIO read splittable

2020-08-07 Thread GitBox
danielxjd commented on pull request #12223: URL: https://github.com/apache/beam/pull/12223#issuecomment-670715872 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ZijieSong946 commented on a change in pull request #12500: Fix precommit errors

2020-08-07 Thread GitBox
ZijieSong946 commented on a change in pull request #12500: URL: https://github.com/apache/beam/pull/12500#discussion_r467270930 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamSqlUnparseContext.java ## @@ -110,

[GitHub] [beam] ibzib commented on pull request #12486: [BEAM-9558] Remove usage of empty data/timers to signify last.

2020-08-07 Thread GitBox
ibzib commented on pull request #12486: URL: https://github.com/apache/beam/pull/12486#issuecomment-670711952 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] Imfuyuwei commented on a change in pull request #12502: [BEAM-9891] Added ZetaSQL planner support and uploaded 100G data

2020-08-07 Thread GitBox
Imfuyuwei commented on a change in pull request #12502: URL: https://github.com/apache/beam/pull/12502#discussion_r467266754 ## File path: sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apach

[GitHub] [beam] TheNeuralBit commented on pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12481: URL: https://github.com/apache/beam/pull/12481#issuecomment-670710921 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] boyuanzz commented on a change in pull request #12430: [BEAM-10303] Scale progress with respect to windows observation.

2020-08-07 Thread GitBox
boyuanzz commented on a change in pull request #12430: URL: https://github.com/apache/beam/pull/12430#discussion_r467266336 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1029,7 +1040,27 @@ public double getProgress() {

[GitHub] [beam] pabloem merged pull request #12473: [BEAM-10601] DICOM API Beam IO connector e2e test

2020-08-07 Thread GitBox
pabloem merged pull request #12473: URL: https://github.com/apache/beam/pull/12473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] TheNeuralBit commented on pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-07 Thread GitBox
TheNeuralBit commented on pull request #12481: URL: https://github.com/apache/beam/pull/12481#issuecomment-670704670 @mxm or @chadrik any chance you'd be able to review the Python changes in this PR? I'd like to get it merge before the 2.24.0 release cut on Aug 12

  1   2   3   >