boyuanzz commented on a change in pull request #12430:
URL: https://github.com/apache/beam/pull/12430#discussion_r467364484
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1029,12 +1040,35 @@ public double getProgress() {
boyuanzz merged pull request #11749:
URL: https://github.com/apache/beam/pull/11749
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lukecwik merged pull request #12488:
URL: https://github.com/apache/beam/pull/12488
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467358540
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
##
@@ -839,19 +845,20 @@ public ProcessContinuation pro
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467358540
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
##
@@ -839,19 +845,20 @@ public ProcessContinuation pro
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467358516
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##
@@ -1499,6 +1504,146 @@ public void populateDisplayData(Build
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467358405
##
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/EvaluationContext.java
##
@@ -183,6 +188,15 @@ public void initialize(
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670817702
Run Dataflow ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the messag
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670817089
run flink portable validatesrunner
This is an automated message from the Apache Git Service.
To respond to the
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670817069
run spark validatesrunner
This is an automated message from the Apache Git Service.
To respond to the message,
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670817062
run flink validatesrunner
This is an automated message from the Apache Git Service.
To respond to the message,
stale[bot] commented on pull request #11856:
URL: https://github.com/apache/beam/pull/11856#issuecomment-670814577
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
stale[bot] commented on pull request #11804:
URL: https://github.com/apache/beam/pull/11804#issuecomment-670814575
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
tvalentyn commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r467352823
##
File path: sdks/python/test-suites/gradle.properties
##
@@ -0,0 +1,38 @@
+
tvalentyn commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r467352823
##
File path: sdks/python/test-suites/gradle.properties
##
@@ -0,0 +1,38 @@
+
lukecwik commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670811848
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
robinyqiu opened a new pull request #12507:
URL: https://github.com/apache/beam/pull/12507
Post-Commit Tests Status (on master branch)
Lang | SDK | Dataflow | Flink | Samza | Spark
lazylynx commented on pull request #12239:
URL: https://github.com/apache/beam/pull/12239#issuecomment-670809891
@tvalentyn updated. PTAL.
This is an automated message from the Apache Git Service.
To respond to the message, p
lazylynx commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r467349799
##
File path: build.gradle
##
@@ -220,13 +220,12 @@ task pythonPreCommit() {
dependsOn ":sdks:python:test-suites:tox:py36:preCommitPy36"
dependsOn "
lazylynx commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r467349765
##
File path: build.gradle
##
@@ -248,9 +247,9 @@ task pythonFormatterPreCommit() {
task python2PostCommit() {
dependsOn
":sdks:python:test-suites:
tvalentyn commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r467346745
##
File path: build.gradle
##
@@ -220,13 +220,12 @@ task pythonPreCommit() {
dependsOn ":sdks:python:test-suites:tox:py36:preCommitPy36"
dependsOn
tvalentyn commented on pull request #12452:
URL: https://github.com/apache/beam/pull/12452#issuecomment-670805985
> @tvalentyn answering your question:
>
> > Also, all actions workflow run in parallel, right? so it takes roughly
the same time as running a regular precommit? In such c
tvalentyn commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r467345624
##
File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py
##
@@ -92,23 +93,29 @@ def test_wrapper_pass_through(self):
# We use a file to
tvalentyn commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r467345624
##
File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py
##
@@ -92,23 +93,29 @@ def test_wrapper_pass_through(self):
# We use a file to
tvalentyn commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r467345624
##
File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py
##
@@ -92,23 +93,29 @@ def test_wrapper_pass_through(self):
# We use a file to
tvalentyn commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r467344934
##
File path: sdks/python/apache_beam/runners/worker/log_handler_test.py
##
@@ -87,7 +87,8 @@ def _verify_fn_log_handler(self, num_log_entries):
tvalentyn commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r467342448
##
File path: sdks/python/apache_beam/io/parquetio_test.py
##
@@ -296,8 +296,10 @@ def test_sink_transform_int96(self):
path, self.SCHEMA9
damondouglas opened a new pull request #12506:
URL: https://github.com/apache/beam/pull/12506
This pull request adds a filter with ParDo lesson to the Go SDK katas. I
would like to request the following reviewer:
(R: @lostluck )
Thank you for y
TheNeuralBit commented on a change in pull request #12498:
URL: https://github.com/apache/beam/pull/12498#discussion_r467339563
##
File path: sdks/python/apache_beam/io/jdbc.py
##
@@ -168,41 +182,33 @@ def __init__(
:param expansion_service: The address (host:port) of the
TheNeuralBit commented on a change in pull request #12498:
URL: https://github.com/apache/beam/pull/12498#discussion_r467335905
##
File path: sdks/python/apache_beam/io/jdbc.py
##
@@ -168,41 +182,33 @@ def __init__(
:param expansion_service: The address (host:port) of the
TheNeuralBit commented on a change in pull request #12498:
URL: https://github.com/apache/beam/pull/12498#discussion_r467112288
##
File path: settings.gradle
##
@@ -181,3 +181,4 @@ include "beam-test-tools"
project(":beam-test-tools").dir = file(".test-infra/tools")
include "
yifanmai commented on pull request #12185:
URL: https://github.com/apache/beam/pull/12185#issuecomment-670789207
@robertwb and @aaltay, gentle ping.
This is an automated message from the Apache Git Service.
To respond to the
amaliujia commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467331678
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
##
@@ -839,19 +845,20 @@ public ProcessContinuation pr
amaliujia commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467331551
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##
@@ -1499,6 +1504,146 @@ public void populateDisplayData(Buil
TheNeuralBit commented on pull request #12481:
URL: https://github.com/apache/beam/pull/12481#issuecomment-670788340
Run XVR_Direct PostCommit
This is an automated message from the Apache Git Service.
To respond to the messag
amaliujia commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467330787
##
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/EvaluationContext.java
##
@@ -183,6 +188,15 @@ public void initialize(
amaliujia commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467330599
##
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java
##
@@ -81,6 +89,22 @@ public DirectTimerInter
TheNeuralBit commented on pull request #12481:
URL: https://github.com/apache/beam/pull/12481#issuecomment-670787524
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
lukecwik commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670785654
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467328411
##
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/EvaluationContext.java
##
@@ -183,6 +188,15 @@ public void initialize(
tvalentyn commented on pull request #12503:
URL: https://github.com/apache/beam/pull/12503#issuecomment-670784808
[incubator-beam...](https://www.alamy.com/old-fork-image276307480.html)
This is an automated message from the A
lukecwik commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670784538
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message, p
lukecwik commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670784514
Run Flink ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message, p
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467326804
##
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
##
@@ -126,23 +12
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467326841
##
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
##
@@ -126,23 +12
tvalentyn merged pull request #12503:
URL: https://github.com/apache/beam/pull/12503
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tvalentyn commented on pull request #12503:
URL: https://github.com/apache/beam/pull/12503#issuecomment-670783195
Both suites listed as 'Pending' on the PR have passed:
https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_PR/286/
https://ci-beam.apache.org/job/be
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467324258
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##
@@ -1499,6 +1504,146 @@ public void populateDisplayData(Build
lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467324202
##
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java
##
@@ -81,6 +89,22 @@ public DirectTimerIntern
emilymye opened a new pull request #12505:
URL: https://github.com/apache/beam/pull/12505
Adding version number to Java image names (in anticipation of releasing
java11 container)
Thank you for your contribution! Follow this checklist to help us
incor
lostluck merged pull request #12504:
URL: https://github.com/apache/beam/pull/12504
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
youngoli commented on pull request #12504:
URL: https://github.com/apache/beam/pull/12504#issuecomment-670774483
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please log on
youngoli opened a new pull request #12504:
URL: https://github.com/apache/beam/pull/12504
Should be checking for nil-ness in the primary/residual elements.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
pabloem commented on pull request #12485:
URL: https://github.com/apache/beam/pull/12485#issuecomment-670774285
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r467317077
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##
@@ -1306,112 +1315,206 @@ public void populateDisplayData(Dis
rohdesamuel commented on pull request #12413:
URL: https://github.com/apache/beam/pull/12413#issuecomment-670773173
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messag
rohdesamuel commented on pull request #12413:
URL: https://github.com/apache/beam/pull/12413#issuecomment-670772725
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messag
rohdesamuel commented on pull request #12413:
URL: https://github.com/apache/beam/pull/12413#issuecomment-670772593
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messag
rohdesamuel commented on pull request #12413:
URL: https://github.com/apache/beam/pull/12413#issuecomment-670772413
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messag
rohdesamuel commented on pull request #12413:
URL: https://github.com/apache/beam/pull/12413#issuecomment-670772296
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messag
rohdesamuel commented on pull request #12413:
URL: https://github.com/apache/beam/pull/12413#issuecomment-670771070
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messag
pabloem commented on pull request #12485:
URL: https://github.com/apache/beam/pull/12485#issuecomment-670770564
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
pabloem commented on pull request #12485:
URL: https://github.com/apache/beam/pull/12485#issuecomment-670770499
r: @chamikaramj
This is an automated message from the Apache Git Service.
To respond to the message, please log
ibzib commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467313292
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##
@@ -1499,6 +1504,146 @@ public void populateDisplayData(Builder
ibzib commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467307061
##
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
##
@@ -126,23 +128,3
TheNeuralBit merged pull request #12440:
URL: https://github.com/apache/beam/pull/12440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pabloem commented on pull request #12480:
URL: https://github.com/apache/beam/pull/12480#issuecomment-670763547
thanks - this looks great fwiw : )
This is an automated message from the Apache Git Service.
To respond to the me
amaliujia commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670758669
Thanks @lukecwik
Will take a look at this PR soon.
This is an automated message from the Apache Git Ser
lukecwik commented on pull request #12503:
URL: https://github.com/apache/beam/pull/12503#issuecomment-670747167
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message, p
lukecwik commented on pull request #12503:
URL: https://github.com/apache/beam/pull/12503#issuecomment-670747393
Run Flink ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message, p
lukecwik commented on pull request #11924:
URL: https://github.com/apache/beam/pull/11924#issuecomment-670746244
This PR enabled new tests which are failing with some of the validates
runner tests. for example:
https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/77
lukecwik commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670746769
Expanded existing JIRA: https://issues.apache.org/jira/browse/BEAM-8460,
opened #12503 to disable failing test category for spark and flink
lukecwik opened a new pull request #12503:
URL: https://github.com/apache/beam/pull/12503
Tests were added as part of #11924 that fail on Spark and Flink.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution q
TheNeuralBit commented on pull request #12481:
URL: https://github.com/apache/beam/pull/12481#issuecomment-670735024
Run XVR_Direct PostCommit
This is an automated message from the Apache Git Service.
To respond to the messag
TheNeuralBit edited a comment on pull request #12481:
URL: https://github.com/apache/beam/pull/12481#issuecomment-670704670
@mxm or @chadrik any chance you'd be able to review the Python changes in
this PR? I'd like to get it merged before the 2.24.0 release cut on Aug 12
lukecwik commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670729248
The test failure is known issue, failing in postcommit
https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/7773/testReport/
and
https://ci-beam.apache.org
TheNeuralBit commented on pull request #12497:
URL: https://github.com/apache/beam/pull/12497#issuecomment-670727799
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
Imfuyuwei commented on pull request #12502:
URL: https://github.com/apache/beam/pull/12502#issuecomment-670727033
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
boyuanzz commented on a change in pull request #12430:
URL: https://github.com/apache/beam/pull/12430#discussion_r467296625
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1029,7 +1040,27 @@ public double getProgress() {
ettirapp commented on pull request #12487:
URL: https://github.com/apache/beam/pull/12487#issuecomment-670726300
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
TheNeuralBit commented on pull request #12440:
URL: https://github.com/apache/beam/pull/12440#issuecomment-670726192
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messa
TheNeuralBit commented on pull request #12440:
URL: https://github.com/apache/beam/pull/12440#issuecomment-670726149
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r467293660
##
File path: sdks/python/apache_beam/testing/datatype_inference_test.py
##
@@ -174,6 +175,7 @@ def test_infer_typehints_schema(self, _, data, schema)
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670725606
Run Dataflow ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the messag
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670725497
run flink portable validatesrunner
This is an automated message from the Apache Git Service.
To respond to the
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670725554
run spark validatesrunner
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib merged pull request #12484:
URL: https://github.com/apache/beam/pull/12484
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ibzib commented on pull request #12486:
URL: https://github.com/apache/beam/pull/12486#issuecomment-670725230
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, ple
reuvenlax commented on pull request #12474:
URL: https://github.com/apache/beam/pull/12474#issuecomment-670725432
run flink validatesrunner
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik commented on pull request #12488:
URL: https://github.com/apache/beam/pull/12488#issuecomment-670724401
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
TheNeuralBit commented on pull request #12498:
URL: https://github.com/apache/beam/pull/12498#issuecomment-670717056
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the messag
lukecwik commented on a change in pull request #12430:
URL: https://github.com/apache/beam/pull/12430#discussion_r467272382
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1029,7 +1040,27 @@ public double getProgress() {
danielxjd commented on pull request #12223:
URL: https://github.com/apache/beam/pull/12223#issuecomment-670715872
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ZijieSong946 commented on a change in pull request #12500:
URL: https://github.com/apache/beam/pull/12500#discussion_r467270930
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamSqlUnparseContext.java
##
@@ -110,
ibzib commented on pull request #12486:
URL: https://github.com/apache/beam/pull/12486#issuecomment-670711952
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
Imfuyuwei commented on a change in pull request #12502:
URL: https://github.com/apache/beam/pull/12502#discussion_r467266754
##
File path:
sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apach
TheNeuralBit commented on pull request #12481:
URL: https://github.com/apache/beam/pull/12481#issuecomment-670710921
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
boyuanzz commented on a change in pull request #12430:
URL: https://github.com/apache/beam/pull/12430#discussion_r467266336
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1029,7 +1040,27 @@ public double getProgress() {
pabloem merged pull request #12473:
URL: https://github.com/apache/beam/pull/12473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
TheNeuralBit commented on pull request #12481:
URL: https://github.com/apache/beam/pull/12481#issuecomment-670704670
@mxm or @chadrik any chance you'd be able to review the Python changes in
this PR? I'd like to get it merge before the 2.24.0 release cut on Aug 12
1 - 100 of 222 matches
Mail list logo