[PR] Bump github.com/docker/docker from 25.0.5+incompatible to 26.0.1+incompatible in /sdks [beam]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #30948: URL: https://github.com/apache/beam/pull/30948 Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.5+incompatible to 26.0.1+incompatible. Release notes Sourced from

Re: [PR] Bump github.com/docker/docker from 25.0.5+incompatible to 26.0.0+incompatible in /sdks [beam]

2024-04-11 Thread via GitHub
dependabot[bot] closed pull request #30763: Bump github.com/docker/docker from 25.0.5+incompatible to 26.0.0+incompatible in /sdks URL: https://github.com/apache/beam/pull/30763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Bump github.com/docker/docker from 25.0.5+incompatible to 26.0.0+incompatible in /sdks [beam]

2024-04-11 Thread via GitHub
dependabot[bot] commented on PR #30763: URL: https://github.com/apache/beam/pull/30763#issuecomment-2050987260 Superseded by #30948. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py311 [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30944: URL: https://github.com/apache/beam/pull/30944#issuecomment-2050983917 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @tvalentyn for label python. Available commands: -

Re: [PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py310 [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30947: URL: https://github.com/apache/beam/pull/30947#issuecomment-2050983734 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py39 [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30945: URL: https://github.com/apache/beam/pull/30945#issuecomment-2050983851 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @shunping for label python. Available commands: - `stop

Re: [PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py38 [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30946: URL: https://github.com/apache/beam/pull/30946#issuecomment-2050983784 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

[PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py310 [beam]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #30947: URL: https://github.com/apache/beam/pull/30947 Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7. Release notes Sourced from https://github.com/kjd/idna/releases;>idna's releases. v3.7 What's Changed Fix

[PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py39 [beam]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #30945: URL: https://github.com/apache/beam/pull/30945 Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7. Release notes Sourced from https://github.com/kjd/idna/releases;>idna's releases. v3.7 What's Changed Fix

[PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py38 [beam]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #30946: URL: https://github.com/apache/beam/pull/30946 Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7. Release notes Sourced from https://github.com/kjd/idna/releases;>idna's releases. v3.7 What's Changed Fix

[PR] Bump idna from 3.6 to 3.7 in /sdks/python/container/py311 [beam]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #30944: URL: https://github.com/apache/beam/pull/30944 Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7. Release notes Sourced from https://github.com/kjd/idna/releases;>idna's releases. v3.7 What's Changed Fix

[PR] SchemaTransformProviderTranslation [beam]

2024-04-11 Thread via GitHub
ahmedabu98 opened a new pull request, #30943: URL: https://github.com/apache/beam/pull/30943 This PR adds support for upgrading any generic SchemaTransform without upgrading the pipeline. This includes breaking changes to the `SchemaTransform` class, which now has a protected

Re: [PR] Update java-dependency-guide contributor-doc reflecting gcpbomupgrader script [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30942: URL: https://github.com/apache/beam/pull/30942#issuecomment-2050905054 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] Bump tar from 6.1.11 to 6.2.1 in /sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel [beam]

2024-04-11 Thread via GitHub
riteshghorse merged PR #30928: URL: https://github.com/apache/beam/pull/30928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [YAML] Adds several tests exercising the cross-language capabilities. [beam]

2024-04-11 Thread via GitHub
riteshghorse commented on code in PR #30880: URL: https://github.com/apache/beam/pull/30880#discussion_r1561952478 ## sdks/python/apache_beam/yaml/yaml_provider.py: ## @@ -875,15 +875,15 @@ def create_java_builtin_provider(): # where possible. This would also require extra

Re: [PR] Add code change guide contributor-doc [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30879: URL: https://github.com/apache/beam/pull/30879#issuecomment-2050882950 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

[PR] Update java-dependency-guide contributor-doc reflecting gcpbomupgrader script [beam]

2024-04-11 Thread via GitHub
Abacn opened a new pull request, #30942: URL: https://github.com/apache/beam/pull/30942 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [I] [Feature Request]: Support table schema field addition with Storage Write API autoSchemaUpdate [beam]

2024-04-11 Thread via GitHub
lucasnoetzold commented on issue #27478: URL: https://github.com/apache/beam/issues/27478#issuecomment-2050830165 > There should be a way to update the schema when appropriate. > This feature is already supported, closing. I ran into this issue recently, is there any way to

Re: [PR] Change ManagedSchemaTransformProvider to take a Row config [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30937: URL: https://github.com/apache/beam/pull/30937#issuecomment-2050805127 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] Re-add iceberg bounded source; test splitting [beam]

2024-04-11 Thread via GitHub
chamikaramj commented on PR #30805: URL: https://github.com/apache/beam/pull/30805#issuecomment-2050791057 LGTM other than handling the re-splitting case above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Re-add iceberg bounded source; test splitting [beam]

2024-04-11 Thread via GitHub
chamikaramj commented on code in PR #30805: URL: https://github.com/apache/beam/pull/30805#discussion_r1561896932 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/CombinedScanReader.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Re-add iceberg bounded source; test splitting [beam]

2024-04-11 Thread via GitHub
chamikaramj commented on code in PR #30805: URL: https://github.com/apache/beam/pull/30805#discussion_r1561894989 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/ScanSource.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Change ManagedSchemaTransformProvider to take a Row config [beam]

2024-04-11 Thread via GitHub
ahmedabu98 commented on PR #30937: URL: https://github.com/apache/beam/pull/30937#issuecomment-2050773630 Java IO precommit failing due to #30941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix broken lint and improve lint rules. [beam]

2024-04-11 Thread via GitHub
liferoad commented on PR #30940: URL: https://github.com/apache/beam/pull/30940#issuecomment-2050756300 cc @akashorabek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Disable profiling in cythonized code by default. [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30938: URL: https://github.com/apache/beam/pull/30938#issuecomment-2050753843 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label python. Available commands: - `stop

Re: [PR] Fix broken lint and improve lint rules. [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30940: URL: https://github.com/apache/beam/pull/30940#issuecomment-2050753819 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] python sdk: fix several bugs regarding avto <-> beam schema conversion [beam]

2024-04-11 Thread via GitHub
ahmedabu98 commented on code in PR #30770: URL: https://github.com/apache/beam/pull/30770#discussion_r1561872345 ## sdks/python/apache_beam/io/avroio.py: ## @@ -649,7 +684,11 @@ def beam_schema_to_avro_schema( def beam_type_to_avro_type(beam_type: schema_pb2.FieldType) ->

Re: [PR] Fix broken lint and improve lint rules. [beam]

2024-04-11 Thread via GitHub
tvalentyn commented on PR #30940: URL: https://github.com/apache/beam/pull/30940#issuecomment-2050735435 whitespace passed: https://github.com/apache/beam/actions/runs/8654695878/job/23732370373?pr=30940 -- This is an automated message from the Apache Git Service. To respond to the

[PR] Fix broken lint and improve lint rules. [beam]

2024-04-11 Thread via GitHub
tvalentyn opened a new pull request, #30940: URL: https://github.com/apache/beam/pull/30940 Lint got broken by https://github.com/apache/beam/pull/30886 , but lint check didn't run on that PR. Thank you for your contribution! Follow this checklist to

Re: [PR] python sdk: fix several bugs regarding avto <-> beam schema conversion [beam]

2024-04-11 Thread via GitHub
ahmedabu98 commented on code in PR #30770: URL: https://github.com/apache/beam/pull/30770#discussion_r1561855432 ## sdks/python/apache_beam/io/avroio_test.py: ## @@ -149,17 +151,37 @@ def _run_avro_test( def test_schema_read_write(self): with

Re: [PR] Move dependency updates to right after branch cut [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30939: URL: https://github.com/apache/beam/pull/30939#issuecomment-2050713963 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Move dependency updates to right after branch cut [beam]

2024-04-11 Thread via GitHub
damccorm commented on PR #30939: URL: https://github.com/apache/beam/pull/30939#issuecomment-2050713177 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Move dependency updates to right after branch cut [beam]

2024-04-11 Thread via GitHub
damccorm opened a new pull request, #30939: URL: https://github.com/apache/beam/pull/30939 This will give dependencies more time to bake Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [PR] Add config validation to kafka read schema transform [beam]

2024-04-11 Thread via GitHub
ahmedabu98 merged PR #30625: URL: https://github.com/apache/beam/pull/30625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Disable profiling in cythonized code by default. [beam]

2024-04-11 Thread via GitHub
tvalentyn commented on PR #30938: URL: https://github.com/apache/beam/pull/30938#issuecomment-2050703228 cc: @robertwb FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Disable profiling in cythonized code by default. [beam]

2024-04-11 Thread via GitHub
tvalentyn opened a new pull request, #30938: URL: https://github.com/apache/beam/pull/30938 Rationale: - Doesn't work in Python 3.12: https://github.com/cython/cython/issues/5470 , which affects #30828 . - might improve performance. from

Re: [I] [Bug]: Install fails with Python3.12 due to old grpcio-tools version [beam]

2024-04-11 Thread via GitHub
tvalentyn closed issue #30820: [Bug]: Install fails with Python3.12 due to old grpcio-tools version URL: https://github.com/apache/beam/issues/30820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Upgrade grpcio-tools. [beam]

2024-04-11 Thread via GitHub
tvalentyn merged PR #30912: URL: https://github.com/apache/beam/pull/30912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Change ManagedSchemaTransformProvider to take a Row config [beam]

2024-04-11 Thread via GitHub
ahmedabu98 opened a new pull request, #30937: URL: https://github.com/apache/beam/pull/30937 This is a small implementation detail change to make `ManagedSchemaTransformProvider` take a config represented as a Row instead of a YAML string. It makes more sense for xlang use-cases to send a

Re: [PR] Restore pip logs also for requirements.txt case [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30936: URL: https://github.com/apache/beam/pull/30936#issuecomment-2050664014 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Restore pip logs also for requirements.txt case [beam]

2024-04-11 Thread via GitHub
tvalentyn commented on PR #30936: URL: https://github.com/apache/beam/pull/30936#issuecomment-2050662853 R: @jrmccluskey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Restore pip logs also for requirements.txt case [beam]

2024-04-11 Thread via GitHub
tvalentyn opened a new pull request, #30936: URL: https://github.com/apache/beam/pull/30936 This is a follow-up for https://github.com/apache/beam/pull/28317/commits/31119dad62a951a075d532813e92e5d108e044da . Thank you for your contribution! Follow

Re: [PR] Update sqlalchemy requirement from >=1.3,<2.0 to >=1.3,<3.0 in /sdks/python [beam]

2024-04-11 Thread via GitHub
AnandInguva commented on PR #30919: URL: https://github.com/apache/beam/pull/30919#issuecomment-2050655729 @Dippatel98 merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update sqlalchemy requirement from >=1.3,<2.0 to >=1.3,<3.0 in /sdks/python [beam]

2024-04-11 Thread via GitHub
AnandInguva merged PR #30919: URL: https://github.com/apache/beam/pull/30919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Upload PerWorkerMetrics every 30 second instead of every 10 seconds [beam]

2024-04-11 Thread via GitHub
JayajP commented on PR #30795: URL: https://github.com/apache/beam/pull/30795#issuecomment-2050621276 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Upload PerWorkerMetrics every 30 second instead of every 10 seconds [beam]

2024-04-11 Thread via GitHub
codecov-commenter commented on PR #30795: URL: https://github.com/apache/beam/pull/30795#issuecomment-2050383573 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30795?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Add PubSubIO Stress test [beam]

2024-04-11 Thread via GitHub
Abacn merged PR #30886: URL: https://github.com/apache/beam/pull/30886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Create YAML Join Transform [beam]

2024-04-11 Thread via GitHub
robertwb commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561503823 ## sdks/python/apache_beam/yaml/yaml_join_test.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

2024-04-11 Thread via GitHub
Polber commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561492612 ## sdks/python/apache_beam/yaml/yaml_join_test.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

2024-04-11 Thread via GitHub
Polber commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561359256 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Bump transformers from 4.36.0 to 4.38.0 in /sdks/python/apache_beam/examples/inference/runinference_metrics [beam]

2024-04-11 Thread via GitHub
tvalentyn merged PR #30924: URL: https://github.com/apache/beam/pull/30924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixup iceberg GitHub Action workflow [beam]

2024-04-11 Thread via GitHub
kennknowles merged PR #30935: URL: https://github.com/apache/beam/pull/30935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixup iceberg GitHub Action workflow [beam]

2024-04-11 Thread via GitHub
kennknowles commented on PR #30935: URL: https://github.com/apache/beam/pull/30935#issuecomment-2050207366 https://github.com/apache/beam/actions/runs/8650999727/job/23720718775 shows that it works and finds a problem in the module -- This is an automated message from the Apache Git

Re: [PR] Bump pillow from 10.2.0 to 10.3.0 in /sdks/python/apache_beam/examples/ml-orchestration/kfp/components/train [beam]

2024-04-11 Thread via GitHub
dependabot[bot] commented on PR #30840: URL: https://github.com/apache/beam/pull/30840#issuecomment-2050193885 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump pillow from 10.2.0 to 10.3.0 in /sdks/python/apache_beam/examples/ml-orchestration/kfp/components/train [beam]

2024-04-11 Thread via GitHub
liferoad closed pull request #30840: Bump pillow from 10.2.0 to 10.3.0 in /sdks/python/apache_beam/examples/ml-orchestration/kfp/components/train URL: https://github.com/apache/beam/pull/30840 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fixup iceberg GitHub Action workflow [beam]

2024-04-11 Thread via GitHub
kennknowles commented on code in PR #30935: URL: https://github.com/apache/beam/pull/30935#discussion_r1561377516 ## .github/workflows/IO_Iceberg.yml: ## @@ -71,8 +71,7 @@ jobs: github.event_name == 'push' || github.event_name == 'pull_request_target' ||

Re: [PR] Fixup iceberg GitHub Action workflow [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30935: URL: https://github.com/apache/beam/pull/30935#issuecomment-2050180158 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label build. Available commands: - `stop

Re: [PR] Update Python Dependencies from BRANCH weekly_update_python_dependencies_1712449899 [beam]

2024-04-11 Thread via GitHub
tvalentyn closed pull request #30881: Update Python Dependencies from BRANCH weekly_update_python_dependencies_1712449899 URL: https://github.com/apache/beam/pull/30881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fixup iceberg GitHub Action workflow [beam]

2024-04-11 Thread via GitHub
Abacn commented on code in PR #30935: URL: https://github.com/apache/beam/pull/30935#discussion_r1561358925 ## .github/workflows/IO_Iceberg.yml: ## @@ -71,8 +71,7 @@ jobs: github.event_name == 'push' || github.event_name == 'pull_request_target' ||

Re: [PR] Update sqlalchemy requirement from >=1.3,<2.0 to >=1.3,<3.0 in /sdks/python [beam]

2024-04-11 Thread via GitHub
Dippatel98 commented on PR #30919: URL: https://github.com/apache/beam/pull/30919#issuecomment-2050157869 > Could you try pulling in the latest master? I'm seeing `testPy38tft-113` failures from `pip check` which I think should be fixed on master. > > ``` > tensorflow 2.13.1 has

Re: [PR] Fixup iceberg GitHub Action workflow [beam]

2024-04-11 Thread via GitHub
Abacn commented on PR #30935: URL: https://github.com/apache/beam/pull/30935#issuecomment-2050156109 Let's also add this workflow to https://github.com/apache/beam/blob/master/.github/workflows/README.md so there is an eye on the status of it The naming was inherited from Jenkins

[PR] Fixup iceberg GitHub Action workflow [beam]

2024-04-11 Thread via GitHub
kennknowles opened a new pull request, #30935: URL: https://github.com/apache/beam/pull/30935 There was an interpolation variable incidentally left in it when I forked from another file. Thank you for your contribution! Follow this checklist to help us

Re: [PR] IcebergIO translation [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30933: URL: https://github.com/apache/beam/pull/30933#issuecomment-2050090771 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] IcebergIO translation [beam]

2024-04-11 Thread via GitHub
ahmedabu98 commented on PR #30933: URL: https://github.com/apache/beam/pull/30933#issuecomment-2050088978 R: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add a link to Grafana statistics for flaky workflows [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30934: URL: https://github.com/apache/beam/pull/30934#issuecomment-2050083907 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck added as fallback since no labels match configuration

Re: [PR] Iceberg Write SchemaTransform [beam]

2024-04-11 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1561302426 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/IcebergWriteSchemaTransformProvider.java: ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache

Re: [PR] Create YAML Join Transform [beam]

2024-04-11 Thread via GitHub
robertwb commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561297296 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

2024-04-11 Thread via GitHub
robertwb commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561294409 ## sdks/python/apache_beam/yaml/yaml_join_test.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[PR] Add a link to Grafana statistics for flaky workflows [beam]

2024-04-11 Thread via GitHub
andreydevyatkin opened a new pull request, #30934: URL: https://github.com/apache/beam/pull/30934 Added a link to Grafana statistics for flaky workflows Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] [yaml] Fix Beam YAML blog links [beam]

2024-04-11 Thread via GitHub
damccorm merged PR #30932: URL: https://github.com/apache/beam/pull/30932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [YAML] Adds several tests exercising the cross-language capabilities. [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30880: URL: https://github.com/apache/beam/pull/30880#issuecomment-2050039706 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-04-11 Thread via GitHub
robertwb commented on PR #30793: URL: https://github.com/apache/beam/pull/30793#issuecomment-2050038374 Any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add PubSubIO Stress test [beam]

2024-04-11 Thread via GitHub
akashorabek commented on code in PR #30886: URL: https://github.com/apache/beam/pull/30886#discussion_r1561276933 ## it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/pubsub/PubSubIOST.java: ## @@ -0,0 +1,510 @@ +/* + * Licensed to the Apache Software Foundation

[PR] IcebergIO translation [beam]

2024-04-11 Thread via GitHub
ahmedabu98 opened a new pull request, #30933: URL: https://github.com/apache/beam/pull/30933 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [YAML] Adds several tests exercising the cross-language capabilities. [beam]

2024-04-11 Thread via GitHub
robertwb commented on PR #30880: URL: https://github.com/apache/beam/pull/30880#issuecomment-2050037585 R: @riteshghorse -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [yaml] Fix Beam YAML blog links [beam]

2024-04-11 Thread via GitHub
damccorm commented on code in PR #30932: URL: https://github.com/apache/beam/pull/30932#discussion_r1561271050 ## website/www/site/content/en/blog/beam-yaml-release.md: ## @@ -39,26 +39,26 @@ come at the expense of sacrificing the rich features that Beam offers. Here are some

Re: [PR] [yaml] Fix Beam YAML blog links [beam]

2024-04-11 Thread via GitHub
damccorm commented on code in PR #30932: URL: https://github.com/apache/beam/pull/30932#discussion_r1561269048 ## website/www/site/content/en/blog/beam-yaml-release.md: ## @@ -39,26 +39,26 @@ come at the expense of sacrificing the rich features that Beam offers. Here are some

Re: [PR] Add gradle target and github workflow for cross-langauge yaml tests. [beam]

2024-04-11 Thread via GitHub
robertwb merged PR #30874: URL: https://github.com/apache/beam/pull/30874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [yaml] Fix Beam YAML blog links [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30932: URL: https://github.com/apache/beam/pull/30932#issuecomment-2049970446 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] [yaml] Fix Beam YAML blog links [beam]

2024-04-11 Thread via GitHub
Polber commented on PR #30932: URL: https://github.com/apache/beam/pull/30932#issuecomment-2049967553 R: @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [yaml] Fix Beam YAML blog links [beam]

2024-04-11 Thread via GitHub
Polber opened a new pull request, #30932: URL: https://github.com/apache/beam/pull/30932 Link and formatting fixes for Beam YAML Blog. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [PR] Update sqlalchemy requirement from >=1.3,<2.0 to >=1.3,<3.0 in /sdks/python [beam]

2024-04-11 Thread via GitHub
damccorm commented on PR #30919: URL: https://github.com/apache/beam/pull/30919#issuecomment-2049960029 Could you try pulling in the latest master? I'm seeing `testPy38tft-113` failures from `pip check` which I think should be fixed on master. ``` tensorflow 2.13.1 has requirement

Re: [I] [Bug]: OnTimer("loopingTimer") not triggered on 2.52.0 [beam]

2024-04-11 Thread via GitHub
je-ik commented on issue #29816: URL: https://github.com/apache/beam/issues/29816#issuecomment-2049956358 I see similar issues with 2.55.0 using Kafka and `--experiments=use_deprecated_read`. This seems to work if `experiments=beam_fn_api` is used, but this works only for classical

Re: [PR] Remove comma that breaks formatting [beam]

2024-04-11 Thread via GitHub
damccorm merged PR #30931: URL: https://github.com/apache/beam/pull/30931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix playground typo breaking rendering [beam]

2024-04-11 Thread via GitHub
Abacn merged PR #30930: URL: https://github.com/apache/beam/pull/30930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix playground typo breaking rendering [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30930: URL: https://github.com/apache/beam/pull/30930#issuecomment-2049910462 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Fix playground typo breaking rendering [beam]

2024-04-11 Thread via GitHub
damccorm commented on PR #30930: URL: https://github.com/apache/beam/pull/30930#issuecomment-2049906712 R: @liferoad @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove comma that breaks formatting [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30931: URL: https://github.com/apache/beam/pull/30931#issuecomment-2049832837 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Remove comma that breaks formatting [beam]

2024-04-11 Thread via GitHub
damccorm commented on PR #30931: URL: https://github.com/apache/beam/pull/30931#issuecomment-2049826383 R: @liferoad @Polber -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Remove comma that breaks formatting [beam]

2024-04-11 Thread via GitHub
damccorm opened a new pull request, #30931: URL: https://github.com/apache/beam/pull/30931 This keeps the notebook from rendering Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [PR] Fix cron in github workflow file [beam]

2024-04-11 Thread via GitHub
damccorm merged PR #30929: URL: https://github.com/apache/beam/pull/30929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix playground typo breaking rendering [beam]

2024-04-11 Thread via GitHub
damccorm opened a new pull request, #30930: URL: https://github.com/apache/beam/pull/30930 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] Fix cron in github workflow file [beam]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #30929: URL: https://github.com/apache/beam/pull/30929#issuecomment-2049773947 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label build. Available commands: - `stop

Re: [PR] [yaml] Add Beam YAML Blog [beam]

2024-04-11 Thread via GitHub
damccorm merged PR #30898: URL: https://github.com/apache/beam/pull/30898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix cron in github workflow file [beam]

2024-04-11 Thread via GitHub
Amar3tto opened a new pull request, #30929: URL: https://github.com/apache/beam/pull/30929 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue

Re: [PR] create helper function [beam]

2024-04-11 Thread via GitHub
liferoad commented on PR #26225: URL: https://github.com/apache/beam/pull/26225#issuecomment-2049696711 @smeet07 are you still working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] The PostRelease Nightly Snapshot job is flaky [beam]

2024-04-11 Thread via GitHub
liferoad commented on issue #30505: URL: https://github.com/apache/beam/issues/30505#issuecomment-2049687189 https://github.com/apache/beam/actions/runs/8619063045 ``` java.lang.RuntimeException: com.google.api.client.googleapis.json.GoogleJsonResponseException: 404 Not Found

Re: [PR] Add PubSubIO Stress test [beam]

2024-04-11 Thread via GitHub
Abacn commented on code in PR #30886: URL: https://github.com/apache/beam/pull/30886#discussion_r1561016059 ## it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/pubsub/PubSubIOST.java: ## @@ -0,0 +1,510 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Load and Stress Tests: Add workflows, improvements and fixes [beam]

2024-04-11 Thread via GitHub
Abacn merged PR #30848: URL: https://github.com/apache/beam/pull/30848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [yaml] Add Beam YAML Blog [beam]

2024-04-11 Thread via GitHub
damccorm commented on code in PR #30898: URL: https://github.com/apache/beam/pull/30898#discussion_r1561003136 ## website/www/site/content/en/blog/beam-yaml-release.md: ## @@ -0,0 +1,318 @@ +--- +title: "Introducing Beam YAML: Apache Beam's First No-code SDK" +date:

  1   2   >