Re: [PR] Create YAML Join Transform [beam]

damccorm commented on PR #30734: URL: https://github.com/apache/beam/pull/30734#issuecomment-2061559694 Merging to make the release cut; @Polber will follow up and do some additional validation, and we will cherry-pick any changes if needed -- This is an automated message from the Apache

Re: [PR] Create YAML Join Transform [beam]

damccorm merged PR #30734: URL: https://github.com/apache/beam/pull/30734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Create YAML Join Transform [beam]

Polber commented on PR #30734: URL: https://github.com/apache/beam/pull/30734#issuecomment-2060172249 It looks like you addressed all my initial comments, and overall looks good. I will probably take another deeper look in the morning, but don't block on me. -- This is an automated

Re: [PR] Create YAML Join Transform [beam]

itodotimothy6 commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1566240502 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

robertwb commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561503823 ## sdks/python/apache_beam/yaml/yaml_join_test.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

Polber commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561492612 ## sdks/python/apache_beam/yaml/yaml_join_test.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

Polber commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561359256 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

robertwb commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561297296 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

robertwb commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561294409 ## sdks/python/apache_beam/yaml/yaml_join_test.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

itodotimothy6 commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1557157650 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

Polber commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1556253586 ## sdks/python/apache_beam/yaml/yaml_join_test.py: ## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Create YAML Join Transform [beam]

robertwb commented on PR #30734: URL: https://github.com/apache/beam/pull/30734#issuecomment-2040585964 If Beam SQL doesn't support cross join out of the box, we don't have to support it for our join (yet) either. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Create YAML Join Transform [beam]

Polber commented on PR #30734: URL: https://github.com/apache/beam/pull/30734#issuecomment-2040575468 > @Polber Do I need to take any action or do I just wait for #30681 and #30864 to be merged? #30864 should fix the issue once it is merged. I was also wrong with my initial claim.

Re: [PR] Create YAML Join Transform [beam]

Polber commented on PR #30734: URL: https://github.com/apache/beam/pull/30734#issuecomment-2038579469 @robertwb @itodotimothy6 FYI this breaks on master due to * https://github.com/apache/beam/pull/30681 I have only been able to repro by using any `SqlBackedProvider` with a query

Re: [PR] Create YAML Join Transform [beam]

itodotimothy6 commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1552520613 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,161 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license