Abacn commented on PR #30638:
URL: https://github.com/apache/beam/pull/30638#issuecomment-2015476490
There is (only) one integration test failing, not too bad:
testBigQueryStorageReadProjectionPushdown
(org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOStorageReadIT) failed
```
Abacn merged PR #30638:
URL: https://github.com/apache/beam/pull/30638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tilgalas commented on PR #30638:
URL: https://github.com/apache/beam/pull/30638#issuecomment-2000383923
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tilgalas commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1526682326
##
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##
@@ -262,8 +262,7 @@ private static
tilgalas commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1526708241
##
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##
@@ -630,7 +630,7 @@ public static SimpleFunction
tilgalas commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1526704038
##
sdks/java/extensions/avro/build.gradle:
##
@@ -72,6 +72,7 @@ dependencies {
}
testImplementation library.java.avro_tests
testImplementation
tilgalas commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1526682326
##
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##
@@ -262,8 +262,7 @@ private static
Abacn commented on PR #30638:
URL: https://github.com/apache/beam/pull/30638#issuecomment-2000166401
also, it's good to run
https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_Avro_Versions.yml
in this PR. You can add an empty file named
Abacn commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1526621904
##
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##
@@ -262,8 +262,7 @@ private static
Abacn commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1525626255
##
sdks/java/extensions/avro/build.gradle:
##
@@ -65,6 +65,7 @@ dependencies {
}
implementation library.java.error_prone_annotations
implementation
tilgalas commented on PR #30638:
URL: https://github.com/apache/beam/pull/30638#issuecomment-1998309674
> Thanks for the contribution! It involves avro dependency and things get
tricky. As avro dependency in Beam is known to be hard to change.
>
> Is it possible to avoid avro
tilgalas commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1525409424
##
sdks/java/extensions/avro/build.gradle:
##
@@ -65,6 +65,7 @@ dependencies {
}
implementation library.java.error_prone_annotations
implementation
Abacn commented on PR #30638:
URL: https://github.com/apache/beam/pull/30638#issuecomment-1998147482
Thanks for the contribution! It involves avro dependency and things get
tricky. As avro dependency in Beam is known to be hard to change.
Is it possible to avoid avro dependency
Abacn commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1525362674
##
sdks/java/extensions/avro/build.gradle:
##
@@ -65,6 +65,7 @@ dependencies {
}
implementation library.java.error_prone_annotations
implementation
Abacn commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1525361475
##
buildSrc/build.gradle.kts:
##
@@ -45,7 +45,7 @@ dependencies {
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.0.14")
Abacn commented on PR #30638:
URL: https://github.com/apache/beam/pull/30638#issuecomment-1998128575
There are test failures related to avro code generation dependency change:
```
java.lang.NoClassDefFoundError: Could not initialize class
github-actions[bot] commented on PR #30638:
URL: https://github.com/apache/beam/pull/30638#issuecomment-1998041763
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated
tilgalas opened a new pull request, #30638:
URL: https://github.com/apache/beam/pull/30638
fixes #30610
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the
18 matches
Mail list logo
