Re: [PR] Add direct path code path [beam]

m-trieu closed pull request #30764: Add direct path code path URL: https://github.com/apache/beam/pull/30764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add direct path code path [beam]

github-actions[bot] commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2110047506 Reminder, please take a look at this pr: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add direct path code path [beam]

scwhittle commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2097906406 @m-trieu Should we close this one for now? We can reopen after rebasing on top of the broken off PRs -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add direct path code path [beam]

scwhittle commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2097904574 @Abacn not sure how to turn off the reminders but this doesn't require a look. It is being broken apart into smaller PRs which I am reviewing. -- This is an automated message from

Re: [PR] Add direct path code path [beam]

github-actions[bot] commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2095876770 Reminder, please take a look at this pr: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1582573447 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/ApplianceWorkerHarness.java: ## @@ -0,0 +1,572 @@

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1582573261 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/WorkProcessingContext.java: ## @@ -0,0 +1,129 @@ +/* +

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1582572204 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/StreamingApplianceComputationStateCacheLoader.java: ## @@

Re: [PR] Add direct path code path [beam]

scwhittle commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575868637 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/ApplianceWorkerHarness.java: ## @@ -0,0 +1,572 @@

Re: [PR] Add direct path code path [beam]

scwhittle commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575866285 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/WorkProcessingContext.java: ## @@ -0,0 +1,129 @@ +/*

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575804014 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/StreamingApplianceComputationStateCacheLoader.java: ## @@

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575777026 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationStateCache.java: ## @@ -0,0 +1,127 @@ +/* + *

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575775495 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/ApplianceWorkerHarness.java: ## @@ -0,0 +1,572 @@

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575774956 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/WorkProcessingContext.java: ## @@ -0,0 +1,129 @@ +/* +

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575765433 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ExecutionState.java: ## @@ -51,4 +54,13 @@ public abstract

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575764755 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationState.java: ## @@ -128,21 +152,26 @@ private

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575763051 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationStateCache.java: ## @@ -0,0 +1,127 @@ +/* + *

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575759363 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationState.java: ## @@ -74,8 +79,22 @@ public

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575757857 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationState.java: ## @@ -74,8 +79,22 @@ public

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575749864 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ActiveWorkState.java: ## @@ -90,11 +83,11 @@ private

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575744499 ## runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsLogger.java: ## @@ -33,10 +33,18 @@ public class MetricsLogger extends

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1575743707 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/HotKeyLogger.java: ## @@ -18,30 +18,41 @@ package

Re: [PR] Add direct path code path [beam]

scwhittle commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1574449155 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/HotKeyLogger.java: ## @@ -18,30 +18,41 @@ package

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1559034068 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/computations/StreamingApplianceComputationStateCacheLoader.java:

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1559031664 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/StreamingEngineDirectPathWorkerHarness.java: ## @@

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1559030637 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/computations/ActiveWorkState.java: ## @@ -124,11 +128,40 @@

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1559030285 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/computations/ActiveWorkState.java: ## @@ -124,11 +128,40 @@

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1559027230 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/ReaderCache.java: ## @@ -39,7 +39,7 @@ @SuppressWarnings({

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1559027583 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java: ## @@ -599,8 +601,10 @@ public static

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1559026566 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/computations/ActiveWorkState.java: ## @@ -15,7 +15,7 @@ *

Re: [PR] Add direct path code path [beam]

m-trieu commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1558353180 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingApplianceConfigLoader.java: ## @@ -0,0

Re: [PR] Add direct path code path [beam]

scwhittle commented on code in PR #30764: URL: https://github.com/apache/beam/pull/30764#discussion_r1551205078 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkProgressUpdater.java: ## @@ -67,7 +67,7 @@ public

Re: [PR] Add direct path code path [beam]

codecov-commenter commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2036354141 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30764?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Add direct path code path [beam]

github-actions[bot] commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2036353096 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn added as fallback since no labels match configuration

Re: [PR] Add direct path code path [beam]

m-trieu commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2031242823 @scwhittle still wrapping up the unit tests, just would like an initial pass thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add direct path code path [beam]

github-actions[bot] commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2022091487 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated