echauchot opened a new pull request #12204:
URL: https://github.com/apache/beam/pull/12204
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
damgad commented on pull request #11968:
URL: https://github.com/apache/beam/pull/11968#issuecomment-656019586
@robertwb I've already written windows versions for the missing posix
functions. Please take a look @robertwb
https://github.com/apache/beam/pull/12172
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655957540
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
damgad commented on a change in pull request #12172:
URL: https://github.com/apache/beam/pull/12172#discussion_r452069922
##
File path: .github/workflows/build_wheels.yml
##
@@ -119,19 +123,24 @@ jobs:
uses: actions/setup-python@v2
with:
python-version:
lazylynx commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r452004982
##
File path: sdks/python/container/boot.go
##
@@ -170,6 +176,28 @@ func main() {
log.Fatalf("Python exited: %v", execx.Execute("python",
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656026101
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the
jmcomets closed pull request #12173:
URL: https://github.com/apache/beam/pull/12173
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jmcomets commented on pull request #12173:
URL: https://github.com/apache/beam/pull/12173#issuecomment-656090239
Closing this as I found a way to inject the pool generically, using
`withDataSourceProviderFn(...)`. IMO one of either methods should be available,
it took me a while before
kamilwu opened a new pull request #12205:
URL: https://github.com/apache/beam/pull/12205
Botocore is a part of [aws], not [interactive].
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and
echauchot commented on a change in pull request #12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452239069
##
File path:
runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##
@@ -69,20 +69,20
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-656151288
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
aromanenko-dev commented on a change in pull request #12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452188740
##
File path:
runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##
@@ -69,20
aromanenko-dev commented on a change in pull request #12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452188740
##
File path:
runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##
@@ -69,20
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-656171851
Run Chicago Taxi on Dataflow
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452329517
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java
##
@@ -15,54 +15,63
lgajowy merged pull request #12117:
URL: https://github.com/apache/beam/pull/12117
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robinyqiu commented on pull request #12163:
URL: https://github.com/apache/beam/pull/12163#issuecomment-656184593
Run SQL PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-656202548
R: @tvalentyn
This effectively fixes https://issues.apache.org/jira/browse/BEAM-10421 as
well. Look for "worker logs:" lines, there are links to Dataflow job details
aaltay edited a comment on pull request #12049:
URL: https://github.com/apache/beam/pull/12049#issuecomment-655635243
What files will be cleared this way? Release branches live forever. Would
there be other branches that this script will clean?
apilloud commented on a change in pull request #12163:
URL: https://github.com/apache/beam/pull/12163#discussion_r452337633
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##
@@ -182,11 +164,10 @@
aromanenko-dev commented on pull request #12204:
URL: https://github.com/apache/beam/pull/12204#issuecomment-656180610
I merge this PR since failed Java PreCommit test is not related.
This is an automated message from the
aromanenko-dev merged pull request #12204:
URL: https://github.com/apache/beam/pull/12204
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit merged pull request #12205:
URL: https://github.com/apache/beam/pull/12205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on pull request #12196:
URL: https://github.com/apache/beam/pull/12196#issuecomment-656201084
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lazylynx commented on pull request #12115:
URL: https://github.com/apache/beam/pull/12115#issuecomment-656225895
@tvalentyn Updated about wheel name with Python 3.8. PTAL.
This is an automated message from the Apache Git
TheNeuralBit commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452326180
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java
##
@@ -15,54 +15,63
TheNeuralBit commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452329517
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java
##
@@ -15,54 +15,63
TobKed commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r452297033
##
File path: .github/workflows/cancel.yml
##
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review
sclukas77 commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452346520
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java
##
@@ -15,54 +15,63 @@
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-656163912
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robinyqiu commented on pull request #12163:
URL: https://github.com/apache/beam/pull/12163#issuecomment-656168054
Run JavaPortabilityApiJava11 PreCommit
This is an automated message from the Apache Git Service.
To respond to
sclukas77 commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452308746
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java
##
@@ -15,54 +15,63 @@
damondouglas opened a new pull request #12206:
URL: https://github.com/apache/beam/pull/12206
The final purpose of this pull request is to consolidate
[learning/katas/go](learning/katas/go) into a single module. Currently, this
pull request is not complete and not ready to merge but
sclukas77 commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452314893
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java
##
@@
ibzib opened a new pull request #12207:
URL: https://github.com/apache/beam/pull/12207
R: @kennknowles
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
robinyqiu commented on a change in pull request #12163:
URL: https://github.com/apache/beam/pull/12163#discussion_r452405560
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##
@@ -182,11 +164,10 @@
tvalentyn commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r452448602
##
File path: sdks/python/container/boot.go
##
@@ -170,6 +176,34 @@ func main() {
log.Fatalf("Python exited: %v", execx.Execute("python",
tvalentyn commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r452448602
##
File path: sdks/python/container/boot.go
##
@@ -170,6 +176,34 @@ func main() {
log.Fatalf("Python exited: %v", execx.Execute("python",
lukecwik commented on pull request #12208:
URL: https://github.com/apache/beam/pull/12208#issuecomment-656315133
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656318834
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656318749
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656318962
Run XVR_Direct PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656318678
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656319283
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656319283
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656318962
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lukecwik opened a new pull request #12208:
URL: https://github.com/apache/beam/pull/12208
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
y1chi opened a new pull request #12210:
URL: https://github.com/apache/beam/pull/12210
…ReadIT
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your
KevinGG commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-656271632
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robinyqiu merged pull request #12163:
URL: https://github.com/apache/beam/pull/12163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ibzib commented on a change in pull request #12163:
URL: https://github.com/apache/beam/pull/12163#discussion_r452406626
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##
@@ -182,11 +164,10 @@
KevinGG commented on pull request #11884:
URL: https://github.com/apache/beam/pull/11884#issuecomment-656286806
We'll discuss the naming and finalize details in the release story before
sending out this PR.
This is an
TheNeuralBit commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452438068
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java
##
@@ -15,54 +15,63
lukecwik commented on pull request #12209:
URL: https://github.com/apache/beam/pull/12209#issuecomment-656297395
R: @iemejia @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik opened a new pull request #12209:
URL: https://github.com/apache/beam/pull/12209
* Make the default max connections to be unlimited. This mirrors the 2.17
and earlier behavior since we used to create one DataSource per execution
thread (and hence one connection).
* Move
lukecwik edited a comment on pull request #12209:
URL: https://github.com/apache/beam/pull/12209#issuecomment-656297395
R: @iemejia @TheNeuralBit @jbonofre
This is an automated message from the Apache Git Service.
To
lukecwik edited a comment on pull request #12208:
URL: https://github.com/apache/beam/pull/12208#issuecomment-656297377
R: @iemejia @TheNeuralBit @jbonofre
This is an automated message from the Apache Git Service.
To
pabloem commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-656314023
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on pull request #12196:
URL: https://github.com/apache/beam/pull/12196#issuecomment-656278107
This change is currently is not in RC1, and we can consider if for RC2 if
there has to be an RC2. The release guildeline clearly say that regressions in
new functionality
TheNeuralBit commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r452432390
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java
##
@@
mxm opened a new pull request #12211:
URL: https://github.com/apache/beam/pull/12211
`test_metrics` was shadowed by a Flink-specific metrics test.
Post-Commit Tests Status (on master branch)
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656331322
Run XVR_Direct PostCommit
This is an automated message from the Apache Git Service.
To respond to the
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656331322
Run XVR_Direct PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on pull request #11792:
URL: https://github.com/apache/beam/pull/11792#issuecomment-656364446
PTAL. I have a final set of exclusions, categorized, with all other tests
passing locally. The local run took about an hour. I have adjusted
`applyPythonNature` to be
kennknowles commented on pull request #11792:
URL: https://github.com/apache/beam/pull/11792#issuecomment-656364580
I have curated the commits into orthogonal changes, if you wish to focus
your review.
This is an automated
y1chi commented on pull request #12210:
URL: https://github.com/apache/beam/pull/12210#issuecomment-656368121
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on a change in pull request #12144:
URL: https://github.com/apache/beam/pull/12144#discussion_r452535839
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##
@@ -311,8 +315,26 @@ public
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-656392982
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r452456541
##
File path: sdks/python/container/boot.go
##
@@ -170,6 +176,28 @@ func main() {
log.Fatalf("Python exited: %v", execx.Execute("python",
ibzib merged pull request #12207:
URL: https://github.com/apache/beam/pull/12207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
steveniemitz commented on a change in pull request #12144:
URL: https://github.com/apache/beam/pull/12144#discussion_r452536242
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##
@@ -311,8 +315,26 @@ public
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656357840
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656357766
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-656388458
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in Python
tvalentyn commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r451988176
##
File path: sdks/python/container/boot.go
##
@@ -170,6 +176,28 @@ func main() {
log.Fatalf("Python exited: %v", execx.Execute("python",
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759
@TheNeuralBit Not a problem. Sorry for lots of changes, I still have little
experience in submitting PRs to Beam.
Those tests run on Flink and Spark in
robinyqiu opened a new pull request #12214:
URL: https://github.com/apache/beam/pull/12214
This PR does not turn on any function or make any functional change. It
simply sync the full list of functions from
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-656410102
Run Python Dataflow ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to
aaltay commented on pull request #12046:
URL: https://github.com/apache/beam/pull/12046#issuecomment-656419524
> Just for completenes, since we chatted offline: I didn't miss this. I
think these are good tests, that just need the rest of the implementation,
already partly plumbed in (the
robinyqiu merged pull request #12214:
URL: https://github.com/apache/beam/pull/12214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tvalentyn opened a new pull request #12212:
URL: https://github.com/apache/beam/pull/12212
Post-Commit Tests Status (on master branch)
Lang | SDK | Dataflow | Flink | Samza | Spark |
tvalentyn opened a new pull request #12213:
URL: https://github.com/apache/beam/pull/12213
Post-Commit Tests Status (on master branch)
Lang | SDK | Dataflow | Flink | Samza | Spark |
aaltay commented on pull request #12147:
URL: https://github.com/apache/beam/pull/12147#issuecomment-656419015
R: @pabloem @rezarokni
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem edited a comment on pull request #12147:
URL: https://github.com/apache/beam/pull/12147#issuecomment-656422531
@reubenvanammers thanks so much for your contribution!
can you please resolve the conflicts of your branch, so that we can review
the final result?
pabloem commented on pull request #12147:
URL: https://github.com/apache/beam/pull/12147#issuecomment-656422531
can you please resolve the conflicts of your branch, so that we can review
the final result?
This is an
youngoli commented on pull request #12215:
URL: https://github.com/apache/beam/pull/12215#issuecomment-656430039
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ihji commented on a change in pull request #12144:
URL: https://github.com/apache/beam/pull/12144#discussion_r452549676
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##
@@ -311,8 +315,26 @@ public
ihji commented on a change in pull request #12144:
URL: https://github.com/apache/beam/pull/12144#discussion_r452551623
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##
@@ -311,8 +315,26 @@ public
ibzib commented on pull request #12211:
URL: https://github.com/apache/beam/pull/12211#issuecomment-656405919
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656406423
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656406423
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
steveniemitz commented on a change in pull request #12144:
URL: https://github.com/apache/beam/pull/12144#discussion_r452553353
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##
@@ -311,8 +315,26 @@ public
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-656407977
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
1 - 100 of 123 matches
Mail list logo