[GitHub] [beam] echauchot opened a new pull request #12204: [BEAM-4553] Add missing step name in graphite metrics sink messages.

2020-07-09 Thread GitBox
echauchot opened a new pull request #12204: URL: https://github.com/apache/beam/pull/12204 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] damgad commented on pull request #11968: [BEAM-10185] Build python wheels on GitHub Actions for Windows [dependent on BEAM-10184]

2020-07-09 Thread GitBox
damgad commented on pull request #11968: URL: https://github.com/apache/beam/pull/11968#issuecomment-656019586 @robertwb I've already written windows versions for the missing posix functions. Please take a look @robertwb https://github.com/apache/beam/pull/12172

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655957540 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] damgad commented on a change in pull request #12172: [BEAM-10185] Building python wheels for Windows (on Github Actions)

2020-07-09 Thread GitBox
damgad commented on a change in pull request #12172: URL: https://github.com/apache/beam/pull/12172#discussion_r452069922 ## File path: .github/workflows/build_wheels.yml ## @@ -119,19 +123,24 @@ jobs: uses: actions/setup-python@v2 with: python-version:

[GitHub] [beam] lazylynx commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

2020-07-09 Thread GitBox
lazylynx commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r452004982 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,28 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python",

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-656026101 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] jmcomets closed pull request #12173: [BEAM-XXX] JdbcIO - Allow customization of the PoolableDataSource's pool

2020-07-09 Thread GitBox
jmcomets closed pull request #12173: URL: https://github.com/apache/beam/pull/12173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] jmcomets commented on pull request #12173: [BEAM-XXX] JdbcIO - Allow customization of the PoolableDataSource's pool

2020-07-09 Thread GitBox
jmcomets commented on pull request #12173: URL: https://github.com/apache/beam/pull/12173#issuecomment-656090239 Closing this as I found a way to inject the pool generically, using `withDataSourceProviderFn(...)`. IMO one of either methods should be available, it took me a while before

[GitHub] [beam] kamilwu opened a new pull request #12205: Fix TODO comment in tox.ini

2020-07-09 Thread GitBox
kamilwu opened a new pull request #12205: URL: https://github.com/apache/beam/pull/12205 Botocore is a part of [aws], not [interactive]. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] echauchot commented on a change in pull request #12204: [BEAM-10431] Add missing step name in graphite metrics sink messages.

2020-07-09 Thread GitBox
echauchot commented on a change in pull request #12204: URL: https://github.com/apache/beam/pull/12204#discussion_r452239069 ## File path: runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java ## @@ -69,20 +69,20

[GitHub] [beam] kamilwu commented on pull request #12195: [BEAM-10422] Chicago Taxi example: set number of Dataflow workers to 5

2020-07-09 Thread GitBox
kamilwu commented on pull request #12195: URL: https://github.com/apache/beam/pull/12195#issuecomment-656151288 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] aromanenko-dev commented on a change in pull request #12204: [BEAM-4553] Add missing step name in graphite metrics sink messages.

2020-07-09 Thread GitBox
aromanenko-dev commented on a change in pull request #12204: URL: https://github.com/apache/beam/pull/12204#discussion_r452188740 ## File path: runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java ## @@ -69,20

[GitHub] [beam] aromanenko-dev commented on a change in pull request #12204: [BEAM-4553] Add missing step name in graphite metrics sink messages.

2020-07-09 Thread GitBox
aromanenko-dev commented on a change in pull request #12204: URL: https://github.com/apache/beam/pull/12204#discussion_r452188740 ## File path: runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java ## @@ -69,20

[GitHub] [beam] kamilwu commented on pull request #12195: [BEAM-10422] Chicago Taxi example: set number of Dataflow workers to 5

2020-07-09 Thread GitBox
kamilwu commented on pull request #12195: URL: https://github.com/apache/beam/pull/12195#issuecomment-656171851 Run Chicago Taxi on Dataflow This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452329517 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63

[GitHub] [beam] lgajowy merged pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

2020-07-09 Thread GitBox
lgajowy merged pull request #12117: URL: https://github.com/apache/beam/pull/12117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robinyqiu commented on pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

2020-07-09 Thread GitBox
robinyqiu commented on pull request #12163: URL: https://github.com/apache/beam/pull/12163#issuecomment-656184593 Run SQL PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kamilwu commented on pull request #12195: [BEAM-10422] Chicago Taxi example: set number of Dataflow workers to 5

2020-07-09 Thread GitBox
kamilwu commented on pull request #12195: URL: https://github.com/apache/beam/pull/12195#issuecomment-656202548 R: @tvalentyn This effectively fixes https://issues.apache.org/jira/browse/BEAM-10421 as well. Look for "worker logs:" lines, there are links to Dataflow job details

[GitHub] [beam] aaltay edited a comment on pull request #12049: [BEAM-10399] Periodic clear of GCS wheels staging bucket

2020-07-09 Thread GitBox
aaltay edited a comment on pull request #12049: URL: https://github.com/apache/beam/pull/12049#issuecomment-655635243 What files will be cleared this way? Release branches live forever. Would there be other branches that this script will clean?

[GitHub] [beam] apilloud commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

2020-07-09 Thread GitBox
apilloud commented on a change in pull request #12163: URL: https://github.com/apache/beam/pull/12163#discussion_r452337633 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -182,11 +164,10 @@

[GitHub] [beam] aromanenko-dev commented on pull request #12204: [BEAM-10431] Add missing step name in graphite metrics sink messages.

2020-07-09 Thread GitBox
aromanenko-dev commented on pull request #12204: URL: https://github.com/apache/beam/pull/12204#issuecomment-656180610 I merge this PR since failed Java PreCommit test is not related. This is an automated message from the

[GitHub] [beam] aromanenko-dev merged pull request #12204: [BEAM-10431] Add missing step name in graphite metrics sink messages.

2020-07-09 Thread GitBox
aromanenko-dev merged pull request #12204: URL: https://github.com/apache/beam/pull/12204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] TheNeuralBit merged pull request #12205: Fix TODO comment in tox.ini

2020-07-09 Thread GitBox
TheNeuralBit merged pull request #12205: URL: https://github.com/apache/beam/pull/12205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] TheNeuralBit commented on pull request #12196: [release-2.23.0][BEAM-10308] Make component ID assignments consistent across Pipeline…

2020-07-09 Thread GitBox
TheNeuralBit commented on pull request #12196: URL: https://github.com/apache/beam/pull/12196#issuecomment-656201084 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lazylynx commented on pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

2020-07-09 Thread GitBox
lazylynx commented on pull request #12115: URL: https://github.com/apache/beam/pull/12115#issuecomment-656225895 @tvalentyn Updated about wheel name with Python 3.8. PTAL. This is an automated message from the Apache Git

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452326180 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452329517 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63

[GitHub] [beam] TobKed commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR

2020-07-09 Thread GitBox
TobKed commented on a change in pull request #12166: URL: https://github.com/apache/beam/pull/12166#discussion_r452297033 ## File path: .github/workflows/cancel.yml ## @@ -16,7 +16,7 @@ # under the License. name: Cancel -on: [push] +on: [push, pull_request] Review

[GitHub] [beam] sclukas77 commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
sclukas77 commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452346520 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63 @@

[GitHub] [beam] kamilwu commented on pull request #12195: [BEAM-10422] Chicago Taxi example: set number of Dataflow workers to 5

2020-07-09 Thread GitBox
kamilwu commented on pull request #12195: URL: https://github.com/apache/beam/pull/12195#issuecomment-656163912 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robinyqiu commented on pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

2020-07-09 Thread GitBox
robinyqiu commented on pull request #12163: URL: https://github.com/apache/beam/pull/12163#issuecomment-656168054 Run JavaPortabilityApiJava11 PreCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] sclukas77 commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
sclukas77 commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452308746 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63 @@

[GitHub] [beam] damondouglas opened a new pull request #12206: [Beam-10428] Consolidate Go SDK katas as a single module

2020-07-09 Thread GitBox
damondouglas opened a new pull request #12206: URL: https://github.com/apache/beam/pull/12206 The final purpose of this pull request is to consolidate [learning/katas/go](learning/katas/go) into a single module. Currently, this pull request is not complete and not ready to merge but

[GitHub] [beam] sclukas77 commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
sclukas77 commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452314893 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java ## @@

[GitHub] [beam] ibzib opened a new pull request #12207: [BEAM-10432] Improve error message for missing pipeline options.

2020-07-09 Thread GitBox
ibzib opened a new pull request #12207: URL: https://github.com/apache/beam/pull/12207 R: @kennknowles Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] robinyqiu commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

2020-07-09 Thread GitBox
robinyqiu commented on a change in pull request #12163: URL: https://github.com/apache/beam/pull/12163#discussion_r452405560 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -182,11 +164,10 @@

[GitHub] [beam] tvalentyn commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

2020-07-09 Thread GitBox
tvalentyn commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r452448602 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,34 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python",

[GitHub] [beam] tvalentyn commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

2020-07-09 Thread GitBox
tvalentyn commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r452448602 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,34 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python",

[GitHub] [beam] lukecwik commented on pull request #12208: [BEAM-10433] Swap to use an embedded derby instance instead of starting and waiting for an instance which is unreliable.

2020-07-09 Thread GitBox
lukecwik commented on pull request #12208: URL: https://github.com/apache/beam/pull/12208#issuecomment-656315133 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318834 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318749 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318962 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318678 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656319283 run seed job This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656319283 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] lukecwik opened a new pull request #12208: [BEAM-10433] Swap to use an embedded derby instance instead of starting and waiting for an instance which is unreliable.

2020-07-09 Thread GitBox
lukecwik opened a new pull request #12208: URL: https://github.com/apache/beam/pull/12208 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] y1chi opened a new pull request #12210: [BEAM-10419] Ignore FhirIOWriteIT testFhirIO_Import instead of FhirIO…

2020-07-09 Thread GitBox
y1chi opened a new pull request #12210: URL: https://github.com/apache/beam/pull/12210 …ReadIT **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] KevinGG commented on pull request #12107: Interactive Environment Inspector for messaging

2020-07-09 Thread GitBox
KevinGG commented on pull request #12107: URL: https://github.com/apache/beam/pull/12107#issuecomment-656271632 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robinyqiu merged pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

2020-07-09 Thread GitBox
robinyqiu merged pull request #12163: URL: https://github.com/apache/beam/pull/12163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] ibzib commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

2020-07-09 Thread GitBox
ibzib commented on a change in pull request #12163: URL: https://github.com/apache/beam/pull/12163#discussion_r452406626 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -182,11 +164,10 @@

[GitHub] [beam] KevinGG commented on pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

2020-07-09 Thread GitBox
KevinGG commented on pull request #11884: URL: https://github.com/apache/beam/pull/11884#issuecomment-656286806 We'll discuss the naming and finalize details in the release story before sending out this PR. This is an

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452438068 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63

[GitHub] [beam] lukecwik commented on pull request #12209: [BEAM-9629] Fix several connection leak issues.

2020-07-09 Thread GitBox
lukecwik commented on pull request #12209: URL: https://github.com/apache/beam/pull/12209#issuecomment-656297395 R: @iemejia @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik opened a new pull request #12209: [BEAM-9629] Fix several connection leak issues.

2020-07-09 Thread GitBox
lukecwik opened a new pull request #12209: URL: https://github.com/apache/beam/pull/12209 * Make the default max connections to be unlimited. This mirrors the 2.17 and earlier behavior since we used to create one DataSource per execution thread (and hence one connection). * Move

[GitHub] [beam] lukecwik edited a comment on pull request #12209: [BEAM-9629] Fix several connection leak issues.

2020-07-09 Thread GitBox
lukecwik edited a comment on pull request #12209: URL: https://github.com/apache/beam/pull/12209#issuecomment-656297395 R: @iemejia @TheNeuralBit @jbonofre This is an automated message from the Apache Git Service. To

[GitHub] [beam] lukecwik edited a comment on pull request #12208: [BEAM-10433] Swap to use an embedded derby instance instead of starting and waiting for an instance which is unreliable.

2020-07-09 Thread GitBox
lukecwik edited a comment on pull request #12208: URL: https://github.com/apache/beam/pull/12208#issuecomment-656297377 R: @iemejia @TheNeuralBit @jbonofre This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem commented on pull request #12107: Interactive Environment Inspector for messaging

2020-07-09 Thread GitBox
pabloem commented on pull request #12107: URL: https://github.com/apache/beam/pull/12107#issuecomment-656314023 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on pull request #12196: [release-2.23.0][BEAM-10308] Make component ID assignments consistent across Pipeline…

2020-07-09 Thread GitBox
tvalentyn commented on pull request #12196: URL: https://github.com/apache/beam/pull/12196#issuecomment-656278107 This change is currently is not in RC1, and we can consider if for RC2 if there has to be an RC2. The release guildeline clearly say that regressions in new functionality

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

2020-07-09 Thread GitBox
TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452432390 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java ## @@

[GitHub] [beam] mxm opened a new pull request #12211: [BEAM-9996] Unshadow test_metrics test for flink_runner_test

2020-07-09 Thread GitBox
mxm opened a new pull request #12211: URL: https://github.com/apache/beam/pull/12211 `test_metrics` was shadowed by a Flink-specific metrics test. Post-Commit Tests Status (on master branch)

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656331322 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656331322 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] kennknowles commented on pull request #11792: Add ValidatesRunner task for local_job_service and Java SDK harness

2020-07-09 Thread GitBox
kennknowles commented on pull request #11792: URL: https://github.com/apache/beam/pull/11792#issuecomment-656364446 PTAL. I have a final set of exclusions, categorized, with all other tests passing locally. The local run took about an hour. I have adjusted `applyPythonNature` to be

[GitHub] [beam] kennknowles commented on pull request #11792: Add ValidatesRunner task for local_job_service and Java SDK harness

2020-07-09 Thread GitBox
kennknowles commented on pull request #11792: URL: https://github.com/apache/beam/pull/11792#issuecomment-656364580 I have curated the commits into orthogonal changes, if you wish to focus your review. This is an automated

[GitHub] [beam] y1chi commented on pull request #12210: [BEAM-10419] Ignore FhirIOWriteIT testFhirIO_Import instead of FhirIO…

2020-07-09 Thread GitBox
y1chi commented on pull request #12210: URL: https://github.com/apache/beam/pull/12210#issuecomment-656368121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

2020-07-09 Thread GitBox
pabloem commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452535839 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] pabloem commented on pull request #12203: Bq main sink

2020-07-09 Thread GitBox
pabloem commented on pull request #12203: URL: https://github.com/apache/beam/pull/12203#issuecomment-656392982 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

2020-07-09 Thread GitBox
tvalentyn commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r452456541 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,28 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python",

[GitHub] [beam] ibzib merged pull request #12207: [BEAM-10432] Improve error message for missing pipeline options.

2020-07-09 Thread GitBox
ibzib merged pull request #12207: URL: https://github.com/apache/beam/pull/12207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] steveniemitz commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

2020-07-09 Thread GitBox
steveniemitz commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452536242 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656357840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656357766 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] pabloem commented on pull request #12203: Bq main sink

2020-07-09 Thread GitBox
pabloem commented on pull request #12203: URL: https://github.com/apache/beam/pull/12203#issuecomment-656388458 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in Python

[GitHub] [beam] tvalentyn commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

2020-07-09 Thread GitBox
tvalentyn commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r451988176 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,28 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python",

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in

[GitHub] [beam] piotr-szuberski edited a comment on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

2020-07-09 Thread GitBox
piotr-szuberski edited a comment on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-655922759 @TheNeuralBit Not a problem. Sorry for lots of changes, I still have little experience in submitting PRs to Beam. Those tests run on Flink and Spark in

[GitHub] [beam] robinyqiu opened a new pull request #12214: [BEAM-10438] Sync ZetaSQL function allowlist with full list from ZetaSQL

2020-07-09 Thread GitBox
robinyqiu opened a new pull request #12214: URL: https://github.com/apache/beam/pull/12214 This PR does not turn on any function or make any functional change. It simply sync the full list of functions from

[GitHub] [beam] tvalentyn commented on pull request #12194: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-07-09 Thread GitBox
tvalentyn commented on pull request #12194: URL: https://github.com/apache/beam/pull/12194#issuecomment-656410102 Run Python Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] aaltay commented on pull request #12046: [BEAM-10290] Add a unit(ish) test for dynamic splitting correctness.

2020-07-09 Thread GitBox
aaltay commented on pull request #12046: URL: https://github.com/apache/beam/pull/12046#issuecomment-656419524 > Just for completenes, since we chatted offline: I didn't miss this. I think these are good tests, that just need the rest of the implementation, already partly plumbed in (the

[GitHub] [beam] robinyqiu merged pull request #12214: [BEAM-10438] Sync ZetaSQL function allowlist with full list from ZetaSQL

2020-07-09 Thread GitBox
robinyqiu merged pull request #12214: URL: https://github.com/apache/beam/pull/12214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] tvalentyn opened a new pull request #12212: Prepare a website update for 2.23.0

2020-07-09 Thread GitBox
tvalentyn opened a new pull request #12212: URL: https://github.com/apache/beam/pull/12212 Post-Commit Tests Status (on master branch) Lang | SDK | Dataflow | Flink | Samza | Spark |

[GitHub] [beam] tvalentyn opened a new pull request #12213: Add a blogpost for Apache Beam 2.23.0.

2020-07-09 Thread GitBox
tvalentyn opened a new pull request #12213: URL: https://github.com/apache/beam/pull/12213 Post-Commit Tests Status (on master branch) Lang | SDK | Dataflow | Flink | Samza | Spark |

[GitHub] [beam] aaltay commented on pull request #12147: [BEAM 7624] Added Null Behavior in JsonToRow

2020-07-09 Thread GitBox
aaltay commented on pull request #12147: URL: https://github.com/apache/beam/pull/12147#issuecomment-656419015 R: @pabloem @rezarokni This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem edited a comment on pull request #12147: [BEAM 7624] Added Null Behavior in JsonToRow

2020-07-09 Thread GitBox
pabloem edited a comment on pull request #12147: URL: https://github.com/apache/beam/pull/12147#issuecomment-656422531 @reubenvanammers thanks so much for your contribution! can you please resolve the conflicts of your branch, so that we can review the final result?

[GitHub] [beam] pabloem commented on pull request #12147: [BEAM 7624] Added Null Behavior in JsonToRow

2020-07-09 Thread GitBox
pabloem commented on pull request #12147: URL: https://github.com/apache/beam/pull/12147#issuecomment-656422531 can you please resolve the conflicts of your branch, so that we can review the final result? This is an

[GitHub] [beam] youngoli commented on pull request #12215: [BEAM-10310] Adding thread-safe restriction tracker wrapper.

2020-07-09 Thread GitBox
youngoli commented on pull request #12215: URL: https://github.com/apache/beam/pull/12215#issuecomment-656430039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] ihji commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

2020-07-09 Thread GitBox
ihji commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452549676 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] ihji commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

2020-07-09 Thread GitBox
ihji commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452551623 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] ibzib commented on pull request #12211: [BEAM-9996] Unshadow test_metrics test for flink_runner_test

2020-07-09 Thread GitBox
ibzib commented on pull request #12211: URL: https://github.com/apache/beam/pull/12211#issuecomment-656405919 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656406423 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

2020-07-09 Thread GitBox
ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656406423 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] steveniemitz commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

2020-07-09 Thread GitBox
steveniemitz commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452553353 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] pabloem commented on pull request #12203: Bq main sink

2020-07-09 Thread GitBox
pabloem commented on pull request #12203: URL: https://github.com/apache/beam/pull/12203#issuecomment-656407977 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >