Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1568435582 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [PR] SpannerIO: support max commit delay [beam]

2024-04-17 Thread via GitHub
kberezin-nshl commented on PR #31008: URL: https://github.com/apache/beam/pull/31008#issuecomment-2060442549 assign set of reviewers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]

2024-04-17 Thread via GitHub
m-trieu commented on code in PR #31000: URL: https://github.com/apache/beam/pull/31000#discussion_r1568308513 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java: ## @@ -106,15 +106,15 @@ static Counter

Re: [PR] Flink 1.17 [beam]

2024-04-17 Thread via GitHub
je-ik commented on code in PR #30197: URL: https://github.com/apache/beam/pull/30197#discussion_r1568280654 ## runners/flink/flink_runner.gradle: ## @@ -25,11 +25,29 @@ import groovy.json.JsonOutput +def base_path = ".." + +def overrides(versions, type, base_path) { +

Re: [PR] Cache parsed metrics in StreamingStepMetricsContainer [beam]

2024-04-17 Thread via GitHub
m-trieu commented on code in PR #31005: URL: https://github.com/apache/beam/pull/31005#discussion_r1568345626 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingStepMetricsContainer.java: ## @@ -256,6 +270,11 @@ private

Re: [PR] [Flink] finalize checkpoint marks in the new Flink source implementation [beam]

2024-04-17 Thread via GitHub
je-ik closed pull request #30849: [Flink] finalize checkpoint marks in the new Flink source implementation URL: https://github.com/apache/beam/pull/30849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] add Yaml_Xlang_Direct PreCommit to README [beam]

2024-04-17 Thread via GitHub
liferoad opened a new pull request, #31009: URL: https://github.com/apache/beam/pull/31009 Follow #30996 to update the readme file Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [I] [Bug]: New option in KafkaIO.Read breaks upgrade compatibility [beam]

2024-04-17 Thread via GitHub
liferoad commented on issue #30997: URL: https://github.com/apache/beam/issues/30997#issuecomment-206078 should be fixed by #30998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Fix workflow param value for Grafana link [beam]

2024-04-17 Thread via GitHub
andreydevyatkin opened a new pull request, #31011: URL: https://github.com/apache/beam/pull/31011 Fix workflow param value for Grafana link. Previous PR: #30934 Thank you for your contribution! Follow this checklist to help us incorporate your

Re: [PR] Revert "Docker - Remove Deprecated Types" [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31010: URL: https://github.com/apache/beam/pull/31010#issuecomment-206676 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck for label go. Available commands: - `stop

Re: [PR] add Yaml_Xlang_Direct PreCommit to README [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31009: URL: https://github.com/apache/beam/pull/31009#issuecomment-206794 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label build. Available commands: - `stop

Re: [I] The PreCommit Python Coverage job is flaky [beam]

2024-04-17 Thread via GitHub
liferoad closed issue #30813: The PreCommit Python Coverage job is flaky URL: https://github.com/apache/beam/issues/30813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] fix naming changes caused by setuptools [beam]

2024-04-17 Thread via GitHub
liferoad opened a new pull request, #31012: URL: https://github.com/apache/beam/pull/31012 Follow #30972 to fix other cases Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [

Re: [I] [Feature Request]: add documentation on maintaining transform update compatiblity when performing changes [beam]

2024-04-17 Thread via GitHub
liferoad commented on issue #31002: URL: https://github.com/apache/beam/issues/31002#issuecomment-2061107489 @xianhualiu could you take this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [DRAFT] Attempt fix Jms watermark [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30337: URL: https://github.com/apache/beam/pull/30337#issuecomment-2061167333 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] [Bug]: New option in KafkaIO.Read breaks upgrade compatibility [beam]

2024-04-17 Thread via GitHub
damccorm closed issue #30997: [Bug]: New option in KafkaIO.Read breaks upgrade compatibility URL: https://github.com/apache/beam/issues/30997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#30941]fix upgrade test due to missed config ConsumerPollingTimeout [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #30998: URL: https://github.com/apache/beam/pull/30998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix workflow param value for Grafana link [beam]

2024-04-17 Thread via GitHub
andreydevyatkin commented on PR #31011: URL: https://github.com/apache/beam/pull/31011#issuecomment-2061085001 @damccorm I forgot to replace whitespaces with special symbols to pass the value as an API param, please take a look -- This is an automated message from the Apache Git Service.

Re: [PR] added custom watermark for kinesis reader [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #28763: URL: https://github.com/apache/beam/pull/28763#issuecomment-2061119444 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R:

Re: [PR] Call `DateTime(long)` instead of `DateTime(Object)`. [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30758: URL: https://github.com/apache/beam/pull/30758#issuecomment-2061119314 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @shunping

Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #31001: URL: https://github.com/apache/beam/pull/31001#issuecomment-2061221248 Closing since https://github.com/apache/beam/pull/30998 went in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] fix naming changes caused by setuptools [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #31012: URL: https://github.com/apache/beam/pull/31012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Downgrade google-api-core to mitigate #30927 [beam]

2024-04-17 Thread via GitHub
damccorm commented on code in PR #31004: URL: https://github.com/apache/beam/pull/31004#discussion_r1568814831 ## sdks/python/setup.py: ## @@ -436,7 +436,9 @@ def get_portability_package_data(): ], 'gcp': [ 'cachetools>=3.1.0,<6', -

[PR] Revert "Docker - Remove Deprecated Types" [beam]

2024-04-17 Thread via GitHub
liferoad opened a new pull request, #31010: URL: https://github.com/apache/beam/pull/31010 Reverts apache/beam#30826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] The PostCommit XVR PythonUsingJava Dataflow job is flaky [beam]

2024-04-17 Thread via GitHub
liferoad closed issue #30904: The PostCommit XVR PythonUsingJava Dataflow job is flaky URL: https://github.com/apache/beam/issues/30904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2061119274 Reminder, please take a look at this pr: @Abacn @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Clean up stale code in BigtableService [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2061119369 Reminder, please take a look at this pr: @robertwb @Abacn @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
Chandrikajoshi123 commented on PR #31013: URL: https://github.com/apache/beam/pull/31013#issuecomment-2061196413 Why I am reciving too much emails While I unsubscribed El mié, 17 abr 2024, 6:11 p. m., scwhittle ***@***.***> escribió: > As there are potential performance

Re: [I] The Python tests job is flaky [beam]

2024-04-17 Thread via GitHub
damccorm closed issue #31006: The Python tests job is flaky URL: https://github.com/apache/beam/issues/31006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [#30184][runners][spark] GBK with global window translation OOM fix [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30185: URL: https://github.com/apache/beam/pull/30185#issuecomment-2061167420 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Add retry to VertexAI embeddings call [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30164: URL: https://github.com/apache/beam/pull/30164#issuecomment-2061167472 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Fix workflow param value for Grafana link [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31011: URL: https://github.com/apache/beam/pull/31011#issuecomment-2061169588 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm added as fallback since no labels match configuration

Re: [PR] Remove GlobalWindows for unbounded pcoll without a default global window [beam]

2024-04-17 Thread via GitHub
liferoad commented on PR #30728: URL: https://github.com/apache/beam/pull/30728#issuecomment-2061041402 Need more time to test this with DataflowRunner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Bug]: Duplicate rows inserted in BigQuery [beam]

2024-04-17 Thread via GitHub
liferoad commented on issue #30973: URL: https://github.com/apache/beam/issues/30973#issuecomment-2061121989 Can you provide a testing example with some details? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] fix naming changes caused by setuptools [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31012: URL: https://github.com/apache/beam/pull/31012#issuecomment-2061169480 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label build. Available commands: - `stop

[PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
scwhittle opened a new pull request, #31013: URL: https://github.com/apache/beam/pull/31013 As there are potential performance concerns, put the removal of caching of global window inputs added by #30991 behind an experiment. Thank you for your

Re: [I] The PostCommit XVR PythonUsingJava Dataflow job is flaky [beam]

2024-04-17 Thread via GitHub
liferoad commented on issue #30904: URL: https://github.com/apache/beam/issues/30904#issuecomment-2061059360 Recent runs are good now: https://github.com/apache/beam/actions/workflows/beam_PostCommit_XVR_PythonUsingJava_Dataflow.yml?query=+branch%3Amaster -- This is an automated message

Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]

2024-04-17 Thread via GitHub
damccorm closed pull request #31001: Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test URL: https://github.com/apache/beam/pull/31001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Downgrade google-api-core to mitigate #30927 [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #31004: URL: https://github.com/apache/beam/pull/31004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Create YAML Join Transform [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #30734: URL: https://github.com/apache/beam/pull/30734#issuecomment-2061559694 Merging to make the release cut; @Polber will follow up and do some additional validation, and we will cherry-pick any changes if needed -- This is an automated message from the Apache

Re: [PR] Add /job/cancel endpoint to prism web server. [beam]

2024-04-17 Thread via GitHub
damondouglas merged PR #30825: URL: https://github.com/apache/beam/pull/30825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1569109482 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [I] [Feature Request]: Support for Apache Flink 1.18 in Beam Runners [beam]

2024-04-17 Thread via GitHub
dan-clst commented on issue #30789: URL: https://github.com/apache/beam/issues/30789#issuecomment-2061699463 @thebozzcl looks like 1.17 support was just merged in https://github.com/apache/beam/pull/30197 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Minor updates to StreamingInsertsMetrics [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31003: URL: https://github.com/apache/beam/pull/31003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug]: Uber jar not work with Dataflow runner v2 due to `UnknownCoderWrapper` for Beam 2.55 [beam]

2024-04-17 Thread via GitHub
Abacn commented on issue #30994: URL: https://github.com/apache/beam/issues/30994#issuecomment-2061431242 I see, so - the underlying issue---coder register auto service not working in uber jar packed in this way---always exist - some change on 2.55.0 makes prefix coder involved in

Re: [PR] add Yaml_Xlang_Direct PreCommit to README [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31009: URL: https://github.com/apache/beam/pull/31009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug]: Uber jar not register coders causing `UnknownCoderWrapper` error [beam]

2024-04-17 Thread via GitHub
robertwb commented on issue #30994: URL: https://github.com/apache/beam/issues/30994#issuecomment-2061613599 Long term, should we try to move away from autoservice for built in components (at least if standard uberjar building tools do not do the right thing with them)? Is this more

Re: [PR] Propagate display_data to Job proto [beam]

2024-04-17 Thread via GitHub
Polber closed pull request #30809: Propagate display_data to Job proto URL: https://github.com/apache/beam/pull/30809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Enable BigQueryMetrics by default [beam]

2024-04-17 Thread via GitHub
JayajP commented on PR #31015: URL: https://github.com/apache/beam/pull/31015#issuecomment-2061689237 Run Java Precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31000: URL: https://github.com/apache/beam/pull/31000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [yaml] backtick generated aliases on sql mappings [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #30895: URL: https://github.com/apache/beam/pull/30895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Flink] finalize checkpoint marks in the new Flink source implementation [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #30849: URL: https://github.com/apache/beam/pull/30849#issuecomment-2061215010 Closing in favor of https://github.com/apache/beam/pull/30987. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31013: URL: https://github.com/apache/beam/pull/31013#issuecomment-2061489406 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] Revert "Docker - Remove Deprecated Types" [beam]

2024-04-17 Thread via GitHub
lostluck merged PR #31010: URL: https://github.com/apache/beam/pull/31010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061635197 Oh whoops, missed https://github.com/apache/beam/pull/30976/commits/91d4dc1af683c87808048bc03ed180522b12c13d - thanks for catching -- This is an automated message from the Apache Git

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
robertwb commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061683074 So I'm still trying to figure out why these same tests pass in isolation ( https://github.com/apache/beam/actions/runs/8722508185/job/23928542728?pr=30976 ) but fail when all tests are

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-17 Thread via GitHub
Abacn commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2061283049 sorry for delay, taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Cache parsed metrics in StreamingStepMetricsContainer [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31005: URL: https://github.com/apache/beam/pull/31005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Enable BigQueryMetrics by default [beam]

2024-04-17 Thread via GitHub
JayajP opened a new pull request, #31015: URL: https://github.com/apache/beam/pull/31015 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] Create YAML Join Transform [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #30734: URL: https://github.com/apache/beam/pull/30734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Remove flink 1.12 1.13 [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #30988: URL: https://github.com/apache/beam/pull/30988#issuecomment-2061597620 Marking this as blocker for 2.56.0, this should be trivial to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] remove CLOUDSDK from javausingpython dataflow xvr workflow [beam]

2024-04-17 Thread via GitHub
volatilemolotov opened a new pull request, #31016: URL: https://github.com/apache/beam/pull/31016 CLOUDSDK env not needed here and is causing issues Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [PR] Flink 1.17 [beam]

2024-04-17 Thread via GitHub
je-ik merged PR #30197: URL: https://github.com/apache/beam/pull/30197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]

2024-04-17 Thread via GitHub
JayajP commented on code in PR #31000: URL: https://github.com/apache/beam/pull/31000#discussion_r1569127726 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java: ## @@ -106,15 +106,15 @@ static Counter

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061227644 (resolved some conflicts and cleaned up CHANGES.md while at it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] python sdk: fix several bugs regarding avto <-> beam schema conversion [beam]

2024-04-17 Thread via GitHub
benkonz commented on code in PR #30770: URL: https://github.com/apache/beam/pull/30770#discussion_r1568845874 ## sdks/python/apache_beam/io/avroio_test.py: ## @@ -149,17 +151,37 @@ def _run_avro_test( def test_schema_read_write(self): with tempfile.TemporaryDirectory()

Re: [PR] Minor updates to StreamingInsertsMetrics [beam]

2024-04-17 Thread via GitHub
JayajP commented on PR #31003: URL: https://github.com/apache/beam/pull/31003#issuecomment-2061392875 Run Java_GCP_IO_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [yaml] add --providers and --providers_file flags [beam]

2024-04-17 Thread via GitHub
Polber closed pull request #30835: [yaml] add --providers and --providers_file flags URL: https://github.com/apache/beam/pull/30835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug]: Uber jar not register coders causing `UnknownCoderWrapper` error [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on issue #30994: URL: https://github.com/apache/beam/issues/30994#issuecomment-2061688287 > Presumably this used to work and doesn't now? Or do we need better instructions on creating an uberjar that correctly preserves all the registration information? Yeah,

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
robertwb commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061769275 Given the uncertainty with what's going on here, another option is to put the changes in to the dataflow template itself in the short term. -- This is an automated message from the

Re: [PR] Enable BigQueryMetrics by default [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31015: URL: https://github.com/apache/beam/pull/31015#issuecomment-2061785502 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #31017: URL: https://github.com/apache/beam/pull/31017#issuecomment-2061844953 R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
je-ik opened a new pull request, #31017: URL: https://github.com/apache/beam/pull/31017 Update CHNAGES.md Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the

Re: [I] [Bug]: Side effect during the for loop execution in beam Pipeline [beam]

2024-04-17 Thread via GitHub
liferoad commented on issue #31014: URL: https://github.com/apache/beam/issues/31014#issuecomment-2061888279 For your first example, I think this is expected. the pipeline won't be executed after the entire pipeline is construct. After that, the variable `i` has the final value, which will

[PR] fix website embedding issue [beam]

2024-04-17 Thread via GitHub
svetakvsundhar opened a new pull request, #31019: URL: https://github.com/apache/beam/pull/31019 Fixes https://github.com/apache/beam/issues/30981 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [PR] [runners-flink] remove 1.12 and 1.13 runners [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31020: URL: https://github.com/apache/beam/pull/31020#issuecomment-2061930085 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] [runners-flink] remove 1.12 and 1.13 runners [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #31020: URL: https://github.com/apache/beam/pull/31020#issuecomment-2061937779 Will merge once checks complete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
tvalentyn opened a new pull request, #31021: URL: https://github.com/apache/beam/pull/31021 Partially address https://github.com/apache/beam/issues/30981 Thank you for your contribution! Follow this checklist to help us incorporate your

Re: [PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on PR #31021: URL: https://github.com/apache/beam/pull/31021#issuecomment-2061940036 R: @aaltay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] remove CLOUDSDK from javausingpython dataflow xvr workflow [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31016: URL: https://github.com/apache/beam/pull/31016#issuecomment-2061727846 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label build. Available commands: - `stop

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
damccorm commented on code in PR #30976: URL: https://github.com/apache/beam/pull/30976#discussion_r1569161181 ## sdks/python/apache_beam/yaml/main.py: ## @@ -64,9 +72,19 @@ def _pipeline_spec_from_args(known_args): return pipeline_yaml +class

Re: [PR] [Testing] Try fixing inference benchmark tests [beam]

2024-04-17 Thread via GitHub
riteshghorse closed pull request #30855: [Testing] Try fixing inference benchmark tests URL: https://github.com/apache/beam/pull/30855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix website embedding issue [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on code in PR #31019: URL: https://github.com/apache/beam/pull/31019#discussion_r1569257366 ## website/www/site/content/en/get-started/resources/videos-and-podcasts.md: ## @@ -133,15 +133,14 @@ Strata+Hadoop World, New York, 2016 Presented by Kenneth

Re: [PR] [changes] Update CHANGES.md (#29939) (#31017) [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #31022: URL: https://github.com/apache/beam/pull/31022#issuecomment-2062026778 R. @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Fix typo in count_unique_words() [beam]

2024-04-17 Thread via GitHub
jrmccluskey opened a new pull request, #31023: URL: https://github.com/apache/beam/pull/31023 Small typo fix for a helper function Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1569144621 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31017: URL: https://github.com/apache/beam/pull/31017#issuecomment-2061846807 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] [Python] Update tensorflow version in relevant tests [beam]

2024-04-17 Thread via GitHub
riteshghorse closed pull request #30822: [Python] Update tensorflow version in relevant tests URL: https://github.com/apache/beam/pull/30822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31021: URL: https://github.com/apache/beam/pull/31021#issuecomment-2061941839 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569225112 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

Re: [PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #31017: URL: https://github.com/apache/beam/pull/31017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
Polber commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061800255 > Given the uncertainty with what's going on here, another option is to put the changes in to the dataflow template itself in the short term. I'll draft up a PR for that -- This

Re: [PR] Remove flink 1.12 1.13 [beam]

2024-04-17 Thread via GitHub
Abacn commented on PR #30988: URL: https://github.com/apache/beam/pull/30988#issuecomment-2061799535 Also please open another PR to update CHANGES.md (changing on this PR will cause many test rerun) -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Remove flink 1.12 1.13 [beam]

2024-04-17 Thread via GitHub
je-ik merged PR #30988: URL: https://github.com/apache/beam/pull/30988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
scwhittle commented on PR #31013: URL: https://github.com/apache/beam/pull/31013#issuecomment-2062005944 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] remove CLOUDSDK from javausingpython dataflow xvr workflow [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31016: URL: https://github.com/apache/beam/pull/31016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569413654 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

[PR] Re-enable schedule trigger for PostCommit Java IO Performance Tests [beam]

2024-04-17 Thread via GitHub
damccorm opened a new pull request, #31024: URL: https://github.com/apache/beam/pull/31024 Once 2.56.0 is in, we can safely do this Fixes #30787 Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [I] [Task]: Re-enable schedule trigger for PostCommit Java IO Performance Tests [beam]

2024-04-17 Thread via GitHub
damccorm commented on issue #30787: URL: https://github.com/apache/beam/issues/30787#issuecomment-2062114945 I have #31024 to fix this once the 2.56 release is out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
tvalentyn merged PR #31021: URL: https://github.com/apache/beam/pull/31021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >