Re: [PR] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

2025-01-17 Thread via GitHub
alamb commented on code in PR #14134: URL: https://github.com/apache/datafusion/pull/14134#discussion_r1920255614 ## datafusion/expr/src/test/function_stub.rs: ## @@ -252,6 +252,10 @@ impl AggregateUDFImpl for Count { Ok(DataType::Int64) } +fn is_nullable(&se

Re: [PR] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

2025-01-17 Thread via GitHub
alamb merged PR #14134: URL: https://github.com/apache/datafusion/pull/14134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

2025-01-17 Thread via GitHub
alamb commented on PR #14134: URL: https://github.com/apache/datafusion/pull/14134#issuecomment-2598460363 Thank you for the review @jonahgao 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

2025-01-15 Thread via GitHub
alamb opened a new pull request, #14134: URL: https://github.com/apache/datafusion/pull/14134 Draft it is based on https://github.com/apache/datafusion/pull/14083 from @mnpw ## Which issue does this PR close? This is a follow up to - https://github.com/apache/datafusion/pul