kazuyukitanimura commented on PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#issuecomment-2132500112
I forgot to ask about dictionary and scalar. Filed
https://github.com/apache/datafusion-comet/issues/477
--
This is an automated message from the Apache Git Service.
To
andygrove merged PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594773167
##
core/src/execution/datafusion/expressions/scalar_funcs/unhex.rs:
##
@@ -0,0 +1,229 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
kazuyukitanimura commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594744119
##
core/src/execution/datafusion/expressions/scalar_funcs/unhex.rs:
##
@@ -0,0 +1,229 @@
+// Licensed to the Apache Software Foundation (ASF) under one
kazuyukitanimura commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594749074
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -1396,6 +1397,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlan
andygrove commented on PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#issuecomment-2101377549
I plan on merging this tomorrow if there is no more feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594127098
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,27 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
andygrove commented on PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#issuecomment-2100675232
@viirya @kazuyukitanimura do you have any additional feedback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594097078
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,27 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594094594
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,27 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594094594
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,27 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594082373
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,27 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593350009
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593261305
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593255210
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593238627
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593238627
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593233984
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593221554
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593213997
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
andygrove commented on PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#issuecomment-2098985033
Thanks for the updates @tshauck. I plan on reviewing later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tshauck commented on PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#issuecomment-2094451349
Err... looks to be an issue w/ spark 3.2 I'll need to look into. Hopefully
the majority of the code'll remain unchanged.
https://github.com/apache/datafusion-comet/assets/421
tshauck commented on PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#issuecomment-2094372353
I think this is ready for review. I updated the `unhex` impl to be more
faithful to Spark's (for odd-length inputs in particular), added better null
handling, and added more tests
tshauck commented on PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#issuecomment-2093665208
Thanks for all the feedback. I think I've addressed the build/naming/etc
feedback, and will have a look at improving the tests and any associated
implementation changes sometime to
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589664005
##
spark/src/main/spark-3.2/org/apache/comet/shims/ShimCometUnhexExpr.scala:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589664353
##
spark/src/main/spark-3.2/org/apache/comet/shims/ShimCometUnhexExpr.scala:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589662961
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1025,6 +1025,19 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589662280
##
pom.xml:
##
@@ -88,7 +88,8 @@ under the License.
-ea -Xmx4g -Xss4m ${extraJavaTestArgs}
spark-3.3-plus
spark-3.4
-spark-3.x
+spark-3.x
viirya commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589294755
##
pom.xml:
##
@@ -88,7 +88,8 @@ under the License.
-ea -Xmx4g -Xss4m ${extraJavaTestArgs}
spark-3.3-plus
spark-3.4
-spark-3.x
+spark-3.x
+
viirya commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589290483
##
spark/src/main/spark-3.2/org/apache/comet/shims/ShimCometUnhexExpr.scala:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589064578
##
common/pom.xml:
##
@@ -179,7 +179,8 @@ under the License.
-src/main/${shims.source}
+
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589063630
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1025,6 +1025,19 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveS
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589061362
##
core/src/execution/datafusion/expressions/scalar_funcs/unhex.rs:
##
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589056857
##
core/src/execution/datafusion/expressions/scalar_funcs/unhex.rs:
##
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1589056095
##
spark/src/main/spark-3.2/org/apache/comet/shims/ShimCometUnhexExpr.scala:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kazuyukitanimura commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1588843008
##
core/src/execution/datafusion/expressions/scalar_funcs/unhex.rs:
##
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
viirya commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1588762861
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1025,6 +1025,19 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpar
viirya commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1588761968
##
pom.xml:
##
@@ -88,7 +88,8 @@ under the License.
-ea -Xmx4g -Xss4m ${extraJavaTestArgs}
spark-3.3-plus
spark-3.4
-spark-3.x
+spark-3.x
+
viirya commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1588760311
##
spark/src/main/spark-3.2/org/apache/comet/shims/ShimCometUnhexExpr.scala:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
viirya commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1588760311
##
spark/src/main/spark-3.2/org/apache/comet/shims/ShimCometUnhexExpr.scala:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
viirya commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1588759861
##
spark/src/main/spark-3.2/org/apache/comet/shims/ShimCometUnhexExpr.scala:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
41 matches
Mail list logo
