iffyio commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2614442501
Thanks @ayman-sigma!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
iffyio merged PR #1539:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
ayman-sigma commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2613773549
@iffyio I rebased to main and resolved all conflicts. I made some changes in
the last commit to best of my knowledge. Please make sure to review the last
commit. Than
iffyio commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2606576392
@ayman-sigma `FieldAccess` being referred to was part of the 0.54 release,
those changes were breaking but the syntax isn't tied to the objectName
changes/this PR.
ayman-sigma commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2603779134
> FWIW I did a test upgrade to DataFusion to prepare for the next release
and it already had some non trivial changes needed (changes to FieldAccess
specifically)
iffyio commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2599616620
@alamb just wanted to double check status of this PR if there were
reservations you had or if you feel this is something we would be able to land?
--
This is an automat
ayman-sigma commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2537677471
> Given the potential for non trivial downstream conflicts due to this
change (look at the list of conflicts it has already collected) I would like to
consider it for
alamb commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2537344240
Given the potential for non trivial downstream conflicts due to this change
(look at the list of conflicts it has already collected) I would like to
consider it for the nex
ayman-sigma commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2510523162
> Hi @ayman-sigma this PR appears to have some conflicts. Is there any
chance you can resolve them so we can merge it in?
>
> Thank you!
@alamb, Done.
ayman-sigma commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2510522046
> Hi @ayman-sigma this PR appears to have some conflicts. Is there any
chance you can resolve them so we can merge it in?
>
> Thank you!
Done.
--
This
alamb commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2508957726
Hi @ayman-sigma this PR appears to have some conflicts. Is there any chance
you can resolve them so we can merge it in?
Thank you!
--
This is an automated message
iffyio commented on code in PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#discussion_r1855110077
##
src/ast/mod.rs:
##
@@ -195,14 +199,36 @@ impl fmt::Display for Ident {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(fea
ayman-sigma commented on code in PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#discussion_r1852686133
##
src/parser/mod.rs:
##
@@ -12579,7 +12599,9 @@ impl<'a> Parser<'a> {
.parse_one_of_keywords(&[Keyword::FROM, Keyword::IN])
mvzink commented on PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2489748570
I think `ObjectNamePart::Wildcard` or something would be better than what I
did in #1538, so this seems like a good idea to me.
--
This is an automated message from the
mvzink commented on code in PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#discussion_r1851117987
##
src/ast/mod.rs:
##
@@ -195,14 +199,36 @@ impl fmt::Display for Ident {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(fea
ayman-sigma commented on code in PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#discussion_r1851069862
##
src/parser/mod.rs:
##
@@ -4294,7 +4312,9 @@ impl<'a> Parser<'a> {
let mut data_type = self.parse_data_type()?;
if let DataType
ayman-sigma commented on code in PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#discussion_r1851074407
##
src/parser/mod.rs:
##
@@ -10778,7 +10798,7 @@ impl<'a> Parser<'a> {
self.expect_token(&Token::LParen)?;
let aggregate_function
17 matches
Mail list logo
