andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2096163931
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2518,6 +2518,15 @@ object QueryPlanSerde extends Logging with CometExprShim
{
andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2096114350
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2518,6 +2518,15 @@ object QueryPlanSerde extends Logging with CometExprShim
{
andygrove merged PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on PR #1744:
URL:
https://github.com/apache/datafusion-comet/pull/1744#issuecomment-2891629103
Thanks for the reviews @mbutrovich and @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
parthchandra commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2096105167
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2518,6 +2518,15 @@ object QueryPlanSerde extends Logging with CometExprShim
{
andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093551804
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2758,16 +2758,14 @@ object QueryPlanSerde extends Logging with
CometExprShim {
andygrove commented on PR #1744:
URL:
https://github.com/apache/datafusion-comet/pull/1744#issuecomment-2887350208
I have a Spark SQL test failure to resolve:
```
SPARK-47430 Support GROUP BY MapType *** FAILED *** (124 milliseconds)
org.apache.spark.SparkException: Job aborted
codecov-commenter commented on PR #1744:
URL:
https://github.com/apache/datafusion-comet/pull/1744#issuecomment-2887342403
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1744?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093365991
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2758,16 +2758,14 @@ object QueryPlanSerde extends Logging with
CometExprShim {
andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093358984
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -242,15 +240,6 @@ object CometSparkSessionExtensions extends Logging {
andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093234206
##
spark/src/main/scala/org/apache/spark/sql/comet/CometNativeScanExec.scala:
##
@@ -237,8 +235,9 @@ object CometNativeScanExec extends DataTypeSupport {
Copilot commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093225482
##
spark/src/main/scala/org/apache/spark/sql/comet/CometNativeScanExec.scala:
##
@@ -237,8 +235,9 @@ object CometNativeScanExec extends DataTypeSupport {
12 matches
Mail list logo
