advancedxy commented on issue #329:
URL:
https://github.com/apache/datafusion-comet/issues/329#issuecomment-208203
I'm +1 for this direction in the long term and I can help review the Iceberg
integration if needed.
In the short term, I think Iceberg could integrate Comet in its
duongcongtoai commented on code in PR #10148:
URL: https://github.com/apache/datafusion/pull/10148#discussion_r1582634557
##
datafusion/physical-expr/src/scalar_function.rs:
##
@@ -146,11 +146,22 @@ impl PhysicalExpr for ScalarFunctionExpr {
// evaluate the function
jayzhan211 commented on PR #10276:
URL: https://github.com/apache/datafusion/pull/10276#issuecomment-2082078281
I think we should change the `display_name` not `create_name`, as the
commented said, name for casting should preserve
--
This is an automated message from the Apache Git Servic
dependabot[bot] opened a new pull request, #10279:
URL: https://github.com/apache/datafusion/pull/10279
Updates the requirements on
[substrait](https://github.com/substrait-io/substrait-rs) to permit the latest
version.
Release notes
Sourced from https://github.com/substrait-io/su
JasonLi-cn opened a new issue, #10280:
URL: https://github.com/apache/datafusion/issues/10280
### Is your feature request related to a problem or challenge?
```shell
DataFusion CLI v37.1.0
> select * from number;
++++
| c0 | c1 | c2 |
++++
| 1
jayzhan211 commented on issue #10074:
URL: https://github.com/apache/datafusion/issues/10074#issuecomment-2082240499
How about we introduce physical aggregate function trait,
`AggregateUDFPhysicalImpl`
I expect that `AggregateUDFPhysicalImpl` handle the physical-expr, for
example, `accum
jayzhan211 commented on issue #10074:
URL: https://github.com/apache/datafusion/issues/10074#issuecomment-2082270314
> Hmm this is a tricky refactor -- it is like a ball knot in a piece of
string -- we just need to keep tugging at it and at some point it will unravel.
Moving Aggregate
mustafasrepo commented on PR #10259:
URL: https://github.com/apache/datafusion/pull/10259#issuecomment-2082318558
I think having dedicated config setting is more verbose and clear (as in
`prefer_existing_union`). If we were to use `prefer_existing_sort` that might
also work. However, if th
planga82 commented on PR #339:
URL: https://github.com/apache/datafusion-comet/pull/339#issuecomment-2082356399
It seems that there are problems in tests with Spark 3.3 and Spark 3.2. I'm
checking it out.
--
This is an automated message from the Apache Git Service.
To respond to the messa
alamb opened a new issue, #10281:
URL: https://github.com/apache/datafusion/issues/10281
### Is your feature request related to a problem or challenge?
Per https://www.apache.org/foundation/board/reporting, for the first three
months of a project it should submit monthly board reports
alamb opened a new issue, #10282:
URL: https://github.com/apache/datafusion/issues/10282
### Is your feature request related to a problem or challenge?
Per https://www.apache.org/foundation/board/reporting, for the first three
months of a project it should submit monthly board reports
alamb opened a new issue, #10283:
URL: https://github.com/apache/datafusion/issues/10283
Follow on to https://github.com/apache/datafusion/issues/10172
**It would be great for other contributors to DataFusion who plan non
trivial work could try to make them visible somehow as well** 🙏
alamb closed issue #10172: DataFusion weekly project plan (Andrew Lamb) - April
22, 2024
URL: https://github.com/apache/datafusion/issues/10172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
alamb commented on issue #10172:
URL: https://github.com/apache/datafusion/issues/10172#issuecomment-2082463655
Next week: https://github.com/apache/datafusion/issues/10283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
alamb commented on issue #10283:
URL: https://github.com/apache/datafusion/issues/10283#issuecomment-2082464041
Review Queue
- [ ] https://github.com/apache/datafusion/pull/10221
- [ ] https://github.com/apache/datafusion/pull/9593
- [ ] https://github.com/apache/datafusion/pull/1014
alamb commented on issue #10135:
URL: https://github.com/apache/datafusion/issues/10135#issuecomment-2082467760
Now that we have completed most of the work on
https://github.com/apache/datafusion/issues/9691 I hope to draft this post
sometime this week
--
This is an automated message fro
alamb commented on code in PR #10284:
URL: https://github.com/apache/datafusion/pull/10284#discussion_r1582954905
##
docs/source/contributor-guide/communication.md:
##
@@ -37,18 +37,35 @@ We use the Slack and Discord platforms for informal
discussions and coordination
meet oth
alamb opened a new pull request, #10284:
URL: https://github.com/apache/datafusion/pull/10284
## Which issue does this PR close?
Part of https://github.com/apache/datafusion/issues/9691
## Rationale for this change
We have new mailing lists for datafusion, so let's document w
matthewmturner opened a new pull request, #10286:
URL: https://github.com/apache/datafusion/pull/10286
## Which issue does this PR close?
Closes #10012
## Rationale for this change
## What changes are included in this PR?
## Are these chang
alamb opened a new issue, #10287:
URL: https://github.com/apache/datafusion/issues/10287
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
alamb commented on issue #10287:
URL: https://github.com/apache/datafusion/issues/10287#issuecomment-2082650814
I believe @Lordworms is working on this --
https://github.com/apache/datafusion/issues/9637#issuecomment-2075311002
--
This is an automated message from the Apache Git Service.
waynexia closed issue #10246: idea: add another `static_name()` method to
`ExecutionPlan` trait
URL: https://github.com/apache/datafusion/issues/10246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
waynexia merged PR #10266:
URL: https://github.com/apache/datafusion/pull/10266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb opened a new issue, #10288:
URL: https://github.com/apache/datafusion/issues/10288
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
matthewmturner commented on PR #10266:
URL: https://github.com/apache/datafusion/pull/10266#issuecomment-2082655628
This is nice @waynexia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
matthewmturner commented on PR #10286:
URL: https://github.com/apache/datafusion/pull/10286#issuecomment-2082652618
@alamb FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
alamb opened a new issue, #10290:
URL: https://github.com/apache/datafusion/issues/10290
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
alamb opened a new issue, #10289:
URL: https://github.com/apache/datafusion/issues/10289
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
alamb opened a new issue, #10291:
URL: https://github.com/apache/datafusion/issues/10291
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
alamb opened a new issue, #10292:
URL: https://github.com/apache/datafusion/issues/10292
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
alamb opened a new issue, #10293:
URL: https://github.com/apache/datafusion/issues/10293
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
alamb opened a new issue, #10295:
URL: https://github.com/apache/datafusion/issues/10295
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
alamb opened a new issue, #10294:
URL: https://github.com/apache/datafusion/issues/10294
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
advancedxy commented on issue #344:
URL:
https://github.com/apache/datafusion-comet/issues/344#issuecomment-2082664013
FYI, I'm working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb opened a new issue, #10296:
URL: https://github.com/apache/datafusion/issues/10296
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9637
As part of making the planner faster, we are updating the optimizer passes
andygrove opened a new pull request, #345:
URL: https://github.com/apache/datafusion-comet/pull/345
## Which issue does this PR close?
N/A
## Rationale for this change
Make it easier for new contributors to understand how Comet works and where
to start lo
andygrove closed issue #328: Implement Spark-compatible CAST from String to
Timestamp
URL: https://github.com/apache/datafusion-comet/issues/328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
andygrove merged PR #337:
URL: https://github.com/apache/datafusion-comet/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
andygrove commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2082781370
@viirya @sunchao @parthchandra @comphead I did quite a bit of refactoring
and performance tuning over the weekend. Please take another look when you can.
--
This is an automate
alamb commented on issue #8373:
URL: https://github.com/apache/datafusion/issues/8373#issuecomment-2082793044
Needed to tweak the title to have a `A` rather than `a`
```
-- Forwarded message -
From: Tim Pollitt
Date: Mon, Apr 29, 2024 at 8:47 AM
Subject: AC
alamb commented on issue #9691:
URL: https://github.com/apache/datafusion/issues/9691#issuecomment-2082798866
I filed a few more doc tweaks
https://github.com/apache/datafusion/pull/10284 and
https://github.com/apache/datafusion/pull/10285
I think all that is left for this epic is to
jayzhan211 commented on code in PR #10268:
URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583125654
##
datafusion/expr/src/signature.rs:
##
@@ -92,14 +92,22 @@ pub enum TypeSignature {
/// A function such as `concat` is `Variadic(vec