@kugel- approved this pull request.
Sorry
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#pullrequestreview-1663708673
You are receiving this because you are subscribed to this thread.
Message ID:
Works for me, happy for you to override the requested changes.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#issuecomment-1752230971
You are receiving this because you are subscribed to this thread.
Message ID:
While testing #3547 I noticed that both goto declaration and goto definition
showed only the cases of the function in the `.hpp` file (the declarations),
and not the cases in the `.cpp` file (the definitions) although both were open
and the functions in the `.cpp` file showed in its symbols.
@eli-schwartz commented on this pull request.
> -if git.found()
+if git.found() and fs.is_dir('.git')
ret = run_command(git, 'rev-parse', '--short', '--revs-only', 'HEAD',
check: true)
cdata.set_quoted('REVISION', ret.stdout().strip())
else
I recommend to use `fs.exists()`
@elextr approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3583#pullrequestreview-1663639956
You are receiving this because you are subscribed to this thread.
Message ID:
Good catch, LGBI
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3583#issuecomment-1752214899
You are receiving this because you are subscribed to this thread.
Message ID:
Works (with 10 mins testing) and aligning the signatures makes file:line much
easier to distinguish from the signature. And code looks ok by quick
inspection except the translation comments.
--
Reply to this email directly or view it on GitHub:
@elextr commented on this pull request.
Looks ok by quick inspection
> if (! first && have_best)
- /* For translators: it's the filename and line number
of a symbol in the goto-symbol popup menu */
- text =
@techee yeah I'd think it's wiser to wait, but probably get it in soon after.
And yeah, HACKING changes are probably useful nonetheless.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-1752172899
You are receiving this because you are
Do we want this in 2.0?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-1752172569
You are receiving this because you are subscribed to this thread.
Message ID:
So I guess this PR will have to wait for the next release, right? I'm a bit sad
about that because Perl 6 was requested several times and this PR was waiting
for a year and a half for merging but I guess it's too late now...
Should I extract the changes from HACKING to a separate PR? It
Merged #3535 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3535#event-10585470950
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3527 as completed via 35d556ede85efb358d1cac156dd0fc8d44b20201.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3527#event-10585470932
You are receiving this because you are subscribed to this thread.
Message ID:
Go for it, it's approved after all.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3568#issuecomment-1752163855
You are receiving this because you are subscribed to this thread.
Message ID:
I just rebased on top of master to fix the merge conflict. I did *not* include
my latest suggested change.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1752161331
You are receiving this because you are subscribed to this thread.
@b4n pushed 4 commits.
c73dc3f0aedbf9b0fbc977a213dbf65b1d8a22f9 Fix go to symbol definition popup
location
229e598dd2b385d39c558b00594eed20db00f684 Drop support for GTK 3.21 and older
439aacc00596611585eeaf5b28378fef2c806bcb drop ui_menu_popup function
d2a64b0ae3af4acc3bad11230a1dec8c20e4bba5
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
As I'm a sucker for weird corner cases, this actually does not work if line
wrapping is enabled and the caret is
Yeah I think we should. There's a conflict, and I'll re-review it once more,
but it probably should make it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1752145766
You are receiving this because you are subscribed to this thread.
I'll test it a bit but I quite like it at the moment. And it basically adds a
new column from what I think I remember was the previous release (if I can
still remember), so it's almost less different, yet adding the extra info
@ntrel wanted, and that I grew to like as well.
I agree that it
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3584
-- Commit Summary --
* it.po 100%
-- File Changes --
M po/it.po (152)
-- Patch Links --
https://github.com/geany/geany/pull/3584.patch
Awesome, thanks!
I'd vote for early merge to have as much testing via master as possible.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#issuecomment-1752091164
You are receiving this because you are subscribed to this thread.
Message ID:
> Which brought me to one more place - we can also drop some settings from
> geany.css!
And also `geany-3.0.css` and `geany-3.20.css` can be dropped which I did in the
last commit.
--
Reply to this email directly or view it on GitHub:
@techee pushed 3 commits.
4bd14af80055e38ed5269a214c7d51872dde9766 Remove GTK < 3.24 stuff from geany.css
337daf7619f7029c6fe09511fa84905e9f7f1bda Update geany.txt with the required
GTK version
9c49eceec823f042ffc93bea6e11e1e72d85df90 Remove geany-3.0.css and
geany-3.20.css
--
View it on
I stumbled upon some http-URL by accident and thought "let's change it'. Then
got surprised how many there still are :(.
Interestingly, I left out the most user visible one:
https://github.com/geany/geany/blob/master/src/about.c#L453
This would cause a fuzzy translation in each language file.
Most URLs just needed to prefixed with https.
Some other URLs were outdated or broken and
got updated to the recent location.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3583
-- Commit Summary --
* Update URLs to use https consistenly
> @techee I just found another place to update, seems like we have forgotten it
> already the last time ():
Good, thanks to this we'll have a smaller diff now bumping just the major
version :-)
Which brought me to one more place - we can also drop some settings from
`geany.css`!
Will do
@techee I just found another place to update, seems like we have forgotten it
already the last time (:smile:):
https://github.com/geany/geany/blob/master/doc/geany.txt?plain=1#L106
--
Reply to this email directly or view it on GitHub:
Regardless of whether this PR gets used for the next release, I just tested the
Colomban's code and added his patch to this PR (I just updated the "For
translators" strings). It works and looks great IMO and my personal vote would
be to use this patch for the next release.
--
Reply to this
@techee pushed 1 commit.
0764b642b64f54af8f11e8dd07a9c60dd2a21acc Align all all signatures in the goto
tag popup
--
View it on GitHub:
https://github.com/geany/geany/pull/3547/files/188038a06a1050308fd7621f11147883d7e5b8fc..0764b642b64f54af8f11e8dd07a9c60dd2a21acc
You are receiving this
> As you can see the translation item has the multiple code occurrences listed
> as comment.
After some googling (while also watching renovation TV so it was a bit slow :-)
I found that:
1. a string can only occur once in the PO files, so one string and commenting
the places its used is the
If nobody stops me, I would like to merge this and the infrastructure PR to fix
the CI (and do this for G-P as well afterwards).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3568#issuecomment-1752015990
You are receiving this because you are
Long story short about the translation strings: this is safe to merge, it will
*NOT* add new untranslated strings.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1752015443
You are receiving this because you are subscribed to this
> > How do you think so? AFAIK the lookup is made solely on the string itself.
> > Either it matches or not.
>
> Oh, I thought it was possible to have the same string at different places in
> the program with differing translations? If not by file/line how is that
> done? (translation newby
@eht16 commented on this pull request.
> @@ -3973,8 +3973,8 @@ On Windows 7 and above you most likely will find it at:
``C:\users\UserName\Roaming\geany``
-Tools menu items
-
+Configuration files menu
While this section is currently mainly about the `Configuration files`
> I think they are just trying to be generic enough for the purpose of the
> definition of the protocol in case some server provides such tokens
Probably, and/or VS server provides them.
Anyway so we are back to the issue of having semantic styling overriding lexer
syntax styling, preferably
> Although MS calls it "semantic" tokens, it seems to also include simple
> syntax things like keywords, numbers, strings, comments etc so it can provide
> the information to completely replace the lexer.
I think they are just trying to be generic enough for the purpose of the
definition of
Sorry terminology error, turn off scintilla lexer setting styles, not do away
with Scintilla and its rendering of the buffer.
So what I am saying is that when the LSP says that a range is a classname we
can set the classname style on that range in Scintilla the same way the lexer
does now.
> How do you think so? AFAIK the lookup is made solely on the string itself.
> Either it matches or not.
Oh, I thought it was possible to have the same string at different places in
the program with differing translations? If not by file/line how is that done?
(translation newby question)
This is an update of the Dutch translation. Some suggestions for clarification
of the original **msgid** texts:
- As for end-users the subtle distinction between removal of an indent
(removing possible multiple characters) or a character may be unclear, please
clarify like With the cursor in
Splitting is just to get the essential part done whilst there are still changes
requested on the other part. I didn't want to say override the changes
requested.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#issuecomment-1751986955
You are
> Don't strings have file/line in their lookup, so "Templates" and "Files" menu
> items would likely show untranslated until updated?
How do you think so? AFAIK the lookup is made solely on the string itself.
Either it matches or not.
Before further speculating, just test it. Check out the
> The problem is that that now it looks this way:
What I mean is, yes its very ugly[^1], and that makes it hard for humans to
use, but it doesn't crash or provide wrong information. We seem to have
concentrated on C++ (probably my fault) but its likely to be useful for simple
situations (ie
But why splitting? IMO it causes only extra work and we want to remove the
workarounds anyway if they are not necessary any more.
Sure there is some risk of breakage but in this case this is probably tolerable
especially since we will probably use and test Geany in the next days even more
than
> Perhaps it should be split.
Can do if this is the preferred solution.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#issuecomment-1751978749
You are receiving this because you are subscribed to this thread.
Message ID:
This is a wayland bugfix IIUC, so yeah would be good to include in 2.0.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1751978216
You are receiving this because you are subscribed to this thread.
Message ID:
> So I'm thinking this shouldn't be rushed into 2.0, it certainly is still
> needed until LSP is more widely available, but its not a bug that needs
> fixing NOW!!
The problem is that that now it looks this way:
https://github.com/geany/geany/pull/3475#issuecomment-1540476259
and this is a
After having used the change history for a few days now, I also think it might
be better disabled by default so users should enable it explicitly if desired.
@kugel-
More importantly, we should document it. At the very least there should be a
few lines describing the feature at
This mixes two things:
- configuration requiring 3.24 which is absolutely required since currently it
only requires 3.0 which is completely wrong.
- removal of various workarounds
The first is uncontroversial, a bugfix, and needed for release 2.0. The second
is nice to have, but not
> @techee @b4n do we still want this in 2.0?
I would say so.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1751976951
You are receiving this because you are subscribed to this thread.
Message ID:
> I just thought, for colouring we can always simply turn off the Scintilla
> lexer (set NULL) and pass the
> [messages](https://www.scintilla.org/ScintillaDoc.html#SCN_STYLENEEDED) to
> the LSP.
You can't live without Scintilla coloring - ultimately it will always be
Scintilla that colors
Don't strings have file/line in their lookup, so "Templates" and "Files" menu
items would likely show untranslated until updated?
Also I don't see those referenced in the documentation modifications?
--
Reply to this email directly or view it on GitHub:
@kugel- what bad thing would happen if this was merged? the strings here would
still lookup the correct translations, right?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1751960604
You are receiving this because you are subscribed
@kugel- commented on this pull request.
> @@ -841,8 +827,8 @@ on_font_dialog_response(GtkDialog *dialog, gint response,
> gpointer user_data)
{
gchar *fontname;
- fontname = gtk_font_selection_dialog_get_font_name(
-
@techee commented on this pull request.
> @@ -841,8 +827,8 @@ on_font_dialog_response(GtkDialog *dialog, gint response,
> gpointer user_data)
{
gchar *fontname;
- fontname = gtk_font_selection_dialog_get_font_name(
-
54 matches
Mail list logo
