But if uctags still generates the `parent_kind:A::B::C` form the problem will
still apply in the case of ctags generated files without `sZ` so needs to still
be able to read those files. And document the ctags option as recommended
somewhere.
How "slow" is it in reality? After all tags are
> I'm slightly worried that users already got used to "goto definition"
> keybinding to behave like ctrl+click and if we modify it now, it will break
> user's expectations.
Or they will be delighted that it finally provides the declarations list as the
name says. Also as the original post
> I'm not sure how robust our parser is against invalid input
I wrote most of it, it ought to be perfect :grin:
> or updated ctags file format
In theory the format is perfectly well defined and stable (just adding new
extension fields), so it should be fine™. But in practice uctags added
Having had a look at #3049 I get the point. But IIUC it must only be merged
after #3049 is, otherwise it'll make things rather worse as the current ctags
file parser don't understand that field (it could be made to, but I guess it's
not the point :))
--
Reply to this email directly or view
@b4n commented on this pull request.
> @@ -436,7 +443,6 @@ static TMTag *new_tag_from_tags_file(TMSourceFile *file,
> FILE *fp, TMParserType
result = init_tag_from_file_alt(tag, file, fp);
break;
case TM_FILE_FORMAT_CTAGS:
-
@techee commented on this pull request.
>
- /* tag name */
- if (! (tab = strchr(p, '\t')) || p == tab)
- return FALSE;
- tag->name = g_strndup(p, (gsize)(tab - p));
- p = tab + 1;
+ if (entry.kind[0] && entry.kind[1])
+
@techee pushed 2 commits.
14c3b8081c79da98f053eda3a2f61925eafa5933 Use C-style comments
5635539d55f069a06211854bc67f1db5d1679c69 End both loops when scope found
--
View it on GitHub:
I've added this to the 2.0 milestone, but, strictly speaking, it's not
absolutely necessary if it's considered problematic for some reason. The tag
files will be parsed alright by https://github.com/geany/geany/pull/3049,
parsing will just be slower and unnecessarily inefficient.
--
Reply to
By default, ctags generates scope information using
```
parent_kind:A::B::C
```
where `A::B::C` is the scope of the parent tag. This is a bit problematic when
parsing such fields because we have to compare the `parent_kind` value against
all valid kinds of the language and if it matches, it
BTW looking at https://scintilla.org/ScintillaDoc.html#ChangeHistory, if we
only showed `!SC_MARKNUM_HISTORY_SAVED` (e.g. display what's *not* saved to
disk) it could be a lot easier to grasp, and probably more useful as well. But
that's for later I think :)
--
Reply to this email directly
@ntrel should I open a PR/update this one with this, do you want to take it
over, do you have anything against it… ?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1756247363
You are receiving this because you are subscribed to this
Merged #1276 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1276#event-10608316088
You are receiving this because you are subscribed to this thread.
Message ID:
Well, there is
- goto definition
- goto declaration
- ctrl+click
I'm slightly worried that users already got used to "goto definition"
keybinding to behave like ctrl+click and if we modify it now, it will break
user's expectations. We could introduce
- goto definition/declaration keybinding
VS Code use "Join Lines" name too.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3590#issuecomment-1755640861
You are receiving this because you are subscribed to this thread.
Message ID:
Maybe Scintilla needs to export some controls, such as resetting when the user
does reload, although of course that can be undone, so maybe not. Agree off by
default until we get more experience with it.
--
Reply to this email directly or view it on GitHub:
> But you invoked it on __the line__ where the symbol was defined already, so
> it swapped to the other search. If you invoked it on the call of that
> function, it would behave the way you expected. [my highlighting]
The behaviour and your discussion is predicated on there being __one__
Updated Spanish translation of the plugins for version 2.0
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1276
-- Commit Summary --
* Update es.po for version 2.0
-- File Changes --
M po/es.po (83)
-- Patch Links --
Actual diff from master that WFM:
```diff
diff --git a/meson.build b/meson.build
index ec3e509af..eacb73cb6 100644
--- a/meson.build
+++ b/meson.build
@@ -166,12 +166,14 @@ python = pymod.find_installation('python3', modules:
doxygen.found() and get_opt
rst2html = find_program('rst2html',
Agree. I was very surprised when I first saw it and thought "what went wrong
with git-changebar?" and it definitely lead to some confusion for me.
Also a suggestion of some possible improvements that could be done in the
future:
* make the colors configurable, possibly in `filetypes.common`
*
@techee commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
Yeah, and what's the problem here? You would like to have the popup's right
corner one character to the right?
Re-rebased on top of master to fix merge conflicts
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1755442929
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 4 commits.
d906453916469769e68a2b35345813aa66737e7e Fix go to symbol definition popup
location
956409479a4dda51e95357cbb28336c121724238 Drop support for GTK 3.21 and older
bbfc201313f948f0528280a9089bc79af1af98a0 drop ui_menu_popup function
4a2999c18e2db59bb40b90ad6453732a2596a316
* It looks either a bit confusing or to have some bugs (without having
investigated deeply, it did things I didnt understand);
* It marks all lines when reloading a file (instead of resetting to a blank
slate);
* If marker margin is not visible, it can render the editor unreadable with the
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
…and for comparison, the exact same screenshot (to my freehand abilities…) with
the `SCI_POINTYFROMPOSITION`
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
With `char_width=1` (and none of the extra tests), I get this:
> Closing now https://github.com/geany/geany/pull/3547 has been merged. Feel
> free to open further adjustments again
As a last minute patch just before the release :-).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3542#issuecomment-1755318284
You
@techee commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
> Yes it is
To be clear, I meant the screenshot is with the `char_width=1` version.
--
Reply to this email
@techee commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
> This is with the current state of this PR right, not with just char_width=0,
> is it?
Yes it is (to be
Some more annoyance: VScode uses **outdent**, but [Microsoft discourages
it](https://learn.microsoft.com/nl-nl/style-guide/a-z-word-list-term-collections/i/indent-outdent).
Democratically, Google reports **unindent** 1.1 million and **outdent** 31,6
million times. Best explanation (to use
Closing now #3547 has been merged. Feel free to open further adjustments again
:wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3542#issuecomment-1755254335
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3542.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3542#event-10603526637
You are receiving this because you are subscribed to this thread.
Message ID:
> > I just rebased on top of master to fix the merge conflict. I did not
> > include my latest suggested change.
>
> And I'm afraid I just introduced another merge conflict by merging #3547...
No worries, I have it resolved locally and it's not a big deal.
--
Reply to this email directly or
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
This is with the current state of this PR right, not with just `char_width=0`,
is it?
The problem with the
> I invoked both goto declaration and goto definition in both .hpp and .cpp,
> always got .hpp in the list.
But you invoked it on the line where the symbol was defined already, so it
swapped to the other search. If you invoked it on the _call_ of that function,
it would behave the way you
> I just rebased on top of master to fix the merge conflict. I did not include
> my latest suggested change.
And I'm afraid I just introduced another merge conflict by merging #3547...
--
Reply to this email directly or view it on GitHub:
(Merging as it is to avoid complicating things further.)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1755019676
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3547 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#event-10602619740
You are receiving this because you are subscribed to this thread.
Message ID:
@techee commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
I don't see what the problem is in this case - this is what happens when I
invoke it on `i` and move the
@techee I don't think it matters much here (but maybe the "all all"? :grin:),
but it could also be one single commit (basically your first one already
combines various things together)
--
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
Ah… I feel it looks bad if cursor is in block mode (or overwrite) and the popup
is placed on the left (when there
Should I somehow squash the commits or is it OK to merge it as it is?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1754907758
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3586 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3586#event-10602297264
You are receiving this because you are subscribed to this thread.
Message ID:
@techee commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
> Which one do you refer to as "lazy"?
Using `char_width = 0` and not calculating it.
--
Reply to this email
@b4n commented on this pull request.
> + if (sci_get_line_from_position(sci, pos_next) == line)
+ char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;
> But really, I'd be for the "lazy" solution here, it's not worth complicating
> the code too much I think.
As I said it does not simply concatenate lines. The lines are joined in a way
that has a reasonable chance of producing reasonably formatted code, not simply
deleting the line breaks. "Join lines" seems to be the most common term used
by editors for the operation, google found Eclipse,
Wiktionary shows "unindent", "outdent", "dedent" as
[synonyms](https://en.wiktionary.org/wiki/outdent) for the exact action
backspace is performing (and the preceding checkbox for shift-tab). Its better
to consistently use the relevant terminology than to attempt to describe it in
English,
So the action is to **"Conc_atenate lines and remove white spaces (and
tabs?)"**. I suggest to use the accelerator key `_a` as this is the most
audible in spoken language.
Also, would using `_U` not be more consistent in the same menu instead of
**"U_ncomment Line(s)"** ?
--
Reply to this
New attempt: "With the cursor inside an indentation, pressing backspace deletes
this indentation level instead of deleting only a single character."
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3588#issuecomment-1754632244
You are receiving this
Would have been good to have clickable permalinks to the relevant code places
(sorry couldn't resist ;-)
For the ones that are tooltips, its not likely to be possible to click on it,
if you move the cursor to try to do so the tooltip will likely change as your
cursor moves onto another widget.
The command does more than literally concatenate the selected lines,
indentation is removed from the second and subsequent lines, and trailing
whitespace is also removed.
Also `_J` is a suitable unique accelerator code, but `_C` which would be the
obvious one is already taken.
--
Reply to
Heh, overlapping comments :-P
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3588#issuecomment-1754572392
You are receiving this because you are subscribed to this thread.
Message ID:
> With the cursor in the indentation, pressing backspace deletes it completely
> (removing multiple characters) instead of deleting a single character.
This is incorrect, it removes one _level_ of indentation, it does not delete
indentation completely. The existing message is more correct
It's not removing indentation completely, it's removing one ident level (AKA
"unindent").
So maybe we indeed need a better wording if it's not clear, but your proposal
is not describing the feature accurately.
--
Reply to this email directly or view it on GitHub:
The string "_Join Lines" doesn't explain the sequence of how the lines are
joined. A description like "Concatenate Lines" would fit better I think. The
strings are located at:
- data/geany.glade:6938
- src/keybindings.c:508
--
Reply to this email directly or view it on GitHub:
The following files (with line numbers) all contain hyperlinks in the text (to
[this](https://docs.gtk.org/glib/method.DateTime.format.html) location), but
cannot be clicked by the end-user.
1. data/geany.glade:5856
2. src/printing.c:279
3. src/ui_utils.c:729
4. plugins/saveactions.c:817
It
The file **data/geany.glade** contains an unclear explanation of the option
between either removal of an indent (removing possible multiple characters) or
a character, see the property tooltip-text of **object
class="GtkCheckButton"**, **id="check_backspace_unindent"**.
Instead of _"With the
56 matches
Mail list logo
