[Github-comments] [geany/geany] Update nl.po (PR #3881)

2024-05-22 Thread Peter C. S. Scholtens via Github-comments
Removed two typo's You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3881 -- Commit Summary -- * Update nl.po -- File Changes -- M po/nl.po (8) -- Patch Links -- https://github.com/geany/geany/pull/3881.patch https://github.com/geany/

[Github-comments] Re: [geany/geany] Safe implementation of Re-load All feature (PR #3722)

2024-05-22 Thread Peter C. S. Scholtens via Github-comments
@peter-scholtens pushed 1 commit. 6bd4bdb66f66b29336957ea5df88129793e4bd38 Merge branch 'geany:master' into re-load-all -- View it on GitHub: https://github.com/geany/geany/pull/3722/files/3f350a7fed5bc57706a263f299da8caeea4e6612..6bd4bdb66f66b29336957ea5df88129793e4bd38 You are receiving this

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-22 Thread elextr via Github-comments
@elextr commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifde

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread Jiří Techet via Github-comments
One more thing, the README file contains all the supported vi commands - would you copy the added commands from `index.txt` in the vimode directory into README? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1327#issuecomment-2125868073 You are

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. I think it looks good functionality-wise, I have just suggested to rename some things to make them clearer (at least to me). > I was unable to reproduce the issue you are talking about with commit > https://github.com/geany/geany-plugins/commit/33

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread Jiří Techet via Github-comments
@scresto09 You seem to have accidentally pushed the commit together with the already merged pull request - could you fix that? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1349#issuecomment-2125456781 You are receiving this because you are sub

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-22 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 2c473da72b5eb9ebf9b54e02e60682697c46140f Merge branch 'master' into vimode-handle-fold-marginclick -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1349/files/0105a26a29b7dadb71c8703e47dfd63b287f9b14..2c473da72b5eb9ebf9b54e02e60682697c46140f You are

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 0105a26a29b7dadb71c8703e47dfd63b287f9b14 Formatting issue -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1349/files/7ecdbba5a39e3f7b91e4debf95e44eeacc267b67..0105a26a29b7dadb71c8703e47dfd63b287f9b14 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Looks good. There's just the minor formatting issue plus I noticed that right now there's a merge conflict, probably because of the other vimode PR I merged - would you have a look at that? You can just squash the result into one commit, I don't e

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-22 Thread Jiří Techet via Github-comments
Looks great, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#issuecomment-2125046192 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-22 Thread Jiří Techet via Github-comments
Merged #1328 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#event-12896294105 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1337)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 0 commits. -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1337/files/69a08680c5037816226d3f00a488e2b38c81ec2c..7615fdcdeae24739d65ddf42554fcaf48a380d82 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-22 Thread cresto sylvain via Github-comments
OK, I just create #1349 for SCN_MARGINCLICK part. Thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1326#issuecomment-2124751106 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-22 Thread cresto sylvain via Github-comments
I just create #1349 for SCN_MARGINCLICK part. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1338#issuecomment-2124750459 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread cresto sylvain via Github-comments
Automatically set the cursor position on the visible line on SCN_MARGINCLICK event You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1349 -- Commit Summary -- * Vimode: handle fold and margin click event -- File Changes -- M vi

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-22 Thread cresto sylvain via Github-comments
OK, it's works fine, thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1338#issuecomment-2124413450 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread cresto sylvain via Github-comments
OK, I tried to make some changes to improve fold support and react more like vim. With za/zo/zc we fold the current block as before. With zA we change the fold depending on the state of the parent, if there is one that is contracted we expand it otherwise we contract it. I was unable to reproduce

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 3 commits. c5e4c30b9a8e2eef9bbc6a7ba9c3516e1b6b33a3 Move fold functions to fold.c/fold.h files c9e04135595b28fc2390d156b9686621b2d6dd24 Merge branch 'vimode-fold-support' of https://github.com/scresto09/geany-plugins into vimode-fold-support c902da4df5df85fcbcb2bd6a2d80484806

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 904ee74be16f74c9cd0173353c224497c87b861e Merge branch 'geany:master' into vimode-fold-support -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1327/files/cd00fbc84dc0480e6a7b9e3c8a934225057fc051..904ee74be16f74c9cd0173353c224497c87b861e You are rece

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-22 Thread cresto sylvain via Github-comments
OK, I did it, is it okay? Thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#issuecomment-2124232024 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-22 Thread elextr via Github-comments
@elextr commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifde