[Github-comments] [geany/geany-plugins] ProjectOrganizer, Workbench: Use GStatBuf for "g_stat()" calls (PR #1353)

2024-05-26 Thread Enrico Tröger via Github-comments
For some reason, since the latest MSYS2 update on my Windows system, I got compiler errors that `g_stat()` requires a `GStatBuf` type as second argument. According to the docs, https://docs.gtk.org/glib/func.stat.html, this is correct and in Geany we also use `GStatBuf` in all places. You can

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-26 Thread Enrico Tröger via Github-comments
One last remark: could we add `AS` to the keywords? It's not strictly a directive on its own but is part of the `FROM` directive, e.g. `FROM debian:bullseye-slim AS builder` and without the highlighting looks a bit broken. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Enrico Tröger via Github-comments
> @eht16 you're the de-facto expert here, remember you did some work on it, now > you're doomed  Remember, this is certainly at least one decade ago and since then I successfully managed to avoid doing any PowerShell :). > I'll try and update this, but feel also free to take this PR over

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 7707c7a346a585bbb79e766bae912d389ad90b2b PowerShell: Add keyword "clean" and aliases "foreach" and "where" -- View it on GitHub: https://github.com/geany/geany/pull/3886/files/5a2a436e69550bed35fdc215baffb8c09a0fa25f..7707c7a346a585bbb79e766bae912d389ad90b2b You are

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-26 Thread Enrico Tröger via Github-comments
> Alright, I made the suggested changes: > > 1. I made GtkFileChooserNative configurable, by default enabled on macOS > and Windows, disabled on Linux. Sweet, works perfectly. > 3. Not sure if intentional or if it's some left-over but `ui_utils.c` > still contains native win32

[Github-comments] Re: [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)

2024-05-26 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -152,6 +152,8 @@ Section "Dependencies" SEC04 SectionEnd Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"' > OK. If `$INSTDIR` ought to be the same, maybe just make the 2.1 installer > depend

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Enrico Tröger via Github-comments
To the removed ones: - "default" - no idea - "where" - according to http://xahlee.info/powershell/powershell_aliases.html and https://superuser.com/a/1397265, "where" is an alias So, we could add "where" to the aliases list. I checked the aliases in PowerShell on my Windows 7 machine, there are

[Github-comments] Re: [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)

2024-05-26 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 5298197dbef2ae5ac5047d461aa521b8b32406c4 Windows: Make installer depend on Geany 2.1 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1352/files/c145a8c902356cb43ec9439e87124de52cabc4ab..5298197dbef2ae5ac5047d461aa521b8b32406c4 You are receiving this

[Github-comments] Re: [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)

2024-05-25 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -152,6 +152,8 @@ Section "Dependencies" SEC04 SectionEnd Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"' > How does this behave if the executable is missing? If it is mandatory, then >

[Github-comments] Re: [geany/geany] Make Custom Target should have a directory combo box (Issue #3883)

2024-05-25 Thread Enrico Tröger via Github-comments
But why not, the combo box could be empty by default and so is not used. If the user wants to adds something, then it will be used. OTOH, this can also be achieved by using "-C src all" (or whatever target is desired) using the existing functionality. -- Reply to this email directly or view

[Github-comments] Re: [geany/geany] #!/bin/busybox ash (Issue #3884)

2024-05-25 Thread Enrico Tröger via Github-comments
Alternative and already working, you can add a header line to hint Geany what filetype to use: ```sh #!/bin/busybox ash # -*- Sh -*- ``` It is roughly described in https://geany.org/manual/#various-preferences (search for "extract_filetype_regex"). -- Reply to this email directly or

[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)

2024-05-25 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -16,7 +16,7 @@ More than financial support, the Geany project needs help > with: If you want to donate money to the Geany project, it will be used to support further development of Geany, to pay running costs for hosting and domains and support

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-25 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-25 Thread Enrico Tröger via Github-comments
> @eht16 paste configuration issue should be fixed. But indeed it's unrelated > to this PR, just to you using a newer GLib Yes, it is fixed. Thanks for fixing it! > > Can't we "simply" run `glib-compile-schemas` during GP (and possibly Geany) > > installation? it's e.g. what Linux distros

[Github-comments] [geany/geany] Windows: Add glib-compile-schemas.exe to GTK bundle (PR #3885)

2024-05-25 Thread Enrico Tröger via Github-comments
This is necessary to compile GLib schemas, e.g. when installing plugins with their dependencies. It is not strictly necessary to compile the schemas again on installation as they are already compiled during the bundle creation but it probably wont hurt and might be useful if installing

[Github-comments] [geany/geany-plugins] Windows: Compile GLib schemas after installation (PR #1352)

2024-05-25 Thread Enrico Tröger via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1352 -- Commit Summary -- * Windows: Compile GLib schemas after installation -- File Changes -- M build/geany-plugins.nsi (2) M build/gtk-bundle-from-msys2.sh (1) -- Patch

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-22 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32

[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)

2024-05-20 Thread Enrico Tröger via Github-comments
Was there any confusion? Now, I'm confused: should this mean bank transfers are only possible in Europe at all or should it mean bank transfers using SEPA are only supported in Europe? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread Enrico Tröger via Github-comments
> > No leftover configuration. I could reproduce this with pastebin.geany.org > > on Linux and Windows. > > After removing the keys from the `[parse]` section in > > `geniuspaste/data/pastebin.geany.org.conf` so that the section remains > > empty in the config, it works. > > What does the

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-20 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-05-20 Thread Enrico Tröger via Github-comments
`#ebdfd8` seems fine to me. Let's see what @rovf says. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/71#issuecomment-2121252920 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-20 Thread Enrico Tröger via Github-comments
If there are no objections, I would merge this next weekend and update the Wiki accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-2120677402 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-05-20 Thread Enrico Tröger via Github-comments
@b4n they are indeed. I gave `#e4d3c7` it try as a rather lighter brown than before. ![Screenshot_2024-05-20_17-12-06](https://github.com/geany/geany-themes/assets/617017/08e46fd5-ff29-44b5-be23-7abf865ef618) This might be better for selection background. Though this makes the braces and the

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2024-05-20 Thread Enrico Tröger via Github-comments
Since the changes in upstream ctags have been pulled into Geany already, the last use was in `ctags/gnu_regex/regex_internal.h` which is our code, if I'm not mistaken. So, what do you think about #3878 to remove the `WIN32` macro completely? CI and manual builds on Windows with Autotools and

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-05-20 Thread Enrico Tröger via Github-comments
Sorry for the commit spam. I wanted to squash them together but somehow I failed to do so :(. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851#issuecomment-2120599747 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-20 Thread Enrico Tröger via Github-comments
Closes #3660. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3878 -- Commit Summary -- * Remove custom WIN32 compiler macro in favor of _WIN32 -- File Changes -- M m4/geany-mingw.m4 (1) -- Patch Links --

[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)

2024-05-20 Thread Enrico Tröger via Github-comments
Closed #3702 as completed via #3851. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#event-12866765344 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-05-20 Thread Enrico Tröger via Github-comments
Merged #3851 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851#event-12866765079 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread Enrico Tröger via Github-comments
> > When trying to paste some file, Geany crashes for me when it is executed > > natively. I don't know yet why this happens and I didn't manage it yet to > > debug it with gdb. This might be related to my system where I use some > > firewall rules to block unwanted internet access from Windows

[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F

2024-05-20 Thread Enrico Tröger via Github-comments
It can be solved. The mentioned Scintilla API is already available in the GIT master version of Geany. So we need to use it and probably add some new styles for inactive selection text. It still needs someone willing to do it but it's possible. -- Reply to this email directly or view it on

[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)

2024-05-19 Thread Enrico Tröger via Github-comments
Merged #1339 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#event-12858384938 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)

2024-05-19 Thread Enrico Tröger via Github-comments
Tested and works. Thank you! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#issuecomment-2119229141 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Selection color changed in default theme but the changed color doesn't take effect if the "Find" dialog box is open. The changed color takes effect only when the "F

2024-05-19 Thread Enrico Tröger via Github-comments
Could it be that the selection color just changes when the find dialog is open because the focus is set from the Geany main window to the find dialog? At least, I see similar behaviour on Linux as well. If so, this is not a problem at all but rather normal behavior and not related to the find

[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)

2024-05-19 Thread Enrico Tröger via Github-comments
I don't think this would be better. Then every time a new instance would be started which works indepedent of the existing one. This is especially unconvenient when opening files via the .desktop items (task bar, app menus, file managers, ...). To me it sounds rather like this would only fix

[Github-comments] Re: [geany/geany] Geany takes \n as 'n' in search/replace whole words only. It should treat new lines as '\n' search only (Issue #3875)

2024-05-19 Thread Enrico Tröger via Github-comments
I wonder if this could be too specific? Maybe there are cases where it is legitimite to treat the 'n' in '\n' as whole word if the context does not know about escape sequences. The behavior can be changed by adding '\\' to the `wordchars` settings in `filetypes.common` and the filetype

[Github-comments] Re: [geany/geany] Geany takes \n as 'n' in search/replace whole words only. It should treat new lines as '\n' search only (Issue #3875)

2024-05-19 Thread Enrico Tröger via Github-comments
Closed #3875 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3875#event-12858279682 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-themes] Flatpak directory location (Issue #47)

2024-05-05 Thread Enrico Tröger via Github-comments
> @eht16 be polite. I did the groundwork beforehand. The archive sure does look > official - https://flathub.org/apps/org.geany.Geany My post wasn't meant to sound that rude, sorry for that. But I guess you got my point. Probably not necessary to say after your last post

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-04 Thread Enrico Tröger via Github-comments
Nice. I think we could add this new filetype and then update the wiki page to have it only a seperate docker-compose filetype and a reference to the GIT version of this Docker filetype. I'm happy to do this after merge. Regarding the `extension=` setting: what do you think about using lower

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-04 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -0,0 +1,14 @@ +[styling=Sh] + +[keywords] +primary=ADD ARG CMD COPY ENTRYPOINT ENV EXPOSE FROM HEALTHCHECK LABEL MAINTAINER ONBUILD RUN SHELL STOPSIGNAL USER VOLUME WORKDIR + +[lexer_properties=C] ```suggestion [lexer_properties=Sh] ``` Or am I

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-04 Thread Enrico Tröger via Github-comments
> Maybe one more question - should the open dialog show hidden files by > default? [...] > I'm not sure if it's possible on Windows too though (on the other hand > Windows hidden files aren't so important I think because it's not those > beginning with `.` like `.gitignore` that typical

[Github-comments] Re: [geany/geany-themes] Flatpak directory location (Issue #47)

2024-05-04 Thread Enrico Tröger via Github-comments
Closed #47 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/issues/47#event-12704196950 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-themes] Flatpak directory location (Issue #47)

2024-05-04 Thread Enrico Tröger via Github-comments
Why do you use Geany as Flatpak at all? I don't understand why users go this way and then wonder why things won't work. This issue is clearly caused by the Flatpak package and should be reported to the maintainers of this package - whoever this is, it is very well hidden on FlatHub and falsely

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-04 Thread Enrico Tröger via Github-comments
I tried to test it on Windows but got mixed results :(. First, we need more dependencies on Windows: ``` diff --git a/build/gtk-bundle-from-msys2.sh b/build/gtk-bundle-from-msys2.sh index 408d727f..529fa24a 100644 --- a/build/gtk-bundle-from-msys2.sh +++ b/build/gtk-bundle-from-msys2.sh @@ -21,7

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-05-01 Thread Enrico Tröger via Github-comments
> So it probably works provided one uses an up to date operating system. If > anyone has access to a Windows 10/11 system, the artifacts of the CI build > https://github.com/geany/geany-plugins/actions/runs/8850165013 contain the > Geany and G-P installers for easy testing. I was about to ask

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-01 Thread Enrico Tröger via Github-comments
The native file dialog on Windows 7 works very well after some testing. Non-ASCII path and file names seem to work well, too. ![Screenshot_2024-05-01_19-35-32](https://github.com/geany/geany/assets/617017/3aaca2a3-9213-4435-89ab-864a9460c383) I don't know how to set up "automounted remote

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-05-01 Thread Enrico Tröger via Github-comments
> Anyway, what do you guys think? Is it good? Are there too many > false-positives? > Should the suppressions be moved back to `AM_CPPCHECKFLAG`s not to alter the > code, although it makes it harder to maintain? I'm fine with having the suppressions inline. I don't remember if it was me

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-29 Thread Enrico Tröger via Github-comments
>Somebody who has Windows 11 and can build Geany with this needs to >test as well. No need to build yourself, a full installer with the changes can be downloaded from the CI builds: https://github.com/geany/geany/actions/runs/8869590862 Windows 10/11 feedback would be great, I can only test on

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-28 Thread Enrico Tröger via Github-comments
I'm curious though as I only use Linux, it won't change anything for me :D. But I'll give it a try on Windows, this will take a few days though. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2081658681 You are receiving this because

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE], GP_ARG_DISABLE([GeniusPaste], [auto]) GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE, - [libsoup-2.4 >= 2.4.0]) + [gtk+-3.0 >= 3.16 No. It

[Github-comments] Re: [geany/geany-plugins] Fix CPP CMake option capitalization (PR #1344)

2024-04-28 Thread Enrico Tröger via Github-comments
Merged #1344 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1344#event-12635099051 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] Fix CPP CMake option capitalization (PR #1344)

2024-04-28 Thread Enrico Tröger via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1344 -- Commit Summary -- * Fix CPP CMake option capitalization -- File Changes -- M .github/workflows/build.yml (2) -- Patch Links --

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Enrico Tröger via Github-comments
> > I "think" it will work. > > In detail this is, when querying https://geany.org/ I get an error: `GET > > request failed: WinHttp error: SECURE_CHANNEL_ERROR`. […] > > If I change the URL to query to https://httpbin.org/anything/version, the > > HTTP request works fine and I get the expected

[Github-comments] Re: [geany/geany-plugins] CI: Download, compile and use latest cppcheck version (PR #1310)

2024-04-28 Thread Enrico Tröger via Github-comments
Merged #1310 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1310#event-12634889055 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-28 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2027099072 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-28 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs gbooleanuse_current_file_dir; /* find in files directory to use on showing dialog */ gbooleanhide_find_dialog; /* hide the find dialog on next or previous

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-28 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. bb15a702a9a0ae9eb4e2f805e391f30c6a9f06ad fixup: do not increase plugin API version -- View it on GitHub: https://github.com/geany/geany/pull/3851/files/c0cd092a49a3162f57691099f115fc2689515774..bb15a702a9a0ae9eb4e2f805e391f30c6a9f06ad You are receiving this because you

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-28 Thread Enrico Tröger via Github-comments
Looks good now. As said before, I cannot judge whether the result of the snippets is as desired. To me it feels a little confusing that the element in the "itemize" environment is indented while for the other ones the cursor position is not indented. Maybe it's ok. -- Reply to this email

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE], GP_ARG_DISABLE([GeniusPaste], [auto]) GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE, - [libsoup-2.4 >= 2.4.0]) + [gtk+-3.0 >= 3.16 We also

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Enrico Tröger via Github-comments
> Guys, be a bit patient :D. I'll test this on Windows/MSYS2 later or in the > next days. I "think" it will work. In detail this is, when querying https://geany.org I get an error: `GET request failed: WinHttp error: SECURE_CHANNEL_ERROR`. But I guess this is not related to the changes but

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-26 Thread Enrico Tröger via Github-comments
Guys, be a bit patient :D. I'll test this on Windows/MSYS2 later or in the next days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079741003 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-26 Thread Enrico Tröger via Github-comments
> > For "table" and "itemize" there is a trailing space after the cursor > > marker. Is this intended? > > "block" uses no indentation at all, "itemize" uses a tab resp. spaces and > > "table" uses a single space only. > > This is fixed. I tried to re-sync the indentions I cannot verify as I

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-26 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > - tmp = g_strdup_printf("\n\\end{%s}", environment); - glatex_insert_string(tmp, FALSE); - g_free(tmp); - - indention_prefs = editor_get_indent_prefs(doc->editor); -

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-23 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > **``search`` group** -find_selection_type See `Find selection`_. 0 immediately -replace_and_find_by_default Set ``Replace & Find`` button as default so trueimmediately -

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-23 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs gbooleanuse_current_file_dir; /* find in files directory to use on showing dialog */ gbooleanhide_find_dialog; /* hide the find dialog on next or previous

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-23 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. c0cd092a49a3162f57691099f115fc2689515774 fixup: move new search pref to the end of struct -- View it on GitHub: https://github.com/geany/geany/pull/3851/files/8c9818eb861065ca48854e0d7aed5b2daf52310a..c0cd092a49a3162f57691099f115fc2689515774 You are receiving this

[Github-comments] Re: [geany/geany] meson: Use host instead of target (PR #3853)

2024-04-23 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. Tested and works on Windows. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3853#pullrequestreview-2018263666 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

2024-04-21 Thread Enrico Tröger via Github-comments
I tested this last week and forgot to comment :). It works fine and parses the random Ocaml code I found on the net properly. Though I don't know the language at all :D. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3163#issuecomment-2068120694 You

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

2024-04-21 Thread Enrico Tröger via Github-comments
@masla84 if this still persists, please check Help->Debug Messages in Geany, at the beginning loading of plugins is logged and also if there any errors occurred. Alternatively, uninstall all of your Geanys, remove the config folder (or at least clean the plugin paths manually) and try again.

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #1292 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1292#event-12551239724 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)

2024-04-21 Thread Enrico Tröger via Github-comments
A new various pref to disable the confirmation dialog is added in #3851. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#issuecomment-2068108109 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)

2024-04-21 Thread Enrico Tröger via Github-comments
Reopened #3702. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#event-12551227374 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Add various pref replace in session (PR #3851)

2024-04-21 Thread Enrico Tröger via Github-comments
Allow brave users to disable the confirmation dialog when replacing text in the whole session. While modifying the docs, I noticed a missing various pref in the table and added it. Because of the long names of the other and the new setting, the table grew and needed reformatting. I put this

[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)

2024-04-21 Thread Enrico Tröger via Github-comments
Merged #3656 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#event-12551171089 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fortran function random_init not highlighted (Issue #3362)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #3362 as completed via #3656. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3362#event-12551171193 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #2088. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#event-12551166960 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-21 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > if (utils_str_equal(environment, "block") == TRUE) { - g_string_append(tmpstring, "}{}"); + tmpstring =

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-21 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. Looks good. As you know I'm not LaTeX expert and so I'm wondering if it is on purpose that different environments produce quite different stylings: ``` \begin{block}{} _ \end{block} \begin{itemize} \item _ \end{itemize} \begin{table} _

[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)

2024-04-21 Thread Enrico Tröger via Github-comments
@StephenWassell is this still relevant or can we close this? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#issuecomment-2068040167 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix search entry after editing the toolbar (PR #3838)

2024-04-21 Thread Enrico Tröger via Github-comments
It seems to work without the guard as well. The connect_proxy function is called four times here, but it's the same on Linux and Windows and in either way, the search toolbar item still works after re-ordering. Since we cannot reproduce this anymore and the "fix" is so long ago, maybe it was

[Github-comments] Re: [geany/geany] Help command should check browser tool's return value (Issue #3468)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #3468 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3468#event-12550837837 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Encodings UI improvements (PR #3720)

2024-04-21 Thread Enrico Tröger via Github-comments
Looks and works great, tested on Linux and Windows! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3720#issuecomment-2068035433 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > geany_debug("Couldn't convert from %s to UTF-8.", > charset); + g_set_error(error, G_CONVERT_ERROR, G_CONVERT_ERROR_ILLEGAL_SEQUENCE, + _("Data contains NULs")); Do we

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread Enrico Tröger via Github-comments
There are actually some encodings which seem not support on Windows: ``` 15:31:32.356445: Geany INFO : Encoding ISO-8859-10 is not supported by the system 15:31:32.356445: Geany INFO : Encoding ISO-8859-14 is not supported by the system 15:31:32.356445: Geany INFO

[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)

2024-04-21 Thread Enrico Tröger via Github-comments
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1323#issuecomment-2068027676 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Line Operations plugin outputs "Value: 0" to terminal when Geany launches (Issue #1322)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #1322 as completed via #1323. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1322#event-12550784189 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)

2024-04-21 Thread Enrico Tröger via Github-comments
Merged #1323 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1323#event-12550784154 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)

2024-04-21 Thread Enrico Tröger via Github-comments
Don't we want to merge this anyway? Maybe the performance impact is tolerable and then it is still an improvement for Fortran users. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#issuecomment-2068027071 You are receiving this because you are

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-14 Thread Enrico Tröger via Github-comments
Well, the CI just builds the code and runs some simple tests. This is already a good indicator, yes. Still, it is different from executing the full application with full loading of GTK and such. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-14 Thread Enrico Tröger via Github-comments
Could anyone who uses Meson on Linux check if this is fine and properly ignored? @b4n or @kugel- maybe? I tested it on Windows and it does what it should. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054064747 You are receiving

[Github-comments] Re: [geany/geany] meson: Add icon with geany program (PR #3812)

2024-04-14 Thread Enrico Tröger via Github-comments
@Biswa96 thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3812#issuecomment-2054062719 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Add icon with geany program (PR #3812)

2024-04-14 Thread Enrico Tröger via Github-comments
Merged #3812 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3812#event-12460442729 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Add icon with geany program (PR #3812)

2024-04-14 Thread Enrico Tröger via Github-comments
Looks fine and works on Windows, the icon and the other meta information on the executable are set properly. > We lack a Meson Windows job to tell We could add it. I might work on this at some point (days, weeks, months, who knows :smile: ). -- Reply to this email directly or view it on

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2024-04-14 Thread Enrico Tröger via Github-comments
Is there anything wrong with merging this? Even if it would be cooler to not have to set the flag, as it is done by Autotools as well, it might be ok. And if uctags is updated next time, we could try to remove it again. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2024-04-14 Thread Enrico Tröger via Github-comments
> > Is `_WIN32` set for cross builds? > > `_WIN32` is set in compiler which targets Windows platform - no header or IDE > is required. You can verify that using `cc -dM -E - < /dev/null | grep WIN32` > command. Yep, looks good. This is in a Docker container running the image we use in CI for

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-14 Thread Enrico Tröger via Github-comments
> > I would suggest to provide Windows installer. Most of the users will still > > use official installer who are not familiar with msys2 and its packaging > > system. > > But as I said above, none of the major contributors use Geany on Windows, > even the nice guy who makes the build (and yes

[Github-comments] Re: [geany/geany-plugins] Default plugins folder incorrect / not found (Issue #1321)

2024-04-14 Thread Enrico Tröger via Github-comments
@socal-nerdtastic if you are curious and brave enough, you could try the Geany and Geany-Plugins installers from: https://github.com/geany/geany-plugins/actions/runs/8679662809/artifacts/1412215267 They should work now. But aware, these installers are created from GIT master, the current

[Github-comments] Re: [geany/geany] [RFC] Enable keyboard searching for Compiler and Messages tree views (PR #3823)

2024-04-14 Thread Enrico Tröger via Github-comments
`git blame` tells that it was me disabling it, in 2006. Unfortunately, I didn't comment why I did this and I don't remember. Maybe there were problems with interactions or I just did it for no specific reason. I'm fine to enable it again and see if it works as expected. -- Reply to this

[Github-comments] Re: [geany/geany-plugins] lineoperations: Commented out debug code to fix #1322 (PR #1323)

2024-04-14 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -117,7 +117,7 @@ lo_init_prefs(GeanyPlugin *plugin) lo_info->use_collation_compare = utils_get_setting_boolean(config, "general", "use_collation_compare", FALSE); - printf("VALUE: %d\n", lo_info->use_collation_compare);

[Github-comments] Re: [geany/geany] Python print() doesn't work well. (Issue #3798)

2024-04-14 Thread Enrico Tröger via Github-comments
Closed #3798 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3798#event-12460279098 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Python print() doesn't work well. (Issue #3798)

2024-04-14 Thread Enrico Tröger via Github-comments
I cannot reproduce this (similar to #3772). Either it is related to Windows 11 vs my Windows 7 or some settings. But as @elextr said, Geany just starts the configured command. -- Reply to this email directly or view it on GitHub:

  1   2   3   4   5   6   7   >