@elextr commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const
> re_string_t *input, int idx,
#define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
#define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
-
@elextr commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const
> re_string_t *input, int idx,
#define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
#define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
-
@elextr commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const
> re_string_t *input, int idx,
#define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
#define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
-
@b4n IIUC using gvfs would add lots of other capability, eg access to networked
files.
There were a couple of attempts, #963 got a lot of comments, but in the end was
not merged, and #1414 got only one comment.
Both now have conflicts so I guess "not planned" is a reasonable response.
--
¯\\_(ツ)_/¯
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3843#issuecomment-2122555486
You are receiving this because you are subscribed to this thread.
Message ID:
> non-composited Metacity WM under MATE
Doesn't that setting relate to composited WMs?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3843#issuecomment-2122536891
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const
> re_string_t *input, int idx,
#define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
#define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
-
I dunno, thats what came up related to `XLIB_SKIP_ARGB_VISUALS`, anyway not
worth learning now, Wayland is the future.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3843#issuecomment-2121988695
You are receiving this because you are subscribed to
> but they all seem to handle the case the visual isn't found
Its not that it isn't found, its that apps (and that includes GTK) are not
supposed to use them even if they do exist, from my link above "Most X
applications ignore this visual since it is not useful to them; however some
@elextr commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const
> re_string_t *input, int idx,
#define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
#define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
-
My basic search of issues does not show any other complaints with this
background colour, so simply replacing one default with another is unlikely to
be accepted. It would need to be a setting in `filetypes.common` (and possibly
overrides from colour schemes) so it can be set by users or
Sounds like its GTK thats misusing the visuals since its not just Geany thats
affected.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3843#issuecomment-2120445875
You are receiving this because you are subscribed to this thread.
Message ID:
We really should not be supporting operation with broken systems, and remember
two Geanys in the same config do not share settings and sessions nicely anyway,
its just generally a "bad thing" to do. Perhaps `-i` should prevent saving
settings and sessions.
--
Reply to this email directly or
And you havn't answered the question of where did you get the copy of Geany
that gives a different message to the original, and what else has been changed
in that copy?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3871#issuecomment-2120114948
You
The OP relates to accessing the socket file that is used for communication to
an existing copy of Geany, that stops Geany execution to avoid corruption, it
is nothing to do with opening the file.
--
Reply to this email directly or view it on GitHub:
Ranting is not needed and unhelpful, volunteers using their own time to develop
software do not need to be SHOUTED at.
What version of Geany is that and where did you get it? The error message in
Geany code is
The default unfocused selection style is part of
[Scintilla](https://www.scintilla.org/), that is another project, its not Geany
code. Geany uploads Scintilla code unmodified, we do not have the resources to
maintain patches for it.
You may try to have Scintilla change that default, but
> I click next on the find box and the text is highlighted in grey.
The found text is not simply highlighted, it is selected, so what is shown is
the unfocused selection style, which as above is hard coded to `#xc0c0c0`.
> In notepad, the matched text is highlighted in blue
So Notepad either
> > The socket file message probably means either Geany crashed
> Does it lead to this? I don't think so
Crashed ... as another user, eg database_admin ...
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3871#issuecomment-2119456562
You are receiving
There is no background that is always right, thats why Scintilla has made it
settable I guess. But the grey has sufficient contrast with black on white
text and white on black text (on my monitor with my eyes, YMMV).
Dimming the selection when not focused is a common idiom on Windows, and
@eht16 has pointed out the reason you don't see the selection colour, you still
have the focus on the find dialog, so the edit pane does not have focus, and
Scintilla makes the selection grey when the edit pane is not focused.
There is a fairly new API that allows [changing the unfocused
> it doesn't know whether it's inside a function so it shows all assignments
> and the result is a little too noisy.
Yeah, if they are not scoped then its not very useful.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3877#issuecomment-2119241869
Python does this too, every assignment is a new declaration and shows in the
sidebar, on the other hand Julia (where assignment is also declaration) has
chosen not to show any assignments in the sidebar, YMMV.
--
Reply to this email directly or view it on GitHub:
The socket file message probably means either Geany crashed (or was crashed by
logging out or shutting down with it still running) or Geany was run as root or
`sudo` and that still owns the socket link in your config directory. You can
look there and the link will be obvious, so you should be
To add to @eht16 comment, search replace does not understand the context of
what it is editing, it does not see a programming language string in which `\n`
means newline, it just sees text characters `\` and `n`.
--
Reply to this email directly or view it on GitHub:
Merged #3866 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3866#event-12857263637
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1348#pullrequestreview-2064966967
You are receiving this because you are subscribed to this thread.
Message ID:
Perhaps you want one of the project plugins that add functionality to the
built-in project capabilities.
There is no agreement how the built-in projects should operate hence there are
(IIRC) three project plugins.
--
Reply to this email directly or view it on GitHub:
This Geany is built from a month or so old Git.
But I am on Linux and I see you are on Windows, maybe its something about GTK
and Windows?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3874#issuecomment-2117555793
You are receiving this because you
Works for me, Geany 2.0, the text found by the find dialog changes colour
immediately `filetypes.common` is saved, even with the find dialog open.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3874#issuecomment-2117480957
You are receiving this
Yes agree, but any scenario that is possible _can_ occur, and the case of the
user closes document while dialog open has been reported already, and see #2599
for a non-KDE example.
Since we don't have many occurrences its not something that needs rushing into,
just put it on the eternal todo
Closed #3839 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3839#event-12780298369
You are receiving this because you are subscribed to this thread.
Message ID:
> checking the ID would be better.
No, actually checking `id` is essential. I didn't really realise how much
until now. Consider for example the sequence:
1. Geany function gets `doc` pointer
2. does something that results in a signal
3. plugin callback is called by signal and it closes the
Sigh, welcome to asynchronous programming and state changing beneath you.
> if the pointer to the doc was freed in the meantime, DOC_VALID() usage would
> lead to memory access over invalid pointer.
Document objects are never freed, so you will never get an invalid pointer, so
thats one less
Version of Geany, what version of GTK?
AFAICT you are operating totally within the GTK open file dialog, it does the
munging of typed input with open directory and Geany can only read the results.
So we can't control that behaviour.
--
Reply to this email directly or view it on GitHub:
Closed #2713 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2713#event-12709232704
You are receiving this because you are subscribed to this thread.
Message ID:
Until Scintilla is ported to GTK4 Geany cannot even think about it, so no point
discussing it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2713#issuecomment-2095085963
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr commented on this pull request.
Couple of suggestions, otherwise looks good.
> @@ -11,7 +11,9 @@ GeanyCtags adds a simple support for generating and
> querying ctags files for a G
project. It requires that the ctags command is installed in a system path. On
unix systems, distrib
I am not an expert, but my understanding is that technically there is not much
wrong with the flatpack format if a project depends on bleeding edge components
but wants to run on an older OS, it can contain/download the newer parts it
needs without overwriting the original versions on the OS,
> The file tm_ctags.c is our source that hides the ctags "API" behind some thin
> layer and it is only this file that includes ctags headers so we don't
> pollute the rest of our sources with symbols included from ctags.
Too easy then.
--
Reply to this email directly or view it on GitHub:
> The custom filetypes that don't use tag_parser also set the parser to
> TM_PARSER_NONE but don't have any global tags file so the crash doesn't
> happen for them.
Ok, it didn't make sense that TM_PARSER_NONE worked for custom, but not
built-in, but in fact that we are doing something that
Sorry, I wasn't clear, many of the custom filetypes have no parser and don't
crash. So what do they set the `tag_parser` to? And can `tag_parser=` be set
to the same value that successfully works for custom filetypes.
--
Reply to this email directly or view it on GitHub:
LGTM, doesn't clash with any other extensions, if no objections can be merged
in about a week.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3866#issuecomment-2094690323
You are receiving this because you are subscribed to this thread.
Message ID:
What does upstream say about the changes?
What is the setting set to if the `tag_parser=` is not present? And can
`tag_parser=` mean that?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3865#issuecomment-2094556791
You are receiving this because you
@AtomicRobotMan0101 since you mentioned LM maybe you should read their
[blog](https://blog.linuxmint.com/) on the topic of flatpack verifications, its
a ways down but there is no direct link AFAICT. Note that (at least on the
website) the "Geany team" on the Geany flatpack is marked "
There are unlikely to be many other editors that use the GTK toolkit on Windows
(vscode definitely does not) so the fact that fonts work elsewhere does not
help. GTK tends to do its own thing, so how it handles fallback fonts on
Windows is unknown. Vscode uses electron which is a browser
Can a flatpack access the internet?
Anyway Geany itself does not perform any internet access and does not contain
the libraries to do that.
A couple of the plugins in the Geany plugins collection do, so maybe "somebody"
could add a plugin to read colour schemes from the repository if a
> The issue you have is that the 4th quote (after the %f) is not an ASCII
> quote, but U+201C Left Double Quotation Mark. Just replace the command with:
Wow eagle eyed!! :eyes:
--
Reply to this email directly or view it on GitHub:
> the issue can be moved?
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3864#issuecomment-2092603896
You are receiving this because you are subscribed to this thread.
Message ID:
Your image did not come through.
As I said above, you should interact via the github website. Github is not a
mailing list, it is a website, and emails are largely intended for
notifications. Although you can post via email the variation in the behaviour
of mailing tools means many
Please post the string from the build entry in github, not via email, the
string you have posted
[here](https://github.com/geany/geany/issues/3863#issuecomment-2091366390)
starts and ends with `*`.
--
Reply to this email directly or view it on GitHub:
Note that the problem is nothing to do with Geany (or codeblocks) its the
command you are entering. The best approach is to get commands to work in the
command line and then paste them into tools.
--
Reply to this email directly or view it on GitHub:
Closed #3863 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3863#event-12691206525
You are receiving this because you are subscribed to this thread.
Message ID:
Also I presume its all one line in the build command entry?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3863#issuecomment-2092040960
You are receiving this because you are subscribed to this thread.
Message ID:
Ok, your problem is that for some reason the website has a `*` at the start and
end of the command, those should not be there.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3863#issuecomment-2091968938
You are receiving this because you are
Well, the original error message indicates the backticks don't match, maybe
post the text from the build command entry (not from the website) on a line by
itself with a line of ``` before and another after it so its not recognised as
markdown. If we can't see exactly what you are inputting
Try a space between the `"%f"` and the text you added.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3863#issuecomment-2089920282
You are receiving this because you are subscribed to this thread.
Message ID:
> ALL settings are default with the exceptions mentioned in that youtube video.
You are asking for help, so requiring people to watch a video to be able to
help you means you have reduced the number who will bother, they simply don't
have time.
As I said, the default "Build" operation for C
Do you mean filebrowser, which is a core plugin and part of the Geany
repository, or treebrowser which is part of this repository?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1347#issuecomment-2089353041
You are receiving this because you
The terminal setting has nothing to do with the Build command. The default
build command for C does not use "/bin/sh". What have you set the build command
to?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3863#issuecomment-2089335228
You are
Ooops, #1197 is the PR that claims to add `library=gtk` but doesn't, #1196 is
the issue that shows the error, off by one, /me needs to be cppchecked :grin:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1346#issuecomment-2088163400
You are
> or it got removed in the meantime
Or it got removed in the version of #1197 that was eventually merged. Not sure
but I think when @eht16 upped the version of cppcheck in CI the `--library=gtk`
got built in or something, so it wasn't included in what got merged. Might
mean it won't work for
> Yes, but I think the problem wasn't the dialogs themselves (apart from the
> fact they were some "old" open dialogs), but rather the fact they were
> implemented using Windows API that nobody understood well.
And #3209 crash.
But one thing positive they did was that they automounted remote
> not using --library=gtk
See #1197 for why its needed
> Anyway, what do you guys think? Is it good? Are there too many
> false-positives? Should the suppressions be moved back to AM_CPPCHECKFLAGs
> not to alter the code, although it makes it harder to maintain?
... should we switch to C++
Since I can't try either of the native dialogs, the reason I (politely) asked
what the advantages of the native dialogs are is because as they are hard coded
at compile time (AFAICT) users on Windows and Macos are gonna be stuck with
them. So its important to know what the advantages are vs
@rdipardo @techee thanks for testing, so apart from the inconsistent theming
issue it seems to work.
@techee you said in the OP "where the GTK dialogs don't offer the best user
experience.". Can you expand on that and why " using native dialogs under
Windows and macOS is more important IMO."?
Fine, both you and frlan prefer it so no problem, the source is only read by
the developers, not the users.
IIRC rEsT (never remember the caPitaLization ;-) spaces list items independent
of blank lines in the source, so should not matter.
The plugin pages in `plugins.geany.org` are made from
@xiota exact formatting for READMEs doesn't matter so long as they render ok on
`plugins.geany.org` which assumes ReST markup IIRC but I don't know how to see
what the new version of the page looks like.
--
Reply to this email directly or view it on GitHub:
Also I presume the native dialogs are themed by the platform, not by GTK
themes, so they may look totally different to the rest of Geany. @techee for
Macos and whoever tests on Windows 11 need to try.
--
Reply to this email directly or view it on GitHub:
@elextr approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851#pullrequestreview-2027483976
You are receiving this because you are subscribed to this thread.
Message ID:
Somebody who has Windows 11 and can build Geany with this needs to test as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081771567
You are receiving this because you are subscribed to this thread.
Message ID:
@techee you don't want to be shipping TLS, that should be using a system
library, the last thing you need is to be constantly updating as CVEs are fixed
against it. If it doesn't use a system library then it shouldn't be available.
> nobody is gonna be using it
Its wrong on Linux, doesn't
WFM.
> if the software draws the string colors AFTER scalar and identifier_1 color,
> these colors are ovewritten by string color, and that seems to be the deep
> problem.
No it doesn't work like that. What version of Geany are you using?
--
Reply to this email directly or view it on
> you never know what the future of the web holds
Yeah, its just a fad :grin:
> A new feature maybe, but well.
But the G* guys would never break API without a new major version
Anyway as you say, there are prototypes for all four plugins available, so if
we are not gonna kill any off
Bash and PHP are mentioned.
AFAICT bash needs property `lexer.bash.styling.inside.string` set but the
default is unset.
Php styles `$word` inside strings as `SCE_HPHP_HSTRING_VARIABLE` so it depends
on what it maps to and what the theme set it to.
--
Reply to this email directly or view it
@b4n:
> Yet, does it currently matter?
Well if you are willing to maintain them in sync its fine. But who knows if a
security alert will require them to change libsoup3.1 API, its a web library
after all!
@xiota:
> You're too far ahead. Takes a while to catch up.
Just around longer, but
The desktop specification requires desktop managers (like Cinnamon) to search
the list of directories in `$XDG_DATA_DIRS` for desktop files and use the first
found only to add to menus, two applications with the same name cannot show in
any desktop spec compliant menu. Geany installs to
Lets move the build tool discussion elsewhere rather than polluting this FR
which has pointed to your plugin, but users have to compile it themselves.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1282#issuecomment-2080655894
You are
> just keep using the libsoup implementation
Yeah, but then its back to four plugins to synchronise on
libsoup3/webkit2gtk-4.1.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080645295
You are receiving this because you
> Do Debian and Ubuntu even bother rebuilding packages for old releases?
Bugfixes, security fixes and those sorts of things, but rarely new versions.
To be honest @xiota has a point, if the plugin causes constraints on others we
need to look at what value it adds, and if it only works for one
@xiota:
> (win/mac – the platforms most likely to need update checkers).
has again pointed out the point I made a while back about this, its useful for
Windows and Macos, but for Linux it lies, just because the project releases a
new Geany does not put it in the distro they are using. And for
> hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR
> because it's HTTP, or depend on a GVFS backend for HTTP?
Waiting for
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079741003
If it works `?` #1340 `:` #1336
--
Reply to this email di
Duplicate of #2736
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3857#issuecomment-2080307580
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3857 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3857#event-12629720274
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3855 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3855#event-12629711665
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr approved this pull request.
Bearing in mind my lack of knowledge of libsoup it looks ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2026126069
You are receiving this because you are subscribed to this thread
@elextr commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document m
Well, I interpret the very first words in the readme "GVfs is a userspace
virtual filesystem implementation for GIO" to mean its part of GIO. IIUC it
provides the implementations for the abstract file/URL/dbus stream operations
in GIO and thats why you get an error if its not installed and you
> Looks like it depends on gvfs... After uninstalling...
Well, IIUC GVFS is _part_ of GIO (not to be confused with GnomeVFS), so if its
uninstalled its not surprising parts of GIO don't work.
But that probably means reading URLs won't work on Windows, dunno about Macos,
so back to the soup I
Yeah, `pkg-config` is the Freedesktop original, `pkgconf` would appear to be a
re-implementation. Your distro installs `pkgconf` and links the original
command to it so existing scripts will work, if they happen to conform to what
`pkgconf` considers "correct".
If an existing script fails
Unfortunately the GIO docs don't say when `g_file_new_from_URI()` and the
associated stream was supported (that I could see) but it works on the machine
I'm on ATM which is pretty olde.
PS I expect not everyone has your alias pkgconf == pkg-config :wink:
--
Reply to this email directly or
@xiota it would be great if you are willing to be maintainer for those plugins,
in that case simply make a PR changing the MAINTAINERS file with your details
for them. Geanylua is orphaned so thats no problem, and codebrainz has not
contributed to Geany or Geany-plugins for many years so
Geany plugins doesn't "freeze" changes, but yes it does slow them down with
reviews etc.
The benefit though is that it gets access to the Geany packagers to put it in
distros if its part of the plugins collection.
The real problem is plugins where there is no maintainer for the plugin to
@xiota neat, and simple, although it has one theoretical bug (though unlikely
in practice) [hint: what if 32 bytes were returned].
Just for general information, Geany used (a __long__ time ago) to avoid GIO,
which is probably why the plugin used libsoup directly. But now GIO is
required by
I don't know enough about libsoup to sensibly review (and don't have the time
to learn), but since Geany uses GIO why not `g_file_new_for_uri()` and
`g_file_read()` (or `g_file_read_async()/g_file_read_finish()` to not block the
UI) instead of using libsoup directly?
--
Reply to this email
@elextr approved this pull request.
LGBI except for one query.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *
As @xiota says, the plugin is still a work in progress, but I'm sure they would
be happy to have someone testing it.
When it is complete they may wish to add it to the plugins collection, in which
case they need to raise a PR to add it, like #1331 or #1337, or they may decide
to keep it
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. I
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. I
@b4n said:
> if the replacement contains the search term, it'll be replaced recursively
> forever (infinite loop + steady memory growth).
@xiota said:
> replace_all searches for needle starting from the beginning of haystack. If
> replacement contains needle, the result is an infinite loop.
1 - 100 of 6642 matches
Mail list logo
