Postponing as it's a bit late now. Should probably be merged soon after
release though.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1769503371
You are receiving this because you are subscribed to this thread.
Message ID:
Should we postpone? Review the comments and merge?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1767210063
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
Looks fairly useful and simple enough :+1:
Apart from my inline comments, LGTM and WFM.
> + gtk_container_add(GTK_CONTAINER(menu), item);
+ gtk_menu_reorder_child(GTK_MENU(menu), item, 0);
```suggestion
@ntrel @elextr
I tested and it works great.
Apart from the little remark on the docs, I'm fine with this.
About the section comment in the docs, this is no big deal, we can also leave
as it is.
--
Reply to this email directly or view it on GitHub:
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#pullrequestreview-1670757655
You are receiving this because you are subscribed to this thread.
Message ID:
Tested and works fine.
Maybe we could squash some of the commits?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1757385379
You are receiving this because you are subscribed to this thread.
Message ID:
> As you can see the translation item has the multiple code occurrences listed
> as comment.
After some googling (while also watching renovation TV so it was a bit slow :-)
I found that:
1. a string can only occur once in the PO files, so one string and commenting
the places its used is the
Long story short about the translation strings: this is safe to merge, it will
*NOT* add new untranslated strings.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1752015443
You are receiving this because you are subscribed to this
> > How do you think so? AFAIK the lookup is made solely on the string itself.
> > Either it matches or not.
>
> Oh, I thought it was possible to have the same string at different places in
> the program with differing translations? If not by file/line how is that
> done? (translation newby
@eht16 commented on this pull request.
> @@ -3973,8 +3973,8 @@ On Windows 7 and above you most likely will find it at:
``C:\users\UserName\Roaming\geany``
-Tools menu items
-
+Configuration files menu
While this section is currently mainly about the `Configuration files`
> How do you think so? AFAIK the lookup is made solely on the string itself.
> Either it matches or not.
Oh, I thought it was possible to have the same string at different places in
the program with differing translations? If not by file/line how is that done?
(translation newby question)
> Don't strings have file/line in their lookup, so "Templates" and "Files" menu
> items would likely show untranslated until updated?
How do you think so? AFAIK the lookup is made solely on the string itself.
Either it matches or not.
Before further speculating, just test it. Check out the
Don't strings have file/line in their lookup, so "Templates" and "Files" menu
items would likely show untranslated until updated?
Also I don't see those referenced in the documentation modifications?
--
Reply to this email directly or view it on GitHub:
@kugel- what bad thing would happen if this was merged? the strings here would
still lookup the correct translations, right?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1751960604
You are receiving this because you are subscribed
This touches strings (doesn't it?) and we're in string freeze so I'm afraid
it's too late now.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1751834172
You are receiving this because you are subscribed to this thread.
Message ID:
@techee Thanks for reviewing. I've approved #3576.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1751118213
You are receiving this because you are subscribed to this thread.
Message ID:
Overall the PR looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1751106555
You are receiving this because you are subscribed to this thread.
Message ID:
@techee commented on this pull request.
> @@ -2133,7 +2132,8 @@ static void on_config_file_clicked(GtkWidget *widget,
> gpointer user_data)
g_file_get_contents(global_file, _content, NULL,
NULL);
doc = document_new_file(utf8_filename, ft,
@techee commented on this pull request.
> @@ -283,6 +285,42 @@ static void create_file_template_menu(void)
g_object_ref(new_with_template_toolbar_menu);
geany_menu_button_action_set_menu(GEANY_MENU_BUTTON_ACTION(toolbar_get_action_by_name("New")),
@ntrel commented on this pull request.
> @@ -2133,7 +2132,8 @@ static void on_config_file_clicked(GtkWidget *widget,
> gpointer user_data)
g_file_get_contents(global_file, _content, NULL,
NULL);
doc = document_new_file(utf8_filename, ft,
@ntrel commented on this pull request.
> + gtk_container_add(GTK_CONTAINER(ui_widgets.config_files_menu), item);
+ menu = gtk_menu_new();
+ gtk_menu_item_set_submenu(GTK_MENU_ITEM(item), menu);
+ list = utils_get_config_files(GEANY_TEMPLATES_SUBDIR);
+
@ntrel commented on this pull request.
> @@ -283,6 +285,42 @@ static void create_file_template_menu(void)
g_object_ref(new_with_template_toolbar_menu);
geany_menu_button_action_set_menu(GEANY_MENU_BUTTON_ACTION(toolbar_get_action_by_name("New")),
@techee commented on this pull request.
> @@ -2133,7 +2132,8 @@ static void on_config_file_clicked(GtkWidget *widget,
> gpointer user_data)
g_file_get_contents(global_file, _content, NULL,
NULL);
doc = document_new_file(utf8_filename, ft,
@techee commented on this pull request.
> @@ -283,6 +285,42 @@ static void create_file_template_menu(void)
g_object_ref(new_with_template_toolbar_menu);
geany_menu_button_action_set_menu(GEANY_MENU_BUTTON_ACTION(toolbar_get_action_by_name("New")),
@techee commented on this pull request.
> + gtk_container_add(GTK_CONTAINER(ui_widgets.config_files_menu), item);
+ menu = gtk_menu_new();
+ gtk_menu_item_set_submenu(GTK_MENU_ITEM(item), menu);
+ list = utils_get_config_files(GEANY_TEMPLATES_SUBDIR);
+
I guess it saves users explicitly copying template files to the user config
directory before editing and maybe reduces the incidence of them editing the
system copies. But most templates distributed with Geany are pretty ummm
basic, so I'm not sure how often they are used as a basis for user
I've split out #3450 which should be merged first.
After that, I'd like to merge this.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1501143208
You are receiving this because you are subscribed to this thread.
Message ID:
@ntrel pushed 1 commit.
f5a7aa51aa83c77efe2cac2061371cd5739002d0 Tweak template wildcards formatting
--
View it on GitHub:
https://github.com/geany/geany/pull/3396/files/f4e6cb084a514b75ce12582f52cbe3a3ad91a69d..f5a7aa51aa83c77efe2cac2061371cd5739002d0
You are receiving this because you are
@ntrel pushed 1 commit.
f4e6cb084a514b75ce12582f52cbe3a3ad91a69d Update docs
--
View it on GitHub:
https://github.com/geany/geany/pull/3396/files/1b425acdb8f0674e7cca61d509db4ef3c317aced..f4e6cb084a514b75ce12582f52cbe3a3ad91a69d
You are receiving this because you are subscribed to this thread.
@ntrel pushed 1 commit.
1b425acdb8f0674e7cca61d509db4ef3c317aced Put items with submenus at the top of
the menu
--
View it on GitHub:
https://github.com/geany/geany/pull/3396/files/4e342421ac90de7202c4d48c1a0105b564fe33ff..1b425acdb8f0674e7cca61d509db4ef3c317aced
You are receiving this
30 matches
Mail list logo
