[Github-comments] Re: [geany/geany] indentation: curly braces difference js x php (review all languages that use them?) (Issue #3655)

2023-10-25 Thread Colomban Wendling via Github-comments
Closed #3655 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3655#event-10768517618 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] indentation: curly braces difference js x php (review all languages that use them?) (Issue #3655)

2023-10-25 Thread Colomban Wendling via Github-comments
Works for me, be it with *current characters* or *matching brace* indentation methods. Note however that auto-indentation here will not happen if you have something on the right of the cursor when typing the closing brace. What is you version of Geany? Does disabling plugins help? (`geany

[Github-comments] Re: [geany/geany] Question: When is the next release coming? (Discussion #3404)

2023-10-24 Thread Colomban Wendling via Github-comments
Closed #3404 as resolved. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3404 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Question: When is the next release coming? (Discussion #3404)

2023-10-24 Thread Colomban Wendling via Github-comments
So, definite answer is "last Thursday" :wink: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3404#discussioncomment-7374811 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Is it possible to increase the menu font size in the Windows version of Geany 2.0 WITHOUT recompiling the program? (Issue #3652)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n converted this issue into discussion #3653. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3652#event-10759585164 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Is it possible to increase the menu font size in the Windows version of Geany 2.0 WITHOUT recompiling the program? (Issue #3652)

2023-10-24 Thread Colomban Wendling via Github-comments
Yes, you can adjust this with custom [GTK CSS](https://docs.gtk.org/gtk3/css-overview.html). Go to [*Tools → Configuration Files → geany.css*](https://geany.org/manual/#customizing-geany-s-appearance-using-gtk-css), and insert something like `menu { font-size: 15pt; }` or `* { -gtk-dpi: 120;

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. Just squash when ready -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3637#pullrequestreview-1695676632 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
BTW, if setting this to `-1`, it'll use the minimum size so things fit, which is a bit wider than current master with the entry (I think I was right earlier). It'll however happily hide tabs as we allow this. Anyway, 220 or 230 look indeed better to me, and work as well if I use Adwaita on my

[Github-comments] Re: [geany/geany] Autotools: regenerate gmo files when po files are updated (PR #3650)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 35043402562a8ba8566f0cd4d7be6a1c94f006ba Autotools: regenerate gmo files when po files are updated -- View it on GitHub: https://github.com/geany/geany/pull/3650/files/6ed2d48a0b32b6a93501e0a49819fa64f06a50b6..35043402562a8ba8566f0cd4d7be6a1c94f006ba You are receiving

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
> > And when it doesn't fit why doesn't it do as I said, hide Documents and > > show the scroll arrows? Is that controlled by Adwaita too? > > I don't know. I had guessed it's rather GTK than the theme but I really don't > know. My guess would land on the search entry that has a minimum with

[Github-comments] Re: [geany/geany] Move "Virtual Spaces" preference to "Editor -> Features" (PR #3643)

2023-10-23 Thread Colomban Wendling via Github-comments
>Looks good - I just tested this PR and it works as described (no way for a >human being to review the XML diff itself). Use Git's own diff to see it, and enable highlighting of moved lines. Almost all of it is just moved, minus a few lines holding indices and such (and maybe uselessly

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-23 Thread Colomban Wendling via Github-comments
OK, got it. Well, it's kind of a special case as IIUC you're using Geany-Plugins' version to depend on Geany; but I get it. Well in the end if it simplifies things I'm fine using `major.minor.micro` everywhere (only `2.0.0` will look kinda ugly (objectively :wink:), `2.1.0` will be fine), I

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-23 Thread Colomban Wendling via Github-comments
> Ok, I made a script to grep all the `#define` and `#undef` symbols in > `config.h` and Geany appears to be fairly careful using `ifdef` `ifndef` or > `defined()`, Good :) > Scintilla has at least one place where it compares a symbol to 0, but I think > its its own internal one so fine.

[Github-comments] Re: [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-23 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGBI -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3641#pullrequestreview-1692419285 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-23 Thread Colomban Wendling via Github-comments
Yeah, but it means not only the set of defines is different between meson and autotools, but also their value. We could be careful (and we probably are), but that sound like a great receipt for weird differences -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-23 Thread Colomban Wendling via Github-comments
Yeah well, meson has its own complicated handling depending on whether the value is a boolean or not…we probably could just use a boolean as IIRC it would just make for a define without a value, but that'd be different from what we have currently, so theoretically it could impact the C code

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-22 Thread Colomban Wendling via Github-comments
This sounds like a continuation of https://github.com/geany/geany/commit/13bc05d80f456d8ed745e4fbfbf4286a49d1acaf#commitcomment-130441271, but I still don't understand what's the actual problem. Yes, it's not the same version string, but what harm does it do? For me, the rationale here is: *

[Github-comments] [geany/geany] Move "Virtual Spaces" preference to "Editor -> Features" (PR #3643)

2023-10-22 Thread Colomban Wendling via Github-comments
Editor - Display is very crowded already, and virtual spaces are not merely a display feature, but rather a tool for editing. Close #3605. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3643 -- Commit Summary -- * Move Virtual Spaces

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread Colomban Wendling via Github-comments
> Probably would be good if "somebody" provided a preliminary `nb.po` file > rather than rushing the whole translation at string freeze. Yes, and it's unlikely a large amount of the translation would be invalidated anyway, so most of it would still be usable by then. -- Reply to this email

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread Colomban Wendling via Github-comments
I'm not sure I entirely get this. We have `nn` translation indeed. We don't have `nb`. I am not sure how the locale selection is made for Norwegian (I guess when the configured language is either `no_NO` or `nb_NO`) as we rely on the system/on the gettext library to perform this step; but

[Github-comments] Re: [geany/geany] "Name" and "Value" is not translatable in Preferences dialog (Issue #3628)

2023-10-22 Thread Colomban Wendling via Github-comments
Closed #3628 as completed via 656b03bc00fe3a17b6b369f41b436c1473fa953d. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3628#event-10733916371 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Enable translations in the "Various" tab in preferences dialog (PR #3634)

2023-10-22 Thread Colomban Wendling via Github-comments
Merged #3634 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3634#event-10733916374 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-22 Thread Colomban Wendling via Github-comments
When a value could either be defined or not, we used to call either `set(varname, 1)` or `set(varname, false)` respectively. This however leads to the value type of `varname` to be conditional, making it virtually unusable for testing its value. Instead, just do not emit anything when we used

[Github-comments] Re: [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-22 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -658,7 +658,7 @@ https://github.com/universal-ctags/ctags Method `` -* Add foo.c to SRCS in Makefile.am and meson.build. +* Add foo.c to SRCS in ctags/Makefile.am and meson.build. It's in `parsers` inside `ctags/Makefile.am` ```suggestion * Add

[Github-comments] Re: [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)

2023-10-22 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3633#pullrequestreview-1691455022 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson error: meson.build:446:32: ERROR: The `==` operator of bool does not accept objects of type int (1) (Issue #3618)

2023-10-22 Thread Colomban Wendling via Github-comments
Actually, its has nothing to do with the Meson version I think, it's just that `fnmatch` isn't found on the OP system, and the code uses either [`cfg_data.set(varname, 1)`](https://mesonbuild.com/Reference-manual_returned_cfg_data.html#cfg_dataset) or [`cfg_data.set(name,

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-21 Thread Colomban Wendling via Github-comments
@scootergrisen did you use a fresh configuration? C.f. > It works for me, but note that this is the default value for a preference, so > it won't ever be updated on an existing installation. Try with `geany -c > /tmp/nonexistant`, you should see the translation. You should also be able to

[Github-comments] Re: [geany/geany] symbols panels dont update list after switching files (Issue #3622)

2023-10-20 Thread Colomban Wendling via Github-comments
Just as puzzled here, but given 2.0 will not load older plugins, it's unlikely it's the issue… Do you see the same thing using a fresh configuration, e.g. with `geany -c /tmp/tmpconf`? If not, save your conf and see if you can share it. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Feature request (Issue #3530)

2023-10-20 Thread Colomban Wendling via Github-comments
IIUC what the goal is, for one keyword you can already use *Search → More → Mark All* (or Ctrl+Shift+M). For more keywords, it kind of depends on the use case; but if you cant to highlight a specific set of keywords, always the same, you can probably make a custom file type based on some

[Github-comments] Re: [geany/geany] Emoji flag section is empty (Issue #3619)

2023-10-20 Thread Colomban Wendling via Github-comments
FWIW I have this on Debian GNU/Linux. Normally this is plain GTK (we don't do anything about this on our end), so either there's something missing in our GTK bundle, or there's something that prevents GTK from showing those (missing font or something?). > Maybe remove/hide sections that have

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-20 Thread Colomban Wendling via Github-comments
OK no, it works fine here, I just had a stale `da.gmo` in my local directory, but the content of the tarball is OK. @eht16 is it possible you didn't build the Windows binaries from a fresh clone, and had a stale thing as well? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-20 Thread Colomban Wendling via Github-comments
Hum, scratch that, doesn't seem to work for Danish… -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3620#issuecomment-1772764720 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-20 Thread Colomban Wendling via Github-comments
It works for me, but note that this is the default value for a preference, so it won't ever be updated on an existing installation. Try with `geany -c /tmp/nonexistant`, you should see the translation. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (13bc05d)

2023-10-19 Thread Colomban Wendling via Github-comments
@kloczek Sorry I don't get it, they both use the same scheme: `major.minor.micro` as the tag, and `major.minor[.micro if micro > 0]` or however I can describe that for the asset names. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (13bc05d)

2023-10-19 Thread Colomban Wendling via Github-comments
@kloczek not sure I get it, it's always been like that -- check e.g. the previous release https://github.com/geany/geany/releases/tag/1.38.0: tag is 1.38.0 but tarballs use 1.38. I guess if there's a compelling reason to do otherwise we could, but up until now we used the full version in tags,

[Github-comments] [geany/geany] Release 2.0.0 - Geany 2.0

2023-10-19 Thread Colomban Wendling via Github-comments
## General * Split "session data" into session.conf, preferences are written to and read from geany.conf ([PR#2776](https://github.com/geany/geany/pull/2776), [PR#2779](https://github.com/geany/geany/pull/2779), [PR#3014](https://github.com/geany/geany/pull/3014),

[Github-comments] Re: [geany/geany-plugins] Set release date (d50d5b3)

2023-10-19 Thread Colomban Wendling via Github-comments
I'm disappointed, when I saw @dmaphy's message I expected at *least* 2024… :disappointed: :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/commit/d50d5b31977db01fe6e63af7e6dedf0601402594#commitcomment-130432943 You are receiving this

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (PR #3617)

2023-10-19 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM if you want, and the `@since` makes sense to update :+1: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3617#pullrequestreview-1688098429 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] `AddGeanyLexers()` omits the AsciiDoc module since 19336d2 (Issue #3615)

2023-10-19 Thread Colomban Wendling via Github-comments
@kugel- no problem, it happens, even if it's kinda stressful right now. And as @techee says, better see this now than in 24 hours… :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3615#issuecomment-1771120466 You are receiving this because

[Github-comments] Re: [geany/geany] `AddGeanyLexers()` omits the AsciiDoc module since 19336d2 (Issue #3615)

2023-10-19 Thread Colomban Wendling via Github-comments
Closed #3615 as completed via bc9f6e4dccea09b746510c0f262c2e3bf0ce11c9. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3615#event-10712974328 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix crash opening an AsciiDoc document (PR #3616)

2023-10-19 Thread Colomban Wendling via Github-comments
Merged #3616 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3616#event-10712974495 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] `AddGeanyLexers()` omits the AsciiDoc module since 19336d2 (Issue #3615)

2023-10-19 Thread Colomban Wendling via Github-comments
@rdipardo big kudos for the detailed and investigated report, hugely appreciated! See #3616 which should fix the crash and bring AsciiDoc back. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3615#issuecomment-1770882492 You are receiving this because

[Github-comments] [geany/geany] Fix crash opening an AsciiDoc document (PR #3616)

2023-10-19 Thread Colomban Wendling via Github-comments
@elextr one for you: not only is it AsciiDoc, but its also a candidate for very-last-minute fix :smile: @elextr @techee @eht16 I think we ought to do something for 2.0 here, because indeed hitting this crash is as easy as trying to open e.g. `foo.asciidoc`… You can view, comment on, or merge

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-19 Thread Colomban Wendling via Github-comments
@elextr what you're describing is hinting ;) The trade-off between faithful glyph shape rendering versus blurry render because pixels are big. And I agree that better hinting is better, but it's tricky. I admittedly got used to bad one because some upgrade lead to poorer hinting everywhere on

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-19 Thread Colomban Wendling via Github-comments
@techee yeah, but here just using the icon name won't solve it, you also need to use the symbolic version for the problematic icons. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3614#issuecomment-1770418473 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Colomban Wendling via Github-comments
@frlan Ideally this could make it to 2.0 as it would extend translation and is fairly trivial, but if it doesn't because it's way too late for this nothing new breaks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1286#issuecomment-1769587343

[Github-comments] [geany/geany-plugins] Small update of the French translation (PR #1287)

2023-10-18 Thread Colomban Wendling via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1287 -- Commit Summary -- * Small update of the French translation -- File Changes -- M po/fr.po (232) -- Patch Links --

[Github-comments] [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Colomban Wendling via Github-comments
@smostertdev @frlan This makes translations actually work in several places (prefs dialog, keybindings list, Nth line dialog) You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1286 -- Commit Summary -- * lineoperations: Fix

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1686329485 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/edit_change_history.png: @eht16 I took the liberty to push to this PR with the fix above. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1364648967 You are receiving this because

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 37647e32ca6861f7d06000d8acf8f8f8e079a405 Distribute new documentation image -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/d2186cccddf8a885eae0ccb7c894564f1ac669a0..37647e32ca6861f7d06000d8acf8f8f8e079a405 You are receiving this because you are

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. New image is missing from the build system. Otherwise I didn't check all PR and issue references, but looks good! :+1: On doc/images/edit_change_history.png: This is not installed! ```diff diff --git a/doc/Makefile.am b/doc/Makefile.am index

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-18 Thread Colomban Wendling via Github-comments
Postponing as it's a bit late now. Should probably be merged soon after release though. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1769503371 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
I'm gonna postpone that as discussed in #3614, although it might come back to bite us. Or we mention it somewhere in the announcement email? @eht16 :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769501953 You are

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread Colomban Wendling via Github-comments
Agreed, it grew way too out of hand to be merged less than 24 hours before the deadline. And I agree with @elextr that it likely requires more testing than just hoping every other distro is shipping a well-behaving theme (better behaving than Debian's Adwaita 43) by default, although @techee

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@elextr regarding the CI it was merely a squash (no diff from the base verified) + a rebase… and yes, I let my build and meson finish :P And it's all green now, ain't it :] (though, I start to think it's becoming late indeed… I'll only plan to make one more PR for 2.0 GP :]) -- Reply to

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
@techee Ah yeah those names are common indeed. And cool, if they are required by GTK itself, it's indeed very likely to be present, or at least work fine if not (e.g. falling back on the non-symbolic version) :+1: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@eht16 looks like there has been a rebase mishap, and you grabbed some unrelated things in there :confused: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769322566 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
You can add #3611 now ;) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769320562 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Restoring the session does not restore the current file or files order when tabs_order_beside is enabled (Issue #3609)

2023-10-18 Thread Colomban Wendling via Github-comments
Closed #3609 as completed via 4246298dd8b3c70528cdad0554000f5d54f39765. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3609#event-10699097436 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
Merged #3611 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#event-10699097461 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
(I just squashed the commits and rebased on master, will now merge) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769315976 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 4246298dd8b3c70528cdad0554000f5d54f39765 Fix startup files order when placing tabs next to the current one -- View it on GitHub: https://github.com/geany/geany/pull/3611/files/0e0b33b5b8f2e858c06ea91128331f7d2252c15b..4246298dd8b3c70528cdad0554000f5d54f39765 You are

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
See #3614 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769309119 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread Colomban Wendling via Github-comments
See #3613. Some of the changes here make sense, some dont really but are still needed not to look terrible with Adwaita 43. See each commit for details. @techee @eht16 thats kind of how it looks to dodge the Adwaita 43 issues I could see. You can view, comment on, or merge this pull request

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
@techee symbolic icons has nothing to do with using icon names rather than stock items, apart that stock items don't use symbolic icons. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769305818 You are receiving this because you

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
> Might there be any risk that other themes may not work well with the changed > icon references? I guess this is hard to answer; the icon loading mechanism > are big mystique to me and so I'm just wondering how much we could break with > this change. Well, I'm not 100% sure, but I think yes,

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; +

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; +

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 0e0b33b5b8f2e858c06ea91128331f7d2252c15b fixup! Fix startup files order when placing tabs next to the current one -- View it on GitHub: https://github.com/geany/geany/pull/3611/files/7ff00f56af24fe1ea9013c9d3b64e14d6dce5f76..0e0b33b5b8f2e858c06ea91128331f7d2252c15b You

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@kugel- > It's not even clear to me if this is even a bug (as in "not working as > intended"). I surely never used that pref. Well, to me it's definitely a bug as the session is *not* restored as it was saved. Both documents order and current document are lost (well, current document is OK

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; +

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
> otherwise we might get flooded with bug reports regarding this problem and we > might have to make a new release because of it anyway. Yeah that's kind of my point, whomever fault it is, some of it will land on us. And it still might, as if you install Geany from Debian under GNOME in

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
Subset of a possible fix: ```diff diff --git a/src/build.c b/src/build.c index 56ec9d613..3d94a683f 100644 --- a/src/build.c +++ b/src/build.c @@ -1898,7 +1898,7 @@ static RowWidgets *build_add_dialog_row(GeanyDocument *doc, GtkTable *table, gui GTK_FILL | GTK_EXPAND,

[Github-comments] [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
Following up https://github.com/geany/geany/pull/3593#issuecomment-1757592993, should we do something about it on our end? Basically the solution is to use `edit-clear-symbolic` icon-name instead of `GTK_STOCK_CLEAR`, which is for most of it easy, for some a bit more involved. * is it our

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/main_window.png: @eht16 yeah… is it a problem in the generated file? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1363823645 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +Screenshots in the document are the default GTK Adwaita theme, +but Geany will adapt to the desktop GTK theme that is set. ```suggestion Screenshots in this document are taken with the default GTK Adwaita theme, but Geany will adapt to

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@eht16 @techee @elextr I added that to %2.0, but if it's not new since 1.38 and you don't feel it's simple enough, we can postpone. It's actually not a problem with the default settings, so it's less bad -- although any sane person would have enabled the problematic option :grin: -- Reply

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#pullrequestreview-1684973051 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Colomban Wendling via Github-comments
@kugel- @techee looks like it's code points if cursory reading is to be trusted (looks like it's based on `g_utf8_strlen()`). Anyway, LGBI and agree that it's not pretty in the prefs dialog as is. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/main_window.png: Agreed it could be bit improved having more room for the editor, event with Adwaita. And having it a bit taller is probably no problem. Something like this (though beware! it's a Git build and you can see it)

[Github-comments] Re: [geany/geany] Restoring the session does not restore the current file or files order (Issue #3609)

2023-10-17 Thread Colomban Wendling via Github-comments
hum… it's bad, but I'm wondering for how long this existed. I didn't bisect, but quickly going through this code seems to suggest it's nothing recent (yet, I might be wrong). -- Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-17 Thread Colomban Wendling via Github-comments
When the `tab_order_beside` option is enabled, tabs are opened on either side of the active tab, depending on `tab_order_ltr`, rather than at either end. However, when loading startup files we dont switch to the last opened document right away, but postpone this to the very end. This affects

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-17 Thread Colomban Wendling via Github-comments
Merged #3599 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599#event-10684019579 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-17 Thread Colomban Wendling via Github-comments
Should we postpone? Review the comments and merge? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1767210063 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/pref_dialog_various.png: > This is also theme-dependent, isn't it? It is, unless we're explicitly asking for the theme to do something like that (there's an option I don't remember, but you're only supposed to use that if things would be

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: > The Gnome default screenshot tool adds a think transparent border around the > images. I could remove it but actually I think it's nice because it gives the > images some margin when embedded in the HTML

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/replace_dialog.png: That one still needs updating, sorry -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1683207407 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/pref_dialog_templ.png: Haha I didn't remember I was there :D -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1683202948 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] macOS: use ".so" extension for plugins instead of ".dylib" (PR #3608)

2023-10-17 Thread Colomban Wendling via Github-comments
Same as @eht16, it looks good if I believe the docs that a value of `[]` make it use the default behavior. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3608#issuecomment-1767017197 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: @eht16 do you want me to take care of the screenshots, or can you do it with what I mentioned? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +* Improved support of ctags file format, this is also the + recommended format for generating tags files (PR#3049). ```suggestion * Improved support for the ctags file format, which is now the recommended format for tags files

[Github-comments] Re: [geany/geany] Restoring the session does not restore the current file or files order (Issue #3609)

2023-10-17 Thread Colomban Wendling via Github-comments
Yeah, it happens if `next to current` is checked. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3609#issuecomment-1766878125 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Colomban Wendling via Github-comments
Ah right, it was notifying when *either* `major` or `minor` was higher. So yeah, only false positives if the local version is newer than the release. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1284#issuecomment-1766870584 You are receiving

[Github-comments] [geany/geany] Restoring the session does not restore the current file or files order (Issue #3609)

2023-10-17 Thread Colomban Wendling via Github-comments
Restoring the session (from my upgraded ~/.config, which has seen all versions since the dawn of time^W^W^W^W I started using Geany) restores the files, but not: * the order * the current file It kinda looks like the first element is right, but the reset is sort of loaded in reverse… Might

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Colomban Wendling via Github-comments
> Here you'll be saved by the copy-paste error of the current code where the > last digit is ignored ;-). Ah indeed, missed that typo :) > The current code won't behave as bad as I thought originally because for > releases the value on the server is the highest number. It would be just in >

[Github-comments] Re: [geany/geany-plugins] [WIP] commander: fixed deprecated gtk3 calls (#865)

2023-10-17 Thread Colomban Wendling via Github-comments
Closed #865 via 38a138f8c0df31787a3f579c5a606c6a71bb1fd9. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/865#event-10680086514 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] commander: Silence expected deprecation warnings (#952)

2023-10-17 Thread Colomban Wendling via Github-comments
Merged #952 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/952#event-10680086535 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] commander: Silence expected deprecation warnings (#952)

2023-10-17 Thread Colomban Wendling via Github-comments
Yeah let's get it in not to have other people waste time trying to "fix" it. This won't remove all deprecation warnings (the plugin still uses `gtk_vbox_new()`) though. I can very easily fix that now we depend on GTK3 anyway though, but that can be for later. -- Reply to this email directly

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM (not tested) Indeed the check is wrong in many aspects -- event 0.0.2 would be < then 1.38.1 Also, it uses `GEANY_VERSION`, which is a compile-time thing, so better update your update checker! It could benefit from Geany exposing

<    1   2   3   4   5   6   7   8   9   10   >