Merged #1459.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1459#event-1039683971
OK, it's fine without changing the label.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1161#issuecomment-293513335
Need to update the manual though.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1161#issuecomment-293513744
ntrel commented on this pull request.
> @@ -3040,6 +3040,24 @@ void document_undo(GeanyDocument *doc)
document_undo(doc);
break;
}
+ case UNDO_INDENT:
+ {
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1459
-- Commit Summary --
* Update status bar after clicking detect indent type menu item
-- File Changes --
M src/callbacks.c (1)
-- Patch Links --
How about changing the menu item text to say *Convert Tabs to Spaces* when
there is no selection?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1161#issuecomment-292148715
ntrel commented on this pull request.
> @@ -3719,9 +3719,15 @@ Clone
>See `Cloning documents
Replace tabs with space Replaces all tabs
with the right amount of spaces
> I guess it's better to have partial support for a language than no support at
> all. Opinions?
Absolutely, highlighting without tag parsing is fine. And once highlighting is
in, people will start to use Swift with Geany, so someone else may step up to
add tag parsing.
--
You are receiving
Merged #1323 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1323#event-2369329975
> most themes map string_2 to string_1
In that case perhaps this should use the `default` named style.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2157#issuecomment-496202512
Reassigning filetype groups works for built-in filetypes too.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2175
-- Commit Summary --
* [doc] Add tip to put commonly used filetypes in the None group
-- File Changes --
M
> filetypes show up in the top-level menu
I realized that reassigning filetype groups works for built-in filetypes too -
see #2175 to update the docs.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #2168 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2168#event-2388541562
Closed #1552 via #2168.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1552#event-2388541572
E.g. *editor.use_gtk_word_boundaries*. This really helps to organise the
Various tab.
* stash_tree_setup() will now show a prefix string before the key name.
* stash_group_set_various() can now set a prefix otherwise `group->name` is
used. This is useful as Geany prefs all use PACKAGE for the
Closing as changes affect multiple dialogs.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2109#issuecomment-498733352
Closed #2109.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2109#event-2388648053
If a global pref is wanted, I think a Various pref is a low impact way to move
forward, otherwise we add work for translators and use up dialog space. #2176
makes various prefs look a lot cleaner IMO.
Rather than per document, I think a per file type setting would be more useful
here. IIRC
Ok, will do.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2168#issuecomment-498998620
ntrel commented on this pull request.
> void configuration_init(void)
{
keyfile_groups = g_ptr_array_new();
pref_groups = g_ptr_array_new();
init_pref_groups();
+
+ g_signal_connect(geany_object, "document-new",
G_CALLBACK(document_list_changed_cb), NULL);
+
It would be good to reduce file writes e.g. to prolong hard disk life. What if
we track when session data changes but only write the keyfile when the main
window loses focus? That would seem to solve the user clicking logout problem
and drastically reduce disk/network writes.
--
You are
> its the order in which filetypes are defined in filetypes_array
Yes. With #2166 you can override just `Javascript=*.js;*.js.aspx;` in the user
conf file and this will be preferred over a matching `*.aspx` system file XML
pattern. This doesn't help if the latter is in the user file though.
> Maybe even just adding bold to whatever is existing would be enough?
string2 is also used for raw strings so bold probably isn't a good fit.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> The default .conf file would of course use a sane organization (ex.
> alphabetical)
Alphabetical means a long menu to move the (mouse) cursor through. I think we
can make categories work. The Pascal style group is not intuitive, particularly
Lua and Ruby, I don't know the others. For C style
> users could choose their own organization and/or hide languages they do not
> use
We can already have filetypes listed underneath the group menus, e.g. for
custom filetypes that haven't set a group. We could support this for non-custom
filetypes too. (Making all filetypes custom might not
#2167 fixes this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1499#issuecomment-497658209
> but then the dialog is getting big and wordy
I think `"string" was not found from cursor` is more accurate, and that wording
also works for *Find Previous*.
> The default button should indeed be [Find] (not Cancel).
I agree here, if the user wants to cancel the dialog they can press escape.
Note that #2167 changes the logic again, so you might rather just review that
;-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2166#issuecomment-497657469
> filetypes.Kotlin.conf
@esotericpig Is this custom filetype good enough to distribute with Geany, have
you or others tested it with much Kotlin code?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ntrel commented on this pull request.
> @@ -0,0 +1,54 @@
+# based on JavaScript file
This file needs to be listed in `data/Makefile.am`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thanks @trustable-code. If you have time to fix the `%e` issue, that would be
great. Otherwise I could fix it later and merge. @b4n's comments all seem to be
resolved now (Nim rejects tabs).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
@jhpratt Plus resolve the conflict please if possible. Thanks for submitting
this BTW.
@marcooliva Download the `filetypes.TypeScript.conf` file and put it in either
your user or system config directory - you can find these at the top of
`Help->Debug Messages`. Then just restart Geany. To
ntrel commented on this pull request.
Providing this works for enough TypeScript code, I think we should merge this.
@jhpratt It would be good to resolve my review points though.
> @@ -0,0 +1,54 @@
+# based on JavaScript file
+# For complete documentation of this file, please see Geany's main
ntrel commented on this pull request.
> +comment_single=#
+comment_use_indent=true
+tag_parser=Python
+lexer_filetype=Python
+
+[indentation]
+
+type=0
+
+[build-menu]
+
+# %f will be replaced by the complete filename
+# %e will be replaced by the filename without extension
+# (use only one of
The status bar shows *Failed to load one or more session files*. Those files
are shown in *Help->Debug Messages*. You could then either kill geany, mount
and relaunch (or you could copy the `.geany` project file to a temporary file,
close the project, mount the drive, copy the project file back
When using New Project/Open project dialogs or the recent project files
submenu, there's no need to confirm closing the project (so long as the dialogs
can be cancelled before closing the session). It's unlikely those actions are
done by accident. I've kept confirmation for opening a project
Before the user would sometimes have to override `UnwantedFiletype=` in the
user config file to remove an extension written in the system file. Geany would
ignore an overridden filetype in the user config file that also matches the
extension. This happened when the wanted filetype had a higher
> it means one submenu level "a-f", "g-m", "n-p", "q-z"
This is hard to internalise, learning the arbitrary ranges. If I want JS, I
can't instantly know which sub menu it is. It doesn't take long though, but
it's nice to avoid this for UX.
> don't need to be a "programming language nerd" to
Discourage the user from overriding system settings unnecessarily.
This fixes #1552.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2168
-- Commit Summary --
* Comment out copied contents opening `Tools->Configuration Files`
-- File
> Are they?
Yes.
> What do you mean by "C family"? Is it just direct descendents, eg C, C++ and
> D?
Yes, as I wrote.
> Or is it all {} languages including Java and its descendents (eg Groovy
> Kotlin etc) and Javascript and the other ECMAscript languages and PHP etc?
No they have C style
Fixes #1581. `filetypes.Kotlin.conf` written by https://github.com/esotericpig.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2186
-- Commit Summary --
* Add Kotlin custom filetype from github.com/esotericpig
-- File Changes --
M
ntrel commented on this pull request.
> +# https://kotlinlang.org/docs/reference/basic-types.html
+secondary=Double Float Long Int Short Byte NaN Void
+# documentation keywords for javadoc
+doccomment=author deprecated exception param return see serial serialData
serialField since throws todo
@esotericpig Thanks, I've made a pull to add this: #2186.
> I'd like to also add Groovy.
I'm happy to merge that if done as a custom filetype.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2192
-- Commit Summary --
* Standardize filetype build menu labels a bit
-- File Changes --
M data/filedefs/filetypes.Swift.conf (6)
M data/filedefs/filetypes.coffeescript (4)
Rebased now #2166 is merged, to remove that pull's commits.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2167#issuecomment-500385157
Instead of `string_2` I've made string escapes use `string_1,bold`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2157#issuecomment-500378957
Merged #2166 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2166#event-2400662648
Oops, I should have chosen *rebase and merge*, sorry.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2166#issuecomment-500383012
> I'm not sure forcing a style attribute is a good idea
The style IMO should be whatever string_1 is plus bold. Users who make string_1
use bold is not something we should worry about, it's not sensible. Adding a
named style that defaults to `string_1,bold` would work if you prefer the
@ntrel pushed 1 commit.
72b7dc98023fe3458c45ac9863b358bd2559fe79 Use more usual build command labels
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
ntrel commented on this pull request.
> +# https://kotlinlang.org/docs/reference/basic-types.html
+secondary=Double Float Long Int Short Byte NaN Void
+# documentation keywords for javadoc
+doccomment=author deprecated exception param return see serial serialData
serialField since throws todo
Fixes #1449. Reboot of #1450 updating `data/Makefile.am`.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2187
-- Commit Summary --
* TypeScript syntax highlighting
-- File Changes --
M data/Makefile.am (1)
A
> I tried to make one, but it's a bit more difficult
Thanks, I've made a start using the C lexer with properties set for dollar
identifiers and triple quoted `"""strings"""`:
https://github.com/ntrel/geany/commits/groovy-ft
The other strings aren't supported by Scintilla's LexCPP AFAIK.
--
@esotericpig I've added a few things for Groovy and made a WIP pull: #2188.
Please test it and advise on what the build commands should be.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Uses the C lexer and C++ tag parsing.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2188
-- Commit Summary --
* Add Groovy custom filetype
* Don't highlight lines with unterminated string literal; C++ tags
* filetype registration
--
> IIRC the xxx.geany file has to be the first one to open as a project, not as
> a keyfile
Just tested, it doesn't have to be the first filename.
> can you give an example of how something bad could happen
`geany *` would open some filenames in the current session, then open a project
file,
> please don't merge until somebody has a chance to confirm on each of OSX
> (since you mentioned it) and Linux and Windows.
This pull does not change the OSX-specific code, that will still work. The
Linux code is also used on Windows, so I have tested it and tested the native
Windows dialog
Merged #2175 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2175#event-2400568393
ntrel commented on this pull request.
> @@ -0,0 +1,42 @@
+# For complete documentation of this file, please see Geany's main
documentation
+[styling=C]
+
+[keywords]
+primary=associativity break case catch class continue convenience default
deinit didSet do else enum extension fallthrough
* `filetype.cpp` etc use `[styling=C]` and `[lexer_properties=C]` so will
inherit the changes.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2157
-- Commit Summary --
* Highlight escape sequences in LexCPP filetypes
-- File Changes --
@b4n wrote in 67329f2b9 "The new C styles escapesequence and taskmarker are
currently mapped conservatively, and may benefit from a more visible mapping".
So it looks like this never got followed up.
I think users will be unaware of this feature if it isn't on by default. I
doubt people will
Thanks @ankitpati.
@b4n et al: OK to merge? (got thumbs up from @codebrainz on my previous
comment).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1323#issuecomment-494463600
> @ntrel the OP wants to hide not close the tabs
I know.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2216#issuecomment-511438449
> Close all files in sub-directory
Geany's built in Documents sidebar supports this, right click on a folder and
click close.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I'll edit the commit message before merging.
> Why even post a PR
So reviewers can check my changes don't introduce bugs.
> if you're reluctant to even minor suggestions?
I learnt that refactoring should focus on doing one thing well. Making multiple
changes at once increases the risk of
I'm using MSYS2 as recommended by: https://wiki.geany.org/howtos/win32/msys2.
Building git master.
```
$ gcc --version
gcc (GCC) 7.4.0
```
`make V=1` gives:
```
depbase=`echo tm_source_file.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ../../libtool --silent --tag=CC --mode=compile gcc
Nevermind, good idea.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2260#issuecomment-522053855
It should be possible to assign ctrl-shift-b to a text selection keybinding in
the preferences dialog. What text do you want to be selected?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Fixes #2261.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2263
-- Commit Summary --
* configure: check for realpath function now MSYS2 has it
-- File Changes --
M configure.ac (2)
M src/tagmanager/tm_source_file.c (2)
--
Merged #2257 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2257#event-2563895515
> As a possible workaround, you could try updating your msys2, judging by the
> GCC version, it's rather out of date.
Done.
I added realpath to AC_CHECK_FUNCS in the referenced pull but it doesn't define
HAVE_REALPATH in config.h, what am I doing wrong?
--
You are receiving this because you
Thanks for the info @eht16. Yes I also have errors with spawn, that might be
the problem. I'll check this on Monday. So should we merge the pull for this
issue or not?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1450.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1450#event-2563910558
Closed #1449 via #2187.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1449#event-2563910118
Merged #2187 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2187#event-2563910117
My gcc is now: gcc version 9.1.0 (GCC)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2261#issuecomment-58768
OK, so after running make I do now get HAVE_REALPATH.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2261#issuecomment-59127
implemented in #2187
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1450#issuecomment-57220
OK, I have now fixed my setup thanks to @eht16. The problem was I had installed
a pacman package called `gcc`, then I installed `mingw-w64-i686-gcc` as well as
written on the wiki page. This was very confusing. I removed gcc, reinstalled
mingw-w64-i686-gcc, then I had to close MSYS2 and
Merged #2256 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2256#event-2563899746
Merged #2188 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2188#event-2563903613
@ntrel pushed 1 commit.
73a807ae368dc6ff9f11b19ffc40181d22a9ac2c TypeScript syntax highlighting
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
ntrel commented on this pull request.
> @@ -2291,6 +2291,22 @@ static void build_load_menu_grp(GKeyFile *config,
> GeanyBuildCommand **dst, gint
}
+/* set GeanyBuildCommand if it doesn't already exist and there is a command */
+static void assign_cmd(GeanyBuildCommand *type, guint id,
+
There are other refactorings for build.c of higher priority IMO than adding
braces or refactoring expressions in assign_cmd (which is short). I support
using an intermediate variable for common expressions, but this should be done
for bigger functions in build.c first.
--
You are receiving
ntrel commented on this pull request.
> @@ -84,7 +84,7 @@ static int get_path_max(const char *path)
}
-#ifdef G_OS_WIN32
+#if defined(G_OS_WIN32) && !defined(HAVE_REALPATH)
Well, the implementation only compiles on Windows.
--
You are receiving this because you are subscribed to this
It might be disconcerting to close a file that has a red tab indicating changes.
I suggest you get used to pressing Alt-d to activate Don't Save.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
It's intentional. I assume it's a problem for you due to accidental clicks?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2266#issuecomment-523582957
It should probably be a Various pref rather than a dialog option IMO.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2266#issuecomment-523799297
**Merge #2268 before this pull**
* Whilst compiling, enable the *Next/Prev Error* menu items only when the first
error is found. Before it enabled them for any compiler tab messages.
* The above has been handled in build.c rather than msgwindow.c, as it has more
build-related information (and
@elextr BTW, what does the O stand for in GBO?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2268#issuecomment-523969497
ntrel commented on this pull request.
> {
- GKeyFile *config;
- GPtrArray *ft_names;
-} ForEachData;
-
-
-static void foreach_project_filetype(gpointer data, gpointer user_data)
-{
- GeanyFiletype *ft = data;
- ForEachData *d = user_data;
C really should require a cast
Move the macros as they are implementation specific and not needed outside
build.c with this pull.
* Format the macros so they are a bit more readable.
* Move build keybinding action code to build.c for better encapsulation.
You can view, comment on, or merge this pull request online at:
* HACKING: Avoid untyped pointers & `*_foreach()` with non-NULL `user_data`
void pointer where practical.
* build.c: Avoid `g_ptr_array_foreach` with `user_data` void pointer - this
also means we can get rid of the singleton `ForEachData`, which simplifies the
code quite a bit.
Note:
Fixes #2260.
Refactor `cb_func_select_action()` a bit.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2264
-- Commit Summary --
* Add 'Select to enclosing brackets' keybinding
-- File Changes --
M doc/geany.txt (9)
M
> it takes too long to find the necessary filetype on the 3rd level of the menu
> among 30+ other types
For completeness, there is a way. I updated the manual with a tip to explain
it, put commonly used filetypes in the None group:
https://www.geany.org/manual/dev/index.html#id211
--
You are
@elextr
I'm going to merge this soon as 2 developers agree with the change and I have
tested all changed code paths. I don't think we should require pulls to be
tested by a reviewer, that will inevitably cause good work to stay in PR
purgatory instead of being merged. Also the easiest way for
> ping it before merging
I agree with this if there have been no supportive comments.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2270#issuecomment-526670589
> Edit: Alternatively, we could say that if a PR has been submitted for over N
> days and has no Github "requested changes" on it, it's safe to merge.
Sounds good, but for simple changes N should be low. Sometimes there's a pull
that causes merge conflicts on other pulls (not the case for this
> DO NOT MERGE PRs while there are still discussions
As Matthew said, the discussion was about foreach_, which the merged code no
longer used.
> neither of us nominated reviewers had approved.
It seemed Matthew agreed with the change because he suggested wording for the
HACKING file. He
ntrel commented on this pull request.
> @@ -1547,25 +1542,17 @@ static void set_stop_button(gboolean stop)
GtkToolButton *run_button;
run_button = GTK_TOOL_BUTTON(toolbar_get_widget_by_name("Run"));
- if (run_button != NULL)
- button_stock_id =
1 - 100 of 559 matches
Mail list logo
