Closed #1223 via b7839a6e421431c8fa83204db351ccee3411cce1.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#event-840931017
b4n approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#pullrequestreview-6348608
Fixed. Should probably be squashed into a single commit before merging.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#issuecomment-257093216
@codebrainz pushed 2 commits.
f92f051 Merge branch 'master' into project-before-close
4d2f1d9 Fix typo (oops)
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1223/files/d15beecebd49d6c5024f979377e25a709f13fb92..4d2f1d
b4n requested changes on this pull request.
LGTM apart the small typo and the merge conflict.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NO
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
b4n commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_BEFORE_C
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
b4n commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_BEFORE_C
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
b4n commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_BEFORE_C
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
kugel- commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_BEFOR
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
kugel- commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_BEFOR
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
kugel- commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_BEFOR
codebrainz commented on this pull request.
> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
G_SIGNAL_RUN_FIRST,
0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
G_TYPE_NONE, 0);
+ geany_object_signals[GDB_PROJECT_B
b4n commented on this pull request.
Mostly LGBI
> @@ -47,6 +47,7 @@ typedef enum
GCB_PROJECT_OPEN,
GCB_PROJECT_SAVE,
GCB_PROJECT_CLOSE,
+ GDB_PROJECT_BEFORE_CLOSE,
Yeah, and this enum isn't in the API either.
> @@ -156,6 +156,12 @@ static void create_signals(GObjec
elextr approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#pullrequestreview-466296
If there are no objections, I will merge this "soon".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#issuecomment-247817103
> @@ -47,6 +47,7 @@ typedef enum
> GCB_PROJECT_OPEN,
> GCB_PROJECT_SAVE,
> GCB_PROJECT_CLOSE,
> + GDB_PROJECT_BEFORE_CLOSE,
Yes, this OKAY. The enum values are only used if you use `g_signal_emit()`
(instead of `g_signal_emit_by_name()`). Plugins shouldn't be emitting these
Both, Geany++ [is a
plugin](https://github.com/codebrainz/geanyplusplus/blob/master/geany%2B%2B/proxy.cpp)
:)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#issuecomment-246271254
Do you have an actual plugin that needs this or is this just for geany++?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#issuecomment-246269523
Ammended commit to change API 229 to 230 since
094737533609dff5a2ff101f97e8c156bcca4979.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#issuecomment-246174611
> @@ -47,6 +47,7 @@ typedef enum
> GCB_PROJECT_OPEN,
> GCB_PROJECT_SAVE,
> GCB_PROJECT_CLOSE,
> + GDB_PROJECT_BEFORE_CLOSE,
@b4n, @kugel- is it safe to change this enum in the middle, although its not
officially in the API is it used by some object macro or something that ma
28 matches
Mail list logo
