kiszk commented on a change in pull request #7555:
URL: https://github.com/apache/arrow/pull/7555#discussion_r450040328
##
File path: cpp/src/arrow/ipc/test_common.cc
##
@@ -79,6 +79,39 @@ Status MakeRandomInt32Array(int64_t length, bool
include_nulls, MemoryPool* pool
liyafan82 commented on a change in pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#discussion_r450041982
##
File path:
java/memory/memory-core/src/test/java/org/apache/arrow/memory/DefaultAllocationManagerFactory.java
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to
rymurr commented on a change in pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#discussion_r450071734
##
File path:
java/memory/memory-core/src/test/java/org/apache/arrow/memory/DefaultAllocationManagerFactory.java
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to
github-actions[bot] commented on pull request #7653:
URL: https://github.com/apache/arrow/pull/7653#issuecomment-654606536
https://issues.apache.org/jira/browse/ARROW-9343
This is an automated message from the Apache Git
projjal opened a new pull request #7653:
URL: https://github.com/apache/arrow/pull/7653
Also refactored the code to remove the parse_float helper function from
context. This was done earlier to save the constructor cost when the
stringconverter object from arrow/util/parsing was needed to
kszucs commented on pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#issuecomment-654234467
@pitrou added the C++ tests.
This is an automated message from the Apache Git Service.
To respond to the message,
andygrove commented on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-654252387
@sunchao Did you have a chance to look at the code sample provided?
This is an automated message from the
pitrou commented on pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#issuecomment-654237098
Looks like the PR needs rebasing and fixing for the latest union changes.
This is an automated message from the
andygrove closed pull request #7591:
URL: https://github.com/apache/arrow/pull/7591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#issuecomment-654248872
I'm going to take another run at this, with smaller changes in new PRs.
Thanks for the reviews so far.
This is
andygrove closed pull request #7253:
URL: https://github.com/apache/arrow/pull/7253
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mrkn opened a new pull request #7643:
URL: https://github.com/apache/arrow/pull/7643
In this pull-request, the slowing down of the conversion introduced in #7539
is canceled, and the conversion speed is improved than before #7539 in some
cases.
pitrou commented on pull request #7620:
URL: https://github.com/apache/arrow/pull/7620#issuecomment-654273536
Thanks for the review @kou . I believe I've addressed all of your comments.
This is an automated message from the
projjal opened a new pull request #7642:
URL: https://github.com/apache/arrow/pull/7642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jorisvandenbossche commented on a change in pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#discussion_r450201426
##
File path: cpp/src/arrow/python/datetime.cc
##
@@ -262,6 +302,42 @@ int64_t PyDate_to_days(PyDateTime_Date* pydate) {
github-actions[bot] commented on pull request #7644:
URL: https://github.com/apache/arrow/pull/7644#issuecomment-654284383
https://issues.apache.org/jira/browse/ARROW-9330
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7646:
URL: https://github.com/apache/arrow/pull/7646#issuecomment-654370419
https://issues.apache.org/jira/browse/ARROW-7237
This is an automated message from the Apache Git
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450383737
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
nealrichardson opened a new pull request #7647:
URL: https://github.com/apache/arrow/pull/7647
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on pull request #7647:
URL: https://github.com/apache/arrow/pull/7647#issuecomment-654385353
https://issues.apache.org/jira/browse/ARROW-9337
This is an automated message from the Apache Git
kszucs commented on a change in pull request #7631:
URL: https://github.com/apache/arrow/pull/7631#discussion_r450396810
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -612,6 +613,83 @@ def test_make_fragment(multisourcefs):
assert
BryanCutler commented on pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#issuecomment-654366148
Looks like the Spark test fails with
```
File "/spark/python/pyspark/sql/tests/test_pandas_grouped_map.py", line
593, in f
"{} !=
BryanCutler edited a comment on pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#issuecomment-654366148
Looks like the Spark test fails with
```
File "/spark/python/pyspark/sql/tests/test_pandas_grouped_map.py", line
593, in f
"{} !=
jorisvandenbossche commented on a change in pull request #7631:
URL: https://github.com/apache/arrow/pull/7631#discussion_r450390113
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -612,6 +613,83 @@ def test_make_fragment(multisourcefs):
assert
pitrou opened a new pull request #7646:
URL: https://github.com/apache/arrow/pull/7646
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pitrou commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450371161
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
jorisvandenbossche commented on pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#issuecomment-654377721
Which I think is as expected? (at least if the data in the test are
tz-aware) And thus the test can be updated on the spark side?
Since we actually change to now
kiszk commented on a change in pull request #7555:
URL: https://github.com/apache/arrow/pull/7555#discussion_r450287754
##
File path: cpp/src/arrow/ipc/test_common.cc
##
@@ -79,6 +79,39 @@ Status MakeRandomInt32Array(int64_t length, bool
include_nulls, MemoryPool* pool
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450317608
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#issuecomment-654308059
@pitrou updated.
This is an automated message from the Apache Git Service.
To respond to the message, please log
kiszk commented on a change in pull request #7555:
URL: https://github.com/apache/arrow/pull/7555#discussion_r450302190
##
File path: cpp/src/arrow/ipc/test_common.cc
##
@@ -79,6 +79,39 @@ Status MakeRandomInt32Array(int64_t length, bool
include_nulls, MemoryPool* pool
github-actions[bot] commented on pull request #7645:
URL: https://github.com/apache/arrow/pull/7645#issuecomment-654314571
https://issues.apache.org/jira/browse/ARROW-8374
This is an automated message from the Apache Git
pitrou commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450314430
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450327095
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
pitrou commented on pull request #7620:
URL: https://github.com/apache/arrow/pull/7620#issuecomment-654331202
The "AMD64 MacOS 10.15 Python 3.7" CI failure looks unrelated.
This is an automated message from the Apache Git
pitrou commented on a change in pull request #7555:
URL: https://github.com/apache/arrow/pull/7555#discussion_r450267748
##
File path: cpp/src/arrow/testing/random.h
##
@@ -140,6 +140,17 @@ class ARROW_TESTING_EXPORT RandomArrayGenerator {
std::shared_ptr Int64(int64_t
kiszk commented on a change in pull request #7555:
URL: https://github.com/apache/arrow/pull/7555#discussion_r450283575
##
File path: cpp/src/arrow/testing/random.h
##
@@ -140,6 +140,17 @@ class ARROW_TESTING_EXPORT RandomArrayGenerator {
std::shared_ptr Int64(int64_t size,
romainfrancois opened a new pull request #7645:
URL: https://github.com/apache/arrow/pull/7645
This needs some testing:
``` r
library(arrow, warn.conflicts = FALSE)
f1 <- factor(c("a"), levels = c("a", "b"))
f2 <- factor(c("c"), levels = c("c", "d"))
ca <-
pitrou commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450319790
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
pitrou commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450328412
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
jorisvandenbossche commented on pull request #7631:
URL: https://github.com/apache/arrow/pull/7631#issuecomment-654334653
I opened https://issues.apache.org/jira/browse/ARROW-9332 for the parquet
statistics
This is an
rok commented on a change in pull request #7477:
URL: https://github.com/apache/arrow/pull/7477#discussion_r450340186
##
File path: python/pyarrow/tensor.pxi
##
@@ -199,7 +202,13 @@ shape: {0.shape}""".format(self)
for x in dim_names:
rok commented on a change in pull request #7477:
URL: https://github.com/apache/arrow/pull/7477#discussion_r450325016
##
File path: python/pyarrow/tensor.pxi
##
@@ -270,8 +279,10 @@ shape: {0.shape}""".format(self)
_data,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450332885
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
github-actions[bot] commented on pull request #7643:
URL: https://github.com/apache/arrow/pull/7643#issuecomment-654284382
https://issues.apache.org/jira/browse/ARROW-9331
This is an automated message from the Apache Git
pitrou commented on a change in pull request #7555:
URL: https://github.com/apache/arrow/pull/7555#discussion_r450285869
##
File path: cpp/src/arrow/testing/random.h
##
@@ -140,6 +140,17 @@ class ARROW_TESTING_EXPORT RandomArrayGenerator {
std::shared_ptr Int64(int64_t
github-actions[bot] commented on pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#issuecomment-654294358
Revision: a550a761781e8a7e1ebe163642a1c6fae98dad52
Submitted crossbow builds: [ursa-labs/crossbow @
kszucs edited a comment on pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#issuecomment-654308059
@pitrou updated. I assume now we propagate the null values from the selected
child array, please double check the union tests.
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450317608
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450318972
##
File path: cpp/src/arrow/scalar.cc
##
@@ -185,6 +192,35 @@
DictionaryScalar::DictionaryScalar(std::shared_ptr type)
0)
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450344074
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
rok commented on pull request #7477:
URL: https://github.com/apache/arrow/pull/7477#issuecomment-654347134
@mrkn - sorry I couldn't spend time on this earlier. I think pyarrow part is
ok (except for the already going discussions).
Would using the canonical flag make value assignment
kszucs commented on a change in pull request #7631:
URL: https://github.com/apache/arrow/pull/7631#discussion_r450361126
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -635,6 +635,37 @@ def test_make_fragment_from_buffer():
assert
github-actions[bot] commented on pull request #7642:
URL: https://github.com/apache/arrow/pull/7642#issuecomment-654192802
https://issues.apache.org/jira/browse/ARROW-9329
This is an automated message from the Apache Git
wesm commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r449802099
##
File path: cpp/src/arrow/compute/api_scalar.h
##
@@ -259,6 +259,27 @@ Result IsValid(const Datum& values, ExecContext*
ctx = NULLPTR);
ARROW_EXPORT
pitrou opened a new pull request #7644:
URL: https://github.com/apache/arrow/pull/7644
Should fix the following issues:
* https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23910
* https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23916
*
jorisvandenbossche commented on pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#issuecomment-654267493
@github-actions crossbow submit test-conda-python-3.7-spark-master
This is an automated message from
nealrichardson opened a new pull request #7648:
URL: https://github.com/apache/arrow/pull/7648
In terms of number of lines of code, this wasn't bad, though I don't know
how efficient these methods are. Maybe there's a better way
The one thing that would be lost is any metadata
kou commented on pull request #7620:
URL: https://github.com/apache/arrow/pull/7620#issuecomment-654445290
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kou closed pull request #7620:
URL: https://github.com/apache/arrow/pull/7620
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rok commented on pull request #7044:
URL: https://github.com/apache/arrow/pull/7044#issuecomment-654457797
Hey @mrkn - sorry I didn't have capacity to reply for a while.
If I remember correctly only SciPy has this architecture of COO index having
two vectors instead of one 2D
BryanCutler commented on pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#issuecomment-654462400
Yeah, it seems possible to fix on the Spark side, but I haven't been able to
take a close look at this yet. I'll try to do that as soon as possible and
report back.
github-actions[bot] commented on pull request #7648:
URL: https://github.com/apache/arrow/pull/7648#issuecomment-654431173
https://issues.apache.org/jira/browse/ARROW-8301
This is an automated message from the Apache Git
kou commented on pull request #7637:
URL: https://github.com/apache/arrow/pull/7637#issuecomment-654434362
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kou closed pull request #7637:
URL: https://github.com/apache/arrow/pull/7637
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7639:
URL: https://github.com/apache/arrow/pull/7639#issuecomment-654434646
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nealrichardson closed pull request #7647:
URL: https://github.com/apache/arrow/pull/7647
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kou closed pull request #7639:
URL: https://github.com/apache/arrow/pull/7639
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou closed pull request #7646:
URL: https://github.com/apache/arrow/pull/7646
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm opened a new pull request #7651:
URL: https://github.com/apache/arrow/pull/7651
I discovered a place where clang-format was left disabled by accident
relatively early in a file and so doing the reformatting as a separate PR to
not have the diff noise in another patch.
wesm closed pull request #7596:
URL: https://github.com/apache/arrow/pull/7596
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on a change in pull request #7596:
URL: https://github.com/apache/arrow/pull/7596#discussion_r450548152
##
File path: cpp/src/arrow/array/array_binary.cc
##
@@ -24,11 +24,27 @@
#include "arrow/type.h"
#include "arrow/util/checked_cast.h"
#include
github-actions[bot] commented on pull request #7651:
URL: https://github.com/apache/arrow/pull/7651#issuecomment-654532558
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
wesm merged pull request #7651:
URL: https://github.com/apache/arrow/pull/7651
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou opened a new pull request #7652:
URL: https://github.com/apache/arrow/pull/7652
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
shiro615 commented on pull request #7639:
URL: https://github.com/apache/arrow/pull/7639#issuecomment-654531677
Thank you for working on this.
This is an automated message from the Apache Git Service.
To respond to the
wesm commented on pull request #7651:
URL: https://github.com/apache/arrow/pull/7651#issuecomment-654532749
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #7652:
URL: https://github.com/apache/arrow/pull/7652#issuecomment-654557935
https://issues.apache.org/jira/browse/ARROW-9341
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7649:
URL: https://github.com/apache/arrow/pull/7649#issuecomment-654476061
https://issues.apache.org/jira/browse/ARROW-9336
This is an automated message from the Apache Git
wesm commented on pull request #7632:
URL: https://github.com/apache/arrow/pull/7632#issuecomment-654491519
Any opinions about these new APIs? @xhochy or @pitrou could you take a quick
look?
This is an automated message
nealrichardson opened a new pull request #7650:
URL: https://github.com/apache/arrow/pull/7650
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on pull request #7650:
URL: https://github.com/apache/arrow/pull/7650#issuecomment-654501588
https://issues.apache.org/jira/browse/ARROW-9340
This is an automated message from the Apache Git
kou opened a new pull request #7649:
URL: https://github.com/apache/arrow/pull/7649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wesm commented on pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#issuecomment-654492131
+1. Thanks @kszucs for this work!
This is an automated message from the Apache Git Service.
To respond to the
wesm closed pull request #7519:
URL: https://github.com/apache/arrow/pull/7519
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nealrichardson commented on pull request #7623:
URL: https://github.com/apache/arrow/pull/7623#issuecomment-654497318
@jorisvandenbossche #7519 has merged so I just rebased this
This is an automated message from the Apache
mrkn commented on pull request #7044:
URL: https://github.com/apache/arrow/pull/7044#issuecomment-654582143
>> If we go for a new type - could I propose a name SparseCOOMatrix (as
opposed to n-dimensional SparseCOOTensor). It could perhaps be shortened to
COOM?
>
> The
mrkn commented on pull request #7044:
URL: https://github.com/apache/arrow/pull/7044#issuecomment-654581941
> Hey @mrkn - sorry I didn't have capacity to reply for a while.
No problem. Thank you for your cooperation!
> If I remember correctly only SciPy has this architecture
88 matches
Mail list logo
